[GitHub] [maven-site] michael-o commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation
michael-o commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r554064780 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test identifier with either the character '!' or '-' as shown below: +---+ -mvn groupId:artifactId:goal -P !profile-1,!profile-2 +mvn groupId:artifactId:goal -P !profile-1,!profile-2,!?profile-3 Review comment: Alright. Keep one consistent option. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] MartinKanters commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation
MartinKanters commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r554058099 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test identifier with either the character '!' or '-' as shown below: +---+ -mvn groupId:artifactId:goal -P !profile-1,!profile-2 +mvn groupId:artifactId:goal -P !profile-1,!profile-2,!?profile-3 Review comment: In the current implementation there is an order in place: - !? is correct and means: "do not activate the profile, but do not fail if it does not exist" - ?! is not correct.. do you think we should support this as well? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] michael-o commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation
michael-o commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r554041608 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test identifier with either the character '!' or '-' as shown below: +---+ -mvn groupId:artifactId:goal -P !profile-1,!profile-2 +mvn groupId:artifactId:goal -P !profile-1,!profile-2,!?profile-3 Review comment: How do I interprete `!?`? Is it the same as `?!`? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] mthmulders commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation
mthmulders commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r554024978 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test identifier with either the character '!' or '-' as shown below: +---+ -mvn groupId:artifactId:goal -P !profile-1,!profile-2 +mvn groupId:artifactId:goal -P !profile-1,!profile-2,!?profile-3 Review comment: > Then you might be affected by something like MNG-7011. Correct - although that is not something that is introduced by [MNG-7051](https://issues.apache.org/jira/browse/MNG-7051). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] pzygielo commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation
pzygielo commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r554014876 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test identifier with either the character '!' or '-' as shown below: +---+ -mvn groupId:artifactId:goal -P !profile-1,!profile-2 +mvn groupId:artifactId:goal -P !profile-1,!profile-2,!?profile-3 Review comment: > Instead of ! you can also use the minus sign, by the way. Then you might be affected by something like MNG-7011. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] MartinKanters commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation
MartinKanters commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r554007128 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test identifier with either the character '!' or '-' as shown below: +---+ -mvn groupId:artifactId:goal -P !profile-1,!profile-2 +mvn groupId:artifactId:goal -P !profile-1,!profile-2,!?profile-3 Review comment: Instead of ! you can also use the minus sign, by the way. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] michael-o commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation
michael-o commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r553996067 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test identifier with either the character '!' or '-' as shown below: +---+ -mvn groupId:artifactId:goal -P !profile-1,!profile-2 +mvn groupId:artifactId:goal -P !profile-1,!profile-2,!?profile-3 Review comment: Correct the ! can be disabled in bash and is a bash problem, not ours. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] mthmulders commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation
mthmulders commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r553966399 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test identifier with either the character '!' or '-' as shown below: +---+ -mvn groupId:artifactId:goal -P !profile-1,!profile-2 +mvn groupId:artifactId:goal -P !profile-1,!profile-2,!?profile-3 Review comment: Should be `mvn -N validate -P \!profile-1,\!profile-2`, but I think it depends on the shell you use. For now, I followed the existing guide... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] mthmulders commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation
mthmulders commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r553965389 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -100,9 +100,11 @@ Introduction to Build Profiles profile IDs to use. The profile(s) specified in the option are activated in addition to any profiles which are activated by their activation configuration or the <<<\>>> section in <<>>. + Maven will refuse to activate or deactivate a profile that cannot be resolved. + To prevent this, prefix the profile identifier with an <<>>, marking it as optional: Review comment: Makes sense, updated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] slawekjaranowski commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation
slawekjaranowski commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r553964597 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test identifier with either the character '!' or '-' as shown below: +---+ -mvn groupId:artifactId:goal -P !profile-1,!profile-2 +mvn groupId:artifactId:goal -P !profile-1,!profile-2,!?profile-3 Review comment: did you try from console ... I have : ``` $ mvn -N validate -P !profile-1,!profile-2 bash: !profile-1,!profile-2: event not found ``` ``` $ bash --version GNU bash, version 5.1.4(1)-release (x86_64-apple-darwin19.6.0) ``` ``` $ mvn --version Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] slawekjaranowski commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation
slawekjaranowski commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r553964597 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test identifier with either the character '!' or '-' as shown below: +---+ -mvn groupId:artifactId:goal -P !profile-1,!profile-2 +mvn groupId:artifactId:goal -P !profile-1,!profile-2,!?profile-3 Review comment: did you try from console ... I have : ``` $ mvn -N validate -P !profile-1,!profile-2 bash: !profile-1,!profile-2: event not found ``` ``` $ bash --version GNU bash, version 5.1.4(1)-release (x86_64-apple-darwin19.6.0) ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] slawekjaranowski commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation
slawekjaranowski commented on a change in pull request #225: URL: https://github.com/apache/maven-site/pull/225#discussion_r553961399 ## File path: content/apt/guides/introduction/introduction-to-profiles.apt ## @@ -100,9 +100,11 @@ Introduction to Build Profiles profile IDs to use. The profile(s) specified in the option are activated in addition to any profiles which are activated by their activation configuration or the <<<\>>> section in <<>>. + Maven will refuse to activate or deactivate a profile that cannot be resolved. + To prevent this, prefix the profile identifier with an <<>>, marking it as optional: Review comment: Does this behavior will be implemented in current version `3.6.x`? - if not, information which version will be impact will be useful This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] mthmulders opened a new pull request #225: [MNG-7051] Add examples of ? prefix in profile activation
mthmulders opened a new pull request #225: URL: https://github.com/apache/maven-site/pull/225 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-doxia] elharo closed pull request #53: rollback Java 7 breaking change
elharo closed pull request #53: URL: https://github.com/apache/maven-doxia/pull/53 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
