Re: Different plugin classpath in Maven 3.6.3 and 4.0.0?

2021-03-03 Thread Robert Scholte
I've created MNG-7110 to track this issue

Robert


[1] https://issues.apache.org/jira/browse/MNG-7110
On 27-2-2021 13:27:04, Robert Scholte  wrote:
Interesting, MavenProjects classrealm is null with Maven 4 (Unlike Maven 
3.6.3). I don't see any relation with that particular commit yet.
This needs more investigation.

Robert
On 23-2-2021 17:32:15, Mirko Friedenhagen  wrote:
And now I was able to reproduce this:

https://github.com/mfriedenhagen/plugin-classpath-maven-3-and-4

mvn clean verify succeeds with 3.6.3 and breaks with 
619973b91cff5af7b5695bda11761a982a159349 ff.



> Am 23.02.2021 um 14:42 schrieb Mirko Friedenhagen :
>
> Not that deep in bisecting as of now. I wrote a small script `bisect`:
>
> ```
> #!/bin/bash -e -p
> mvn -q -B -s ~/.m2/settings-oss.xml clean package -Dmaven.test.skip=true 
> -Denforcer.skip=true -Drat.skip=true
> bin_tar_gz=apache-maven/target/apache-maven-[3,4]*-bin.tar.gz
> test -f $bin_tar_gz
> gunzip -dc $bin_tar_gz | (cd /tmp/ && rm -rf apache-maven-*-SNAPSHOT && tar x)
> cd $HOME/ghq/gitlab.example.com/group/failing-project
> /tmp/apache-maven-*-SNAPSHOT/bin/mvn -B -V -q clean verify -DskipTests
> ```
>
> Running:
> ```
> $ git bisect start 84a1ff2d5cb7bf49fa3171dd92f7ac088e837185 maven-3.6.3
> $ git bisect run ./bisect
> ```
>
> led to:
>
> ```
> $ git bisect log
> # bad: [84a1ff2d5cb7bf49fa3171dd92f7ac088e837185] [MNG-7063] Add unittest to 
> ensure rereading a pom won't return the cached Model
> …
> # first bad commit: [619973b91cff5af7b5695bda11761a982a159349] [MNG-7063] 
> Infinite loop using Shade plugin and JUnit 5 dependency
> ```
>
> Best Regards
> Mirko
>
>
>> Am 23.02.2021 um 10:21 schrieb Michael Osipov :
>>
>> Am 2021-02-23 um 10:16 schrieb Mirko Friedenhagen:
>>> Hello Michal, hello Robert,
>>> Thanks for the answers.
>>> I am trying to reproduce this with a smaller project, but it is quite hard. 
>>> The problem occurs with an inhouse project where we use inhouse plugins 
>>> etc. We manage the lifecycle of standard packagings as well in the the 
>>> extension. I wrote a FOSS derivate (not widely use) and will try to give a 
>>> small example.
>>> Robert, did you mean to bisect the maven-core?
>>
>> Yes, he did. This is what I would do.
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
>> For additional commands, e-mail: dev-h...@maven.apache.org
>>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>



[GitHub] [maven-artifact-transfer] aajisaka closed pull request #22: [MSHARED-981] Upgrade Maven common artifact filters to 3.2.0

2021-03-03 Thread GitBox


aajisaka closed pull request #22:
URL: https://github.com/apache/maven-artifact-transfer/pull/22


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[GitHub] [maven-artifact-transfer] aajisaka commented on pull request #22: [MSHARED-981] Upgrade Maven common artifact filters to 3.2.0

2021-03-03 Thread GitBox


aajisaka commented on pull request #22:
URL: 
https://github.com/apache/maven-artifact-transfer/pull/22#issuecomment-789778922


   > It might sound a good idea to add this information to the repo itself so 
people won't spend their time on a PR that would be closed.
   
   Yes, that's a good idea.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[GitHub] [maven-artifact-transfer] KroArtem commented on pull request #22: [MSHARED-981] Upgrade Maven common artifact filters to 3.2.0

2021-03-03 Thread GitBox


KroArtem commented on pull request #22:
URL: 
https://github.com/apache/maven-artifact-transfer/pull/22#issuecomment-789706459


   I was just passing near and remember that the plan was not to update maven 
minimum version https://github.com/apache/maven-artifact-transfer/pull/20 
(especially 
https://github.com/apache/maven-artifact-transfer/pull/20#issuecomment-752440522)
   
   It might sound a good idea to add this information to the repo itself so 
people won't spend their time on a PR that would be closed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[GitHub] [maven-artifact-transfer] aajisaka opened a new pull request #22: [MSHARED-981] Upgrade Maven common artifact filters to 3.2.0

2021-03-03 Thread GitBox


aajisaka opened a new pull request #22:
URL: https://github.com/apache/maven-artifact-transfer/pull/22


   Drop support for Maven 3.0.x
   
   Maven Common Artifact Filters 3.2.0 only supports Maven 3.1.1+ 
(https://issues.apache.org/jira/browse/MSHARED-974), and after the dependency 
upgrade, the source code for Maven 3.0.x cannot be compiled. Therefore I 
dropped the source code for Maven 3.0.x.
   
   Manually tested with `mvn -Prun-its verify` command.
   
   JIRA: https://issues.apache.org/jira/browse/MSHARED-981



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org