[GitHub] [maven-site] hboutemy commented on a change in pull request #236: [MNGSITE-444] Add missing reactor documentation

2021-04-30 Thread GitBox


hboutemy commented on a change in pull request #236:
URL: https://github.com/apache/maven-site/pull/236#discussion_r624362868



##
File path: content/apt/guides/mini/guide-multiple-modules.apt
##
@@ -59,25 +75,117 @@ Guide to Working with Multiple Modules
 
   Note that only "instantiated" references are used - 
<<>> and <<>> elements do not cause a 
change to the reactor sort order.
 
-** Command Line Options
+** Selecting Modules
 
-  No special configuration is required to take advantage of the reactor, 
however it is possible to customize its behavior.
+  By default, Maven will build all modules it has collected. However, you can 
select a subset of these modules to build using command line flags.
+  Those flags come in three categories:
 
-  The following command line switches are available:
+* Inclusion and exclusion
+
+* Relationships between modules
+
+* Dealing with failures
+
+  This section ends with how those flags relate to each other.
+
+*** Inclusion and exclusion
+
+  Using <<<--projects>>> you can specify which modules you want to build.
+  You can do this by specifying a comma-delimited list of project selectors.
+  A project selector is a string that is composed of the 
<<>>, only <<<:artifactId>>> or the relative path to a 
module.
+
+  A module can be selected (default), or excluded from the build. You exclude 
a module by prefixing the selector with a <<>> or <<<->>>. To explicitly 
select a module, prefix it with a <<<+>>>.
+
+  When a selector does not resolve to an existing module, Maven will fail the 
build. You can prevent this by adding the <<>> prefix.
+  This prefix should always go after the other prefixes.
 
-* <<<--resume-from>>> - resumes a reactor from the specified project (e.g. 
when it fails in the middle)
+*** Relationships between modules
 
-* <<<--also-make>>> - build the specified projects, and any of their 
dependencies in the reactor
+  Modules inside a project can have two types of relationships: parent/child 
and dependency/dependent.
 
-* <<<--also-make-dependents>>> - build the specified projects, and any 
that depend on them
+  When selecting a parent (aggregate), Maven automatically selects the child 
modules as well. Similarly, Maven excludes child modules of an excluded parent 
(aggregate).

Review comment:
   aggregate -> aggregator




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[GitHub] [maven-site] hboutemy commented on a change in pull request #236: [MNGSITE-444] Add missing reactor documentation

2021-04-30 Thread GitBox


hboutemy commented on a change in pull request #236:
URL: https://github.com/apache/maven-site/pull/236#discussion_r624362541



##
File path: content/apt/guides/mini/guide-multiple-modules.apt
##
@@ -59,25 +75,117 @@ Guide to Working with Multiple Modules
 
   Note that only "instantiated" references are used - 
<<>> and <<>> elements do not cause a 
change to the reactor sort order.
 
-** Command Line Options
+** Selecting Modules

Review comment:
   perhaps add a "Maven 4" tip here, because IIUC, this is the new part




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[GitHub] [maven-site] hboutemy commented on a change in pull request #236: [MNGSITE-444] Add missing reactor documentation

2021-04-30 Thread GitBox


hboutemy commented on a change in pull request #236:
URL: https://github.com/apache/maven-site/pull/236#discussion_r624361148



##
File path: content/apt/guides/mini/guide-multiple-modules.apt
##
@@ -37,11 +39,25 @@ Guide to Working with Multiple Modules
 
 * Collects all the available modules to build
 
-* Sorts the projects into the correct build order
+* Sorts the modules into the correct build order
 
-* Builds the selected projects in order
+* Selects which modules to build
 
-** Reactor Sorting
+* Builds the selected modules in order
+
+** Collecting Modules
+
+  Module collection starts from one aggregate project. That project defines 
the modules of which it consists using the <<<\>>> element.

Review comment:
   "aggregate project" or "aggregating project"? (or "aggregator projects", 
now I read the next sentences)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[GitHub] [maven-site] hboutemy commented on a change in pull request #236: [MNGSITE-444] Add missing reactor documentation

2021-04-30 Thread GitBox


hboutemy commented on a change in pull request #236:
URL: https://github.com/apache/maven-site/pull/236#discussion_r624361148



##
File path: content/apt/guides/mini/guide-multiple-modules.apt
##
@@ -37,11 +39,25 @@ Guide to Working with Multiple Modules
 
 * Collects all the available modules to build
 
-* Sorts the projects into the correct build order
+* Sorts the modules into the correct build order
 
-* Builds the selected projects in order
+* Selects which modules to build
 
-** Reactor Sorting
+* Builds the selected modules in order
+
+** Collecting Modules
+
+  Module collection starts from one aggregate project. That project defines 
the modules of which it consists using the <<<\>>> element.

Review comment:
   "aggregate project" or "aggregating project"?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[GitHub] [maven-site] elharo commented on a change in pull request #236: [MNGSITE-444] Add missing reactor documentation

2021-04-30 Thread GitBox


elharo commented on a change in pull request #236:
URL: https://github.com/apache/maven-site/pull/236#discussion_r624241259



##
File path: content/apt/guides/mini/guide-multiple-modules.apt
##
@@ -37,11 +39,25 @@ Guide to Working with Multiple Modules
 
 * Collects all the available modules to build
 
-* Sorts the projects into the correct build order
+* Sorts the modules into the correct build order
 
-* Builds the selected projects in order
+* Selects which modules to build
 
-** Reactor Sorting
+* Builds the selected modules in order
+
+** Collecting Modules
+
+  Module collection starts from one aggregate project. That project defines 
the modules of which it consists using the <<<\>>> element.
+  This is a recursive process, so aggregators can have child modules which are 
aggregators themselves.
+
+  For this process to work, it does not matter which POM you start with.
+  Maven will attempt to find the root of a multi-module project, by traversing 
upwards in the directory structure until it finds a POM with a <<<.mvn>>> 
sibling directory.

Review comment:
   will attempt --> attempts
   
   In general pick a single tense, usually present, in the document

##
File path: content/apt/guides/mini/guide-multiple-modules.apt
##
@@ -59,25 +75,117 @@ Guide to Working with Multiple Modules
 
   Note that only "instantiated" references are used - 
<<>> and <<>> elements do not cause a 
change to the reactor sort order.
 
-** Command Line Options
+** Selecting Modules
 
-  No special configuration is required to take advantage of the reactor, 
however it is possible to customize its behavior.
+  By default, Maven will build all modules it has collected. However, you can 
select a subset of these modules to build using command line flags.

Review comment:
   will build --> builds

##
File path: content/apt/guides/mini/guide-multiple-modules.apt
##
@@ -59,25 +75,117 @@ Guide to Working with Multiple Modules
 
   Note that only "instantiated" references are used - 
<<>> and <<>> elements do not cause a 
change to the reactor sort order.
 
-** Command Line Options
+** Selecting Modules
 
-  No special configuration is required to take advantage of the reactor, 
however it is possible to customize its behavior.
+  By default, Maven will build all modules it has collected. However, you can 
select a subset of these modules to build using command line flags.
+  Those flags come in three categories:
 
-  The following command line switches are available:
+* Inclusion and exclusion
+
+* Relationships between modules
+
+* Dealing with failures
+
+  This section ends with how those flags relate to each other.
+
+*** Inclusion and exclusion
+
+  Using <<<--projects>>> you can specify which modules you want to build.
+  You can do this by specifying a comma-delimited list of project selectors.
+  A project selector is a string that is composed of the 
<<>>, only <<<:artifactId>>> or the relative path to a 
module.
+
+  A module can be selected (default), or excluded from the build. You exclude 
a module by prefixing the selector with a <<>> or <<<->>>. To explicitly 
select a module, prefix it with a <<<+>>>.
+
+  When a selector does not resolve to an existing module, Maven will fail the 
build. You can prevent this by adding the <<>> prefix.
+  This prefix should always go after the other prefixes.
 
-* <<<--resume-from>>> - resumes a reactor from the specified project (e.g. 
when it fails in the middle)
+*** Relationships between modules
 
-* <<<--also-make>>> - build the specified projects, and any of their 
dependencies in the reactor
+  Modules inside a project can have two types of relationships: parent/child 
and dependency/dependent.
 
-* <<<--also-make-dependents>>> - build the specified projects, and any 
that depend on them
+  When selecting a parent (aggregate), Maven automatically selects the child 
modules as well. Similarly, Maven excludes child modules of an excluded parent 
(aggregate).
+  To prevent this recursive behaviour, combine <<<--projects>>> with 
<<<--non-recursive>>>.
 
-* <<<--fail-fast>>> - the default behavior - whenever a module build 
fails, stop the overall build immediately
+  Maven knows about the dependencies between modules inside the multi-module 
project.
+  Using <<<--also-make>>>, Maven includes all dependencies of the selected 
projects in the build.
+  Similarly, <<<--also-make-dependents>>> lets Maven include all modules which 
are dependent on the selected projects.
 
-* <<<--fail-at-end>>> - if a particular module build fails, continue the 
rest of the reactor and report all failed modules at the end instead
+*** Dealing with failures
 
-* <<<--non-recursive>>> - do not use a reactor build, even if the current 
project declares modules and just build the project in the current directory
+  There are several ways to customize how the reactor deals with fail

Re: Accessing Maven Repository with Java11, SplitPackages

2021-04-30 Thread Robert Scholte
The codebase of Maven is over 15 years old and you can clearly see that it has 
evolved over the years. This implies that sometimes we've decided to move 
classes from one jar to the other.
On the classpath this is not an issue and as Maven is using only the classpath 
to run there is no issue here.

Having said that, you're clearly trying to use the maven-resolver-provider on 
the module-path, which is not going to work without any tricks (such as 
providing extra flags to java / javac or to rebundle jars).
However, Java 11 (or actually Java 9) doesn't mean you can't use the classpath 
anymore.

Currently there is no need for Maven to switch to the module path. Assuming we 
would do that, we need to rename packages which would probably make all current 
maven-plugins useless.It comes with much more pain than gain.
So the advice is: remove your module-info file and stay on the classpath

Robert
On 30-4-2021 22:45:57, jan.uhli...@web.de  wrote:
Dear Maven Developers,
 
I am currently struggling with a problem related to the maven-resolver-provider 
in version 3.8.1 because its’ inherent dependencies seem to not be compatible 
with Java14.
 
This brought me to the question if there is an intention to migrate alike maven 
projects to at least Java11, regarding the restriction of package splitting 
since Java11.
( With the premise that maven-resolver-provider and such are built with Java8, 
what wouldn’t cause the problems at all. Sadly, I didn’t find much but some 
notes that many related projects are still developed under Java8. )
 
Derived from this more general question I can surely provide more information 
about my special issue and for sure can create an actual Issue on this, but as 
I am not that much experienced in this universe, I thought I’d like to contact 
you in advance:
 
The maven-resolver-provider is the dependency that allows me to resolve a Maven 
repository in Java with access to Artifacts and much more. What is mainly what 
I want to do, and what worked with Java8 like a charm.
Since split packages are restricted in Java11, at startup Java throws 
ResolutionExceptions as soon as the dependency* is declared. Amongst others, 
the really concerning issue strikes as follows:
 
java.lang.module.ResolutionException: Modules maven.model and 
maven.model.builder export package org.apache.maven.model.merge to module 
maven.repository.metadata
 
Looking at these projects, one can easily see that the only class provided by 
the maven-model-build -> org.apache.maven.model.merge package is a class called 
“MavenModelMerger.java” extends “ModelMerger.java”
>From maven-model project and seems to have no dependencies on the 
>maven-model-builder project at all. Couldn’t this be moved to the maven-model 
>project to support Java11 at this point?
(The image below shows the imports for the MavenModelMerger.class.)
As you may have guessed, I really need these projects maven-model and 
maven-model-builder, what directly leads to the above provided question: Are 
there intentions to migrate these projects to a newer Java version?
 
 
PS: In case I am completely misleaded, I am sorry.
 
Best Regards,
Stay Healthy,
Jan Uhlig
 
*

  org.apache.maven
  maven-resolver-provider
  3.8.1

 
The following image demonstrates the imports in the MavenModelMerger class:

Accessing Maven Repository with Java11, SplitPackages

2021-04-30 Thread jan.uhlig01
Dear Maven Developers,



I am currently struggling with a problem related to the
maven-resolver-provider in version 3.8.1 because its' inherent dependencies
seem to not be compatible with Java14.



This brought me to the question if there is an intention to migrate alike
maven projects to at least Java11, regarding the restriction of package
splitting since Java11.

( With the premise that maven-resolver-provider and such are built with
Java8, what wouldn't cause the problems at all. Sadly, I didn't find much
but some notes that many related projects are still developed under Java8. )




Derived from this more general question I can surely provide more
information about my special issue and for sure can create an actual Issue
on this, but as I am not that much experienced in this universe, I thought
I'd like to contact you in advance:



The maven-resolver-provider is the dependency that allows me to resolve a
Maven repository in Java with access to Artifacts and much more. What is
mainly what I want to do, and what worked with Java8 like a charm.

Since split packages are restricted in Java11, at startup Java throws
ResolutionExceptions as soon as the dependency* is declared. Amongst others,
the really concerning issue strikes as follows:



java.lang.module.ResolutionException: Modules maven.model and
maven.model.builder export package org.apache.maven.model.merge to module
maven.repository.metadata



Looking at these projects, one can easily see that the only class provided
by the maven-model-build -> org.apache.maven.model.merge package is a class
called "MavenModelMerger.java" extends "ModelMerger.java"

From maven-model project and seems to have no dependencies on the
maven-model-builder project at all. Couldn't this be moved to the
maven-model project to support Java11 at this point?

(The image below shows the imports for the MavenModelMerger.class.)

As you may have guessed, I really need these projects maven-model and
maven-model-builder, what directly leads to the above provided question: Are
there intentions to migrate these projects to a newer Java version?





PS: In case I am completely misleaded, I am sorry.



Best Regards,
Stay Healthy,
Jan Uhlig



*



  org.apache.maven

  maven-resolver-provider

  3.8.1





The following image demonstrates the imports in the MavenModelMerger class:





[ANN] Maven Project Info Reports Plugin 3.1.2 released

2021-04-30 Thread Michael Osipov
The Apache Maven team is pleased to announce the release of the Maven 
Project Info Reports Plugin version 3.1.2.


https://maven.apache.org/plugins/maven-project-info-reports-plugin/

You should specify the version in your project's plugin configuration:


  org.apache.maven.plugins
  maven-project-info-reports-plugin
  3.1.2



Release Notes - Maven Project Info Reports Plugin - Version 3.1.2

** New Feature
* [MPIR-395] - Add TeamCity as a possibility for ciManagement entry

** Improvement
* [MPIR-391] - Continuous Integration support for GitHub Actions
* [MPIR-401] - Mailing list subscribe and unsubscribe links


Enjoy,

-The Apache Maven team

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[ANN] Apache Maven Shared Utils 3.3.4 Released

2021-04-30 Thread Maarten Mulders
The Apache Maven team is pleased to announce the release of the Apache 
Maven Shared Utils, version 3.3.4.


This project aims to be a functional replacement for plexus-utils in Maven.

https://maven.apache.org/shared/maven-shared-utils/

You should specify the version in your project's plugin configuration:


  org.apache.maven.shared
  maven-shared-utils
  3.3.4


You can download the appropriate sources etc. from the download page:

https://maven.apache.org/plugins/maven-shared-utils/download.cgi

Release Notes - Maven Shared Utils - Version 3.3.4

** Bug

  * [MSHARED-951] - Checked exception converted to raw runtime exception
  * [MSHARED-952] - PrettyPrintXmlWriter output is platform dependent
  * [MSHARED-954] - Deprecate StringUtils.unifyLineSeparator
  * [MSHARED-969] - Environment variable with null value

** Dependency upgrade

  * [MSHARED-962] - Upgrade Jansi to 2.0.1
  * [MSHARED-973] - Upgrade Jansi to 2.2.0


Enjoy,

-The Apache Maven team



OpenPGP_signature
Description: OpenPGP digital signature


[RESULT] [VOTE] Release Maven Project Info Reports Plugin version 3.1.2

2021-04-30 Thread Michael Osipov

Hi,

The vote has passed with the following result:

+1: Tibor Digana, Slawomir Jaranowski, Sylwester Lachiewicz, Tamás 
Cservenák, Olivier Lamy, Hervé Boutemy, Karl Heinz Marbaise


PMC quorum: reached

I will promote the artifacts to the central repo, the source release ZIP 
file

and add this release the board report.


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[GitHub] [maven-site] mthmulders commented on pull request #236: [MNGSITE-444] Add missing reactor documentation

2021-04-30 Thread GitBox


mthmulders commented on pull request #236:
URL: https://github.com/apache/maven-site/pull/236#issuecomment-830141468


   > I would prefer no priorpritary format/application to be necessary to draw 
stuff. SVG is preferred or as @hboutemy did a dep over view with LO Draw.
   
   I found some .ai files (think it's Adobe Illustrator) so I thought it would 
be no problem. Replaced it with ODP which I believe is an open format.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[GitHub] [maven-site] michael-o commented on pull request #236: [MNGSITE-444] Add missing reactor documentation

2021-04-30 Thread GitBox


michael-o commented on pull request #236:
URL: https://github.com/apache/maven-site/pull/236#issuecomment-830131062


   I would prefer no priorpritary format/application to be necessary to draw 
stuff. SVG is preferred or as @hboutemy did a dep over view with LO Draw.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[GitHub] [maven-site] MartinKanters opened a new pull request #236: [MNGSITE-444] Add missing reactor documentation

2021-04-30 Thread GitBox


MartinKanters opened a new pull request #236:
URL: https://github.com/apache/maven-site/pull/236


   This PR describes most of the changes to the reactor that are coming in 
Maven 4.
   @mthmulders and I also extended the existing docs.
   
   @elharo We would like to ask you for a review at least, as you are a native 
speaker.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[RESULT] [VOTE] Release Apache Maven Shared Utils version 3.3.4

2021-04-30 Thread Maarten Mulders

Hi,

The vote has passed with the following result:

+1 : Elliotte Rusty Harold, Hervé Boutemy, Robert Scholte, Karl Heinz 
Marbaise, Olivier Lamy, Martin Kanters


PMC quorum: reached.

I will promote the artifacts to the central repo.

Thanks for your votes,

Maarten

On April 26, 2021 at 19:59, Maarten Mulders wrote:

Hi,

We solved 6 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317922&version=12350122&styleName=Text 



There are still a couple of issues left in JIRA:
https://issues.apache.org/jira/issues/?jql=project%20%3D%2012317922%20AND%20resolution%20%3D%20Unresolved%20AND%20component%20%3D%20maven-shared-utils%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC 



Staging repo:
https://repository.apache.org/content/repositories/maven-1643/
https://repository.apache.org/content/repositories/maven-1643/org/apache/maven/shared/maven-shared-utils/3.3.4/maven-shared-utils-3.3.4-source-release.zip 



Source release checksum(s):
maven-shared-utils-3.3.4-source-release.zip sha512: 
27b63d3c8214c3ced472c4eae69199adad85b4badabd3b1608b8ab288f2246efba8f833763e87ad13e55268814e392b0d8146fb4a32a9de6d3c50c9652d66326 



Staging site:
https://maven.apache.org/components/shared-archives/maven-shared-utils-LATEST/ 



Guide to testing staged releases:
https://maven.apache.org/guides/development/guide-testing-releases.html

Vote open for at least 72 hours.

[ ] +1
[ ] +0
[ ] -1


Thanks in advance for your votes,


Maarten



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org