[GitHub] [maven-shared-incremental] dependabot[bot] commented on pull request #11: Bump slf4j-api from 1.7.36 to 2.0.0

2022-08-22 Thread GitBox


dependabot[bot] commented on PR #11:
URL: 
https://github.com/apache/maven-shared-incremental/pull/11#issuecomment-1222819645

   OK, I won't notify you again about this release, but will get in touch when 
a new version is available. If you'd rather skip all updates until the next 
major or minor version, let me know by commenting `@dependabot ignore this 
major version` or `@dependabot ignore this minor version`. You can also ignore 
all major, minor, or patch releases for a dependency by adding an [`ignore` 
condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore)
 with the desired `update_types` to your config file.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[GitHub] [maven-shared-incremental] asfgit closed pull request #11: Bump slf4j-api from 1.7.36 to 2.0.0

2022-08-22 Thread GitBox


asfgit closed pull request #11: Bump slf4j-api from 1.7.36 to 2.0.0
URL: https://github.com/apache/maven-shared-incremental/pull/11


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[GitHub] [maven-shared-incremental] dependabot[bot] commented on pull request #4: Bump mavenVersion from 2.2.1 to 3.8.6

2022-08-22 Thread GitBox


dependabot[bot] commented on PR #4:
URL: 
https://github.com/apache/maven-shared-incremental/pull/4#issuecomment-1222815824

   OK, I won't notify you again about this release, but will get in touch when 
a new version is available. You can also ignore all major, minor, or patch 
releases for a dependency by adding an [`ignore` 
condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore)
 with the desired `update_types` to your config file.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[GitHub] [maven-shared-incremental] asfgit closed pull request #4: Bump mavenVersion from 2.2.1 to 3.8.6

2022-08-22 Thread GitBox


asfgit closed pull request #4: Bump mavenVersion from 2.2.1 to 3.8.6
URL: https://github.com/apache/maven-shared-incremental/pull/4


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[GitHub] [maven-shared-incremental] dependabot[bot] opened a new pull request, #11: Bump slf4j-api from 1.7.36 to 2.0.0

2022-08-22 Thread GitBox


dependabot[bot] opened a new pull request, #11:
URL: https://github.com/apache/maven-shared-incremental/pull/11

   Bumps [slf4j-api](https://github.com/qos-ch/slf4j) from 1.7.36 to 2.0.0.
   
   Commits
   
   https://github.com/qos-ch/slf4j/commit/0614d467d7bca81724f45e228f4f871161222b51;>0614d46
 prepare release 2.0.0
   https://github.com/qos-ch/slf4j/commit/b1afcd01b1092f0dfda12b4502aa202124e24a8e;>b1afcd0
 javadoc edits
   https://github.com/qos-ch/slf4j/commit/20cd3ad0abd25d1837f5b9354c6729cb4a978d69;>20cd3ad
 start work on 2.0.0-SNAPSHOT
   https://github.com/qos-ch/slf4j/commit/aeebb6199d412a3883af2d0c414a69fde26b5971;>aeebb61
 prepare release 2.0.0-beta1
   https://github.com/qos-ch/slf4j/commit/1068cd0eb9fb2460d368e3ba6112517ef3fedd2a;>1068cd0
 javadoc changes
   https://github.com/qos-ch/slf4j/commit/4e4e56a2df730cdb6877449b6341279208f20a78;>4e4e56a
 add CheckReturnValue annotation in org.slf4j.helpers
   https://github.com/qos-ch/slf4j/commit/0dcfa19040fb2d7f45dfe00823d15bdff0434d6a;>0dcfa19
 check for return value in some oggingEventBuilder methods
   https://github.com/qos-ch/slf4j/commit/e7ca8d17c8db1fc956019404153cc7b90b8f0c61;>e7ca8d1
 start work on 2.0.0-beta1-SNAPSHOPT
   https://github.com/qos-ch/slf4j/commit/2314de9dd9f9abbef360f5c6240487c0ac7e5fc3;>2314de9
 add setMessage and log method to the fluent API
   https://github.com/qos-ch/slf4j/commit/508a796552640c83d6d814374a9b50a424e88cfa;>508a796
 set version to 2.0.0-beta0
   Additional commits viewable in https://github.com/qos-ch/slf4j/compare/v_1.7.36...v_2.0.0;>compare 
view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.slf4j:slf4j-api=maven=1.7.36=2.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: Integration test suite

2022-08-22 Thread Henning Schmiedehausen
Hi Herve,

I saw your fix but I was wondering if just adding those two lines to the
bootstrap.txt:

+org.apache.maven.plugins:maven-dependency-plugin:3.1.1
+org.apache.maven.plugins:maven-dependency-plugin:3.3.0

wouldn't be a simpler fix. The test itself seems fine, just the deps are
missing.

-h



On Sun, Aug 21, 2022 at 11:29 PM Hervé BOUTEMY 
wrote:

> I did a first quick pass, but I fear there is an unexpected warning with m-
> antrun-p that still causes a failure: I don't time yet to fix, I need to
> leave,
> help welcome...
>
> Le lundi 22 août 2022, 07:57:31 CEST Hervé BOUTEMY a écrit :
> > uh, sorry, I overlooked that I broke the core ITs...
> >
> > looking at the error message:
> > "[ERROR] Plugin org.apache.maven.plugins:maven-dependency-plugin:3.3.0 or
> > one of its dependencies could not be resolved:
> > org.apache.maven.plugins:maven- dependency-plugin:jar:3.3.0 was not found
> > in file:target/null"
> > it seems it's the classical "disconnected ITs run" issue: let's use my
> > mistake as a training :)
> >
> > - explanations are in the "Core ITs Suite and Dependencies (incl.
> Plugins)"
> > of https://maven.apache.org/core-its/core-it-suite/
> >
> > - looking at bootstrap output, it seems maven-dependency-plugin 3.1.1 is
> > available instead of 3.3.0 => I'll update the failing ITs and it should
> be
> > solved
> >
> > Regards,
> >
> > Hervé
> >
> > Le lundi 22 août 2022, 06:50:40 CEST Henning Schmiedehausen a écrit :
> > > Folks,
> > >
> > > I am somewhat struggling to make integration tests pass for PRs. And it
> > > seems that I am not alone. Looking at
> > > https://github.com/apache/maven/commits/master, none of the merged
> commits
> > > on master has successfully passed the test suite. It seems to have
> started
> > > with the "[MNG-7353] ..." commit here:
> > >
> https://github.com/apache/maven/commit/35b93b0a589752cc88105623a2ddf9e52b5
> > > 6c 1ce
> > >
> > > The same seems to apply for the maven-3.9.x branch (
> > > https://github.com/apache/maven/commits/maven-3.9.x) - test failures
> for
> > > all commits after "[MNG-7353] ..." (
> > >
> https://github.com/apache/maven/commit/95bdbf6821d16c2b4f1df6f820600e0d4b1
> > > b9 166 )
> > >
> > > This makes it slightly difficult for me to understand if my PRs
> actually
> > > break something in maven (I am pretty sure they do not) or whether
> this is
> > > a knock on effect from other integration tests failing.  The issue may
> be
> > > with the CI setup itself; I can make the integration test suite pass
> > > locally (MacOS 12, Intel, JDK 17) for either branch.
> > >
> > > I tried to make sense of the github actions but they seem to be more
> > > complicated than I thought. I can get the test to pass locally by
> running
> > >
> > > % cd maven
> > > % mvn -PversionlessMavenDist clean install
> > > % cd ../maven-integration-testing
> > > % mvn -Prun-its clean install  -DmavenDistro=... reference to the maven
> > > folder .../apache-maven/target/apache-maven-bin.zip
> > >
> > > Grateful for any advice. Ideally the folks that wrote the gh actions
> > > (Martin, Sylwester, Maarten) or who commited that change (Hervé) could
> > > help.
> > >
> > > Thanks,
> > >
> > > Henning
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > For additional commands, e-mail: dev-h...@maven.apache.org
>
>
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>


Re: Integration test suite

2022-08-22 Thread Henning Schmiedehausen
Hi Maarten,

Thank you for the explanation! The GH actions are much more visible on Pull
Requests; I was not even aware that there is a jenkins setup (as this is
not surfaced anywhere for a PR).

It would be good to document that implicit maven /
maven-integration-testing checking; I am not actually sure that I used the
same branch names.

I see failures in the GH actions (as shown on the github project in the
actions tab). Hervé seems to have found the root cause; I can wait for him
to dig deeper into this.

-h


-h


On Mon, Aug 22, 2022 at 6:59 AM Maarten Mulders 
wrote:

> Hi all,
>
> The overall idea of the integation tests in GH Actions is this:
> 1. Check if the org/owner of the fork where the PR comes from _also_ has
> a fork of maven-integration-testing.
> 2. If so, check if they have a branch on that fork with the same name as
> the fork of maven-core.
> 3. If so, run the Maven PR against that fork.
> Otherwise, run the Maven PR against the *master* branch of
> maven-integration-testing.
>
> Having said that, I believe most of the GH Action jobs run fine. What
> indeed fails - starting at #35b93b0a - is same jobs running in ASF
> Jenkins. I believe they should do the same as GH Actions, but apparently
> they do not do the same thing. Ideally, if one fails, the other should
> fail as well.
>
> I've had a look at it and I think the main difference is that the GH
> Actions set maven.repo.local to $HOME/.m2/repository, whereas Jenkins
> does not. Would it make sense to specify maven.repo.local for GitHub
> actions, too?
>
>
> Thanks,
>
> Maarten
>
>
> On 22/08/2022 07:57, Hervé BOUTEMY wrote:
> > uh, sorry, I overlooked that I broke the core ITs...
> >
> > looking at the error message:
> > "[ERROR] Plugin org.apache.maven.plugins:maven-dependency-plugin:3.3.0
> or one
> > of its dependencies could not be resolved:
> org.apache.maven.plugins:maven-
> > dependency-plugin:jar:3.3.0 was not found in file:target/null"
> > it seems it's the classical "disconnected ITs run" issue: let's use my
> mistake
> > as a training :)
> >
> > - explanations are in the "Core ITs Suite and Dependencies (incl.
> Plugins)" of
> > https://maven.apache.org/core-its/core-it-suite/
> >
> > - looking at bootstrap output, it seems maven-dependency-plugin 3.1.1 is
> > available instead of 3.3.0 => I'll update the failing ITs and it should
> be
> > solved
> >
> > Regards,
> >
> > Hervé
> >
> > Le lundi 22 août 2022, 06:50:40 CEST Henning Schmiedehausen a écrit :
> >> Folks,
> >>
> >> I am somewhat struggling to make integration tests pass for PRs. And it
> >> seems that I am not alone. Looking at
> >> https://github.com/apache/maven/commits/master, none of the merged
> commits
> >> on master has successfully passed the test suite. It seems to have
> started
> >> with the "[MNG-7353] ..." commit here:
> >>
> https://github.com/apache/maven/commit/35b93b0a589752cc88105623a2ddf9e52b56c
> >> 1ce
> >>
> >> The same seems to apply for the maven-3.9.x branch (
> >> https://github.com/apache/maven/commits/maven-3.9.x) - test failures
> for
> >> all commits after "[MNG-7353] ..." (
> >>
> https://github.com/apache/maven/commit/95bdbf6821d16c2b4f1df6f820600e0d4b1b9
> >> 166 )
> >>
> >> This makes it slightly difficult for me to understand if my PRs actually
> >> break something in maven (I am pretty sure they do not) or whether this
> is
> >> a knock on effect from other integration tests failing.  The issue may
> be
> >> with the CI setup itself; I can make the integration test suite pass
> >> locally (MacOS 12, Intel, JDK 17) for either branch.
> >>
> >> I tried to make sense of the github actions but they seem to be more
> >> complicated than I thought. I can get the test to pass locally by
> running
> >>
> >> % cd maven
> >> % mvn -PversionlessMavenDist clean install
> >> % cd ../maven-integration-testing
> >> % mvn -Prun-its clean install  -DmavenDistro=... reference to the maven
> >> folder .../apache-maven/target/apache-maven-bin.zip
> >>
> >> Grateful for any advice. Ideally the folks that wrote the gh actions
> >> (Martin, Sylwester, Maarten) or who commited that change (Hervé) could
> help.
> >>
> >> Thanks,
> >>  Henning
> >
> >
> >
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > For additional commands, e-mail: dev-h...@maven.apache.org
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>


JDK 19 first Release Candidates!

2022-08-22 Thread David Delabassee

Greetings!

I hope you had a chance to take some time off. On our side, and despite 
the summer vacation, everything is on track for the Java 19 GA release 
on September 20th with JDK 19 now in the Release Candidate Phase [1]. If 
you haven't done so yet, it is time to start testing your project(s) 
using JDK 20 Early-Access builds. Speaking of Early-Access builds, there 
is now a new set of EA builds, i.e., the jextract EA builds. jextract is 
a tool developed under the Project Panama umbrella whose goal is to 
mechanically generate Java bindings from native library headers. If you 
are using the Foreign Function & Memory API (Preview Feature in JDK 19), 
make sure to check jextract too (see the jextract section below).


[1] https://mail.openjdk.org/pipermail/jdk-dev/2022-August/006861.html


## Heads-up - New system properties for `System.out` and `System.err` in 
JDK 19


Two new system properties, `stdout.encoding` and `stderr.encoding`, have 
been introduced. The value of these system properties is the encoding 
used by the standard output (`System.out`) and standard error 
(`System.err`) streams. The default values of these system properties 
depend on the platform. The values take on the value of the 
`native.encoding` property when the platform does not provide streams 
for the console. The properties can be overridden on the launcher's 
command line option, with `-D`, to set them to UTF-8 where required. For 
more details see https://bugs.openjdk.org/browse/JDK-8283620



## Heads-up - SSLSocketImpl finalizer implementation removed in JDK 19

The finalizer implementation in SSLSocket has been removed, with the 
underlying native resource releases now done by the Socket 
implementation. With this update, the TLS close_notify messages will no 
longer be emitted if SSLSocket is not explicitly closed. Not closing 
Sockets properly is an error condition that should be avoided. 
Applications should always close sockets and not rely on garbage 
collection. For more details see https://bugs.openjdk.org/browse/JDK-8212136



## Heads-up - New providerPath jarsigner option in JDK 19

A new `-providerPath` option has been added to the jarsigner. This 
option is used to specify the class path of an alternate keystore 
implementation, it can be used together with the -providerClass option. 
For more details see https://bugs.openjdk.org/browse/JDK-8281175



## JDK 19 Release Candidate builds

JDK 19 first Release Candidates (builds 36) are now available [2], and 
are provided under the GNU General Public License v2, with the Classpath 
Exception. The Release Notes are available here [3].


[2] https://jdk.java.net/19/
[3] https://jdk.java.net/19/release-notes


## JDK 20 Early-Access builds

JDK 20 Early-Access builds 11 are now available [4], and are provided 
under the GNU General Public License v2, with the Classpath Exception. 
The Release Notes are available here [5].


[4] https://jdk.java.net/20/
[5] https://jdk.java.net/20/release-notes

### Recent changes that maybe of interest:

- JDK-8282730: LdapLoginModule throw NPE from logout method after login 
failure

- JDK-8290706: Remove the support for inline contiguous allocations
- JDK-8289551: Conversions between bit representations of half precision 
values and floats
- JDK-8290485: [vector] REVERSE_BYTES for byte type should not emit any 
instructions
- JDK-8289137: Automatically adapt Young/OldPLABSize and when setting 
only MinTLABSize

- JDK-8290034: Auto vectorize reverse bit operations.
- JDK-8290868: NMT: MallocSiteTable statistics improvements
- JDK-8291822: ARM32: Build errors with GCC 11 in 
frame::saved_oop_result [Reported by JaCoCo]

- JDK-8289249: Add methods to Elements for record constructors
- JDK-8283232: x86: Improve vector broadcast operations
- JDK-8288327: Executable.hasRealParameterData should not be volatile
- JDK-8291360: Create entry points to expose low-level class file 
information

- JDK-8290840: Refactor the "os" class
- JDK-8292327: InflaterInputStream.read throws EOFException
- JDK-8155246: Throw error if default java.security file is missing
- JDK-8289332: Auto-generate ids for user-defined headings
- JDK-8292153: x86: Represent Registers as values


## Jextract Early-Access Builds

Early Access Builds 19-jextract+2-3 (2022/7/19) are now available [6]. 
These open-source builds are provided under the GNU General Public 
License, version 2, with the Classpath Exception.


These builds are from the OpenJDK jextract project [7] which is part of 
Code Tools [8]. jextract is a tool developed under the Panama umbrealla 
whose goal is to mechanically generate Java bindings from native library 
headers. These EA builds are intended for advanced users, and are 
provided as a convenience so that they don't need to build it from the 
sources. Additional notes on builds, documentation and known issues are 
available at [6].


Please subscribe to the jextract mailing list [9] to share feedback.

[6] https://jdk.java.net/jextract/

Re: Integration test suite

2022-08-22 Thread Maarten Mulders

Hi all,

The overall idea of the integation tests in GH Actions is this:
1. Check if the org/owner of the fork where the PR comes from _also_ has 
a fork of maven-integration-testing.
2. If so, check if they have a branch on that fork with the same name as 
the fork of maven-core.

3. If so, run the Maven PR against that fork.
Otherwise, run the Maven PR against the *master* branch of 
maven-integration-testing.


Having said that, I believe most of the GH Action jobs run fine. What 
indeed fails - starting at #35b93b0a - is same jobs running in ASF 
Jenkins. I believe they should do the same as GH Actions, but apparently 
they do not do the same thing. Ideally, if one fails, the other should 
fail as well.


I've had a look at it and I think the main difference is that the GH 
Actions set maven.repo.local to $HOME/.m2/repository, whereas Jenkins 
does not. Would it make sense to specify maven.repo.local for GitHub 
actions, too?



Thanks,

Maarten


On 22/08/2022 07:57, Hervé BOUTEMY wrote:

uh, sorry, I overlooked that I broke the core ITs...

looking at the error message:
"[ERROR] Plugin org.apache.maven.plugins:maven-dependency-plugin:3.3.0 or one
of its dependencies could not be resolved: org.apache.maven.plugins:maven-
dependency-plugin:jar:3.3.0 was not found in file:target/null"
it seems it's the classical "disconnected ITs run" issue: let's use my mistake
as a training :)

- explanations are in the "Core ITs Suite and Dependencies (incl. Plugins)" of
https://maven.apache.org/core-its/core-it-suite/

- looking at bootstrap output, it seems maven-dependency-plugin 3.1.1 is
available instead of 3.3.0 => I'll update the failing ITs and it should be
solved

Regards,

Hervé

Le lundi 22 août 2022, 06:50:40 CEST Henning Schmiedehausen a écrit :

Folks,

I am somewhat struggling to make integration tests pass for PRs. And it
seems that I am not alone. Looking at
https://github.com/apache/maven/commits/master, none of the merged commits
on master has successfully passed the test suite. It seems to have started
with the "[MNG-7353] ..." commit here:
https://github.com/apache/maven/commit/35b93b0a589752cc88105623a2ddf9e52b56c
1ce

The same seems to apply for the maven-3.9.x branch (
https://github.com/apache/maven/commits/maven-3.9.x) - test failures for
all commits after "[MNG-7353] ..." (
https://github.com/apache/maven/commit/95bdbf6821d16c2b4f1df6f820600e0d4b1b9
166 )

This makes it slightly difficult for me to understand if my PRs actually
break something in maven (I am pretty sure they do not) or whether this is
a knock on effect from other integration tests failing.  The issue may be
with the CI setup itself; I can make the integration test suite pass
locally (MacOS 12, Intel, JDK 17) for either branch.

I tried to make sense of the github actions but they seem to be more
complicated than I thought. I can get the test to pass locally by running

% cd maven
% mvn -PversionlessMavenDist clean install
% cd ../maven-integration-testing
% mvn -Prun-its clean install  -DmavenDistro=... reference to the maven
folder .../apache-maven/target/apache-maven-bin.zip

Grateful for any advice. Ideally the folks that wrote the gh actions
(Martin, Sylwester, Maarten) or who commited that change (Hervé) could help.

Thanks,
 Henning






-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: Integration test suite

2022-08-22 Thread Hervé BOUTEMY
I did a first quick pass, but I fear there is an unexpected warning with m-
antrun-p that still causes a failure: I don't time yet to fix, I need to leave, 
help welcome...

Le lundi 22 août 2022, 07:57:31 CEST Hervé BOUTEMY a écrit :
> uh, sorry, I overlooked that I broke the core ITs...
> 
> looking at the error message:
> "[ERROR] Plugin org.apache.maven.plugins:maven-dependency-plugin:3.3.0 or
> one of its dependencies could not be resolved:
> org.apache.maven.plugins:maven- dependency-plugin:jar:3.3.0 was not found
> in file:target/null"
> it seems it's the classical "disconnected ITs run" issue: let's use my
> mistake as a training :)
> 
> - explanations are in the "Core ITs Suite and Dependencies (incl. Plugins)"
> of https://maven.apache.org/core-its/core-it-suite/
> 
> - looking at bootstrap output, it seems maven-dependency-plugin 3.1.1 is
> available instead of 3.3.0 => I'll update the failing ITs and it should be
> solved
> 
> Regards,
> 
> Hervé
> 
> Le lundi 22 août 2022, 06:50:40 CEST Henning Schmiedehausen a écrit :
> > Folks,
> > 
> > I am somewhat struggling to make integration tests pass for PRs. And it
> > seems that I am not alone. Looking at
> > https://github.com/apache/maven/commits/master, none of the merged commits
> > on master has successfully passed the test suite. It seems to have started
> > with the "[MNG-7353] ..." commit here:
> > https://github.com/apache/maven/commit/35b93b0a589752cc88105623a2ddf9e52b5
> > 6c 1ce
> > 
> > The same seems to apply for the maven-3.9.x branch (
> > https://github.com/apache/maven/commits/maven-3.9.x) - test failures for
> > all commits after "[MNG-7353] ..." (
> > https://github.com/apache/maven/commit/95bdbf6821d16c2b4f1df6f820600e0d4b1
> > b9 166 )
> > 
> > This makes it slightly difficult for me to understand if my PRs actually
> > break something in maven (I am pretty sure they do not) or whether this is
> > a knock on effect from other integration tests failing.  The issue may be
> > with the CI setup itself; I can make the integration test suite pass
> > locally (MacOS 12, Intel, JDK 17) for either branch.
> > 
> > I tried to make sense of the github actions but they seem to be more
> > complicated than I thought. I can get the test to pass locally by running
> > 
> > % cd maven
> > % mvn -PversionlessMavenDist clean install
> > % cd ../maven-integration-testing
> > % mvn -Prun-its clean install  -DmavenDistro=... reference to the maven
> > folder .../apache-maven/target/apache-maven-bin.zip
> > 
> > Grateful for any advice. Ideally the folks that wrote the gh actions
> > (Martin, Sylwester, Maarten) or who commited that change (Hervé) could
> > help.
> > 
> > Thanks,
> > 
> > Henning
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org





-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org