Re: plexus-utils 4.x and Xpp3DomBuilder
Howdy, Basil's issue is made me realize: o.c.p:p-u 4.x that depends on -> o.c.p:p-xml 4 that depends on -> o.a.m:m-api-xml that depends on -> o.a.m:m-api-meta This means that p-u pulls in new Maven4 API bits. Hence, Maven 3 plugin, that is built against maven-plugin-api 3.x, if switched to p-u 4, would start receiving bits of Maven4 new API... This is a big no for me, not to mention how this can prove problematic down the road too: this means that today (as all this is "just on CP") mvn3 plugin could use bits of Maven4 API that later -- if run in Maven4 -- becomes forbidden/unavailable... So, IMHO this just proves, that Maven 3.x level plugins should stick with p-u 3.x On Fri, Sep 8, 2023 at 6:24 PM Basil Crow wrote: > I raised this issue in > > https://github.com/jenkinsci/maven-hpi-plugin/pull/490#issuecomment-1557970717 > but did not receive a response. > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
Re: plexus-utils 4.x and Xpp3DomBuilder
I raised this issue in https://github.com/jenkinsci/maven-hpi-plugin/pull/490#issuecomment-1557970717 but did not receive a response. - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[VOTE] Release Maven Resolver Ant Tasks 1.5.0
Howdy, We solved 6 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628=12348840 There are still some issues in JIRA: https://issues.apache.org/jira/issues/?jql=project%20%3D%20MRESOLVER%20AND%20status%20%3D%20Open%20AND%20component%20%3D%20%22Ant%20Tasks%22 Staging repository: https://repository.apache.org/content/repositories/maven-1988 Source release SHA512: 6e5bd3918d8b9d7c30fe4f1b5c71521789a4960effa6e5af36fd683755bed0c3b2ac51bb69f53677e1cd0acd909edcbc7d5c7991e9bf9c4bc9631d4fc95f3e0f Staging site: https://maven.apache.org/resolver-archives/resolver-ant-tasks-LATEST/ Guide to testing staged releases: https://maven.apache.org/guides/development/guide-testing-releases.html Vote open for 72 hours. [ ] +1 [ ] +0 [ ] -1
Re: plexus-utils 4.x and Xpp3DomBuilder
Adding my last 5 cents and will stop here: - as you know, my goal is to push through the door latest Maven 3.x (3.9.5) and Resolver 1.x (1.9.16) - in a moment that happens, declare Maven 3.x and Resolver 1.x "bugfix only" -- and we should focus on Maven 4 - hence, for this, simplest would be to declare "maven 3 plugins (and our all plugins are current maven 3 plugins!) are stuck with p-u 3.x - yes, this may need some extra effort down the line to produce p-u 3.5.2 for some security/bugfix maybe, but that is the least problematic - keep p-u 4.x for Maven 4 plugins T On Fri, Sep 8, 2023 at 11:38 AM Tamás Cservenák wrote: > I disagree here (or would like to have us be very cautious here): > > - the reason why p-u XML bits are exported are Modello generated models > only (as they may have fiels like Xpp3Dom and generated IO classes uses XML > bits as well) > - plugins should remain capable to interact with Modello generated models > - Maven 3.x uses "classic" modello, that must have runtime present/depends > on p-u 3.x > > By mixing here p-u 4 with p-u 3 IMHO we just look for trouble > > Also, by this change, we will introduce "plugin X will work ONLY with > Maven 3.9.5+", no? > > T > > On Mon, Sep 4, 2023 at 10:51 PM Guillaume Nodet wrote: > >> I think the decision to not export plexus-utils was taken some time ago. >> >> Unfortunately, the xml bits still have to be provided by the maven core >> class loader. >> I think in this case, Maven 3.9.x should also expose the builder class >> >> >> org.codehaus.plexus.util.xml.Xpp3DomBuilder >> I think this should work, but this would only solve the problem for the >> latest 3.9.x maven, not older versions. >> >> >> Le mar. 25 juil. 2023 à 20:56, Slawomir Jaranowski < >> s.jaranow...@gmail.com> >> a écrit : >> >> > Hi >> > >> > I'm trying to update plexus-utils 3.5.x to plexus-utils/plexus-xml 4.x >> in >> > maven-enforcer >> > >> > In maven-enforcer (and in many other plugins ...) is used, code like: >> > >> > Xpp3Dom enforcerRules = >> Xpp3DomBuilder.build(descriptorStream, >> > "UTF-8"); >> > >> > Xpp3Dom and Xpp3DomBuilder - has new implementation in plexus-xml >> but >> > Maven 3.x exports >> > >> > >> > >> org.codehaus.plexus.util.xml.Xpp3Dom >> > >> > >> > >> org.codehaus.plexus.util.xml.pull.XmlPullParser >> > >> > >> > >> org.codehaus.plexus.util.xml.pull.XmlPullParserException >> > >> > >> > >> org.codehaus.plexus.util.xml.pull.XmlSerializer >> > >> > It is very magical that we export classes but not export artifact >> > which contains those classes ... >> > >> > so incompatibilite code for Xpp3Dom is used ... >> > >> > Any hints on how to process it. >> > >> > -- >> > Sławomir Jaranowski >> > >> >> >> -- >> >> Guillaume Nodet >> >
Re: plexus-utils 4.x and Xpp3DomBuilder
I disagree here (or would like to have us be very cautious here): - the reason why p-u XML bits are exported are Modello generated models only (as they may have fiels like Xpp3Dom and generated IO classes uses XML bits as well) - plugins should remain capable to interact with Modello generated models - Maven 3.x uses "classic" modello, that must have runtime present/depends on p-u 3.x By mixing here p-u 4 with p-u 3 IMHO we just look for trouble Also, by this change, we will introduce "plugin X will work ONLY with Maven 3.9.5+", no? T On Mon, Sep 4, 2023 at 10:51 PM Guillaume Nodet wrote: > I think the decision to not export plexus-utils was taken some time ago. > > Unfortunately, the xml bits still have to be provided by the maven core > class loader. > I think in this case, Maven 3.9.x should also expose the builder class > > > org.codehaus.plexus.util.xml.Xpp3DomBuilder > I think this should work, but this would only solve the problem for the > latest 3.9.x maven, not older versions. > > > Le mar. 25 juil. 2023 à 20:56, Slawomir Jaranowski > > a écrit : > > > Hi > > > > I'm trying to update plexus-utils 3.5.x to plexus-utils/plexus-xml 4.x in > > maven-enforcer > > > > In maven-enforcer (and in many other plugins ...) is used, code like: > > > > Xpp3Dom enforcerRules = > Xpp3DomBuilder.build(descriptorStream, > > "UTF-8"); > > > > Xpp3Dom and Xpp3DomBuilder - has new implementation in plexus-xml > but > > Maven 3.x exports > > > > > > > org.codehaus.plexus.util.xml.Xpp3Dom > > > > > > > org.codehaus.plexus.util.xml.pull.XmlPullParser > > > > > > > org.codehaus.plexus.util.xml.pull.XmlPullParserException > > > > > > > org.codehaus.plexus.util.xml.pull.XmlSerializer > > > > It is very magical that we export classes but not export artifact > > which contains those classes ... > > > > so incompatibilite code for Xpp3Dom is used ... > > > > Any hints on how to process it. > > > > -- > > Sławomir Jaranowski > > > > > -- > > Guillaume Nodet >
Re: plexus-utils 4.x and Xpp3DomBuilder
On Tue, Jul 25, 2023 at 8:57 PM Slawomir Jaranowski wrote: > It is very magical that we export classes but not export artifact > which contains those classes ... > > So, just to clear up: For ref http://takari.io/book/91-maven-classloading.html In relation to https://github.com/apache/maven/blob/maven-3.9.x/maven-core/src/main/resources/META-INF/maven/extension.xml "export package" => the package is imported by child classloader (or in other words, is exported by core) "export artifact" => (and this may be surprising) HAS NO DIRECT CLASSLOADER EFFECT, this is more like whole artifact is IGNORED/not added to child classloader CP, despite artifact has dependency on it (keyed by GA, V ignored), as assumption is that core "export package" provides replacement And one more remark: classrealms created are "self first" (so they consult themselves first, then parent), EXCEPT for imported entries that always come from import (someone correct me if I am wrong here). And plugin realms have Maven API imported (!) if no extension, or have Maven API as parent and imported extension, if any, Conclusion: "exported package" ALWAYS OVERRIDE classes, whatever plugin does (sans shading, of course). Digression: You may remember, that this was the whole point of "provided" changes sweeping across plugins: - in Maven 3.8.x times, such artifacts were collected/resolved (jar downloaded to local repo) only to be omitted from CP --> waste of time, bandwidth and confusing to users: after build their local repo contained million different Vs of things like maven-core (all the versions that each plugins were coded against) - with "provided" scope this does not happen anymore (is not collected nor resolved/downloaded) - but, we had experiments in this area (for example https://issues.apache.org/jira/browse/MNG-7097) that led to the first "provided" solution (but it needed a bugfix in MPP) - moreover, extension.xml changes are to be expected, as there are other upcoming experiments (and we'd need V, so "exported artifacts" should be expanded to GAV at least (probably at build time) - and based on that, next "major improvement" (in guided resolution) improving speed and all is something along this line: https://github.com/apache/maven/pull/1188 (where Maven Core, "knowing itself constituents" already auto-injects itself as depMgt for plugins) And sorry for the thread hijack... === As for current thread: Given our goal is to totally decouple plexus-utils, maybe we want instead this: org.codehaus.plexus.util.xml.Xpp3Dom org.codehaus.plexus.util.xml.pull.XmlPullParser org.codehaus.plexus.util.xml.pull.XmlPullParserException org.codehaus.plexus.util.xml.pull.XmlSerializer to have this? org.codehaus.plexus.util.xml ?
Re: [VOTE] Release Apache Maven Enforcer version 3.4.1
+1 On Fri, 8 Sept 2023 at 03:40, Slawomir Jaranowski wrote: > > Hi, > > We solved 2 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317520=12353576 > > There are still a couple of issues left in JIRA: > https://issues.apache.org/jira/issues/?jql=project%20%3D%20MENFORCER%20AND%20resolution%20%3D%20Unresolved > > Staging repo: > https://repository.apache.org/content/repositories/maven-1987/ > https://repository.apache.org/content/repositories/maven-1987/org/apache/maven/enforcer/enforcer/3.4.1/enforcer-3.4.1-source-release.zip > > Source release checksum(s): > enforcer-3.4.1-source-release.zip - SHA-512 : > 64fcd4a97487ae50976426da63f3ba58cb0fe47a72235afa8f05e5d6e8118ad09dbc8269c5ff106ab1e274dd54e439c737585df1232b85be7ea202aee6ac5864 > > Staging site: > https://maven.apache.org/enforcer-archives/enforcer-LATEST/ > > Guide to testing staged releases: > https://maven.apache.org/guides/development/guide-testing-releases.html > > Vote open for at least 72 hours. > > [ ] +1 > [ ] +0 > [ ] -1 > > -- > Sławomir Jaranowski - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven Enforcer version 3.4.1
+1 On Thu, Sep 7, 2023 at 7:40 PM Slawomir Jaranowski wrote: > Hi, > > We solved 2 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317520=12353576 > > There are still a couple of issues left in JIRA: > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20MENFORCER%20AND%20resolution%20%3D%20Unresolved > > Staging repo: > https://repository.apache.org/content/repositories/maven-1987/ > > https://repository.apache.org/content/repositories/maven-1987/org/apache/maven/enforcer/enforcer/3.4.1/enforcer-3.4.1-source-release.zip > > Source release checksum(s): > enforcer-3.4.1-source-release.zip - SHA-512 : > > 64fcd4a97487ae50976426da63f3ba58cb0fe47a72235afa8f05e5d6e8118ad09dbc8269c5ff106ab1e274dd54e439c737585df1232b85be7ea202aee6ac5864 > > Staging site: > https://maven.apache.org/enforcer-archives/enforcer-LATEST/ > > Guide to testing staged releases: > https://maven.apache.org/guides/development/guide-testing-releases.html > > Vote open for at least 72 hours. > > [ ] +1 > [ ] +0 > [ ] -1 > > -- > Sławomir Jaranowski >
Re: [VOTE] Release Apache Maven Enforcer version 3.4.1
+1 pt., 8 wrz 2023, 07:59 użytkownik Herve Boutemy napisał: > +1 > > Reproducible Build ok: reference build done with JDK 17 on *nix with umask > 022 > > Regards, > > Hervé > > On 2023/09/07 17:39:48 Slawomir Jaranowski wrote: > > Hi, > > > > We solved 2 issues: > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317520=12353576 > > > > There are still a couple of issues left in JIRA: > > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20MENFORCER%20AND%20resolution%20%3D%20Unresolved > > > > Staging repo: > > https://repository.apache.org/content/repositories/maven-1987/ > > > https://repository.apache.org/content/repositories/maven-1987/org/apache/maven/enforcer/enforcer/3.4.1/enforcer-3.4.1-source-release.zip > > > > Source release checksum(s): > > enforcer-3.4.1-source-release.zip - SHA-512 : > > > 64fcd4a97487ae50976426da63f3ba58cb0fe47a72235afa8f05e5d6e8118ad09dbc8269c5ff106ab1e274dd54e439c737585df1232b85be7ea202aee6ac5864 > > > > Staging site: > > https://maven.apache.org/enforcer-archives/enforcer-LATEST/ > > > > Guide to testing staged releases: > > https://maven.apache.org/guides/development/guide-testing-releases.html > > > > Vote open for at least 72 hours. > > > > [ ] +1 > > [ ] +0 > > [ ] -1 > > > > -- > > Sławomir Jaranowski > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
Re: plexus-utils 4.x and Xpp3DomBuilder
Thanks, I will create an IT for it. Good idea to describe the migration from plexus 3.x to 4.x. pt., 8 wrz 2023 o 10:26 Guillaume Nodet napisał(a): > I've raised MNG-7873. > Slawomir, do you think you could create an IT for that ? > I'll try to provide a fix asap, but a clean IT would make sure the problem > is actually fixed. > > I think we should also update the plexus-utils release notes with some more > information about the migration to 4.x when using the xml bits. > > [1] https://issues.apache.org/jira/browse/MNG-7873 > > Le lun. 4 sept. 2023 à 22:50, Guillaume Nodet a écrit > : > > > I think the decision to not export plexus-utils was taken some time ago. > > > > Unfortunately, the xml bits still have to be provided by the maven core > > class loader. > > I think in this case, Maven 3.9.x should also expose the builder class > > > > > org.codehaus.plexus.util.xml.Xpp3DomBuilder > > I think this should work, but this would only solve the problem for the > > latest 3.9.x maven, not older versions. > > > > > > Le mar. 25 juil. 2023 à 20:56, Slawomir Jaranowski < > s.jaranow...@gmail.com> > > a écrit : > > > >> Hi > >> > >> I'm trying to update plexus-utils 3.5.x to plexus-utils/plexus-xml 4.x > in > >> maven-enforcer > >> > >> In maven-enforcer (and in many other plugins ...) is used, code like: > >> > >> Xpp3Dom enforcerRules = > Xpp3DomBuilder.build(descriptorStream, > >> "UTF-8"); > >> > >> Xpp3Dom and Xpp3DomBuilder - has new implementation in plexus-xml > but > >> Maven 3.x exports > >> > >> > >> > >> org.codehaus.plexus.util.xml.Xpp3Dom > >> > >> > >> > org.codehaus.plexus.util.xml.pull.XmlPullParser > >> > >> > >> > org.codehaus.plexus.util.xml.pull.XmlPullParserException > >> > >> > >> > org.codehaus.plexus.util.xml.pull.XmlSerializer > >> > >> It is very magical that we export classes but not export artifact > >> which contains those classes ... > >> > >> so incompatibilite code for Xpp3Dom is used ... > >> > >> Any hints on how to process it. > >> > >> -- > >> Sławomir Jaranowski > >> > > > > > > -- > > > > Guillaume Nodet > > > > > > -- > > Guillaume Nodet > -- Sławomir Jaranowski
Re: plexus-utils 4.x and Xpp3DomBuilder
I've raised MNG-7873. Slawomir, do you think you could create an IT for that ? I'll try to provide a fix asap, but a clean IT would make sure the problem is actually fixed. I think we should also update the plexus-utils release notes with some more information about the migration to 4.x when using the xml bits. [1] https://issues.apache.org/jira/browse/MNG-7873 Le lun. 4 sept. 2023 à 22:50, Guillaume Nodet a écrit : > I think the decision to not export plexus-utils was taken some time ago. > > Unfortunately, the xml bits still have to be provided by the maven core > class loader. > I think in this case, Maven 3.9.x should also expose the builder class > > org.codehaus.plexus.util.xml.Xpp3DomBuilder > I think this should work, but this would only solve the problem for the > latest 3.9.x maven, not older versions. > > > Le mar. 25 juil. 2023 à 20:56, Slawomir Jaranowski > a écrit : > >> Hi >> >> I'm trying to update plexus-utils 3.5.x to plexus-utils/plexus-xml 4.x in >> maven-enforcer >> >> In maven-enforcer (and in many other plugins ...) is used, code like: >> >> Xpp3Dom enforcerRules = Xpp3DomBuilder.build(descriptorStream, >> "UTF-8"); >> >> Xpp3Dom and Xpp3DomBuilder - has new implementation in plexus-xml but >> Maven 3.x exports >> >> >> >> org.codehaus.plexus.util.xml.Xpp3Dom >> >> >> org.codehaus.plexus.util.xml.pull.XmlPullParser >> >> >> org.codehaus.plexus.util.xml.pull.XmlPullParserException >> >> >> org.codehaus.plexus.util.xml.pull.XmlSerializer >> >> It is very magical that we export classes but not export artifact >> which contains those classes ... >> >> so incompatibilite code for Xpp3Dom is used ... >> >> Any hints on how to process it. >> >> -- >> Sławomir Jaranowski >> > > > -- > > Guillaume Nodet > > -- Guillaume Nodet
Re: Coming soon: Maven 3.9.5
I think we need to expose the missing class before cutting a release, see https://lists.apache.org/thread/ltd1g1dbv0lqqdw5q941gmrkfyn6m87m I've raised MNG-7873 for that. Le jeu. 7 sept. 2023, 16:18, Tamás Cservenák a écrit : > Howdy, > > Just a heads up, that am targeting following releases: > > Maven Resolver 1.9.16: > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20MRESOLVER%20AND%20fixVersion%20%3D%201.9.16 > > Maven 3.9.5: > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20MNG%20AND%20fixVersion%20%3D%203.9.5 > > So if anyone has anything more to add, bring it up! > > TIA > T >
