Re: Maven 5 pom extension for agents

2023-10-17 Thread Romain Manni-Bucau
Side note: any agent wants to be first so it is an user explicit choice -
if you want to work on mockito - it happens - you need an agent before.

With agent dependency like list we have an order but will be a mess with
inheritance.

My 2cts are this is a false issue, we use agent with maven with years
(since I startes to work on my side) and it never got a blocker.

Mockito hits it as a blocker due to its switch for java 21 but they can
likely rethink their design or document their setup - surefire being
integrated with idea it is smooth to use.

Hope it makes sense.

Le mer. 18 oct. 2023 à 07:05, Benjamin Marwell  a
écrit :

> If you can still use it twice, works for me, too.
>
> Either way, you'd need it both as a dependency and as an agent.
>
> Another requirement Romain mentioned is the order of agent loading. Mockito
> wants to be first, and others can come later.
>
> - Ben
>
>
>
>
> On Wed, 18 Oct 2023, 00:11 Tamás Cservenák,  wrote:
>
> > What about type=java-agent? Basically a new ArtifactHandler?
> >
> > See https://maven.apache.org/repositories/artifacts.html
> >
> > T
> >
> > On Tue, Oct 17, 2023, 23:54 Benjamin Marwell 
> wrote:
> >
> > > Hey all,
> > >
> > > In a mockito issue, JDK maintainers suggested to differentiate between
> > > agents and normal dependencies. Starting with JDK 21 already, this
> makes
> > a
> > > lot of sense: dynamic loading of agents will be a no-go.
> > >
> > > One suggestion was:
> > >
> > > 
> > > 
> > > ...
> > > 
> > > 
> > > 
> > > ...
> > > 
> > > 
> > > 
> > >
> > > Not sure if this is the best way, but this is something similar might
> be
> > > needed.
> > > Currently, the only way to handle agents is to add them manually to the
> > > surefire argLine. To make things worse, a deoendency goal is needed
> until
> > > Romains PR is merged:
> > > https://github.com/apache/maven/pull/1281
> > >
> > > Another issue is that a parent pom might not be able to easily define
> > this
> > > option. There were some concerns that part of the configuration needed
> to
> > > be repeated in every module.
> > >
> > > So, I wrote Maven 5.
> > > Maven 4 is the stepping stone to the build/consumer pom. But this is an
> > > extension. Not really a breaking change in terms of parsing, but in
> terms
> > > of building a project. Thus, it should go onto the roadmap.
> > >
> > > ... unless you want to keep the current status quo, which is also an
> > > option. But before making an argument here, I'd recommend reading the
> > > lengthy (sorry!) discussion on the mockito issue tracker. Since Karl
> > Heinz
> > > started the issue, I'd love to hear back from you, too. Link:
> > > https://github.com/mockito/mockito/issues/3037
> > >
> > > If no discussion is needed at this point, let's keep this as a reminder
> > for
> > > the next Apero and/or Maven 5 then.
> > >
> > > - Ben
> > >
> >
>


Re: Maven 5 pom extension for agents

2023-10-17 Thread Benjamin Marwell
If you can still use it twice, works for me, too.

Either way, you'd need it both as a dependency and as an agent.

Another requirement Romain mentioned is the order of agent loading. Mockito
wants to be first, and others can come later.

- Ben




On Wed, 18 Oct 2023, 00:11 Tamás Cservenák,  wrote:

> What about type=java-agent? Basically a new ArtifactHandler?
>
> See https://maven.apache.org/repositories/artifacts.html
>
> T
>
> On Tue, Oct 17, 2023, 23:54 Benjamin Marwell  wrote:
>
> > Hey all,
> >
> > In a mockito issue, JDK maintainers suggested to differentiate between
> > agents and normal dependencies. Starting with JDK 21 already, this makes
> a
> > lot of sense: dynamic loading of agents will be a no-go.
> >
> > One suggestion was:
> >
> > 
> > 
> > ...
> > 
> > 
> > 
> > ...
> > 
> > 
> > 
> >
> > Not sure if this is the best way, but this is something similar might be
> > needed.
> > Currently, the only way to handle agents is to add them manually to the
> > surefire argLine. To make things worse, a deoendency goal is needed until
> > Romains PR is merged:
> > https://github.com/apache/maven/pull/1281
> >
> > Another issue is that a parent pom might not be able to easily define
> this
> > option. There were some concerns that part of the configuration needed to
> > be repeated in every module.
> >
> > So, I wrote Maven 5.
> > Maven 4 is the stepping stone to the build/consumer pom. But this is an
> > extension. Not really a breaking change in terms of parsing, but in terms
> > of building a project. Thus, it should go onto the roadmap.
> >
> > ... unless you want to keep the current status quo, which is also an
> > option. But before making an argument here, I'd recommend reading the
> > lengthy (sorry!) discussion on the mockito issue tracker. Since Karl
> Heinz
> > started the issue, I'd love to hear back from you, too. Link:
> > https://github.com/mockito/mockito/issues/3037
> >
> > If no discussion is needed at this point, let's keep this as a reminder
> for
> > the next Apero and/or Maven 5 then.
> >
> > - Ben
> >
>


Re: Maven 5 pom extension for agents

2023-10-17 Thread Tamás Cservenák
What about type=java-agent? Basically a new ArtifactHandler?

See https://maven.apache.org/repositories/artifacts.html

T

On Tue, Oct 17, 2023, 23:54 Benjamin Marwell  wrote:

> Hey all,
>
> In a mockito issue, JDK maintainers suggested to differentiate between
> agents and normal dependencies. Starting with JDK 21 already, this makes a
> lot of sense: dynamic loading of agents will be a no-go.
>
> One suggestion was:
>
> 
> 
> ...
> 
> 
> 
> ...
> 
> 
> 
>
> Not sure if this is the best way, but this is something similar might be
> needed.
> Currently, the only way to handle agents is to add them manually to the
> surefire argLine. To make things worse, a deoendency goal is needed until
> Romains PR is merged:
> https://github.com/apache/maven/pull/1281
>
> Another issue is that a parent pom might not be able to easily define this
> option. There were some concerns that part of the configuration needed to
> be repeated in every module.
>
> So, I wrote Maven 5.
> Maven 4 is the stepping stone to the build/consumer pom. But this is an
> extension. Not really a breaking change in terms of parsing, but in terms
> of building a project. Thus, it should go onto the roadmap.
>
> ... unless you want to keep the current status quo, which is also an
> option. But before making an argument here, I'd recommend reading the
> lengthy (sorry!) discussion on the mockito issue tracker. Since Karl Heinz
> started the issue, I'd love to hear back from you, too. Link:
> https://github.com/mockito/mockito/issues/3037
>
> If no discussion is needed at this point, let's keep this as a reminder for
> the next Apero and/or Maven 5 then.
>
> - Ben
>


Maven 5 pom extension for agents

2023-10-17 Thread Benjamin Marwell
Hey all,

In a mockito issue, JDK maintainers suggested to differentiate between
agents and normal dependencies. Starting with JDK 21 already, this makes a
lot of sense: dynamic loading of agents will be a no-go.

One suggestion was:



...



...




Not sure if this is the best way, but this is something similar might be
needed.
Currently, the only way to handle agents is to add them manually to the
surefire argLine. To make things worse, a deoendency goal is needed until
Romains PR is merged:
https://github.com/apache/maven/pull/1281

Another issue is that a parent pom might not be able to easily define this
option. There were some concerns that part of the configuration needed to
be repeated in every module.

So, I wrote Maven 5.
Maven 4 is the stepping stone to the build/consumer pom. But this is an
extension. Not really a breaking change in terms of parsing, but in terms
of building a project. Thus, it should go onto the roadmap.

... unless you want to keep the current status quo, which is also an
option. But before making an argument here, I'd recommend reading the
lengthy (sorry!) discussion on the mockito issue tracker. Since Karl Heinz
started the issue, I'd love to hear back from you, too. Link:
https://github.com/mockito/mockito/issues/3037

If no discussion is needed at this point, let's keep this as a reminder for
the next Apero and/or Maven 5 then.

- Ben


Re: [VOTE] Retire Maven Docck Plugin

2023-10-17 Thread Benjamin Marwell
+1





On Tue, 17 Oct 2023, 00:50 Slawomir Jaranowski, 
wrote:

> Hi,
>
> - Last release was in 2015
> - use Maven 2.2.1
> - we have a Maven Plugin Tools - which should be one project for build and
> check Maven plugins
> - no active development ...
>
>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MDOCCK%20AND%20(%20resolution%20%3D%20Unresolved%20OR%20fixVersion%20%3D%203.0.0)
> - no working with current plugins
>
> I therefore propose that we retire maven-docck-plugin -
> https://maven.apache.org/plugins/maven-docck-plugin/
>
> If this vote is successful I will make one final release of the plugin,
> making it clear on the plugin site that it has been retired.
> After that the source code will be moved into read-only mode.
>
> The process for retiring a plugin is described here:
> https://maven.apache.org/developers/retirement-plan-plugins.html
>
> The vote is open for 72 hours.
>
> [ ] +1 Yes, it's about time
> [ ] -1 No, because...
>
> [1]
>
> --
> Sławomir Jaranowski
>


Re: [VOTE] Retire Maven Docck Plugin

2023-10-17 Thread Enrico Olivelli
+1 (non binding)

Enrico

Il Mar 17 Ott 2023, 21:57 Karl Heinz Marbaise  ha
scritto:

> Hi,
>
> +1 from me.
>
> Kind regards
> Karl Heinz Marbaise
> On 17.10.23 00:50, Slawomir Jaranowski wrote:
> > Hi,
> >
> > - Last release was in 2015
> > - use Maven 2.2.1
> > - we have a Maven Plugin Tools - which should be one project for build
> and
> > check Maven plugins
> > - no active development ...
> >
> >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MDOCCK%20AND%20(%20resolution%20%3D%20Unresolved%20OR%20fixVersion%20%3D%203.0.0)
> > - no working with current plugins
> >
> > I therefore propose that we retire maven-docck-plugin -
> > https://maven.apache.org/plugins/maven-docck-plugin/
> >
> > If this vote is successful I will make one final release of the plugin,
> > making it clear on the plugin site that it has been retired.
> > After that the source code will be moved into read-only mode.
> >
> > The process for retiring a plugin is described here:
> > https://maven.apache.org/developers/retirement-plan-plugins.html
> >
> > The vote is open for 72 hours.
> >
> > [ ] +1 Yes, it's about time
> > [ ] -1 No, because...
> >
> > [1]
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>


Re: [VOTE] Retire Maven Docck Plugin

2023-10-17 Thread Karl Heinz Marbaise

Hi,

+1 from me.

Kind regards
Karl Heinz Marbaise
On 17.10.23 00:50, Slawomir Jaranowski wrote:

Hi,

- Last release was in 2015
- use Maven 2.2.1
- we have a Maven Plugin Tools - which should be one project for build and
check Maven plugins
- no active development ...

https://issues.apache.org/jira/issues/?jql=project%20%3D%20MDOCCK%20AND%20(%20resolution%20%3D%20Unresolved%20OR%20fixVersion%20%3D%203.0.0)
- no working with current plugins

I therefore propose that we retire maven-docck-plugin -
https://maven.apache.org/plugins/maven-docck-plugin/

If this vote is successful I will make one final release of the plugin,
making it clear on the plugin site that it has been retired.
After that the source code will be moved into read-only mode.

The process for retiring a plugin is described here:
https://maven.apache.org/developers/retirement-plan-plugins.html

The vote is open for 72 hours.

[ ] +1 Yes, it's about time
[ ] -1 No, because...

[1]




-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: Strange ServiceLoader issue with Surefire and JDK 21 bytecode

2023-10-17 Thread Mark Raynsford
On 2023-10-16T13:59:05 +0200
Romain Manni-Bucau  wrote:

> Yes, this is the one I had in mind, think it comes from plexus transitive
> deps.

For reference:

  

  

  org.apache.maven.plugins
  maven-surefire-plugin
  3.1.2
  

  org.ow2.asm
  asm
  9.6

  

  

  

... does indeed fix the problem. Thanks!

-- 
Mark Raynsford | https://www.io7m.com



pgpIs_MHRxpyT.pgp
Description: OpenPGP digital signature


Re: [VOTE] Retire Maven Docck Plugin

2023-10-17 Thread Maarten Mulders

+1

On 17/10/2023 00:50, Slawomir Jaranowski wrote:

Hi,

- Last release was in 2015
- use Maven 2.2.1
- we have a Maven Plugin Tools - which should be one project for build and
check Maven plugins
- no active development ...

https://issues.apache.org/jira/issues/?jql=project%20%3D%20MDOCCK%20AND%20(%20resolution%20%3D%20Unresolved%20OR%20fixVersion%20%3D%203.0.0)
- no working with current plugins

I therefore propose that we retire maven-docck-plugin -
https://maven.apache.org/plugins/maven-docck-plugin/

If this vote is successful I will make one final release of the plugin,
making it clear on the plugin site that it has been retired.
After that the source code will be moved into read-only mode.

The process for retiring a plugin is described here:
https://maven.apache.org/developers/retirement-plan-plugins.html

The vote is open for 72 hours.

[ ] +1 Yes, it's about time
[ ] -1 No, because...

[1]



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[ANN] Apache Maven Reporting Impl 4.0.0-M11 released

2023-10-17 Thread Michael Osipov
The Apache Maven team is pleased to announce the release of the Maven 
Reporting Impl version 4.0.0-M11.


https://maven.apache.org/shared/maven-reporting-impl/


Release Notes - Maven Shared Components - Version 
maven-reporting-impl-4.0.0-M11


** Improvement
* [MSHARED-1314] - mark execute() final to avoid users extending 
reporting-impl implementation


** Dependency upgrade
* [MSHARED-1318] - Upgrade to Doxia 2.0.0-M8
* [MSHARED-1319] - Upgrade to Doxia Sitetools 2.0.0-M13
* [MSHARED-1320] - Upgrade to Maven Reporting API 4.0.0-M8
* [MSHARED-1321] - Upgrade plugins and components (in ITs)


Enjoy,

-The Apache Maven team

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[ANN] Apache Maven Doxia Sitetools 2.0.0-M13 released

2023-10-17 Thread Michael Osipov
The Apache Maven team is pleased to announce the release of the Apache 
Maven Doxia Sitetools, version 2.0.0-M13


https://maven.apache.org/doxia/doxia-sitetools/


Release Notes - Maven Doxia Sitetools - Version 2.0.0-M13

** Dependency upgrade
* [DOXIASITETOOLS-314] - Upgrade to Doxia 2.0.0-M8
* [DOXIASITETOOLS-315] - Upgrade to Maven Fluido Skin 2.0.0-M8 in 
default site descriptor

* [DOXIASITETOOLS-316] - Upgrade to Maven Reporting API 4.0.0-M8


Enjoy,

-The Apache Maven team

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[ANN] Maven Site Plugin 4.0.0-M11 released

2023-10-17 Thread Michael Osipov
The Apache Maven team is pleased to announce the release of the Maven 
Site Plugin, version 4.0.0-M11.


https://maven.apache.org/plugins/maven-site-plugin/


Release Notes - Maven Site Plugin - Version 4.0.0-M11

** Dependency upgrade
* [MSITE-981] - Upgrade to Doxia 2.0.0-M8
* [MSITE-982] - Upgrade to Doxia Sitetools 2.0.0-M13
* [MSITE-983] - Upgrade to Maven Reporting API 4.0.0-M8
* [MSITE-984] - Upgrade to Maven Reporting Impl/Exec 4.0.0-M11
* [MSITE-985] - Upgrade plugins and components (in ITs)


Please also note for this new major version: 
https://cwiki.apache.org/confluence/display/MAVEN/Towards+Doxia+2.0.0+Stack


Enjoy,

-The Apache Maven team

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[ANN] Apache Maven Reporting Exec 2.0.0-M11 released

2023-10-17 Thread Michael Osipov
The Apache Maven team is pleased to announce the release of the Maven 
Reporting Exec version 2.0.0-M11.


https://maven.apache.org/shared/maven-reporting-exec/


Release Notes - Maven Shared Components - Version 
maven-reporting-exec-2.0.0-M11


** Dependency upgrade
* [MSHARED-1322] - Upgrade to Doxia 2.0.0-M8
* [MSHARED-1323] - Upgrade to Maven Reporting API 4.0.0-M8
* [MSHARED-1324] - Upgrade plugins and components (in ITs)


Enjoy,

-The Apache Maven team

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[ANN] Apache Maven Reporting API 4.0.0-M8 released

2023-10-17 Thread Michael Osipov
The Apache Maven team is pleased to announce the release of the Maven 
Reporting API version 4.0.0-M8.


https://maven.apache.org/shared/maven-reporting-api/


Release Notes - Maven Shared Components - Version 
maven-reporting-api-4.0.0-M8


** Dependency upgrade
* [MSHARED-1316] - Upgrade to Parent 40
* [MSHARED-1317] - Upgrade to Doxia 2.0.0-M8


Enjoy,

-The Apache Maven team

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[ANN] Apache Maven Doxia version 2.0.0-M8 released

2023-10-17 Thread Michael Osipov
The Apache Maven team is pleased to announce the release of the Apache 
Maven Doxia, version 2.0.0-M8


https://maven.apache.org/doxia/


Release Notes - Maven Doxia - Version 2.0.0-M8

* Bug
* [DOXIA-706] - Sink.text(String, SinkEventAttributes) not properly 
supported by Xhtml5BaseSink


** Dependency upgrade
* [DOXIA-708] - Upgrade to Parent 40


Enjoy,

-The Apache Maven team

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[RESULT] [VOTE] Release Apache Maven Reporting Exec version 2.0.0-M11

2023-10-17 Thread Michael Osipov

Hi,

The vote has passed with the following result:

+1: Hervé Boutemy, Jean-Baptiste Onofré, Michael Osipov, Slawomir 
Jaranowski, Sylwester Lachiewicz, Guillaume Nodet, Olivier Lamy


PMC quorum: reached

I will promote the artifacts to the central repo, the source release ZIP 
file and add this release the board report.


[RESULT] [VOTE] Release Maven Site Plugin version 4.0.0-M11

2023-10-17 Thread Michael Osipov

Hi,

The vote has passed with the following result:

+1: Hervé Boutemy, Jean-Baptiste Onofré, Michael Osipov, Slawomir 
Jaranowski, Sylwester Lachiewicz, Guillaume Nodet. Olivier Lamy


PMC quorum: reached

I will promote the artifacts to the central repo, the source release ZIP 
file

and add this release the board report.


[RESULT] [VOTE] Release Apache Maven Reporting Impl version 4.0.0-M11

2023-10-17 Thread Michael Osipov

Hi,

The vote has passed with the following result:

+1: Hervé Boutemy, Jean-Baptiste Onofré, Michael Osipov, Slawomir 
Jaranowski, Sylwester Lachiewicz, Guillaume Nodet, Olivier Lamy


PMC quorum: reached

I will promote the artifacts to the central repo, the source release ZIP 
file and add this release the board report.


[RESULT] [VOTE] Release Apache Maven Doxia Sitetools version 2.0.0-M13

2023-10-17 Thread Michael Osipov

Hi,

The vote has passed with the following result:

+1: Hervé Boutemy, Jean-Baptiste Onofré, Michael Osipov, Slawomir 
Jaranowski, Sylwester Lachiewicz, Guillaume Nodet, Olivier Lamy


PMC quorum: reached

I will promote the artifacts to the central repo, the source release ZIP 
file and add this release the board report.


[RESULT] [VOTE] Release Apache Maven Reporting API version 4.0.0-M8

2023-10-17 Thread Michael Osipov

Hi,

The vote has passed with the following result:

+1: Hervé Boutemy, Jean-Baptiste Onofré, Michael Osipov, Slawomir 
Jaranowski, Sylwester Lachiewicz, Guillaume Nodet


PMC quorum: reached

I will promote the artifacts to the central repo, the source release ZIP 
file and add this release the board report.


[RESULT] [VOTE] Release Maven Doxia version 2.0.0-M8

2023-10-17 Thread Michael Osipov

Hi,

The vote has passed with the following result:

+1: Hervé Boutemy, Jean-Baptiste Onofré, Michael Osipov, Slawomir 
Jaranowski, Sylwester Lachiewicz, Guillaume Nodet


PMC quorum: reached

I will promote the artifacts to the central repo, the source release ZIP 
file and add this release the board report.


Re: [VOTE] Retire Maven Docck Plugin

2023-10-17 Thread Tamás Cservenák
+1

On Tue, Oct 17, 2023, 00:50 Slawomir Jaranowski 
wrote:

> Hi,
>
> - Last release was in 2015
> - use Maven 2.2.1
> - we have a Maven Plugin Tools - which should be one project for build and
> check Maven plugins
> - no active development ...
>
>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MDOCCK%20AND%20(%20resolution%20%3D%20Unresolved%20OR%20fixVersion%20%3D%203.0.0)
> - no working with current plugins
>
> I therefore propose that we retire maven-docck-plugin -
> https://maven.apache.org/plugins/maven-docck-plugin/
>
> If this vote is successful I will make one final release of the plugin,
> making it clear on the plugin site that it has been retired.
> After that the source code will be moved into read-only mode.
>
> The process for retiring a plugin is described here:
> https://maven.apache.org/developers/retirement-plan-plugins.html
>
> The vote is open for 72 hours.
>
> [ ] +1 Yes, it's about time
> [ ] -1 No, because...
>
> [1]
>
> --
> Sławomir Jaranowski
>


Re: [VOTE] Retire Maven Docck Plugin

2023-10-17 Thread Michael Osipov
+1

On 2023/10/16 22:50:18 Slawomir Jaranowski wrote:
> Hi,
> 
> - Last release was in 2015
> - use Maven 2.2.1
> - we have a Maven Plugin Tools - which should be one project for build and
> check Maven plugins
> - no active development ...
> 
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MDOCCK%20AND%20(%20resolution%20%3D%20Unresolved%20OR%20fixVersion%20%3D%203.0.0)
> - no working with current plugins
> 
> I therefore propose that we retire maven-docck-plugin -
> https://maven.apache.org/plugins/maven-docck-plugin/
> 
> If this vote is successful I will make one final release of the plugin,
> making it clear on the plugin site that it has been retired.
> After that the source code will be moved into read-only mode.
> 
> The process for retiring a plugin is described here:
> https://maven.apache.org/developers/retirement-plan-plugins.html
> 
> The vote is open for 72 hours.
> 
> [ ] +1 Yes, it's about time
> [ ] -1 No, because...
> 
> [1]
> 
> -- 
> Sławomir Jaranowski
> 

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org