Re: [Maven-Shade-plugin] Support for Multi Release Jars (JEP-238): Feedback needed

2023-11-11 Thread Romain Manni-Bucau 
Hi Niels,

Looking quickly the drop of the conditional read of the manifest seems the
issue for tests.

In terms of impl my 2cts would be that we shouldnt have had jdependency in
this plugin IMHO so better to stay off it (in particular cause there it is
really not needed, probably saner to read the manifest first then if mjar
is enabled list META-INF/$digit/.* and enable to copy them at need but
otherwise impl looks at the right location for me.

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le sam. 11 nov. 2023 à 19:29, Niels Basjes  a écrit :

> Hi,
>
> I've been working on trying to make the shade plugin support jars that
> are Multi Release Jars (JEP-238)
> https://issues.apache.org/jira/browse/MSHADE-406
> A Multi Release Jar simply means you can have a single class in a single
> jar with multiple implementations (and thus multiple class files in the
> jar) which are used depending on the runtime Java version.
>
> Right now I have made some changes in
> https://github.com/tcurdt/jdependency/pull/209 and
> https://github.com/apache/maven-shade-plugin/pull/202
>
> Right now the m-shade-p build fails over a few tests that are related to
> the META-INF/MANIFEST.MF file.
>
> I have trouble figuring out what is going wrong.
>
> *I would really appreciate it if someone can have a peek at my efforts and
> provide feedback.*
>
> My key questions:
>
>- Is this a correct implementation direction? All the m-shade-p code
>assumes the path of the class file to be the same (if you replace '.'
> and
>'/') as the packagename+classname. I have tried to keep the impact
> limited.
>Perhaps a much more impactful change is needed where for all files a
> record
>is introduced which contains a set of properties (like classname and
>filename separately).
>- What did I do to break the META-INF/MANIFEST.MF related tests? I did
>add the extra flag to indicate it is a multi release jar because that is
>needed by the java runtime, but other than that I've tried to not touch
> it
>(and apparently failed).
>
> Thanks for the feedback
>
> --
> Best regards / Met vriendelijke groeten,
>
> Niels Basjes
>

[Maven-Shade-plugin] Support for Multi Release Jars (JEP-238): Feedback needed

2023-11-11 Thread Niels Basjes 
Hi,

I've been working on trying to make the shade plugin support jars that
are Multi Release Jars (JEP-238)
https://issues.apache.org/jira/browse/MSHADE-406
A Multi Release Jar simply means you can have a single class in a single
jar with multiple implementations (and thus multiple class files in the
jar) which are used depending on the runtime Java version.

Right now I have made some changes in
https://github.com/tcurdt/jdependency/pull/209 and
https://github.com/apache/maven-shade-plugin/pull/202

Right now the m-shade-p build fails over a few tests that are related to
the META-INF/MANIFEST.MF file.

I have trouble figuring out what is going wrong.

*I would really appreciate it if someone can have a peek at my efforts and
provide feedback.*

My key questions:

   - Is this a correct implementation direction? All the m-shade-p code
   assumes the path of the class file to be the same (if you replace '.' and
   '/') as the packagename+classname. I have tried to keep the impact limited.
   Perhaps a much more impactful change is needed where for all files a record
   is introduced which contains a set of properties (like classname and
   filename separately).
   - What did I do to break the META-INF/MANIFEST.MF related tests? I did
   add the extra flag to indicate it is a multi release jar because that is
   needed by the java runtime, but other than that I've tried to not touch it
   (and apparently failed).

Thanks for the feedback

-- 
Best regards / Met vriendelijke groeten,

Niels Basjes

Re: [VOTE] Release Apache Maven POMs 41

2023-11-11 Thread Michael Osipov 

Am 2023-11-09 um 01:06 schrieb Sylwester Lachiewicz:

+1

śr., 8 lis 2023, 23:57 użytkownik Slawomir Jaranowski <
s.jaranow...@gmail.com> napisał:


Hi,

NOTE: Staging of Apache ASF parent 41 is required for testing.

We solved 10 issues:

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311250=12353349

Changes since the last release for Apache Maven POMs:

https://github.com/apache/maven-parent/compare/maven-parent-40...maven-parent-41

Staging repo:
https://repository.apache.org/content/repositories/maven-2026/

https://repository.apache.org/content/repositories/maven-2026/org/apache/maven/maven-parent/41/maven-parent-41-source-release.zip

Source release checksum(s):
maven-parent-41-source-release.zip - SHA-512 :

d3a76493f784edf7032c73b5497837d64db0441a30da1debcb99c3341748c774b791d5f88f4b825937d84394116fe72012b6da9a0dd20e5c5d890269178f6834


Staging site:
https://maven.apache.org/pom-archives/maven-LATEST/

Guide to testing staged releases:
https://maven.apache.org/guides/development/guide-testing-releases.html

Vote open for at least 72 hours.



+1

Re: [VOTE] Release Apache Maven POMs 41

2023-11-11 Thread Michael Osipov 

Am 2023-11-08 um 23:56 schrieb Slawomir Jaranowski:

Hi,

NOTE: Staging of Apache ASF parent 41 is required for testing.

We solved 10 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311250=12353349

Changes since the last release for Apache Maven POMs:
https://github.com/apache/maven-parent/compare/maven-parent-40...maven-parent-41

Staging repo:
https://repository.apache.org/content/repositories/maven-2026/
https://repository.apache.org/content/repositories/maven-2026/org/apache/maven/maven-parent/41/maven-parent-41-source-release.zip

Source release checksum(s):
maven-parent-41-source-release.zip - SHA-512 :
d3a76493f784edf7032c73b5497837d64db0441a30da1debcb99c3341748c774b791d5f88f4b825937d84394116fe72012b6da9a0dd20e5c5d890269178f6834


Staging site:
https://maven.apache.org/pom-archives/maven-LATEST/

Guide to testing staged releases:
https://maven.apache.org/guides/development/guide-testing-releases.html

Vote open for at least 72 hours.


+1


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Apache Maven ASF Parent 31

2023-11-11 Thread Olivier Lamy 
+1

On Thu, 9 Nov 2023 at 08:27, Slawomir Jaranowski  wrote:
>
> Hi,
>
> We solved 11 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311250=12353313
>
> Changes since the last release for Apache Maven ASF Parent:
> https://github.com/apache/maven-apache-parent/compare/apache-30...apache-31
>
> Staging repo:
> https://repository.apache.org/content/repositories/orgapacheapache-1036/
> https://repository.apache.org/content/repositories/orgapacheapache-1036/org/apache/apache/31/apache-31-source-release.zip
>
> Source release checksum(s):
> apache-31-source-release.zip - SHA-512 :
> b60e0ef1899ab77a44b9afe5af50087d353fc67bda991fca11815abc18514f4fea6e90c452a503d56bb342a2a1854f9b4a7f655ce48bda90c5dab67468a06316
>
> Staging site:
> https://maven.apache.org/pom-archives/asf-LATEST/
>
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for at least 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> --
> Sławomir Jaranowski
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Apache Maven POMs 41

2023-11-11 Thread Olivier Lamy 
+1

On Thu, 9 Nov 2023 at 08:57, Slawomir Jaranowski  wrote:
>
> Hi,
>
> NOTE: Staging of Apache ASF parent 41 is required for testing.
>
> We solved 10 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311250=12353349
>
> Changes since the last release for Apache Maven POMs:
> https://github.com/apache/maven-parent/compare/maven-parent-40...maven-parent-41
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-2026/
> https://repository.apache.org/content/repositories/maven-2026/org/apache/maven/maven-parent/41/maven-parent-41-source-release.zip
>
> Source release checksum(s):
> maven-parent-41-source-release.zip - SHA-512 :
> d3a76493f784edf7032c73b5497837d64db0441a30da1debcb99c3341748c774b791d5f88f4b825937d84394116fe72012b6da9a0dd20e5c5d890269178f6834
>
>
> Staging site:
> https://maven.apache.org/pom-archives/maven-LATEST/
>
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for at least 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
> --
> Sławomir Jaranowski
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[ANN] Apache Maven Plugin Testing version 4.0.0-alpha-2 Released

2023-11-11 Thread Slawomir Jaranowski 
The Apache Maven team is pleased to announce the release of the Apache
Maven Plugin Testing version, version 4.0.0-alpha-2

https://maven.apache.org/plugin-testing/

You can download the appropriate sources etc. from the download page:

https://maven.apache.org/plugin-testing/download.html

Release Notes - Maven Plugin Testing - Version 4.0.0-alpha-2

** New Feature
* [MPLUGINTESTING-84] - Support JUnit 5 on Maven 3

** Improvement
* [MPLUGINTESTING-90] - Get rid of maven-compat
* [MPLUGINTESTING-91] - Maven 3 compatible and improvements

** Task
* [MPLUGINTESTING-92] - Refresh download page

** Dependency upgrade
* [MPLUGINTESTING-85] - Bump org.codehaus.plexus:plexus-archiver
from 4.6.1 to 4.8.0
* [MPLUGINTESTING-87] - Upgrade parent from 39 to 40
* [MPLUGINTESTING-88] - Upgrade surefire from 3.0.0-M7 to 3.2.1
* [MPLUGINTESTING-89] - Upgrade Maven from 4.0.0-alpha-4 to 4.0.0-alpha-8

Enjoy,

-The Apache Maven team

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Broken unsubscribe

2023-11-11 Thread py torche 
Hi,
sorry to pollute the mailing list with such a message but can any
administrator of the mailing list check the unsubscription process ?

It is broken, I tried multiple times, made sure that I sent the
unsubscription email to  dev-unsubscr...@maven.apache.org with the same
email address that I registered with but I continue to receive email from
the maven developers list.

The dev-h...@maven.apache.org works though.

Regards

[RESULT] [VOTE] Release Apache Plugin Testing version 4.0.0-alpha-2

2023-11-11 Thread Slawomir Jaranowski 
Hi,

The vote has passed with the following result:

+1: Sylwester Lachiewicz, Slawomir Jaranowski, Tamás Cservenák


PMC quorum: reached

I will promote the source release zip file to the Apache distribution
area and the artifacts to the central repo.

-- 
Sławomir Jaranowski

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org