[jira] Commented: (MWAR-12) Add resource filtering to war plugin
[ http://jira.codehaus.org/browse/MWAR-12?page=comments#action_59006 ] Brian Topping commented on MWAR-12: --- I started working on a solution to this, not realizing that it was already in JIRA. When I tried this a few weeks ago, my assumption was that I would add a resources block to the project POM. Since it already specified packagingwar/packaging, I just assumed that the same configuration would work here, but it doesn't. Having gone through quite a bit of the code for both plugins by now, I can attest to the complexity of the resource filtering and how it would be good to avoid duplicating that into the war plugin. So I'm +1 for linking having these work together. It seems like a lot of the code in AbstractWarMojo.java could be removed if that were the case, and it looks like the class has had a lot of authors, so it would be worth doing. Add resource filtering to war plugin Key: MWAR-12 URL: http://jira.codehaus.org/browse/MWAR-12 Project: Maven 2.x War Plugin Type: Improvement Reporter: Mark Hobson Assignee: Brett Porter Attachments: test.zip Original Estimate: 15 minutes Remaining: 15 minutes I'd like to patch the war plugin to perform resource filtering as per the resources plugin. This is a trivial patch but would duplicate the following code from the resources plugin: PropertyUtils ReflectionProperties ResourcesMojo.copyFile(File, File) These look like handy util methods that could be incorporated into plexus-utils - what do the developers think? Also not sure how resource filtering will be affected by MNG-788. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (MWAR-12) Add resource filtering to war plugin
[ http://jira.codehaus.org/browse/MWAR-12?page=all ] Brian Topping updated MWAR-12: -- Attachment: MWAR-12.patch Add resource filtering to war plugin Key: MWAR-12 URL: http://jira.codehaus.org/browse/MWAR-12 Project: Maven 2.x War Plugin Type: Improvement Reporter: Mark Hobson Assignee: Brett Porter Attachments: MWAR-12.patch, test.zip Original Estimate: 15 minutes Remaining: 15 minutes I'd like to patch the war plugin to perform resource filtering as per the resources plugin. This is a trivial patch but would duplicate the following code from the resources plugin: PropertyUtils ReflectionProperties ResourcesMojo.copyFile(File, File) These look like handy util methods that could be incorporated into plexus-utils - what do the developers think? Also not sure how resource filtering will be affected by MNG-788. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Created: (MNG-2065) Abstract resource filtering into Plexus
Abstract resource filtering into Plexus --- Key: MNG-2065 URL: http://jira.codehaus.org/browse/MNG-2065 Project: Maven 2 Type: Improvement Components: Plugins and Lifecycle Reporter: Brian Topping Priority: Minor Attachments: mng-2065.patch ResourcesMojo has capacity for doing resource filtering. This functionality is useful in other parts of the source tree, and rather than duplicate it, I abstracted the functionality into Plexus FileUtils. Attached is a patch for ResourcesMojo to use this new functionality. If you have svn trunk from Plexus, this code will work. I do not understand the versioning and dependency changes that are required for this, so I left those patches out. For my part in it, I did a version override to get things to compile. I'll get the web filtering done shortly. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (MNG-2065) Abstract resource filtering into Plexus
[ http://jira.codehaus.org/browse/MNG-2065?page=all ] Brian Topping updated MNG-2065: --- Attachment: mng-2065.patch Abstract resource filtering into Plexus --- Key: MNG-2065 URL: http://jira.codehaus.org/browse/MNG-2065 Project: Maven 2 Type: Improvement Components: Plugins and Lifecycle Reporter: Brian Topping Priority: Minor Attachments: mng-2065.patch ResourcesMojo has capacity for doing resource filtering. This functionality is useful in other parts of the source tree, and rather than duplicate it, I abstracted the functionality into Plexus FileUtils. Attached is a patch for ResourcesMojo to use this new functionality. If you have svn trunk from Plexus, this code will work. I do not understand the versioning and dependency changes that are required for this, so I left those patches out. For my part in it, I did a version override to get things to compile. I'll get the web filtering done shortly. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Created: (MEV-317) Dependencies for axion
Dependencies for axion -- Key: MEV-317 URL: http://jira.codehaus.org/browse/MEV-317 Project: Maven Evangelism Type: Bug Components: Dependencies Reporter: Brian Topping Presumably, this patch will also work for 1.0-M1-dev and 1.0-M3-dev -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (MEV-317) Dependencies for axion
[ http://jira.codehaus.org/browse/MEV-317?page=all ] Brian Topping updated MEV-317: -- Attachment: axion.patch Dependencies for axion -- Key: MEV-317 URL: http://jira.codehaus.org/browse/MEV-317 Project: Maven Evangelism Type: Bug Components: Dependencies Reporter: Brian Topping Attachments: axion.patch Presumably, this patch will also work for 1.0-M1-dev and 1.0-M3-dev -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Closed: (MEV-317) Dependencies for axion
[ http://jira.codehaus.org/browse/MEV-317?page=all ] Brian Topping closed MEV-317: - Resolution: Incomplete Will upload in another patch Dependencies for axion -- Key: MEV-317 URL: http://jira.codehaus.org/browse/MEV-317 Project: Maven Evangelism Type: Bug Components: Dependencies Reporter: Brian Topping Attachments: axion.patch Presumably, this patch will also work for 1.0-M1-dev and 1.0-M3-dev -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (MEV-318) Dependencies for Axion
[ http://jira.codehaus.org/browse/MEV-318?page=all ] Brian Topping updated MEV-318: -- Attachment: axion.patch Dependencies for Axion -- Key: MEV-318 URL: http://jira.codehaus.org/browse/MEV-318 Project: Maven Evangelism Type: Bug Components: Dependencies Reporter: Brian Topping Attachments: axion.patch This should work for 1.0-M1-dev and 1.0-M3-dev as well -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Created: (MEV-318) Dependencies for Axion
Dependencies for Axion -- Key: MEV-318 URL: http://jira.codehaus.org/browse/MEV-318 Project: Maven Evangelism Type: Bug Components: Dependencies Reporter: Brian Topping Attachments: axion.patch This should work for 1.0-M1-dev and 1.0-M3-dev as well -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
