from:"ChristianSchulte"

Github user ChristianSchulte commented on the issue:

https://github.com/apache/maven/pull/148
  
[Corresponding IT pull 
request.](https://github.com/apache/maven-integration-testing/pull/30)


---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request #148: [MNG-5600] Dependency management import should supp...

GitHub user ChristianSchulte opened a pull request:

https://github.com/apache/maven/pull/148

[MNG-5600] Dependency management import should support exclusions.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ChristianSchulte/maven MNG-5600

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven/pull/148.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #148


commit 47e30c446a753e6d8bad04c99b9456957f5394df
Author: Christian Schulte 
Date:   2016-06-19T14:32:25Z

[MNG-5600] Dependency management import should support exclusions.




---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven issue #147: [MNG-5527] Dependency management import should support rel...

Github user ChristianSchulte commented on the issue:

https://github.com/apache/maven/pull/147
  
[Corresponding IT pull 
request.](https://github.com/apache/maven-integration-testing/pull/29)


---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request #147: [MNG-5527] Dependency management import should supp...

GitHub user ChristianSchulte opened a pull request:

https://github.com/apache/maven/pull/147

[MNG-5527] Dependency management import should support relocations.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ChristianSchulte/maven MNG-5527

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven/pull/147.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #147


commit 4c17874bd9a051b1aee2fa48d886fb2e9c2e4e38
Author: Christian Schulte 
Date:   2016-06-21T19:35:40Z

[MNG-5527] Dependency management import should support relocations.




---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven issue #146: [MNG-4463] Dependency management import should support ver...

Github user ChristianSchulte commented on the issue:

https://github.com/apache/maven/pull/146
  
[Corresponding IT pull 
request.](https://github.com/apache/maven-integration-testing/pull/28)


---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request #146: [MNG-4463] Dependency management import should supp...

GitHub user ChristianSchulte opened a pull request:

https://github.com/apache/maven/pull/146

[MNG-4463] Dependency management import should support version ranges.

Closes #64 without merging. ITs are pending to be committed.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ChristianSchulte/maven MNG-4463

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven/pull/146.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #146


commit 9f236fdb8305ffbce9e1b76c8cb4ecf012efc6da
Author: Christian Schulte 
Date:   2016-01-30T18:17:34Z

[MNG-4463] Dependency management import should support version ranges.

Closes #64 without merging. ITs are pending to be committed.




---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven issue #143: [MNG-5359] Declared execution in PluginMgmt gets bound to ...

Github user ChristianSchulte commented on the issue:

https://github.com/apache/maven/pull/143
  
[Corresponding IT pull 
request.](https://github.com/apache/maven-integration-testing/pull/27)


---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request #145: [MNG-6112] Central repository in the 4.0.0 super PO...

GitHub user ChristianSchulte opened a pull request:

https://github.com/apache/maven/pull/145

[MNG-6112] Central repository in the 4.0.0 super POM should declare uâ¦

â¦pdate policy 'never'.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ChristianSchulte/maven MNG-6112

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven/pull/145.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #145


commit a70406bb2cfe6ec14f717c53cebe8f23919aa0fc
Author: Christian Schulte 
Date:   2017-03-25T23:18:24Z

[MNG-6112] Central repository in the 4.0.0 super POM should declare update 
policy 'never'.




---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request #144: [MNG-2893] Update the DefaultPluginManager to not u...

GitHub user ChristianSchulte opened a pull request:

https://github.com/apache/maven/pull/144

[MNG-2893] Update the DefaultPluginManager to not use a project depMaâ¦

â¦n for controlling it's transitive dependencies

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ChristianSchulte/maven MNG-2893

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven/pull/144.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #144


commit 1de1ce1fdc50a8574a6b0e32ce4adc8389fcf73a
Author: Christian Schulte 
Date:   2017-03-25T22:01:03Z

[MNG-2893] Update the DefaultPluginManager to not use a project depMan for 
controlling it's transitive dependencies




---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request #143: [MNG-5359] Declared execution in PluginMgmt gets bo...

GitHub user ChristianSchulte opened a pull request:

https://github.com/apache/maven/pull/143

[MNG-5359] Declared execution in PluginMgmt gets bound to lifecycle (â¦

â¦regression)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ChristianSchulte/maven MNG-5359

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven/pull/143.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #143


commit 06d8d4533b3810cf767615e83f51ac43e4f474c0
Author: Christian Schulte 
Date:   2017-10-22T04:22:10Z

[MNG-5359] Declared execution in PluginMgmt gets bound to lifecycle 
(regression)




---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request #142: [MNG-6114] Profiles from the global settings should...

GitHub user ChristianSchulte opened a pull request:

https://github.com/apache/maven/pull/142

[MNG-6114] Profiles from the global settings should be ordered beforeâ¦

â¦ profiles from the user settings.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ChristianSchulte/maven MNG-6114

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven/pull/142.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #142


commit 633af8e1d7a841f3829121ffda69e35f89775b3e
Author: Christian Schulte 
Date:   2016-11-12T20:06:19Z

[MNG-6114] Profiles from the global settings should be ordered before 
profiles from the user settings.




---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request #141: [MNG-6164] Collections inconsistently immutable.

GitHub user ChristianSchulte opened a pull request:

https://github.com/apache/maven/pull/141

[MNG-6164] Collections inconsistently immutable.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ChristianSchulte/maven MNG-6164

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven/pull/141.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #141


commit d08cb28d5353b1dc71ffd314b23c08a7fefec484
Author: Christian Schulte 
Date:   2015-12-14T03:57:47Z

[MNG-6164] Collections inconsistently immutable.




---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request #124: Make resolver debug log messages for projects and p...

2017-06-21 Thread ChristianSchulte

GitHub user ChristianSchulte opened a pull request:

https://github.com/apache/maven/pull/124

Make resolver debug log messages for projects and plugins consistent.

The graph returned by the resolver after resolution is logged at debug 
level. This pull request only updates those debug log messages to be consistent 
across project and plugin resolution and to provide as much information as 
possible to make users aware of what is going on.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ChristianSchulte/maven debugging

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven/pull/124.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #124


commit 150858d6ebc4fdedff287a89915705a3bb0d6518
Author: Christian Schulte 
Date:   2017-06-22T00:31:30Z

Upgrade to Maven Resolver 1.1.0-SNAPSHOT.
Update debug log messages about management performed.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven issue #107: Fixes to various JIRA issues.

2017-06-13 Thread ChristianSchulte

Github user ChristianSchulte commented on the issue:

https://github.com/apache/maven/pull/107

You'll need to merge the resolver bugfixes as well to make the IT work, of
course.

[MRESOLVER-8](https://github.com/ChristianSchulte/maven-resolver/commit/2813a8f9e290f8a6523486c0ca30cca8c9b7cc45)

[MRESOLVER-9](https://github.com/ChristianSchulte/maven-resolver/commit/67a37de1feabcb420152981cd9b07c2288b46108)

This will make the resolver discard any non-transitive dependencies
(optional and test-scope) correctly. Existing builds relying on the incorrect
behaviour will stop working. The POMs of the resolver itself rely on that
incorrect behaviour. Working on those issues is a waste of time! It will sadly
never pass a release vote.

I haven't split the unit tests into smaller commits. To be able to merge
the unit tests, you'll need to merge the following commits as well.

[MRESOLVER-10](https://github.com/ChristianSchulte/maven-resolver/commit/fb743981623504a00bf88c6c060ced9d08880355)

[MRESOLVER-12](https://github.com/ChristianSchulte/maven-resolver/commit/e0f9180da1532adbdc30f5f9470c445a2d9cc199)

---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-integration-testing pull request #20: Integration tests for various JI...

2017-03-25 Thread ChristianSchulte

GitHub user ChristianSchulte opened a pull request:

https://github.com/apache/maven-integration-testing/pull/20

Integration tests for various JIRA issues. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ChristianSchulte/maven-integration-testing 
master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven-integration-testing/pull/20.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #20


commit b4391c672a88cc6819dba0666952b50faaedb68f
Author: Christian Schulte 
Date:   2015-12-20T18:34:40Z

[MNG-5359] Declared execution in PluginMgmt gets bound to lifecycle 
(regression)

commit 11dccc9e061f3326b6ef61c97e6e1242803fd0d1
Author: Christian Schulte 
Date:   2016-01-30T19:21:33Z

[MNG-4463] Dependency management import should support version ranges.

commit b2a25c9af3db26ba099a40018843baf48ae6ae66
Author: Christian Schulte 
Date:   2016-06-22T15:41:42Z

[MNG-5527] Dependency management import should support relocations.

commit bae3d8c959ce528d9dcbb41d5039128494582f3e
Author: Christian Schulte 
Date:   2016-06-19T15:18:51Z

[MNG-5600] Dependency management import should support exclusions.

commit 619d2466c74a1f05074861f9bd8f95e0092ee8ba
Author: Christian Schulte 
Date:   2016-02-20T13:42:20Z

[MNG-5971] Imported dependencies should be available to inheritance 
processing

commit 1287046f9372810baf643576674e13d8b689f9a5
Author: Christian Schulte 
Date:   2016-08-13T00:04:02Z

[MNG-6079] 3.4 regression: cannot override version of a 
dependencyManagement in a submodule any more

commit 0bd5b8396bdc1c882679090ade5d67affc4aec3a
Author: Christian Schulte 
Date:   2016-01-27T07:09:55Z

[MNG-5227] The 'optional' flag of a dependency should be manageable.

commit 7e7901459eb97fb05e6e71c050d448ed0db89dcc
Author: Christian Schulte 
Date:   2016-12-13T22:28:45Z

[MNG-5761] Dependency management is not transitive.

commit a7576d90f761321c397d4d51e2e01991a6bfdd56
Author: Christian Schulte 
Date:   2016-12-19T00:51:44Z

[MNG-6135] Maven plugins and core extensions are not dependencies, they 
should be resolved the same way as projects.

o Updated to add all missing POMs to the test repository. Due to core 
extensions getting
  resolved as projects, the POMs of all dependencies need to be available 
in that
  repository even if the dependency is filtered out during resolution.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request #107: Fixes to various JIRA issues.

2017-03-11 Thread ChristianSchulte

GitHub user ChristianSchulte opened a pull request:

https://github.com/apache/maven/pull/107

 Fixes to various JIRA issues.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ChristianSchulte/maven master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven/pull/107.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #107


commit 0c2b3603916688432860d56836f1e84b16bd76a1
Author: Christian Schulte 
Date:   2014-12-18T01:37:09Z

[MNG-5738] Addition of command line flag '--legacy-reactor-resolution'.

o Updated to add command line option '--legacy-reactor-resolution' to allow
  disabling workspace resolution introduced in Maven 3 as discussed at
  MPIR-238.

commit 9cd745148123baca3d6307b6dede0cb3ec95f588
Author: Arnaud Heritier 
Date:   2017-01-31T09:26:28Z

[MNG-5961] Fix the SLF4J logger factory implementation used for LOG4J2

commit 71fb5bde6c5ea110bc745da8647262cacff45e8d
Author: Josh Soref 
Date:   2017-01-23T04:57:23Z

[MNG-6165] Deprecate and replace incorrectly spelled public API

Spelling fixes:

* spelling: collector
* spelling: executions
* spelling: repositories
* spelling: workspace

This closes #101

commit 2344fed7135de441b4701f1f5b73d85a43d14cab
Author: Archimedes Trajano 
Date:   2017-02-03T23:41:58Z

[MNG-6166] mvn dependency:go-offline fails due to missing transitive 
dependency jdom:jdom:jar:1.1

commit bc401b5a168a01f96e39f96f61638cf0363214dd
Author: rfscholte 
Date:   2017-02-10T16:05:24Z

Squashed commit of the following:

commit f3f981022f9157e9d74a9d9dfef7ae102c4d0593
Author: rfscholte 
Date:   Thu Feb 9 11:00:17 2017 +0100

[MNG-6109] PluginDescriptor doesn't read since value of parameter
There's no specific IT, just a unittest, so itBranch should stay on 
master

commit 862e8e4e3a2b857eeeb4761a1568c15ebb442932
Author: rfscholte 
Date:   Wed Feb 8 21:55:30 2017 +0100

[MNG-6109] PluginDescriptor doesn't read since value of parameter

commit 76b539ecf2733b2a8564c18581d60176dc0185a3
Author: rfscholte 
Date:   Mon Oct 31 21:05:28 2016 +0100

PluginDescriptor doesn't read since value of parameter

commit 318b7b6f06a389a07ea4dc366db4df1295f5b616
Author: Christian Schulte 
Date:   2015-12-12T19:28:56Z

[MNG-2199] Support version ranges in parent elements

o Updated to fix parent version range resolution broken since 3.2.3 and to
  remove parent version range resolution logic obsolete since Maven
  3.2.3 which changed the initialization of MavenProject instances.
o Updated local parent resolution to behave the same way remote parent
  resolution behaves. When referencing a parent using version ranges,
  inheriting the version or using version expressions should not be 
supported.
  It has been implemented that way for remote parent resolution as it got
  introduced in Maven 3.2.2. For local parent resolution the version in 
parent
  declarations had been ignored completely as of Maven 3.3.0 due to commit
  be3fb200326208ca4b8c41ebf16d5ae6b8049792 removing all local parent version
  validation. Work on fixing this is tracked by MNG-5840 released with Maven
  3.3.9. This commit adds the final missing bits to make local and remote 
parent
  resolution behave the same way as much as possible. As an exception, 
remote
  parent resolution still is a bit more strict than local parent resolution 
due
  to a different API in use. When resolving a parent from a repository using
  version ranges, the ModelBuilder verifies the range in use to declare an 
upper
  bound. When resolving a parent locally using version ranges, those ranges 
are
  not required to declare an upper bound because the API in use does not 
support
  querying that. Authoring a POM relying on this difference should be 
considered
  a bug.
o Added test cases to maven-core testing parent version range resolution for
  local and remote parent models.

commit 878f8045c39288db836799e0b61bc08d4b2bb000
Author: Alex Henrie 
Date:   2016-01-19T19:04:59Z

[MNG-5934] String handling issues identified by PMD

commit 7bc05b8576b23d4d8354be3c59b0750c8e0693e5
Author: Christian Schulte 
Date:   2016-01-25T02:48:14Z

[MNG-5967] Dependency updates

commit 1b31c4bc7fee18f8531babb9965ad3c7d11202ce
Author: Christian Schulte 
Date:   2017-02-11T18:21:03Z

[MNG-5968] Default plugin version updates

commit 4a7d03a38785662d7667e9827606a01fe2bc39c3
Author: HervÃ© Boutemy 
Date:   2016-09-18T21:57:24Z

[MNG-5297] improved explanations on prerequisites.maven in Maven 3

commit bb4bfdb05ffe672532f03f626b51a6b8a56ea068
Author:

[GitHub] maven-surefire pull request #144: Resource leaks.

2017-02-26 Thread ChristianSchulte

Github user ChristianSchulte commented on a diff in the pull request:

https://github.com/apache/maven-surefire/pull/144#discussion_r103110250
  
--- Diff: 
surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java
 ---
@@ -236,13 +236,17 @@ private static void exit( int returnCode, Shutdown 
shutdownType, CommandReader r
 switch ( shutdownType )
 {
 case KILL:
+System.out.close();
--- End diff --

`System.in` and `System.out` are both 
[`PrintStream`](http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/file/8108ffe38ccb/src/share/classes/java/io/PrintStream.java)s.
 That class already is error prone like mad (autoFlush yes or no, checkError 
instead of throwing exceptions, etc.). It internally creates a `BufferedWriter` 
used for writing characters. I haven't found anything in the JDK flushing those 
buffers so it seems this is up to the application. I am quite sure that closing 
those streams manually is correct. That's what you would do in a C application 
as well.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire pull request #144: Resource leaks.

2017-02-26 Thread ChristianSchulte

Github user ChristianSchulte commented on a diff in the pull request:

https://github.com/apache/maven-surefire/pull/144#discussion_r103110034
  
--- Diff: 
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/ConsoleOutputFileReporter.java
 ---
@@ -69,8 +69,8 @@ public void close()
 {
 try
 {
-fileOutputStream.flush();
-fileOutputStream.close();
+// fileOutputStream.flush(); Will not call close on 
exception!
+fileOutputStream.close(); // Will implicitly flush.
--- End diff --

I just wanted to be sure that `close` is always called. See the comment. 
When `flush` throws an exception, `close` will never be called and leak 
resources.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire pull request #144: Resource leaks.

2017-02-26 Thread ChristianSchulte

Github user ChristianSchulte commented on a diff in the pull request:

https://github.com/apache/maven-surefire/pull/144#discussion_r103109929
  
--- Diff: 
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java
 ---
@@ -240,6 +240,10 @@ public void testSetCompleted( WrappedReportEntry 
testSetReportEntry, TestSetStat
 }
 ppw.endElement(); // TestSuite
 }
+catch ( final IOException e )
+{
+throw new ReporterException( "Failure generating XML report.", 
e );
--- End diff --

I started a surefire build and then left because it runs a long time and I 
did not want to wait. There were a couple of ITs no longer failing. I'll write 
an email when getting home. Results looked promising on OpenBSD. Last commit is 
just temporary for testing. I closed various maven-shared-utils issues today 
which seem to fix things for surefire as well. I'll send an email when I am 
back. I hope the console will show a successful build. 


[CommandLineUtils](http://svn.apache.org/viewvc?view=revision&revision=1784432)
[StreamFeeder](http://svn.apache.org/viewvc?view=revision&revision=1784431)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire pull request #144: Resource leaks.

2017-02-18 Thread ChristianSchulte

GitHub user ChristianSchulte opened a pull request:

https://github.com/apache/maven-surefire/pull/144

Resource leaks.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ChristianSchulte/maven-surefire master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven-surefire/pull/144.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #144


commit 3530cc137cbeb12002212a516bc2d41a769b3274
Author: Christian Schulte 
Date:   2017-02-18T22:37:27Z

o Resource leak in 'RunEntryStatisticsMap'.

commit 9f1ace227eef2d8e9c2bb9dbf66b848f0ffeec9e
Author: Christian Schulte 
Date:   2017-02-18T22:40:38Z

o Resource leak in 'ConsoleOutputFileReporter'.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven issue #99: [MNG-6127] Fix plugin execution configuration interference

2016-11-23 Thread ChristianSchulte

Github user ChristianSchulte commented on the issue:

https://github.com/apache/maven/pull/99
  
Could you please also provide an integration test against 
[maven-integration-testing](https://github.com/apache/maven-integration-testing).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

2016-02-23 Thread ChristianSchulte

Github user ChristianSchulte commented on the pull request:

https://github.com/apache/maven/pull/70#issuecomment-188009400
  
@barthel: See 
[c31be833a6f8d9266990a708efe624d09fa06dec](https://github.com/ChristianSchulte/maven/commit/c31be833a6f8d9266990a708efe624d09fa06dec)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: String handling issues identified by PMD

2016-02-09 Thread ChristianSchulte

Github user ChristianSchulte commented on the pull request:

https://github.com/apache/maven/pull/72#issuecomment-181984267
  
This has been committed. See MNG-5934. Please close this pull request 
manually.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: fix release profile to use source:jar-no-fork ...

2016-02-09 Thread ChristianSchulte

Github user ChristianSchulte commented on the pull request:

https://github.com/apache/maven/pull/61#issuecomment-181983567
  
This has been committed. See MNG-5940. Please close this pull request 
manually.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: MNG-5837: Use a subshell, rather than the 'loc...

2015-12-17 Thread ChristianSchulte

Github user ChristianSchulte commented on the pull request:

https://github.com/apache/maven/pull/50#issuecomment-165627334
  
Can you please 'rebase' the commit onto 'origin/master' so that I can merge 
it without conflicts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...

2015-03-12 Thread ChristianSchulte

Github user ChristianSchulte commented on the pull request:

https://github.com/apache/maven/pull/32#issuecomment-78281257
  
@jvanzyl: You would not want the `test-jar` goal to package compiled test 
classes instrumented by some reporting tool, would you ? So the forking logic 
needs to change in a way that a forked lifecycle will run isolated (e.g. with 
its own output directory). A rather incompatible change in the core requiring 
new reporting plugins. Something to be done in the next Maven version 
introducing a new POM version.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...

2015-03-11 Thread ChristianSchulte

Github user ChristianSchulte commented on the pull request:

https://github.com/apache/maven/pull/32#issuecomment-78290027
  
I totally agree with this. Do not cripple Maven to support bad ideas or 
concepts. "Supported by Maven" as an indicator for something. Not supported by 
Maven so not worth integrating means Maven must be ideal.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...

2015-03-11 Thread ChristianSchulte

Github user ChristianSchulte closed the pull request at:

https://github.com/apache/maven/pull/32


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...

2015-03-11 Thread ChristianSchulte

Github user ChristianSchulte commented on the pull request:

https://github.com/apache/maven/pull/32#issuecomment-78226219
  
I am really no fan of adding just another workaround.

@Jason: Are you suggesting to split site rendering from report data 
generation ? So the build lifecycle produces report data attached to the 
project picked up during site rendering ? Cobertura instrumentation takes place 
during the build lifecycle and site rendering picks up the data generated there 
without compiling and running any tests any more, for example ? Not talking 
about picking up data from the build output directory here but resolving that 
data based on e.g. classifiers.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...

2015-03-05 Thread ChristianSchulte

Github user ChristianSchulte commented on the pull request:

https://github.com/apache/maven/pull/32#issuecomment-77428933
  
I have no experience with the cobertura plugin. I just added

```

  org.codehaus.mojo
  cobertura-maven-plugin
  2.7

```

to the configuration of the site plugin of a working project. Executing 
`mvn site -e` with Maven 3.2.5, site building succeeds. Using Maven 
3.3.0-SNAPSHOT with the latest changes to head, the following exception is 
thrown.

```
[ERROR] Exception in thread "main" java.lang.NoClassDefFoundError: 
org/slf4j/LoggerFactory
at 
net.sourceforge.cobertura.instrument.InstrumentMain$LoggerWrapper.(InstrumentMain.java:165)
at 
net.sourceforge.cobertura.instrument.InstrumentMain$LoggerWrapper.(InstrumentMain.java:164)
at 
net.sourceforge.cobertura.instrument.InstrumentMain.(InstrumentMain.java:66)
Caused by: java.lang.ClassNotFoundException: org.slf4j.LoggerFactory
at java.net.URLClassLoader$1.run(URLClassLoader.java:366)
at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
at java.lang.ClassLoader.loadClass(ClassLoader.java:425)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308)
at java.lang.ClassLoader.loadClass(ClassLoader.java:358)
... 3 more
```

That exception is not thrown using Maven 3.2.5. There still seems to be a 
class loading issue.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...

2015-03-03 Thread ChristianSchulte

Github user ChristianSchulte commented on the pull request:

https://github.com/apache/maven/pull/32#issuecomment-76933957
  
What's the state of the current head as of today ? I just wanted to test 
the cobertura plugin but cannot build the site with Maven 3.2.6-SNAPSHOT due to 
the following exception. That's happening with a released project known to 
work. So `mvn site -e` with Maven 3.2.5 succeeds whereas 3.2.6-SNAPSHOT fails.

```
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project 
jomc-parent: Execution default-site of goal 
org.apache.maven.plugins:maven-site-plugin:3.4:site failed: A required class 
was missing while executing 
org.apache.maven.plugins:maven-site-plugin:3.4:site: 
org/slf4j/spi/LocationAwareLogger
```

```
Caused by: java.lang.NoClassDefFoundError: org/slf4j/spi/LocationAwareLogger
at 
org.apache.commons.logging.impl.SLF4JLogFactory.getInstance(SLF4JLogFactory.java:157)
at org.apache.commons.logging.LogFactory.getLog(LogFactory.java:289)
at org.apache.commons.digester.Digester.(Digester.java:308)
at 
org.apache.velocity.tools.config.XmlFactoryConfiguration.read(XmlFactoryConfiguration.java:117)
at 
org.apache.velocity.tools.config.FileFactoryConfiguration.read(FileFactoryConfiguration.java:140)
at 
org.apache.velocity.tools.config.FileFactoryConfiguration.read(FileFactoryConfiguration.java:116)
at 
org.apache.velocity.tools.config.FileFactoryConfiguration.read(FileFactoryConfiguration.java:91)
at 
org.apache.velocity.tools.config.FileFactoryConfiguration.read(FileFactoryConfiguration.java:69)
at 
org.apache.velocity.tools.config.FileFactoryConfiguration.read(FileFactoryConfiguration.java:59)
at 
org.apache.velocity.tools.config.ConfigurationUtils.getDefaultTools(ConfigurationUtils.java:79)
at 
org.apache.velocity.tools.config.ConfigurationUtils.getAutoLoaded(ConfigurationUtils.java:176)
at 
org.apache.velocity.tools.ToolManager.autoConfigure(ToolManager.java:74)
at org.apache.velocity.tools.ToolManager.(ToolManager.java:68)
at org.apache.velocity.tools.ToolManager.(ToolManager.java:59)
at 
org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.createVelocityContext(DefaultSiteRenderer.java:427)
at 
org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.generateDocument(DefaultSiteRenderer.java:565)
at 
org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.renderDocument(DefaultSiteRenderer.java:422)
at 
org.apache.maven.doxia.siterenderer.DoxiaDocumentRenderer.renderDocument(DoxiaDocumentRenderer.java:51)
at 
org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.renderModule(DefaultSiteRenderer.java:311)
at 
org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.render(DefaultSiteRenderer.java:129)
at 
org.apache.maven.plugins.site.render.SiteMojo.renderDoxiaDocuments(SiteMojo.java:261)
at 
org.apache.maven.plugins.site.render.SiteMojo.renderLocale(SiteMojo.java:172)
at 
org.apache.maven.plugins.site.render.SiteMojo.execute(SiteMojo.java:141)
at 
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:132)
... 21 more
Caused by: java.lang.ClassNotFoundException: 
org.slf4j.spi.LocationAwareLogger
at 
org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfFirstStrategy.java:50)
at 
org.codehaus.plexus.classworlds.realm.ClassRealm.unsynchronizedLoadClass(ClassRealm.java:271)
at 
org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:247)
at 
org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:239)
... 45 more
```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...

2015-02-25 Thread ChristianSchulte

Github user ChristianSchulte commented on the pull request:

https://github.com/apache/maven/pull/32#issuecomment-76122905
  
```
parent
  module1
  module2
```

With Maven 3 I need to

```
cmd>cd parent && mvn site-deploy -N && cd module1 && mvn site-deploy && cd 
../module2 && mvn site-deploy
```
to get the same behaviour as executing

```
cmd>cd parent && mvn site-deploy
```

with Maven 2. So in Maven 3 I would like to

```
cmd>cd parent && mvn --legacy-reactor-resolution site-deploy
```

Pretty much the same way the following command line flag can be used to 
make Maven 3 behave the same way as Maven 2.

```
 -llr,--legacy-local-repository Use Maven 2 Legacy Local
Repository behaviour, ie no use of
_remote.repositories. Can also be
activated by using
-Dmaven.legacyLocalRepo=true
```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...

2015-02-25 Thread ChristianSchulte

Github user ChristianSchulte commented on the pull request:

https://github.com/apache/maven/pull/32#issuecomment-76081933
  
Could not be more confusing.

Apache Maven is a software project management and comprehension tool. Based 
on the concept of a project object model (POM), Maven can manage a project's 
build, reporting and documentation from a central piece of information.

No more 'reporting and documentation' in the future makes the 'from a 
central piece of information' meaningless.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...

2015-02-25 Thread ChristianSchulte

Github user ChristianSchulte commented on the pull request:

https://github.com/apache/maven/pull/32#issuecomment-75990941
  
There are situations the behaviour is not wrong, in my opinion. Resolution 
for non project `` related lifecycles, for example. Maven could 
detect this automically based on various criteria: not the default lifecycle, 
not project packaging related, attribute of a lifecycle, not executed at an 
even hour, etc but it does not. No issue. The command line option lets you 
choose the needed behaviour yourself without being forced (issue!) by Maven to 
anything. I can live with this not getting committed. That's not the point. For 
me that standalone site building tool would exactly be `mvn 
--legacy-reactor-resolution site`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...

2015-02-24 Thread ChristianSchulte

Github user ChristianSchulte commented on the pull request:

https://github.com/apache/maven/pull/32#issuecomment-75848081
  
I am still convinced that it is a good idea to allow Maven 3 'mvn 
site-deploy' to work the same way as Maven 2. What's the issue with that ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...

2015-02-24 Thread ChristianSchulte

Github user ChristianSchulte commented on the pull request:

https://github.com/apache/maven/pull/32#issuecomment-75794059
  
Regarding the recent discussion about releasing 3.2.6 as 3.3.0: Could this 
be part of 3.3.0, please ?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...

Github user ChristianSchulte commented on the pull request:

https://github.com/apache/maven/pull/32#issuecomment-67626029
  
Feeding the tagged sources to the reports is not an issue. Feeding 
intermediate build results is. That's like the tagged sources changing with 
every build. Everything in `target/classes` is not identical to what is 
deployed to `central` . Different compiler version, different Maven version, 
shading, etc. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...

Github user ChristianSchulte commented on the pull request:

https://github.com/apache/maven/pull/32#issuecomment-67625161
  
Maybe the proper solution would be to control this behaviour based on an 
attribute of the lifecycle ? So a lifecycle can be flagged as producing 
artifacts or as consuming artifacts. Lifecycles producing artifacts behave like 
Maven 3. Lifecycles consuming artifacts behave like Maven 2.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...

Github user ChristianSchulte commented on the pull request:

https://github.com/apache/maven/pull/32#issuecomment-67622663
  
It is re-enabling the following workflow in Maven 3.

cmd> mvn release:prepare
cmd> mvn release:perform

Wait until the artifacts are synced to `central`. Then

cmd> mvn site-deploy

This should now deploy the site for the released artifacts from `central` 
and not some intermediate build result.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...

Github user ChristianSchulte commented on the pull request:

https://github.com/apache/maven/pull/32#issuecomment-67621081
  
I would need a way to disable workspace resolution mainly for the `site` 
lifecycle.

cmd> svn checkout .../tags/maven-3.0
cmd> cd maven-3.0
cmd> mvn site

This feeds intermediate build results to the various reports thrown away 
right after site generation whereas

cmd> mvn --legacy-reactor-resolution site

makes Maven 3 download the artifacts from `central` or fail, if not finding 
them. 

Feeding the released artifacts to the various reports is the expected 
behaviour in my opinion as the reports are now generated using the same 
released artifacts instead of some intermediate build result. The `site` 
lifecycle does not produce any artifacts. It consumes pre-built artifacts and 
should really fail, if those artifacts cannot be found. Maven 2 did the right 
thing here, in my opinion. I would always execute `mvn  
--legacy-reactor-resolution site` with this option available.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...

2014-12-18 Thread ChristianSchulte

Github user ChristianSchulte commented on the pull request:

https://github.com/apache/maven/pull/32#issuecomment-67605975
  
Rebased and then pushed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MPIR-238] Addition of command line flag '--le...

2014-12-18 Thread ChristianSchulte

Github user ChristianSchulte commented on the pull request:

https://github.com/apache/maven/pull/32#issuecomment-67459407
  
Are you referring to

git rebase -i upstream/master

then squash all commits and push that ?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MPIR-238] Addition of command line flag '--le...

Github user ChristianSchulte commented on the pull request:

https://github.com/apache/maven/pull/32#issuecomment-67438782
  
See http://jira.codehaus.org/browse/MNG-5738


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MPIR-238] Addition of command line flag '--le...

GitHub user ChristianSchulte reopened a pull request:

https://github.com/apache/maven/pull/32

[MPIR-238] Addition of command line flag '--legacy-reactor-resolution'.

See http://jira.codehaus.org/browse/MPIR-238

This pull request will add a new command line flag 
'--legacy-reactor-resolution' to Maven to allow disabling workspace resolution. 
The name was choosen to be consistent with '--legacy-local-repositoy'.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ChristianSchulte/maven master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven/pull/32.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #32


commit 1bc2602dc3e348399fbfa7bdd39b82fde3d95759
Author: Christian Schulte 
Date:   2014-06-12T23:59:34Z

[MNG-2199] Version ranges not supported for parent artifacts

commit 0d51e693830e9d803e43b4bac155b958dc2bd343
Author: Christian Schulte 
Date:   2014-06-14T01:22:47Z

Merge remote-tracking branch 'upstream/master'

commit 85ba5c0f4b5b28c425168a699bc5df6d89baecbf
Author: Christian Schulte 
Date:   2014-07-01T22:12:58Z

Merge remote-tracking branch 'upstream/master'

commit 1615188e7eb2bc21141309dfa69bc57eec225473
Author: Christian Schulte 
Date:   2014-07-05T13:25:09Z

Merge remote-tracking branch 'upstream/master'

commit 23e0de86814fa9dfb19ed9ef452f2f9bdb4da0ef
Author: Christian Schulte 
Date:   2014-07-17T20:57:13Z

Merge remote-tracking branch 'upstream/master'

commit be46f8643eeb17c9cbb53e58a0e7a0942c1c8f04
Author: Christian Schulte 
Date:   2014-12-17T23:56:51Z

Merge remote-tracking branch 'upstream/master'

commit 66ec29f3942048808a3415da9f82a18d71bd2f99
Author: Christian Schulte 
Date:   2014-12-18T01:37:09Z

o Updated to add command line option '--legacy-reactor-resolution' to allow 
disabling workspace resolution introduced in Maven 3 as discussed at MPIR-238.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MPIR-238] Addition of command line flag '--le...

Github user ChristianSchulte closed the pull request at:

https://github.com/apache/maven/pull/32


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MPIR-238] Addition of command line flag '--le...

GitHub user ChristianSchulte opened a pull request:

https://github.com/apache/maven/pull/32

[MPIR-238] Addition of command line flag '--legacy-reactor-resolution'.

See http://jira.codehaus.org/browse/MPIR-238

This pull request will add a new command line flag 
'--legacy-reactor-resolution' to Maven to allow disabling workspace resolution. 
The name was choosen to be consistent with '--legacy-local-repositoy'.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ChristianSchulte/maven master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven/pull/32.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #32


commit 1bc2602dc3e348399fbfa7bdd39b82fde3d95759
Author: Christian Schulte 
Date:   2014-06-12T23:59:34Z

[MNG-2199] Version ranges not supported for parent artifacts

commit 0d51e693830e9d803e43b4bac155b958dc2bd343
Author: Christian Schulte 
Date:   2014-06-14T01:22:47Z

Merge remote-tracking branch 'upstream/master'

commit 85ba5c0f4b5b28c425168a699bc5df6d89baecbf
Author: Christian Schulte 
Date:   2014-07-01T22:12:58Z

Merge remote-tracking branch 'upstream/master'

commit 1615188e7eb2bc21141309dfa69bc57eec225473
Author: Christian Schulte 
Date:   2014-07-05T13:25:09Z

Merge remote-tracking branch 'upstream/master'

commit 23e0de86814fa9dfb19ed9ef452f2f9bdb4da0ef
Author: Christian Schulte 
Date:   2014-07-17T20:57:13Z

Merge remote-tracking branch 'upstream/master'

commit be46f8643eeb17c9cbb53e58a0e7a0942c1c8f04
Author: Christian Schulte 
Date:   2014-12-17T23:56:51Z

Merge remote-tracking branch 'upstream/master'

commit 66ec29f3942048808a3415da9f82a18d71bd2f99
Author: Christian Schulte 
Date:   2014-12-18T01:37:09Z

o Updated to add command line option '--legacy-reactor-resolution' to allow 
disabling workspace resolution introduced in Maven 3 as discussed at MPIR-238.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-19 Thread ChristianSchulte

Github user ChristianSchulte commented on the pull request:

https://github.com/apache/maven/pull/20#issuecomment-46547866
  
Could be as simple as:
```

  simple script 
evaluating to a boolean

```
'engine-name' translates to javax.script.ScriptEngine.getEngineByName()
'extension' translates to javax.script.ScriptEngine.getEngineByExtension()
'mime-type' translates to javax.script.ScriptEngine.getEngineByMimeType()

All you need to do is populating the corresponding script engine scope with 
some pre-defined values.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-19 Thread ChristianSchulte

Github user ChristianSchulte commented on the pull request:

https://github.com/apache/maven/pull/20#issuecomment-46546268
  
Another option would be to provide support for activations based on some 
language like:

  OS IS 'Linux' AND ( PROPERTY 'Some Name' IS 'true' OR JDK IS 
'1.6 )

Maybe some scripting language provided by the platform ScriptEngine.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-integration-testing pull request: [MNG-2199] Version ranges ...

2014-06-13 Thread ChristianSchulte

GitHub user ChristianSchulte opened a pull request:

https://github.com/apache/maven-integration-testing/pull/7

[MNG-2199] Version ranges not supported for parent artifacts

Integration tests corresponding to Maven PR #21.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ChristianSchulte/maven-integration-testing 
master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven-integration-testing/pull/7.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #7


commit 0ae51066d82dde1c4e48c1faffe29cbaf1f03143
Author: Christian Schulte 
Date:   2014-06-13T20:27:14Z

[MNG-2199] Version ranges not supported for parent artifacts




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-2199] Version ranges not supported for pa...

Github user ChristianSchulte commented on the pull request:

https://github.com/apache/maven/pull/21#issuecomment-45980866
  
http://wiki.eclipse.org/Aether/New_and_Noteworthy#Version_Ranges


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-2199] Version ranges not supported for pa...

Github user ChristianSchulte commented on the pull request:

https://github.com/apache/maven/pull/21#issuecomment-45980581
  
From what I can tell, release:prepare-with-pom should work the same way as 
before. What this patch basically does is to resolve any parent version range 
and then continue with the highest version found the same way as if that 
highest version had been specified in the pom.

If I remember correctly, Aether already provides an extended version range 
syntax which allows to specify if snapshots are to be included or not. I am not 
sure about that, however. If it does, Maven already supports that as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-2199] Version ranges not supported for pa...

Github user ChristianSchulte commented on the pull request:

https://github.com/apache/maven/pull/21#issuecomment-45974252
  
I have done several releases using 'release:prepare release:perform' with a 
parent version range in use. The release plugin won't write the resolved parent 
version to the released pom. That's intentional. It shouldn't. The parent 
version range should be deployed as is. That's the reason the build will fail 
if a parent version range is in use and a child module uses a version 
expression or inherits the version from the parent. As soon as a parent version 
range is in use, ${some.expression} and not providing a 
version element will not be supported in child modules. In addition, the parent 
version range is checked to contain an upper bound so that it is not possible 
to e.g. deploy an artifact to central using a parent version range which is not 
upper-bounded.

ITs are working with the patch applied. I will provide a pull-request 
against 'maven-integration-testing' as soon as I finish some ITs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-2199] Version ranges not supported for pa...