[jira] Created: (MPMD-17) Add report summary

2006-02-27 Thread Nick Giles (JIRA)
Add report summary
--

 Key: MPMD-17
 URL: http://jira.codehaus.org/browse/MPMD-17
 Project: Maven 2.x Pmd Plugin
Type: Improvement

Reporter: Nick Giles
Priority: Minor


Add a summary of the PMD report to the top of the report page, in the same 
manner as Checkstyle. This should include information such as the total number 
of violations, number of violations by priority, and optionally number of 
violations by file and rule

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Commented: (MPMD-17) Add report summary

2006-02-27 Thread Nick Giles (JIRA)
[ http://jira.codehaus.org/browse/MPMD-17?page=comments#action_59550 ] 

Nick Giles commented on MPMD-17:


I'll look into making the changes necessary, but the main problem looks like 
being that the report is generated using a listener, not by returning and 
evaluating the Report object.

 Add report summary
 --

  Key: MPMD-17
  URL: http://jira.codehaus.org/browse/MPMD-17
  Project: Maven 2.x Pmd Plugin
 Type: Improvement

 Reporter: Nick Giles
 Priority: Minor



 Add a summary of the PMD report to the top of the report page, in the same 
 manner as Checkstyle. This should include information such as the total 
 number of violations, number of violations by priority, and optionally number 
 of violations by file and rule

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Created: (MPMD-15) End line of violation displays as begin line

2006-02-15 Thread Nick Giles (JIRA)
End line of violation displays as begin line


 Key: MPMD-15
 URL: http://jira.codehaus.org/browse/MPMD-15
 Project: Maven 2.x Pmd Plugin
Type: Bug

Versions: 2.0-beta-2
Reporter: Nick Giles
Priority: Minor
 Attachments: MPMD-15.patch

The line range currently displays as 'begin - begin', it was clearly meant to 
be 'begin - end'. Easy patch to follow in a moment.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (MPMD-15) End line of violation displays as begin line

2006-02-15 Thread Nick Giles (JIRA)
 [ http://jira.codehaus.org/browse/MPMD-15?page=all ]

Nick Giles updated MPMD-15:
---

Attachment: MPMD-15.patch

 End line of violation displays as begin line
 

  Key: MPMD-15
  URL: http://jira.codehaus.org/browse/MPMD-15
  Project: Maven 2.x Pmd Plugin
 Type: Bug

 Versions: 2.0-beta-2
 Reporter: Nick Giles
 Priority: Minor
  Attachments: MPMD-15.patch


 The line range currently displays as 'begin - begin', it was clearly meant to 
 be 'begin - end'. Easy patch to follow in a moment.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Created: (MPMD-16) Utilise the exclusion mechanism to allow arbitrary exclusions

2006-02-15 Thread Nick Giles (JIRA)
Utilise the exclusion mechanism to allow arbitrary exclusions
-

 Key: MPMD-16
 URL: http://jira.codehaus.org/browse/MPMD-16
 Project: Maven 2.x Pmd Plugin
Type: Improvement

Versions: 2.0-beta-2
Reporter: Nick Giles
Priority: Minor
 Attachments: MPMD-16.patch

Files named package-info.java are currently excluded through some hard-coding, 
but the same mechanism can helpfully be used to exclude any user-defined set of 
classes, for instance if they are generated files that you don't care about the 
code quality of. Or in my case if some classes are caught by a bug in the PMD 
grammar. Patch to follow.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (MPMD-16) Utilise the exclusion mechanism to allow arbitrary exclusions

2006-02-15 Thread Nick Giles (JIRA)
 [ http://jira.codehaus.org/browse/MPMD-16?page=all ]

Nick Giles updated MPMD-16:
---

Attachment: MPMD-16.patch

 Utilise the exclusion mechanism to allow arbitrary exclusions
 -

  Key: MPMD-16
  URL: http://jira.codehaus.org/browse/MPMD-16
  Project: Maven 2.x Pmd Plugin
 Type: Improvement

 Versions: 2.0-beta-2
 Reporter: Nick Giles
 Priority: Minor
  Attachments: MPMD-16.patch


 Files named package-info.java are currently excluded through some 
 hard-coding, but the same mechanism can helpfully be used to exclude any 
 user-defined set of classes, for instance if they are generated files that 
 you don't care about the code quality of. Or in my case if some classes are 
 caught by a bug in the PMD grammar. Patch to follow.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Created: (MCHECKSTYLE-29) Checkstyle violations should link to Xref if available

2006-01-04 Thread Nick Giles (JIRA)
Checkstyle violations should link to Xref if available
--

 Key: MCHECKSTYLE-29
 URL: http://jira.codehaus.org/browse/MCHECKSTYLE-29
 Project: Maven 2.x Checkstyle Plugin
Type: New Feature

Reporter: Nick Giles
Priority: Minor


The Checkstyle report should link to the location of the violation in the 
Source Cross Reference if it is available. Attached is a patch that will 
generate a link based on an additional parameter 'xrefLocation'. If this is not 
present, or is null, no link will be created.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (MCHECKSTYLE-29) Checkstyle violations should link to Xref if available

2006-01-04 Thread Nick Giles (JIRA)
 [ http://jira.codehaus.org/browse/MCHECKSTYLE-29?page=all ]

Nick Giles updated MCHECKSTYLE-29:
--

Attachment: MCHECKSTYLE-29.patch

 Checkstyle violations should link to Xref if available
 --

  Key: MCHECKSTYLE-29
  URL: http://jira.codehaus.org/browse/MCHECKSTYLE-29
  Project: Maven 2.x Checkstyle Plugin
 Type: New Feature

 Reporter: Nick Giles
 Priority: Minor
  Attachments: MCHECKSTYLE-29.patch


 The Checkstyle report should link to the location of the violation in the 
 Source Cross Reference if it is available. Attached is a patch that will 
 generate a link based on an additional parameter 'xrefLocation'. If this is 
 not present, or is null, no link will be created.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Created: (MPPMD-22) Link violations to Xref

2005-12-21 Thread Nick Giles (JIRA)
Link violations to Xref
---

 Key: MPPMD-22
 URL: http://jira.codehaus.org/browse/MPPMD-22
 Project: maven-pmd-plugin
Type: Improvement

Reporter: Nick Giles
Priority: Minor


The violations should link to their location in the source xref, as happened in 
Maven 1. I'll attach a patch for this that does a simple but hopefully 
sufficient job. It's based on the latest SCM code.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (MPPMD-22) Link violations to Xref

2005-12-21 Thread Nick Giles (JIRA)
 [ http://jira.codehaus.org/browse/MPPMD-22?page=all ]

Nick Giles updated MPPMD-22:


Attachment: MPPMD-22.patch

 Link violations to Xref
 ---

  Key: MPPMD-22
  URL: http://jira.codehaus.org/browse/MPPMD-22
  Project: maven-pmd-plugin
 Type: Improvement

 Reporter: Nick Giles
 Priority: Minor
  Attachments: MPPMD-22.patch


 The violations should link to their location in the source xref, as happened 
 in Maven 1. I'll attach a patch for this that does a simple but hopefully 
 sufficient job. It's based on the latest SCM code.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Created: (MNG-1855) Exception when creating Checkstyle report as part of a 'site' build

2005-12-16 Thread Nick Giles (JIRA)
Exception when creating Checkstyle report as part of a 'site' build
---

 Key: MNG-1855
 URL: http://jira.codehaus.org/browse/MNG-1855
 Project: Maven 2
Type: Bug

  Components: maven-checkstyle-plugin  
Versions: 2.0.2
 Environment: Windows XP, JDK 1.4.2_10, Maven 2.0.2-SNAPSHOT, 
maven-checkstyle-plugin 2.0-beta-2-SNAPSHOT
Reporter: Nick Giles
 Attachments: error_trace.txt

When attempting to create a project site including a checkstyle report, the 
build fails with the attached stack trace. However, when creating a checkstyle 
report simply by running 'mvn checkstyle:checkstyle', the build is successful 
and the report is produced.

From some initial investigation, it appears that the classloader passed in to 
checkstyle itself by the plugin can locate essential resources when the build 
is specifically for checkstyle, but cannot locate them when it is invoked as 
part of a call for 'site'. This can be tested by adding the following lines of 
code into 
org.apache.maven.plugin.checkstyle.CheckstyleReport.getModuleFactory(), where 
'loader' is the ClassLoader being passed to the PackageNamesLoader:

getLog().info(\n\n\n\nClass loader:  + loader.getClass().getName());
getLog().info(Input stream:  + 
loader.getResourceAsStream(com/puppycrawl/tools/checkstyle/checkstyle_packages.xml));
getLog().info(DTD:  + 
loader.getResourceAsStream(com/puppycrawl/tools/checkstyle/packages_1_0.dtd));

These should show jar file URLs if found, and null if not, which will happen 
respectively when run as 'mvn checkstyle:checkstyle' and 'mvn site'.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Created: (MNG-1846) Use of 'severity' attribute in module configuration file causes UnsupportedOperationException

2005-12-15 Thread Nick Giles (JIRA)
Use of 'severity' attribute in module configuration file causes 
UnsupportedOperationException
-

 Key: MNG-1846
 URL: http://jira.codehaus.org/browse/MNG-1846
 Project: Maven 2
Type: Bug

  Components: maven-checkstyle-plugin  
Versions: 2.0.2, 2.0
 Environment: Windows XP, J2SDK 1.4.2_10, maven-checkstyle-plugin 
2.0-beta-2-SNAPSHOT, Maven 2.0.2-SNAPSHOT
Reporter: Nick Giles
 Attachments: trace.txt

When I provide the Checkstyle plugin with a customised config file, it causes 
it to crash unpleasantly when generating the report. It appears that this is 
due to calling the 'remove' method on Arrays$ArrayList, which doesn't implement 
the method. The call is actually removing the 'severity' property from the list 
of columns before going on to process the rest. Wrapping the list in an actual 
ArrayList (java.util.ArrayList) solves the problem.

To replicate, add configLocationyour-rules.xml/configLocation to the plugin 
configuration, and ensure that at least two modules in your-rules.xml have the 
severity property set, something like:

?xml version=1.0?
!DOCTYPE module PUBLIC
-//Puppy Crawl//DTD Check Configuration 1.2//EN
http://www.puppycrawl.com/dtds/configuration_1_2.dtd;

module name=Checker
module name=PackageHtml
  property name=severity value=warning /
/module

module name=NewlineAtEndOfFile
  property name=severity value=info /
/module
/module



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]