[jira] Commented: (MECLIPSE-71) eclipse:clean delets too much
[ http://jira.codehaus.org/browse/MECLIPSE-71?page=comments#action_60229 ] Reinhard Poetz commented on MECLIPSE-71: Are there any implications if I don't run "eclipse:clean" before I run "eclipse:eclipse"? Is it possible that the plugin creates some inconsistent Eclipse settings files? If no, I agree with you that deleting isn't necessary. (Although Maven delets a file that it doesn't generate *completly* --> org.eclipse.jdt.core.prefs) I'd propose following cleaning procedure: - eclipse:clean delets all files it generates/manipulates - if after deleting these files, something is left (e.g. .svn directory) the .settings directory is _not_ deleted - if .settings is empty, the .settings directory is deleted too. WDYT? > eclipse:clean delets too much > - > > Key: MECLIPSE-71 > URL: http://jira.codehaus.org/browse/MECLIPSE-71 > Project: Maven 2.x Eclipse Plugin > Type: Bug > Versions: 2.1 > Reporter: Reinhard Poetz > > > If I call eclipse:clean, the complete ".settings" directory is deleted. In my > projects we share some Eclipse settings in our team by adding the .settings > directory to SVN. > This behaviour is unpractical for us as SVN gets confused by the missing > ./settings/.svn directory. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (MECLIPSE-71) eclipse:clean delets too much
[ http://jira.codehaus.org/browse/MECLIPSE-71?page=comments#action_59893 ] Reinhard Poetz commented on MECLIPSE-71: ok, this makes it even easier :-) AFAICS, the SettingsWriter writes to org.eclipse.jdt.core.prefs. It doesn't generate the complete file, but reads out the already set parameters and overrides the "o.e.j.c.c.compliance", "o.e.j.c.c.source" and "o.e.j.c.c.target" properties. The question now is: Should we delete the file or not? In my projects, org.eclipse.jdt.core.prefs is shared via SVN (e.g. to set project specific code styles) and deleting it is problematic and I don't think necessary. IIUC, the only file within the .settings directory that should get deleted with eclipse:clean is ".settings/.component", which is generated by the EclipseWtpComponentWriter. I could provide a patch if you want. WDYT? > eclipse:clean delets too much > - > > Key: MECLIPSE-71 > URL: http://jira.codehaus.org/browse/MECLIPSE-71 > Project: Maven 2.x Eclipse Plugin > Type: Bug > Versions: 2.1 > Reporter: Reinhard Poetz > > > If I call eclipse:clean, the complete ".settings" directory is deleted. In my > projects we share some Eclipse settings in our team by adding the .settings > directory to SVN. > This behaviour is unpractical for us as SVN gets confused by the missing > ./settings/.svn directory. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (MECLIPSE-71) eclipse:clean delets too much
[ http://jira.codehaus.org/browse/MECLIPSE-71?page=comments#action_59810 ] Reinhard Poetz commented on MECLIPSE-71: My idea was adding a configuration parameter, that makes it possible to add paths that are excluded from deletion. WDYT? > eclipse:clean delets too much > - > > Key: MECLIPSE-71 > URL: http://jira.codehaus.org/browse/MECLIPSE-71 > Project: Maven 2.x Eclipse Plugin > Type: Bug > Versions: 2.1 > Reporter: Reinhard Poetz > > > If I call eclipse:clean, the complete ".settings" directory is deleted. In my > projects we share some Eclipse settings in our team by adding the .settings > directory to SVN. > This behaviour is unpractical for us as SVN gets confused by the missing > ./settings/.svn directory. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Created: (MECLIPSE-71) eclipse:clean delets too much
eclipse:clean delets too much - Key: MECLIPSE-71 URL: http://jira.codehaus.org/browse/MECLIPSE-71 Project: Maven 2.x Eclipse Plugin Type: Bug Versions: 2.1 Reporter: Reinhard Poetz If I call eclipse:clean, the complete ".settings" directory is deleted. In my projects we share some Eclipse settings in our team by adding the .settings directory to SVN. This behaviour is unpractical for us as SVN gets confused by the missing ./settings/.svn directory. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (MECLIPSE-70) Duplicate entries in .project (/projectDescription/projects/project)
[ http://jira.codehaus.org/browse/MECLIPSE-70?page=all ] Reinhard Poetz updated MECLIPSE-70: --- Attachment: patch_removeDuplicateEntries.diff > Duplicate entries in .project (/projectDescription/projects/project) > > > Key: MECLIPSE-70 > URL: http://jira.codehaus.org/browse/MECLIPSE-70 > Project: Maven 2.x Eclipse Plugin > Type: Bug > Versions: 2.0, 2.2, 2.1 > Reporter: Reinhard Poetz > Attachments: patch_removeDuplicateEntries.diff, > patch_removeDuplicateEntries.diff > > > If a pom.xml has following dependencies > > com.mycompany > app-framework > 1.0-SNAPSHOT > jar > > > com.mycompany > app-framework > 1.0-SNAPSHOT > test-jar > test > > the plugin creates an invalid .project for Eclipse as the artifactId is used > as project name. As the artifactId is not a unique identifier, following is > created: > > webapp > > > app-framework > app-framework > > > This, of course, leads to an error in Eclipse -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (MECLIPSE-70) Duplicate entries in .project (/projectDescription/projects/project)
[ http://jira.codehaus.org/browse/MECLIPSE-70?page=all ] Reinhard Poetz updated MECLIPSE-70: --- Attachment: patch_removeDuplicateEntries.diff > Duplicate entries in .project (/projectDescription/projects/project) > > > Key: MECLIPSE-70 > URL: http://jira.codehaus.org/browse/MECLIPSE-70 > Project: Maven 2.x Eclipse Plugin > Type: Bug > Versions: 2.2, 2.0, 2.1 > Reporter: Reinhard Poetz > Attachments: patch_removeDuplicateEntries.diff > > > If a pom.xml has following dependencies > > com.mycompany > app-framework > 1.0-SNAPSHOT > jar > > > com.mycompany > app-framework > 1.0-SNAPSHOT > test-jar > test > > the plugin creates an invalid .project for Eclipse as the artifactId is used > as project name. As the artifactId is not a unique identifier, following is > created: > > webapp > > > app-framework > app-framework > > > This, of course, leads to an error in Eclipse -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Created: (MECLIPSE-70) Duplicate entries in .project (/projectDescription/projects/project)
Duplicate entries in .project (/projectDescription/projects/project) Key: MECLIPSE-70 URL: http://jira.codehaus.org/browse/MECLIPSE-70 Project: Maven 2.x Eclipse Plugin Type: Bug Versions: 2.2, 2.0, 2.1 Reporter: Reinhard Poetz If a pom.xml has following dependencies com.mycompany app-framework 1.0-SNAPSHOT jar com.mycompany app-framework 1.0-SNAPSHOT test-jar test the plugin creates an invalid .project for Eclipse as the artifactId is used as project name. As the artifactId is not a unique identifier, following is created: webapp app-framework app-framework This, of course, leads to an error in Eclipse -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
