[GitHub] maven issue #127: [MNG-6255] Fix concat_lines in mvn to deal with CRLF
Github user Tunaki commented on the issue: https://github.com/apache/maven/pull/127 Looks like we have a similar bug in `mvn.cmd`. The added `testJvmConfigFileCR` test fails on Windows: ``` testJvmConfigFileCR(org.apache.maven.it.MavenITmng6255FixConcatLines) Time elapsed: 1.983 sec <<< FAILURE! junit.framework.ComparisonFailure: null expected:<ok[]> but was:<ok[-Xms256m-Xmx512m]> at junit.framework.Assert.assertEquals(Assert.java:81) at junit.framework.Assert.assertEquals(Assert.java:87) at org.apache.maven.it.MavenITmng6255FixConcatLines.runWithLineEndings(MavenITmng6255FixConcatLines.java:89) at org.apache.maven.it.MavenITmng6255FixConcatLines.testJvmConfigFileCR(MavenITmng6255FixConcatLines.java:50) ``` Looks like the carriage returns at the end of the line were stripped and everything was put on a single line. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-integration-testing issue #23: [MNG-6265] Integration test for Maven s...
Github user Tunaki commented on the issue: https://github.com/apache/maven-integration-testing/pull/23 I ran the IT with 3.5.0 on Windows, but it passed. Since the issue resolves around the error message that is printed on the console, I think the two files `folder-with- -space/pom.xml` and `folder-with-)-closing-bracket/pom.xml` should be removed, and instead it should be tested that the correct error message is printed, right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #128: [MNG-6256] Surround variables in echo command with double ...
Github user Tunaki commented on the issue:
https://github.com/apache/maven/pull/128
Shouldn't there be the same fix for `mvn`, and not just `mvn.cmd`?
[`${basedir}`](https://github.com/apache/maven/blob/707cff6ffdecbfb0e0356c70e3a7b490535e7ce4/apache-maven/src/bin/mvn#L150)
and
[`${arg}`](https://github.com/apache/maven/blob/707cff6ffdecbfb0e0356c70e3a7b490535e7ce4/apache-maven/src/bin/mvn#L154)
are not escaped as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #127: [MNG-6255] Fix concat_lines in mvn to deal with CRLF
Github user Tunaki commented on the issue: https://github.com/apache/maven/pull/127 This looks OK, verified with `bash` and `dash` (on Ubuntu 16.04), `tcsh` and `sh` (on FreeBSD 11.0). Could you add an integration test for this (https://github.com/apache/maven-integration-testing)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #127: Fix concat_lines in mvn to deal with CRLF
Github user Tunaki commented on the issue: https://github.com/apache/maven/pull/127 This doesn't seem to work on CRLF files on Git Bash (or Ubuntu). Result is the same as with `tr`. ```sh $ echo -e "Foo\nBar" > test.txt $ cat -e test.txt Foo$ Bar$ $ paste -s -d' ' test.txt Foo Bar $ unix2dos test.txt unix2dos: converting file test.txt to DOS format ... $ cat -e test.txt Foo^M$ Bar^M$ $ paste -s -d' ' test.txt Bar ``` When the line endings were changed to Windows format, only the last line was kept. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #151: Fixing build on Windows cmd.exe.
Github user Tunaki closed the pull request at: https://github.com/apache/maven-surefire/pull/151 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #151: Fixing build on Windows cmd.exe.
Github user Tunaki commented on the issue: https://github.com/apache/maven-surefire/pull/151 Yes, I was finishing typing it up: https://issues.apache.org/jira/browse/SUREFIRE-1375. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #151: Fixing build on Windows cmd.exe.
GitHub user Tunaki opened a pull request: https://github.com/apache/maven-surefire/pull/151 Fixing build on Windows cmd.exe. Files generated with the XJC tool were using the platform encoding, that can be different from the project source encoding. In this case, the project source encoding is UTF-8, but cmd.exe can use another (e.g. code page 850). In turn, this created an error while compiling the generated sources because they contain unmappable characters for UTF-8 as expected by the compiler. The encoding that should be used by XJC is specified through the -encoding option. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Tunaki/maven-surefire master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven-surefire/pull/151.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #151 commit 92efe82cf2b1a81fb184e89146119b84e6334a25 Author: Tunaki <guillaume_b...@orange.fr> Date: 2017-05-28T19:16:46Z Fixing build on Windows cmd.exe. Files generated with the XJC tool were using the platform encoding, that can be different from the project source encoding. In this case, the project source encoding is UTF-8, but cmd.exe can use another (e.g. code page 850). In turn, this created an error while compiling the generated sources because they contain unmappable characters for UTF-8 as expected by the compiler. The encoding that should be used by XJC is specified through the -encoding option. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-wagon pull request #32: [WAGON-485] ScpWagon file size Integer to Long
Github user Tunaki commented on a diff in the pull request: https://github.com/apache/maven-wagon/pull/32#discussion_r95232415 --- Diff: wagon-providers/wagon-ssh/src/main/java/org/apache/maven/wagon/providers/ssh/jsch/ScpWagon.java --- @@ -297,7 +297,7 @@ public void fillInputData( InputData inputData ) throw new IOException( "Invalid transfer header: " + line ); } -int filesize = Integer.valueOf( line.substring( 5, index ) ).intValue(); +long filesize = Long.valueOf( line.substring( 5, index ) ); --- End diff -- Small note, `Long.parseLong` is better here as it wouldn't involve an unboxing conversion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
