[GitHub] maven issue #125: [MNG-5965] Parallel build multiplies work if multiple goal...
Github user ifedorenko commented on the issue: https://github.com/apache/maven/pull/125 No, sorry, I can't "assign" this to anyone, you just have to wait for somebody to review and merge this pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #125: [MNG-5965] Parallel build multiplies work if multiple goal...
Github user ifedorenko commented on the issue: https://github.com/apache/maven/pull/125 The change looks reasonable but I don't use built-in multithreaded build support myself and do not feel comfortable merging this change without proper testing. I will have to defer to somebody more familiar with this part of Maven codebase. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #125: [MNG-5965] Parallel build multiplies work if multiple goal...
Github user ifedorenko commented on the issue: https://github.com/apache/maven/pull/125 No, having IT failures are not normal, and [jenkins seems to be happy](https://builds.apache.org/view/M-R/view/Maven%20Core%20ITs/job/core-integration-testing-maven-3-embedded/). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #125: [MNG-5965] Parallel build multiplies work if multiple goal...
Github user ifedorenko commented on the issue: https://github.com/apache/maven/pull/125 Can you provide a regression test that demonstrates the problem and the fix? Semi-related, I recently fixed similar problem in [Takari Smart Builder](https://github.com/takari/takari-smart-builder) where aggregate tasks ran multiple times. Multithreading is hard :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader
Github user ifedorenko commented on the issue: https://github.com/apache/maven/pull/116 Wow. That's backwards. I wonder what will happen if I push my change with github's magic "fixes 116" pseudo comment. Guess there is one way to find out :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader
Github user ifedorenko commented on the issue: https://github.com/apache/maven/pull/116 Opened https://issues.apache.org/jira/browse/MNG-6233. If you any concerns or suggestions, I suggest we continue the discussion there. @jdillon I can't close this pull request --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader
Github user ifedorenko commented on the issue: https://github.com/apache/maven/pull/116 I have a commit on a local branch that fully converts maven-resolver-provider to jsr330, I can push that to master if you can wait few days. Either way we'll need a JIRA to track the changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #69: MNG-5899 Reactor should use reduced dependency pom
Github user ifedorenko commented on the issue: https://github.com/apache/maven/pull/69 I am dead serious. I am not at liberty to disclose exact numbers, but lets say our main codebase is in the same ballpark if we allow some room for growth. So 5K modules is not "aspirational pipe dream" kind of goal but very much a real-life requirement we have. (if you are interested, I can provide some details about how we use Maven for a project of this size, but maven dev list is probably a better place to talk about it). Even in opensource [some projects](https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668) apparently have ~700 modules. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #69: MNG-5899 Reactor should use reduced dependency pom
Github user ifedorenko commented on the issue: https://github.com/apache/maven/pull/69 I still vote -1 on this change. While I appreciate "dependency reduced pom" usecase, I'd like the following two concerns addressed first: * Mutated pom.xml files must not invalidate original reactor ProjectDependencyGraph. More specifically, if the original graph allowed certain build order, the new graph must still allow the same order. In practice this means the new graph must not have any new dependencies, which is rather tricky to guarantee when we consider dependency `` and dependency management. * Implementation must scale well to 5K+ modules and 5K managed external dependencies. In practice this requires some sort of caching to avoid repeated reparsing/reinterpollation of reactor pom.xml files. Additionally, I'd like to understand expected behaviour when projects with dependency reduced pom files are excluded from the build using `--projects` command line argument or pom-reducing mojo is not part of selected build phase. I have not analyzed this in details, but I believe mutable pom.xml files can lead to odd/unexpected build results that will be difficult to explain and hence require extra support effort (I happen to help maintain builds for a reasonably large developer community, so supportability is an important concern for me). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #110: plexus
Github user ifedorenko commented on the issue: https://github.com/apache/maven/pull/110 spam? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: MNG-5899 Reactor should use reduced dependency...
Github user ifedorenko commented on the pull request: https://github.com/apache/maven/pull/69#issuecomment-145727506 I am not sure I fully understand the problem, but maven generally expects project dependencies to stay the same during the build. If you need to suppress certain storm-core dependencies from "leaking" into uber-jar projects, I think you should be able to simple mark those dependencies as optional=true (which really means "non-transitive"). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: MNG-5899 Reactor should use reduced dependency...
Github user ifedorenko commented on the pull request: https://github.com/apache/maven/pull/69#issuecomment-145722376 -1 The old behaviour allowed inconsistency between dependencies used to calculate project build order and project dependencies used during the build. It also resulted in reparsing reactor project pom.xml files multiple times during the build, which affected build performance for larger projects. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: [MNG-5840] Parent version is a range hack
Github user ifedorenko commented on the pull request: https://github.com/apache/maven/pull/60#issuecomment-123711202 What other options do we have? I guess we can create new `maven-versioning` module, move `org.apache.maven.artifact.versioning` implementation there and change maven-artifact to delegate to the new code. This is the only "clean" solution I can think of, but I do not have time to do this now and not sure new module with only a handful of classes is justifiable. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: MNG-3092: Add strategy based version range res...
Github user ifedorenko commented on the pull request: https://github.com/apache/maven/pull/57#issuecomment-120415902 What will happen when projects using new/custom version range resolution strategy are deployed to shared repository like Central? Won't this break consumers of project artifacts? For example, say my project uses odd/even versioning convention to distinguish between developer and stable versions and I implemented custom range resolver to enforce this convention. Since consumers of my project's artifacts will have no knowledge of the versioning scheme I use, they may resolve wrong transitive dependencies. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: #MNG-5844: Close IO Streams in finally block
Github user ifedorenko commented on the pull request: https://github.com/apache/maven/pull/53#issuecomment-113485035 Maven is targeting java 7 already, try-with-resource is more appropriate way to guarantee IO streams are closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: Added support for MAVEN_ARGS in mvn, mvnDebug,...
Github user ifedorenko commented on the pull request: https://github.com/apache/maven/pull/49#issuecomment-105632922 This seems to break org.apache.maven.it.MavenITmng3529QuotedCliArgTest integration test. Will have a closer look later today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: MNG-5786: Fix edge case in determining maven.m...
Github user ifedorenko commented on the pull request: https://github.com/apache/maven/pull/40#issuecomment-89838717 @Stephan202 what is your usecase for having multiple maven or jvm options for the same codebase? Is this to support svn (and similar) repositories that effectively host multiple codebases or something else? .mvn is meant to configure environment parameters like jvm -Xmx or builder and I can't think of a reason these would be different for different parts of the same codebase. As for searching "true" multi-module project root, lack of `pom.xml` is not a good indicator traversal reached outside project tree. First, we wanted to support alternative pom formats with this feature. Second, even for projects that do use `pom.xml`, parent pom does not have to be at the root of the project codebase. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...
Github user ifedorenko commented on the pull request: https://github.com/apache/maven/pull/32#issuecomment-78070683 http://jira.codehaus.org/browse/MNG-5783 should be fixed in master now. I've provided explanation of the problem and links to the fix and corresponding IT changes in the jira. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
