[GitHub] maven issue #161: [MNG-6370] Fix typo in list filtering ConcurrencyDependenc...
Github user slachiewicz commented on the issue: https://github.com/apache/maven/pull/161 Sure, unit test are always funny part:) done --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #161: [MNG-6370] Fix typo in list filtering ConcurrencyDe...
GitHub user slachiewicz opened a pull request: https://github.com/apache/maven/pull/161 [MNG-6370] Fix typo in list filtering ConcurrencyDependencyGraph.getU⦠â¦nfinishedProjects You can merge this pull request into a Git repository by running: $ git pull https://github.com/slachiewicz/maven fix/MNG-6370 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven/pull/161.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #161 commit 683504fdcd0d901a06c9b49463175d9076299925 Author: Sylwester Lachiewicz <slachiewicz@...> Date: 2018-03-05T21:24:14Z [MNG-6370] Fix typo in list filtering ConcurrencyDependencyGraph.getUnfinishedProjects --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #135: [MNG-6296] Parse properties before configuring the logging...
Github user slachiewicz commented on the issue: https://github.com/apache/maven/pull/135 Merged to master http://git-wip-us.apache.org/repos/asf/maven/commit/b2afafe5 --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #160: Fix links to Apache/CDDL/MIT licenses
GitHub user slachiewicz opened a pull request: https://github.com/apache/maven/pull/160 Fix links to Apache/CDDL/MIT licenses - skip download of Apache License files - correct address to Oracle CDDL and MIT licenses You can merge this pull request into a Git repository by running: $ git pull https://github.com/slachiewicz/maven fix/licence1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven/pull/160.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #160 commit 5923288a0034a97b885254a0a675b03ca65e0fcd Author: Sylwester Lachiewicz <slachiewicz@...> Date: 2018-02-21T00:48:43Z Fix links to Apache/CDDL/MIT licenses - skip download of Apache License files - correct address to Oracle CDDL and MIT licenses --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #156: Remove Google Guava usage (move to Java7)
Github user slachiewicz closed the pull request at: https://github.com/apache/maven/pull/156 --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #156: Remove Google Guava usage (move to Java7)
GitHub user slachiewicz opened a pull request: https://github.com/apache/maven/pull/156 Remove Google Guava usage (move to Java7) You can merge this pull request into a Git repository by running: $ git pull https://github.com/slachiewicz/maven remove-guava-java7 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven/pull/156.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #156 commit 6eede1a8ff4b7bcbbbafd0729548b87deec30e07 Author: Sylwester Lachiewicz <slachiewicz@...> Date: 2017-11-08T21:29:50Z Remove Google Guava usage (move to Java7) --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #155: [MNG-5378] Replace plexus-util StringUtils with com...
GitHub user slachiewicz opened a pull request: https://github.com/apache/maven/pull/155 [MNG-5378] Replace plexus-util StringUtils with commons-lang3 You can merge this pull request into a Git repository by running: $ git pull https://github.com/slachiewicz/maven fix/MNG-5378 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven/pull/155.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #155 commit 6c57ccb33ef97170dba63b835200a0fd84de6a68 Author: Sylwester Lachiewicz <slachiewicz@...> Date: 2018-02-10T18:05:53Z [MNG-5378] Replace plexus-utils with commons-lang3 --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #153: [MNG-6069] Migrate to non deprecated parts of Commo...
Github user slachiewicz commented on a diff in the pull request:
https://github.com/apache/maven/pull/153#discussion_r167400525
--- Diff: maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
---
@@ -1620,14 +1620,18 @@ static void populateProperties( CommandLine
commandLine, Properties systemProper
if ( commandLine.hasOption( CLIManager.SET_SYSTEM_PROPERTY ) )
{
-String[] defStrs = commandLine.getOptionValues(
CLIManager.SET_SYSTEM_PROPERTY );
-
-if ( defStrs != null )
+Properties lineOptionProperties =
commandLine.getOptionProperties( CLIManager.SET_SYSTEM_PROPERTY );
+
+for ( String defStr :
lineOptionProperties.stringPropertyNames( ) )
{
-for ( String defStr : defStrs )
-{
-setCliProperty( defStr, userProperties );
-}
+String optValue = lineOptionProperties.getProperty( defStr
);
+userProperties.setProperty( defStr, optValue );
+
+//
--
+// I'm leaving the setting of system properties here as
not to break
+// the SystemPropertyProfileActivator. This won't harm
embedding. jvz.
+//
--
+ System.setProperty( defStr, optValue );
--- End diff --
System properties will stay, new commons-cli just simplified setCliProperty.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #154: [MNG-5967] Correct Mockito scope to test
Github user slachiewicz closed the pull request at: https://github.com/apache/maven/pull/154 --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #150: [ MNG-6335] Update Mockito to 2.12.0
Github user slachiewicz closed the pull request at: https://github.com/apache/maven/pull/150 --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-shared pull request #26: [MCHECKSTYLE-326] Fix checkstyle error
Github user slachiewicz closed the pull request at: https://github.com/apache/maven-shared/pull/26 --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #154: [MNG-5967] Correct Mockito scope to test
GitHub user slachiewicz opened a pull request: https://github.com/apache/maven/pull/154 [MNG-5967] Correct Mockito scope to test You can merge this pull request into a Git repository by running: $ git pull https://github.com/slachiewicz/maven fix/MNG-5967 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven/pull/154.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #154 commit 379eeef17134646b6b19bd42517e108de574c04c Author: Sylwester Lachiewicz <slachiewicz@...> Date: 2018-01-13T23:01:43Z [MNG-5967] Correct Mockito scope to test --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-shared pull request #26: [MCHECKSTYLE-326] Fix checkstyle error
GitHub user slachiewicz opened a pull request: https://github.com/apache/maven-shared/pull/26 [MCHECKSTYLE-326] Fix checkstyle error You can merge this pull request into a Git repository by running: $ git pull https://github.com/slachiewicz/maven-shared fix/MCHECKSTYLE-326 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven-shared/pull/26.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #26 commit fcec6a315f358fef9ee1eeb43ed6f25c6f61a256 Author: Sylwester Lachiewicz <slachiewicz@...> Date: 2018-01-11T22:21:25Z [MCHECKSTYLE-326] Fix checkstyle error --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #151: [MNG-5968] Default plugin version updates
Github user slachiewicz closed the pull request at: https://github.com/apache/maven/pull/151 --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #151: [MNG-5968] Default plugin version updates
Github user slachiewicz commented on the issue: https://github.com/apache/maven/pull/151 Thank you for the explanation, I have seen previous discussions about the update - for sure the refreshment of the topic will be useful like MNG-6169 I have prepared fix for MNG-5992 and clossing this pull. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #153: [MNG-6069] Migrate to non deprecated parts of Commo...
GitHub user slachiewicz opened a pull request: https://github.com/apache/maven/pull/153 [MNG-6069] Migrate to non deprecated parts of Commons CLI Without 2nd commit 719234d when I set -Dstyle.color=never is not working correctly and returns value "true" not "never" You can merge this pull request into a Git repository by running: $ git pull https://github.com/slachiewicz/maven fix/MNG-6069 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven/pull/153.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #153 commit 23b24d314c4253f722a282444cb133e5bd37d5c5 Author: Karl Heinz Marbaise <khmarbaise@...> Date: 2017-03-18T17:18:27Z [MNG-6069] Migrate to non deprecated parts of Commons CLI commit 719234dacf63bfee36f67c1a8c2f7a9e76eb3842 Author: Sylwester Lachiewicz <slachiewicz@...> Date: 2017-11-24T02:21:09Z [MNG-6069] Fix optionProperties parsing --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #137: [MNG-6069] Migrate to non deprecated parts of Commo...
Github user slachiewicz closed the pull request at: https://github.com/apache/maven/pull/137 --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #152: [MNG-5992] Upgrade default version of maven-release...
GitHub user slachiewicz opened a pull request: https://github.com/apache/maven/pull/152 [MNG-5992] Upgrade default version of maven-release-plugin to 2.5.3 Fix password printout to logs Credit to: Ryan J. McDonough You can merge this pull request into a Git repository by running: $ git pull https://github.com/slachiewicz/maven fix/MNG-5992-maven-release-plugin Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven/pull/152.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #152 commit 285158e1f76667eea2b92c17fe770b226c15e259 Author: Sylwester Lachiewicz <slachiewicz@...> Date: 2018-01-07T11:22:11Z [MNG-5992] Upgrade default version of maven-release-plugin to 2.5.3 Fix password printout to logs Credit to: Ryan J. McDonough --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #151: [MNG-5968] Default plugin version updates
Github user slachiewicz commented on the issue: https://github.com/apache/maven/pull/151 I found this changes in abdoned 3.4 line. Should also fix MNG-5992 --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #151: [MNG-5968] Default plugin version updates
GitHub user slachiewicz opened a pull request: https://github.com/apache/maven/pull/151 [MNG-5968] Default plugin version updates o Updated default plugin versions to latest release version to bring in the latest fixes (and issues to report). o Updated to correct the 'ear' packaging bindings. o Downgraded the 'maven-plugin-plugin' from 3.4 to 3.3 due to MPLUGIN-296. o Updated to 'maven-site-plugin' 3.7 You can merge this pull request into a Git repository by running: $ git pull https://github.com/slachiewicz/maven fix/MNG-5968 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven/pull/151.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #151 commit 235ed356c43802b6a0e96a982a95efe9313d Author: Sylwester Lachiewicz <slachiewicz@...> Date: 2018-01-07T01:10:35Z [MNG-5968] Default plugin version updates. o Updated default plugin versions to latest release version to bring in the latest fixes (and issues to report). o Updated to correct the 'ear' packaging bindings. o Downgraded the 'maven-plugin-plugin' from 3.4 to 3.3 due to MPLUGIN-296. o Updated to 'maven-site-plugin' 3.7 --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #150: [ MNG-6335] Update Mockito to 2.12.0
GitHub user slachiewicz opened a pull request: https://github.com/apache/maven/pull/150 [ MNG-6335] Update Mockito to 2.12.0 Also change scope to test You can merge this pull request into a Git repository by running: $ git pull https://github.com/slachiewicz/maven feature/mockito Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven/pull/150.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #150 commit 47a88e22df7a08d3e56e3a110f4b473e38787604 Author: Sylwester Lachiewicz <slachiewicz@...> Date: 2018-01-07T00:17:32Z [ MNG-6335]Update Mockito to 2.12.0 Also change scope to test --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #149: Upgrade maven-checkstyle-plugin to 3.0.0 (Checkstyle 6.18)...
Github user slachiewicz commented on the issue: https://github.com/apache/maven/pull/149 Please verify after planned plugin release --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #149: Upgrade maven-checkstyle-plugin to 3.0.0 (Checkstyl...
GitHub user slachiewicz opened a pull request: https://github.com/apache/maven/pull/149 Upgrade maven-checkstyle-plugin to 3.0.0 (Checkstyle 6.18) and fix errors You can merge this pull request into a Git repository by running: $ git pull https://github.com/slachiewicz/maven feature/checkstyle-3.18-maven Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven/pull/149.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #149 commit fad10665e35ad33555c700349bc908aef831eb6d Author: Sylwester Lachiewicz <slachiewicz@...> Date: 2018-01-06T19:32:20Z Upgrade maven-checkstyle-plugin to 3.0.0 with fixing errors commit a3cc6ade355a79a4e7ae68ba14bcc3bf334c3ca3 Author: Sylwester Lachiewicz <slachiewicz@...> Date: 2018-01-06T23:01:15Z Fix more checkstyle errors --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #138: MNG-6306 remove Guava usage from maven-resolver-pro...
GitHub user slachiewicz opened a pull request: https://github.com/apache/maven/pull/138 MNG-6306 remove Guava usage from maven-resolver-provider You can merge this pull request into a Git repository by running: $ git pull https://github.com/slachiewicz/maven feature/MNG-6306 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven/pull/138.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #138 commit d2c7a34af7be5b1ff5c9d0b824bd2b1a4435aea0 Author: Sylwester Lachiewicz <slachiew...@gmail.com> Date: 2017-11-24T19:38:10Z MNG-6306 remove Guava usage from maven-resolver-provider --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #137: [MNG-6069] Migrate to non deprecated parts of Commo...
GitHub user slachiewicz opened a pull request: https://github.com/apache/maven/pull/137 [MNG-6069] Migrate to non deprecated parts of Commons CLI You can merge this pull request into a Git repository by running: $ git pull https://github.com/slachiewicz/maven master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven/pull/137.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #137 commit 8adb76446bad6b060d127532900ce19750f5df76 Author: Robin Müller <coder-h...@users.noreply.github.com> Date: 2017-10-26T07:41:20Z [MNG-6296] Parse properties before configuring the logging settings commit 7850ad9ff67ea681984932a51bc411a871d44a65 Author: Karl Heinz Marbaise <khmarba...@apache.org> Date: 2017-03-18T17:18:27Z [MNG-6069] Migrate to non deprecated parts of Commons CLI commit 7ea398985427df9f8e212fde20649f47fcb2866c Author: Sylwester Lachiewicz <slachiew...@gmail.com> Date: 2017-11-24T02:21:09Z Fix optionProperties parsing --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #118: Upgrade SLF4J to 1.7.25
Github user slachiewicz commented on the issue: https://github.com/apache/maven/pull/118 This one can be closed. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #109: Update Mockito to 2.x
Github user slachiewicz commented on the issue: https://github.com/apache/maven/pull/109 ok, MNG-6196 with slf4j was merged to master - i'm clossing this issue. Mockito will be in diffrent pull. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #109: Update Mockito to 2.x
Github user slachiewicz closed the pull request at: https://github.com/apache/maven/pull/109 --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #109: Updated dependences
GitHub user slachiewicz opened a pull request: https://github.com/apache/maven/pull/109 Updated dependences Mockito 2.7.19 slf4j 1.7.25 logback-classic 1.2.2 You can merge this pull request into a Git repository by running: $ git pull https://github.com/slachiewicz/maven feature/MNG-6196 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven/pull/109.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #109 commit 324ed1c063785a66a8ebbd1e6e54e6031bf4013f Author: Sylwester Lachiewicz <slachiew...@gmail.com> Date: 2017-03-25T16:31:32Z Updated dependences: Mockito 2.7.19 slf4j 1.7.25 logback-classic 1.2.2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
