[GitHub] maven pull request: MNG-5899 Reactor should use reduced dependency...
Github user trask commented on the pull request: https://github.com/apache/maven/pull/69#issuecomment-145723525 @ifedorenko, thanks for reviewing this. Any thoughts what we should do with the downstream implication of this change? https://issues.apache.org/jira/browse/MSHADE-206 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: MNG-5899 Reactor should use reduced dependency...
Github user trask commented on the pull request: https://github.com/apache/maven/pull/69#issuecomment-145730242 The nice thing about how maven-shade-plugin's "dependency reduced pom" used to work, is that you could run mvn compile or mvn test from your parent module (and so maven shade plugin wouldn't kick in since it is bound to package phase), and transitive dependencies would work as normal. And you could run mvn package or mvn install from your parent module, and maven shade plugin would kick in and expose the shaded jar and dependency reduced pom to downstream modules. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: MNG-5899 Reactor should use reduced dependency...
GitHub user trask opened a pull request: https://github.com/apache/maven/pull/69 MNG-5899 Reactor should use reduced dependency pom You can merge this pull request into a Git repository by running: $ git pull https://github.com/trask/maven MNG-5899 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven/pull/69.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #69 commit 1ca0deec41814815d82033645ca00fe6bbfdd813 Author: Trask Stalnaker <trask.stalna...@gmail.com> Date: 2015-10-01T22:09:41Z MNG-5899 Reactor should use reduced dependency pom --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Patch review request for https://jira.codehaus.org/browse/MSHADE-112
Hi, Could someone review the patch attached to this issue and commit or let me know what I can do to make the patch more acceptable? I have found this patch useful for deploying a fully shaded sources artifact which helps a lot when stepping through the shaded artifact in the eclipse debugger. https://jira.codehaus.org/browse/MSHADE-112 Thanks, Trask
Re: Maven shade plugin question
Thanks for reviewing and committing the patch. Could you also deploy a new snapshot build to the apache snapshot repository? Thanks, Trask On Sun, Nov 20, 2011 at 10:12 AM, Trask Stalnaker trask.stalna...@gmail.com wrote: Thanks so much for the response. I look forward to your review of the patch. I'm happy to re-write it taking a different approach if you see fit, so just shoot me your feedback. Thanks again. Trask On Sun, Nov 20, 2011 at 5:00 AM, Benson Margulies bimargul...@gmail.comwrote: Trask, No problem, but in the future feel free to send such a thing to the maven dev list. I'll look at your patch. Honestly, there's no one who is very reliably looking for new patches across many of the plugins, so a ping is a good idea. We generally don't release for only one patch, and we released recently, but if it fixes a howler and it would help you I'll try to also turn the crank. --benson On Sun, Nov 20, 2011 at 4:41 AM, Trask Stalnaker trask.stalna...@gmail.com wrote: Hi Benson, I hope you don't mind me emailing you directly. I noticed that you have made the last few contributions to the maven shade plugin. I have submitted https://jira.codehaus.org/browse/MSHADE-104 a month or two ago. I just updated the jira ticket tonight with a second version of the patch. Is there anything I can do to help this patch get accepted into the maven shade plugin trunk? I'm happy to make any modifications to the patch that you would like to see, and I can provide more docs/examples/tests/explanations/etc if that will help. Thank you for your time. Sincerely, Trask Stalnaker
Re: Maven shade plugin question
Thanks so much for the response. I look forward to your review of the patch. I'm happy to re-write it taking a different approach if you see fit, so just shoot me your feedback. Thanks again. Trask On Sun, Nov 20, 2011 at 5:00 AM, Benson Margulies bimargul...@gmail.comwrote: Trask, No problem, but in the future feel free to send such a thing to the maven dev list. I'll look at your patch. Honestly, there's no one who is very reliably looking for new patches across many of the plugins, so a ping is a good idea. We generally don't release for only one patch, and we released recently, but if it fixes a howler and it would help you I'll try to also turn the crank. --benson On Sun, Nov 20, 2011 at 4:41 AM, Trask Stalnaker trask.stalna...@gmail.com wrote: Hi Benson, I hope you don't mind me emailing you directly. I noticed that you have made the last few contributions to the maven shade plugin. I have submitted https://jira.codehaus.org/browse/MSHADE-104 a month or two ago. I just updated the jira ticket tonight with a second version of the patch. Is there anything I can do to help this patch get accepted into the maven shade plugin trunk? I'm happy to make any modifications to the patch that you would like to see, and I can provide more docs/examples/tests/explanations/etc if that will help. Thank you for your time. Sincerely, Trask Stalnaker
