Re: [2.0.10 RC7] please test
Jason van Zyl wrote: I think this is a regression: http://jira.codehaus.org/browse/MNG-3922 Attached artifacts with classifiers seem to have gotten hosed. Works in 2.0.8. No worky in 2.0.9. I don't get that working with Maven 2.0.8 either, i.e. I don't believe it's a regression, so could be postponed. The important point in this issue is the order of plugin executions. Maybe a change in parent inheritance or profile merging between 2.0.8 and 2.0.9 produced an order that worked for Max, hard to says more without his build logs. While it looks unintentional to me that an executionProject forked by one mojo makes it into the execution of another mojo, it looks even more strange that the Shade Plugin attaches the artifacts to the executionProject when existent, considering that the shade mojo itself does not fork the lifecycle. The code in question was introduced in [0] but I can't imagine a use case where this would be required. So, should we also fill a bug for the Shade Plugin and remove any references to the executionProject? Benjamin [0] http://fisheye.codehaus.org/changelog/mojo/?cs=3821 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [2.0.10 RC7] please test
On 23-Dec-08, at 9:34 AM, Benjamin Bentmann wrote: Jason van Zyl wrote: I think this is a regression: http://jira.codehaus.org/browse/MNG-3922 Attached artifacts with classifiers seem to have gotten hosed. Works in 2.0.8. No worky in 2.0.9. I don't get that working with Maven 2.0.8 either, i.e. I don't believe it's a regression, so could be postponed. The important point in this issue is the order of plugin executions. Maybe a change in parent inheritance or profile merging between 2.0.8 and 2.0.9 produced an order that worked for Max, hard to says more without his build logs. While it looks unintentional to me that an executionProject forked by one mojo makes it into the execution of another mojo, it looks even more strange that the Shade Plugin attaches the artifacts to the executionProject when existent, considering that the shade mojo itself does not fork the lifecycle. The code in question was introduced in [0] but I can't imagine a use case where this would be required. So, should we also fill a bug for the Shade Plugin and remove any references to the executionProject? I don't think most people know the difference here so it was probably an oversight. It should just be attached to the normal project. Benjamin [0] http://fisheye.codehaus.org/changelog/mojo/?cs=3821 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org Thanks, Jason -- Jason van Zyl Founder, Apache Maven jason at sonatype dot com -- A language that doesn’t affect the way you think about programming is not worth knowing. -— Alan Perlis - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [2.0.10 RC7] please test
No regressions found. Cheers Brian E. Fox wrote: (once again with the right url) This fixes the NPE reported in the last RC: http://jira.codehaus.org/browse/MNG-3921 (Thanks Benjamin and Henrique) Here's the list of issues fixed in 2.0.10: http://jira.codehaus.org/secure/ReleaseNote.jspa?version=14112styleName =HtmlprojectId=10500Create=Create And I've staged RC-6 here: http://people.apache.org/~brianf/staging-repository/org/apache/maven/apa che-maven/2.0.10-RC7/ Please try it out and see if we have any remaining regressions over 2.0.9. Thanks, Brian -- Brian Fox Apache Maven PMC http://blogs.sonatype.com/brian/ - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [2.0.10 RC7] please test
I was looking at the regressions set down for 2.1.0-M1 and found this one that also effects 2.0.10: http://jira.codehaus.org/browse/MNG-3769 It's related to relocation, so probably a result of this: http://jira.codehaus.org/browse/MNG-3380 - Brett On 18/12/2008, at 11:44 AM, Brian E. Fox wrote: (once again with the right url) This fixes the NPE reported in the last RC: http://jira.codehaus.org/browse/MNG-3921 (Thanks Benjamin and Henrique) Here's the list of issues fixed in 2.0.10: http://jira.codehaus.org/secure/ReleaseNote.jspa?version=14112styleName =HtmlprojectId=10500Create=Create And I've staged RC-6 here: http://people.apache.org/~brianf/staging-repository/org/apache/maven/apa che-maven/2.0.10-RC7/ Please try it out and see if we have any remaining regressions over 2.0.9. Thanks, Brian -- Brian Fox Apache Maven PMC http://blogs.sonatype.com/brian/ - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org -- Brett Porter br...@apache.org http://blogs.exist.com/bporter/ - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [2.0.10 RC7] please test
On 22/12/2008, at 11:07 PM, Brett Porter wrote: I was looking at the regressions set down for 2.1.0-M1 and found this one that also effects 2.0.10: http://jira.codehaus.org/browse/MNG-3769 It's related to relocation, so probably a result of this: http://jira.codehaus.org/browse/MNG-3380 I've added an IT and confirmed that was the cause, but will have to come back to fixing it later (unless someone else feels inclined to take a look :) - Brett -- Brett Porter br...@apache.org http://blogs.exist.com/bporter/ - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
RE: [2.0.10 RC7] please test
Surprising that no one noticed this, we must be on an edge case somewhere here. Will take a look. -Original Message- From: Jason van Zyl [mailto:jvan...@sonatype.com] Sent: Thursday, December 18, 2008 7:40 PM To: Maven Developers List Subject: Re: [2.0.10 RC7] please test I think this is a regression: http://jira.codehaus.org/browse/MNG-3922 Attached artifacts with classifiers seem to have gotten hosed. Works in 2.0.8. No worky in 2.0.9. On 17-Dec-08, at 7:44 PM, Brian E. Fox wrote: (once again with the right url) This fixes the NPE reported in the last RC: http://jira.codehaus.org/browse/MNG-3921 (Thanks Benjamin and Henrique) Here's the list of issues fixed in 2.0.10: http://jira.codehaus.org/secure/ReleaseNote.jspa?version=14112styleName =HtmlprojectId=10500Create=Create And I've staged RC-6 here: http://people.apache.org/~brianf/staging-repository/org/apache/maven/apa che-maven/2.0.10-RC7/ Please try it out and see if we have any remaining regressions over 2.0.9. Thanks, Brian -- Brian Fox Apache Maven PMC http://blogs.sonatype.com/brian/ - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org Thanks, Jason -- Jason van Zyl Founder, Apache Maven jason at sonatype dot com -- happiness is like a butterfly: the more you chase it, the more it will elude you, but if you turn your attention to other things, it will come and sit softly on your shoulder ... -- Thoreau - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [2.0.10 RC7] please test
I think this is a regression: http://jira.codehaus.org/browse/MNG-3922 Attached artifacts with classifiers seem to have gotten hosed. Works in 2.0.8. No worky in 2.0.9. On 17-Dec-08, at 7:44 PM, Brian E. Fox wrote: (once again with the right url) This fixes the NPE reported in the last RC: http://jira.codehaus.org/browse/MNG-3921 (Thanks Benjamin and Henrique) Here's the list of issues fixed in 2.0.10: http://jira.codehaus.org/secure/ReleaseNote.jspa?version=14112styleName =HtmlprojectId=10500Create=Create And I've staged RC-6 here: http://people.apache.org/~brianf/staging-repository/org/apache/maven/apa che-maven/2.0.10-RC7/ Please try it out and see if we have any remaining regressions over 2.0.9. Thanks, Brian -- Brian Fox Apache Maven PMC http://blogs.sonatype.com/brian/ - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org Thanks, Jason -- Jason van Zyl Founder, Apache Maven jason at sonatype dot com -- happiness is like a butterfly: the more you chase it, the more it will elude you, but if you turn your attention to other things, it will come and sit softly on your shoulder ... -- Thoreau - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[2.0.10 RC7] please test
This fixes the NPE reported in the last RC: http://jira.codehaus.org/browse/MNG-3921 (Thanks Benjamin and Henrique) Here's the list of issues fixed in 2.0.10: http://jira.codehaus.org/secure/ReleaseNote.jspa?version=14112styleName =HtmlprojectId=10500Create=Create And I've staged RC-6 here: http://people.apache.org/~brianf/staging-repository/org/apache/maven/apa che-maven/2.0.10-RC6/ Please try it out and see if we have any remaining regressions over 2.0.9. Thanks, Brian -- Brian Fox Apache Maven PMC http://blogs.sonatype.com/brian/ - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[2.0.10 RC7] please test
(once again with the right url) This fixes the NPE reported in the last RC: http://jira.codehaus.org/browse/MNG-3921 (Thanks Benjamin and Henrique) Here's the list of issues fixed in 2.0.10: http://jira.codehaus.org/secure/ReleaseNote.jspa?version=14112styleName =HtmlprojectId=10500Create=Create And I've staged RC-6 here: http://people.apache.org/~brianf/staging-repository/org/apache/maven/apa che-maven/2.0.10-RC7/ Please try it out and see if we have any remaining regressions over 2.0.9. Thanks, Brian -- Brian Fox Apache Maven PMC http://blogs.sonatype.com/brian/ - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
