[GitHub] [maven-wrapper-plugin] slawekjaranowski commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
slawekjaranowski commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980633392 Of course, `wrapperUrl` in properties is wrong, but release (even staging) should resolve it ``` wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.0.3-SNAPSHOT/maven-wrapper-3.0.3-SNAPSHOT.zip ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-wrapper-plugin] slawekjaranowski commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
slawekjaranowski commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980632912 in `maven-wrapper` ``` mvn clean install -P run-its ``` and in other project ``` mvn org.apache.maven.plugins:maven-wrapper-plugin:3.0.3-SNAPSHOT:wrapper -Dtype=bin -Dmaven=3.6.2 ``` important is `type=bin`, so I have: ``` tree .mvn/ .mvn/ └── wrapper ├── maven-wrapper.jar └── maven-wrapper.properties ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-wrapper-plugin] slawekjaranowski commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
slawekjaranowski commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980598578 @hboutemy great job. I've tested by: - build project - unit and IT test are executed, plugin and artifacts are installed - use in another project with some of released maven version ... looks ok In this point of time I'm not looking deeper in code, simple build and use. I think that push this code to public repo and release this version as is - will be the best approach. It opens a way. to testing by other users as well. Next improvement can be done in small, easy to review changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-wrapper-plugin] slawekjaranowski commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
slawekjaranowski commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-970426760 From wrapper perspective should not be important what `mvn` command is and what happen inside `mvn`. We should assume that `mvn` command from Maven distribution simply work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-wrapper-plugin] slawekjaranowski commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
slawekjaranowski commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-952590460 I think that running `mvn` from Maven distribution will be better ... Some change to maven scripts can be depend on Maven core code like: https://github.com/apache/maven/pull/602 so what will happen when we have newer scripts in wrapper and want to setup older Maven to use ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-wrapper-plugin] slawekjaranowski commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build
slawekjaranowski commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-951775639 Another idea ... why not simply call `mvn*` scripts from Maven distribution ... of course after needed job for wrapper like downloading In this case code will be in one place -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
