slawekjaranowski edited a comment on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-980598578
@hboutemy great job. I've tested by: - build project - unit and IT test are executed, plugin and artifacts are installed - use in another project with some of released maven version ... looks ok In this point of time I'm not looking deeper in code, simple build and use. I think that push this code to public repo and release this version as is - will be the best approach. It opens a way to testing by other users as well. Next improvement can be done in small, easy to review changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
