[GitHub] maven-integration-testing pull request #21: [MNG-6127] Add plugin execution ...
Github user mkrizmanic closed the pull request at: https://github.com/apache/maven-integration-testing/pull/21 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-integration-testing pull request #21: [MNG-6127] Add plugin execution ...
Github user michael-o commented on a diff in the pull request: https://github.com/apache/maven-integration-testing/pull/21#discussion_r115065672 --- Diff: core-it-suite/src/test/resources/mng-6127/plugin/pom.xml --- @@ -0,0 +1,55 @@ + + + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + + mng-6127 + mng-6127-plugin + 0.1 + maven-plugin + + +3.3.1 --- End diff -- Alright, my bad. Thanks for the clarification. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-integration-testing pull request #21: [MNG-6127] Add plugin execution ...
Github user mkrizmanic commented on a diff in the pull request: https://github.com/apache/maven-integration-testing/pull/21#discussion_r115063523 --- Diff: core-it-suite/src/test/resources/mng-6127/plugin/pom.xml --- @@ -0,0 +1,55 @@ + + + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + + mng-6127 + mng-6127-plugin + 0.1 + maven-plugin + + +3.3.1 --- End diff -- Hi, it should be defined here because we do not have a parent pom which contains the next artifact versions. The same pattern is used in other ITs. For instance: https://github.com/apache/maven-integration-testing/blob/master/core-it-suite/src/test/resources/mng-5578-session-scope/plugin/pom.xml --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-integration-testing pull request #21: [MNG-6127] Add plugin execution ...
Github user michael-o commented on a diff in the pull request: https://github.com/apache/maven-integration-testing/pull/21#discussion_r115049986 --- Diff: core-it-suite/src/test/resources/mng-6127/plugin/pom.xml --- @@ -0,0 +1,55 @@ + + + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + + mng-6127 + mng-6127-plugin + 0.1 + maven-plugin + + +3.3.1 --- End diff -- This should rather be `maven.version` as we always do in POMs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-integration-testing pull request #21: [MNG-6127] Add plugin execution ...
GitHub user mkrizmanic opened a pull request: https://github.com/apache/maven-integration-testing/pull/21 [MNG-6127] Add plugin execution configuration interference test You can merge this pull request into a Git repository by running: $ git pull https://github.com/mkrizmanic/maven-integration-testing MNG-6127 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven-integration-testing/pull/21.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #21 commit 33b3681c7ed55481cdfd0f7c8ec61781f979babd Author: Mario Krizmanic Date: 2016-11-23T21:25:34Z [MNG-6127] Add plugin execution configuration interference test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
