[GitHub] maven issue #127: [MNG-6255] Fix concat_lines in mvn to deal with CRLF

[grkvlt]

Github user grkvlt commented on the issue:

https://github.com/apache/maven/pull/127
  
ping?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven issue #127: [MNG-6255] Fix concat_lines in mvn to deal with CRLF

[grkvlt]

Github user grkvlt commented on the issue:

https://github.com/apache/maven/pull/127
  
@Tunaki I will disable the *CR* test, then


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven issue #127: [MNG-6255] Fix concat_lines in mvn to deal with CRLF

[Tunaki]

Github user Tunaki commented on the issue:

https://github.com/apache/maven/pull/127
  
Looks like we have a similar bug in `mvn.cmd`. The added 
`testJvmConfigFileCR` test fails on Windows:

```
testJvmConfigFileCR(org.apache.maven.it.MavenITmng6255FixConcatLines)  Time 
elapsed: 1.983 sec  <<< FAILURE!
junit.framework.ComparisonFailure: null expected: but 
was:
  at junit.framework.Assert.assertEquals(Assert.java:81)
  at junit.framework.Assert.assertEquals(Assert.java:87)
  at 
org.apache.maven.it.MavenITmng6255FixConcatLines.runWithLineEndings(MavenITmng6255FixConcatLines.java:89)
  at 
org.apache.maven.it.MavenITmng6255FixConcatLines.testJvmConfigFileCR(MavenITmng6255FixConcatLines.java:50)
```

Looks like the carriage returns at the end of the line were stripped and 
everything was put on a single line.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven issue #127: [MNG-6255] Fix concat_lines in mvn to deal with CRLF

[Tunaki]

Github user Tunaki commented on the issue:

https://github.com/apache/maven/pull/127
  
This looks OK, verified with `bash` and `dash` (on Ubuntu 16.04), `tcsh` 
and `sh` (on FreeBSD 11.0). Could you add an integration test for this 
(https://github.com/apache/maven-integration-testing)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org