[GitHub] maven pull request: [MNG-5947] dependencyManagement import section...

[akacme]

Github user akacme commented on the pull request:

https://github.com/apache/maven/pull/74#issuecomment-168756278
  
I've added POM-property-based configuration. Based on my current skill 
level embedding configuration somewhere else would require change in 
dependencies section for maven-model-builder, which I'm afraid to do (let alone 
creating a separate project). I'll implement more elegant solution if you point 
me in the right direction.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-5947] dependencyManagement import section...

[jvanzyl]

Github user jvanzyl commented on the pull request:

https://github.com/apache/maven/pull/74#issuecomment-168565897
  
POM property, CLI property override, or we might want to start collecting 
these provisional changes in a special maven plugin configuration section for 
activating proposed features in Maven 4.x that 3.x users can try at their 
convenience. There are quite a few things stacking up so I think a plugin 
configuration can act as a feature toggle of sorts so that we don't affect 
existing users but easily allow the adventurous to try things out.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-5947] dependencyManagement import section...

[akacme]

Github user akacme commented on the pull request:

https://github.com/apache/maven/pull/74#issuecomment-168543843
  
Perhaps a POM property with predefined name could activate this behaviour 
in 3.x? In this way it can be set on a per-project basis as well as global 
(with properties injected via settings.xml).

In case when a change of DependencyManagement model is allowed (4.x?) - 
this might be better approach in the long run as this info can be reused in the 
maven dependency plugin (to show where managed version comes from) and perhaps 
will allow to introduce pluggable dependency resolution strategy 
(nearest-match, newest-version, etc.) in both dependency and 
dependencyManagement sections.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-5947] dependencyManagement import section...

[akacme]

Github user akacme commented on the pull request:

https://github.com/apache/maven/pull/74#issuecomment-168519406
  
I've introduced DependencyManagementGraph object to store and compute 
"distance" for dependencyManagement section - so there is no change to the 
model itself. Signature of DependencyManagementImporter.importManagement is 
changed to pass this graph as argument.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-5947] dependencyManagement import section...

[jvanzyl]

Github user jvanzyl commented on the pull request:

https://github.com/apache/maven/pull/74#issuecomment-168534190
  
General rule of thumb is that a change in resolution will definitely not go 
in if it changes the default behaviour within a minor version. First smoke test 
is making sure the ITs pass, second smoke test is that I run it against 40-50 
projects I use as a sampling. So at least make sure the core integration tests 
pass. If it does change resolution within a minor version then it needs to be 
activated consciously on the users part. If this is deemed an improvement it 
can become something activated by default in 4.x possibly.

For better or worse the way Maven resolves dependencies currently is how it 
works for everyone. Making changes to this and possibly selecting different 
versions of dependencies based on different rules can potentially break a lot 
of people.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-5947] dependencyManagement import section...

[akacme]

Github user akacme commented on the pull request:

https://github.com/apache/maven/pull/74#issuecomment-168403276
  
Code has been compiled using Java 7. Model has been enhanced to store graph 
of imports in dependency management section - I can rewrite it to store it 
elsewhere, but such solution is not elegant and requires more changes to API.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-5947] dependencyManagement import section...

[michael-o]

Github user michael-o commented on the pull request:

https://github.com/apache/maven/pull/74#issuecomment-168402507
  
You are using Java 8 features which we can't accept. Java 7 only. The model 
is changed. I would opt-in for that not before Maven 4.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-5947] dependencyManagement import section...

[michael-o]

Github user michael-o commented on the pull request:

https://github.com/apache/maven/pull/74#issuecomment-168405448
  
Now I see, the `Optional´ comes from Guava and not from Java. I think the 
likelyhood is higher w/o a model change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-5947] dependencyManagement import section...

[akacme]

Github user akacme commented on the pull request:

https://github.com/apache/maven/pull/74#issuecomment-168404937
  
In other words - will it go to Maven 3.x when there is no modification to 
the model itself?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-5947] dependencyManagement import section...

[akacme]

GitHub user akacme opened a pull request:

https://github.com/apache/maven/pull/73

[MNG-5947] dependencyManagement import section does not resolve 
dependencies using "nearest" definition

dependencies using "nearest" definition

o DepenencyManagement model updated to contain declared dependencies 
  and imported dependency managements
o DefaultModelBuilder responsible for filling updated
  DependencyManagement model
o DefaultDepenendcyManagementImporter uses graph of dependencyManagement
  imports to properly find depth of a dependency in a tree and use
  "nearest" version (instead of first match)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/akacme/maven MNG-5947

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven/pull/73.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #73


commit 71c7195e130c73d9e67fd5d55b4f963499951781
Author: Michal Kowalcze 
Date:   2015-12-14T07:19:33Z

[MNG-5947] dependencyManagement import section does not resolve
dependencies using "nearest" definition

o DepenencyManagement model updated to contain declared dependencies 
  and imported dependency managements
o DefaultModelBuilder responsible for filling updated
  DependencyManagement model
o DefaultDepenendcyManagementImporter uses graph of dependencyManagement
  imports to properly find depth of a dependency in a tree and use
  "nearest" version (instead of first match)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-5947] dependencyManagement import section...

[akacme]

Github user akacme closed the pull request at:

https://github.com/apache/maven/pull/73


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-5947] dependencyManagement import section...

[akacme]

GitHub user akacme opened a pull request:

https://github.com/apache/maven/pull/74

[MNG-5947] dependencyManagement import section does not resolve 
dependencies using "nearest" definition

o DepenencyManagement model updated to contain declared dependencies
  and imported dependency managements
o DefaultModelBuilder responsible for filling updated
  DependencyManagement model
o DefaultDepenendcyManagementImporter uses graph of dependencyManagement
  imports to properly find depth of a dependency in a tree and use
  "nearest" version (instead of first match)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/akacme/maven MNG-5947-fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven/pull/74.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #74


commit 43e905229c9a046d4e601f697a71d616c35f0a6c
Author: Michal Kowalcze 
Date:   2015-12-14T07:19:33Z

[MNG-5947] dependencyManagement import section does not resolve
dependencies using "nearest" definition

o DepenencyManagement model updated to contain declared dependencies
  and imported dependency managements
o DefaultModelBuilder responsible for filling updated
  DependencyManagement model
o DefaultDepenendcyManagementImporter uses graph of dependencyManagement
  imports to properly find depth of a dependency in a tree and use
  "nearest" version (instead of first match)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org