[jira] Commented: (MSUREFIRE-69) stop output to test-output directory

2006-03-05 Thread Jesse Kuhnert (JIRA)
[ http://jira.codehaus.org/browse/MSUREFIRE-69?page=comments#action_60176 ] 

Jesse Kuhnert commented on MSUREFIRE-69:


Awesome, thanks Brett! I don't use a sun jvm so don't have the javadoc libs 
available via normal means. (ibm's jre runs much much faster on linux than sun) 

It looks like it runs though so I've added it to cvs . 

> stop output to test-output directory
> 
>
>  Key: MSUREFIRE-69
>  URL: http://jira.codehaus.org/browse/MSUREFIRE-69
>  Project: Maven 2.x Surefire Plugin
> Type: Sub-task

> Reporter: Brett Porter
>  Fix For: 2.2
>  Attachments: pom.xml, surefire-patch.txt, surefire-patch.txt
>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Commented: (MSUREFIRE-69) stop output to test-output directory

2006-03-05 Thread Jesse Kuhnert (JIRA)
[ http://jira.codehaus.org/browse/MSUREFIRE-69?page=comments#action_60167 ] 

Jesse Kuhnert commented on MSUREFIRE-69:


I think it will ~probably~ be possible to build it with m2? There have to be 
other projects with seperate source trees for differing jre versions. I don't 
know how they handle it but any amount of research I've done so far hasn't made 
it seem very easy. 

> stop output to test-output directory
> 
>
>  Key: MSUREFIRE-69
>  URL: http://jira.codehaus.org/browse/MSUREFIRE-69
>  Project: Maven 2.x Surefire Plugin
> Type: Sub-task

> Reporter: Brett Porter
>  Fix For: 2.2
>  Attachments: surefire-patch.txt, surefire-patch.txt
>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Commented: (MSUREFIRE-69) stop output to test-output directory

2006-03-05 Thread Brett Porter (JIRA)
[ http://jira.codehaus.org/browse/MSUREFIRE-69?page=comments#action_60166 ] 

Brett Porter commented on MSUREFIRE-69:
---

don't worry about uploads. I'll create snapshots from the cvs repository.

I haven't tried building testNG with m2, but I don't think it would be too 
hard. I'll try it.


> stop output to test-output directory
> 
>
>  Key: MSUREFIRE-69
>  URL: http://jira.codehaus.org/browse/MSUREFIRE-69
>  Project: Maven 2.x Surefire Plugin
> Type: Sub-task

> Reporter: Brett Porter
>  Fix For: 2.2
>  Attachments: surefire-patch.txt, surefire-patch.txt
>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Commented: (MSUREFIRE-69) stop output to test-output directory

2006-03-05 Thread Jesse Kuhnert (JIRA)
[ http://jira.codehaus.org/browse/MSUREFIRE-69?page=comments#action_60152 ] 

Jesse Kuhnert commented on MSUREFIRE-69:


Got it now. Didn't realize TestNG was instantiated in two different places. 

The patch supplied only works against the latest testng, which currently only 
lives in testng cvs head . (4.7) 

No output files/directories are created now. 

Still need to look at other jira issues created, create a new ibiblio upload. 
(Is it really even possible to create a pom capable of building testng 
properly? I'm starting to think it isn't. I had to manually copy over my testng 
jars to get them installed correctly because the classsifier parm was being 
ignored)

> stop output to test-output directory
> 
>
>  Key: MSUREFIRE-69
>  URL: http://jira.codehaus.org/browse/MSUREFIRE-69
>  Project: Maven 2.x Surefire Plugin
> Type: Sub-task

> Reporter: Brett Porter
>  Fix For: 2.2
>  Attachments: surefire-patch.txt, surefire-patch.txt
>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Commented: (MSUREFIRE-69) stop output to test-output directory

2006-03-05 Thread Brett Porter (JIRA)
[ http://jira.codehaus.org/browse/MSUREFIRE-69?page=comments#action_60121 ] 

Brett Porter commented on MSUREFIRE-69:
---

it should only require:

cd surefire-testng
vi pom.xml
mvn install

mvn -X might help.

I don't know how you go about getting testng into your repository though. Are 
you sure you have the right version of that?

> stop output to test-output directory
> 
>
>  Key: MSUREFIRE-69
>  URL: http://jira.codehaus.org/browse/MSUREFIRE-69
>  Project: Maven 2.x Surefire Plugin
> Type: Sub-task

> Reporter: Brett Porter
>  Fix For: 2.2
>  Attachments: surefire-patch.txt
>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Commented: (MSUREFIRE-69) stop output to test-output directory

2006-03-05 Thread Jesse Kuhnert (JIRA)
[ http://jira.codehaus.org/browse/MSUREFIRE-69?page=comments#action_60116 ] 

Jesse Kuhnert commented on MSUREFIRE-69:


No I think you're right, I just think it's something I'm not completely in 
control of. TestNG tries very hard to provide defaults that do have outputs. 
The new constructor seemed to be the only option without wildly changing other 
things internal to testng. 

I've made it so that setUseDefaultReports ( false ) works for the most part, 
but am not completely sure that html output won't still be generated with this 
alone. Perhaps me figuring out how to make my local repo use my surefire code 
changes will solve my dilemna. 

I wasn't having any problems getting the surefire stuff to use the new testng 
code, it was problems getting the new surefire code to be used by testing in 
general. 

> stop output to test-output directory
> 
>
>  Key: MSUREFIRE-69
>  URL: http://jira.codehaus.org/browse/MSUREFIRE-69
>  Project: Maven 2.x Surefire Plugin
> Type: Sub-task

> Reporter: Brett Porter
>  Fix For: 2.2
>  Attachments: surefire-patch.txt
>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Commented: (MSUREFIRE-69) stop output to test-output directory

2006-03-05 Thread Brett Porter (JIRA)
[ http://jira.codehaus.org/browse/MSUREFIRE-69?page=comments#action_60115 ] 

Brett Porter commented on MSUREFIRE-69:
---

I was just saying that

new TestNG ( false )

is not a particularly help piece of code to read when used.

new TestNG()
testNG.setUseDefaultReports( false )

is much clearer. But, I'm not one to dictate your API, so I'll use what I can.

You'll need to change the dependency in the surefire-testng module. That is the 
piece of code that calls TestNG.


> stop output to test-output directory
> 
>
>  Key: MSUREFIRE-69
>  URL: http://jira.codehaus.org/browse/MSUREFIRE-69
>  Project: Maven 2.x Surefire Plugin
> Type: Sub-task

> Reporter: Brett Porter
>  Fix For: 2.2
>  Attachments: surefire-patch.txt
>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Commented: (MSUREFIRE-69) stop output to test-output directory

2006-03-05 Thread Jesse Kuhnert (JIRA)
[ http://jira.codehaus.org/browse/MSUREFIRE-69?page=comments#action_60113 ] 

Jesse Kuhnert commented on MSUREFIRE-69:


Hi Brett,

The use of that method is decieving in it's current form. The default no args 
constructor creates a default listener for html reporting output. After that, 
setting the defaultListeners boolean flag is problematic because you have no 
idea what in the local list are defaults and what are things people have added. 

I would like to take out the setter altogether but haven't as I'm not sure if 
it's used  by others. The new constructor with a boolean arg should fix our 
problems. 

I also re-factored the suiterunner to not add a bunch of others by default (ie 
the xml/txt outputs, which are our biggest problem). So, this should be fixed 
by using testng from the latest cvs head. 

I've tried testing it locally but for some reason doing a mvn install of 
surefire isn't causing my local repo jars to be used. It could be that the 
surefire plugin is explicitly using a particular version of surefire that takes 
precedence over my local build? 



> stop output to test-output directory
> 
>
>  Key: MSUREFIRE-69
>  URL: http://jira.codehaus.org/browse/MSUREFIRE-69
>  Project: Maven 2.x Surefire Plugin
> Type: Sub-task

> Reporter: Brett Porter
>  Fix For: 2.2
>  Attachments: surefire-patch.txt
>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Commented: (MSUREFIRE-69) stop output to test-output directory

2006-03-04 Thread Brett Porter (JIRA)
[ http://jira.codehaus.org/browse/MSUREFIRE-69?page=comments#action_60088 ] 

Brett Porter commented on MSUREFIRE-69:
---

Jesse,

This doesn't seem like the best way to fix this from the TestNG perspective. 
Shouldn't it be more explicit?

I assume this is what you added before with setReportResults( false ) but it 
disappeared. I noticed there is a call to disable the default listeners, but 
that doesn't help with this. Unless I'm misunderstanding it's intent, that 
would be a better way.

> stop output to test-output directory
> 
>
>  Key: MSUREFIRE-69
>  URL: http://jira.codehaus.org/browse/MSUREFIRE-69
>  Project: Maven 2.x Surefire Plugin
> Type: Sub-task

> Reporter: Brett Porter
>  Fix For: 2.2
>  Attachments: surefire-patch.txt
>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Commented: (MSUREFIRE-69) stop output to test-output directory

2006-03-04 Thread Jesse Kuhnert (JIRA)
[ http://jira.codehaus.org/browse/MSUREFIRE-69?page=comments#action_60064 ] 

Jesse Kuhnert commented on MSUREFIRE-69:


I meant fixed in testng itself, it probably got re-enabled somehow. Will report 
back when testng get's fixed and if any patches need to be made in surefire to 
call new methods. 

> stop output to test-output directory
> 
>
>  Key: MSUREFIRE-69
>  URL: http://jira.codehaus.org/browse/MSUREFIRE-69
>  Project: Maven 2.x Surefire Plugin
> Type: Sub-task

> Reporter: Brett Porter
>  Fix For: 2.2

>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Commented: (MSUREFIRE-69) stop output to test-output directory

2006-03-04 Thread Brett Porter (JIRA)
[ http://jira.codehaus.org/browse/MSUREFIRE-69?page=comments#action_60060 ] 

Brett Porter commented on MSUREFIRE-69:
---

this was by setting the output directory - but that was to 
target/surefire-reports which isn't wanted.

ideally, the listeners would be turned off, but I couldn't get that to work.

> stop output to test-output directory
> 
>
>  Key: MSUREFIRE-69
>  URL: http://jira.codehaus.org/browse/MSUREFIRE-69
>  Project: Maven 2.x Surefire Plugin
> Type: Sub-task

> Reporter: Brett Porter
>  Fix For: 2.2

>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Commented: (MSUREFIRE-69) stop output to test-output directory

2006-03-04 Thread Jesse Kuhnert (JIRA)
[ http://jira.codehaus.org/browse/MSUREFIRE-69?page=comments#action_60059 ] 

Jesse Kuhnert commented on MSUREFIRE-69:


I had originally removed this when developing the first round of patches but it 
seems to have re-surfaced again. Will do it again and sync up to make sure it 
doesn't re-appear. 

> stop output to test-output directory
> 
>
>  Key: MSUREFIRE-69
>  URL: http://jira.codehaus.org/browse/MSUREFIRE-69
>  Project: Maven 2.x Surefire Plugin
> Type: Sub-task

> Reporter: Brett Porter
>  Fix For: 2.2

>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]