Re: MNG-6069 2nd - seconders
My concern is that somebody sees a deprecated GnuParser and will replace it
without knowing why we left it here, hence I've added a simple unittest that
should reflect the usecase and which fails once replacing GnuParser with
DefaultParser.
So now it is +1 for me
On 16-5-2019 23:40:06, Sylwester Lachiewicz wrote:
Hi Robert,
I tested this change locally and yes it works fine with additional space
after -D
Here is note in Jira:
For now, leave GnuParser. Despite the upgrade advice in the GnuParser Javadoc
> ("since 1.3, use the DefaultParser instead"), it behaves differently (see this
> Stack Overflow answer
> for
> possible reasons).
BR
Sylwester
śr., 15 maj 2019 o 21:17 Robert Scholte napisał(a):
> There's an important line in the description:
> "Ensure that the following command succeeds: mvn -X -D x=1 -D y=2 test (
> watch out for the space after -D )"
>
> Maybe I'm not looking good enough, but I don't see any related
> codechanges
> for this.
>
> thanks,
> Robert
>
> On Wed, 15 May 2019 21:10:43 +0200, Sylwester Lachiewicz
> wrote:
>
> > kindly reminder, anyone to look and confirm on ML?
> >
> > W dniu niedz., 12.05.2019 o 23:08 Sylwester Lachiewicz
> > slachiew...@gmail.com> napisał(a):
> >
> >> Hi,
> >> We have fix for MNG-6069 Migrate to non deprecated parts of Commons
> CLI
> >> -
> >> 2nd attempt
> >> https://issues.apache.org/jira/browse/MNG-6069
> >> PR: https://github.com/apache/maven/pull/247
> >> commit:
> >>
> https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=b01f861729214e45a1f3754ed5456bcdc1c3b4fc
> >> CI build:
> >>
> https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/MNG-6069v2/
> >>
> >> Seconders, please?
> >>
> >> Regards,
> >> Sylwester
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>
Re: MNG-6069 2nd - seconders
Hi Robert,
I tested this change locally and yes it works fine with additional space
after -D
Here is note in Jira:
For now, leave GnuParser. Despite the upgrade advice in the GnuParser Javadoc
> ("since 1.3, use the DefaultParser instead"), it behaves differently (see this
> Stack Overflow answer
>
> for
> possible reasons).
BR
Sylwester
śr., 15 maj 2019 o 21:17 Robert Scholte napisał(a):
> There's an important line in the description:
> "Ensure that the following command succeeds: mvn -X -D x=1 -D y=2 test (
> watch out for the space after -D )"
>
> Maybe I'm not looking good enough, but I don't see any related
> codechanges
> for this.
>
> thanks,
> Robert
>
> On Wed, 15 May 2019 21:10:43 +0200, Sylwester Lachiewicz
> wrote:
>
> > kindly reminder, anyone to look and confirm on ML?
> >
> > W dniu niedz., 12.05.2019 o 23:08 Sylwester Lachiewicz <
> > slachiew...@gmail.com> napisał(a):
> >
> >> Hi,
> >> We have fix for MNG-6069 Migrate to non deprecated parts of Commons
> CLI
> >> -
> >> 2nd attempt
> >> https://issues.apache.org/jira/browse/MNG-6069
> >> PR: https://github.com/apache/maven/pull/247
> >> commit:
> >>
> https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=b01f861729214e45a1f3754ed5456bcdc1c3b4fc
> >> CI build:
> >>
> https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/MNG-6069v2/
> >>
> >> Seconders, please?
> >>
> >> Regards,
> >> Sylwester
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>
Re: MNG-6069 2nd - seconders
There's an important line in the description: "Ensure that the following command succeeds: mvn -X -D x=1 -D y=2 test ( watch out for the space after -D )" Maybe I'm not looking good enough, but I don't see any related codechanges for this. thanks, Robert On Wed, 15 May 2019 21:10:43 +0200, Sylwester Lachiewicz wrote: kindly reminder, anyone to look and confirm on ML? W dniu niedz., 12.05.2019 o 23:08 Sylwester Lachiewicz < slachiew...@gmail.com> napisał(a): Hi, We have fix for MNG-6069 Migrate to non deprecated parts of Commons CLI - 2nd attempt https://issues.apache.org/jira/browse/MNG-6069 PR: https://github.com/apache/maven/pull/247 commit: https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=b01f861729214e45a1f3754ed5456bcdc1c3b4fc CI build: https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/MNG-6069v2/ Seconders, please? Regards, Sylwester - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: MNG-6069 2nd - seconders
kindly reminder, anyone to look and confirm on ML? W dniu niedz., 12.05.2019 o 23:08 Sylwester Lachiewicz < slachiew...@gmail.com> napisał(a): > Hi, > We have fix for MNG-6069 Migrate to non deprecated parts of Commons CLI - > 2nd attempt > https://issues.apache.org/jira/browse/MNG-6069 > PR: https://github.com/apache/maven/pull/247 > commit: > https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=b01f861729214e45a1f3754ed5456bcdc1c3b4fc > CI build: > https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/MNG-6069v2/ > > Seconders, please? > > Regards, > Sylwester >
MNG-6069 2nd - seconders
Hi, We have fix for MNG-6069 Migrate to non deprecated parts of Commons CLI - 2nd attempt https://issues.apache.org/jira/browse/MNG-6069 PR: https://github.com/apache/maven/pull/247 commit: https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=b01f861729214e45a1f3754ed5456bcdc1c3b4fc CI build: https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/MNG-6069v2/ Seconders, please? Regards, Sylwester
