Re: [maven-shade-plugin] TLC [WAS Re: [maven-assembly-plugin] smart(er) dependency merge]
On Thu, Jun 30, 2011 at 1:11 PM, Benson Margulies bimargul...@gmail.com wrote: I'll play patch monkey. Name those JIRA. :-) [1] patches the documentation to add descriptions for the resource descriptors which worked well for me. Moving on to prepare test cases and fixes for issues discovered. Robert [1] http://jira.codehaus.org/browse/MSHADE-100 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [maven-shade-plugin] TLC [WAS Re: [maven-assembly-plugin] smart(er) dependency merge]
The JIRA count is not a reliable indication of anything. Lots of us use shade in production. The JIRA count can indicate a plethora of improvement suggestions, or a bunch of uninvestigated complaints. Don't get me wrong, please do dig in. But you are likely to find that it works for you as is. On Thu, Jun 30, 2011 at 6:30 AM, Robert Burrell Donkin robertburrelldon...@gmail.com wrote: On Thu, Jun 30, 2011 at 8:52 AM, David Jencks david_jen...@yahoo.com wrote: I think the shade plugin does something like this. Thanks I've taken a look and this seems the right place to start but I'll probably need to do some development... There are 21 open issues [1] and (by my count) 8 patches (which are probably missing test cases). Perhaps this indicates that some TLC is needed. I'm happy to work with folks who have karma if they have the energy to review. I'm happy to fork over at GitHub and then present a sizable pull request at the end. But I'm open to other suggestions too. Opinions on my best option? Robert [1] http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=truejqlQuery=project+%3D+MSHADE+AND+status+%3D+Open+ORDER+BY+priority+DESCmode=hide - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [maven-shade-plugin] TLC [WAS Re: [maven-assembly-plugin] smart(er) dependency merge]
On Thu, Jun 30, 2011 at 11:30 AM, Robert Burrell Donkin robertburrelldon...@gmail.com wrote: On Thu, Jun 30, 2011 at 8:52 AM, David Jencks david_jen...@yahoo.com wrote: I think the shade plugin does something like this. Thanks I've taken a look and this seems the right place to start but I'll probably need to do some development... There are 21 open issues [1] and (by my count) 8 patches (which are probably missing test cases). Perhaps this indicates that some TLC is needed. I'm happy to work with folks who have karma if they have the energy to review. I'm happy to fork over at GitHub and then present a sizable pull request at the end. But I'm open to other suggestions too. Opinions on my best option? Robert If you can mange to get some patches applied and a release of the shade plugin done that would be fantastic. MSHADE-88 for me and I've another fix to different scoped dependencies which i can submit if theres a chance someone might apply it now. ...ant - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [maven-shade-plugin] TLC [WAS Re: [maven-assembly-plugin] smart(er) dependency merge]
On Thu, Jun 30, 2011 at 11:41 AM, Benson Margulies bimargul...@gmail.com wrote: The JIRA count is not a reliable indication of anything. Lots of us use shade in production. The JIRA count can indicate a plethora of improvement suggestions, or a bunch of uninvestigated complaints. Don't get me wrong, please do dig in. But you are likely to find that it works for you as is. I'm looking for smart merger of NOTICEs and LICENSEs. How is this currently implemented? Robert - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [maven-shade-plugin] TLC [WAS Re: [maven-assembly-plugin] smart(er) dependency merge]
On Thu, Jun 30, 2011 at 11:41 AM, Benson Margulies bimargul...@gmail.com wrote: The JIRA count is not a reliable indication of anything. Lots of us use shade in production. The JIRA count can indicate a plethora of improvement suggestions, or a bunch of uninvestigated complaints. True. That's why I spent a few moments reading them. I'm sure that it does everything that people with Maven karma want it to do. The open question is whether it works well for the rest of the community. Robert - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [maven-shade-plugin] TLC [WAS Re: [maven-assembly-plugin] smart(er) dependency merge]
On Thu, Jun 30, 2011 at 11:47 AM, ant elder ant.el...@gmail.com wrote: snip If you can mange to get some patches applied and a release of the shade plugin done that would be fantastic. MSHADE-88 for me and I've another fix to different scoped dependencies which i can submit if theres a chance someone might apply it now. I'm happy to work with someone with Maven karma to review and improve the patches submitted (for example by add missing test cases) but if that's not possible then I'd be happy to fork and maintain an improved version over at GitHub (say). Be good to hear from you in either case :-) Robert - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [maven-shade-plugin] TLC [WAS Re: [maven-assembly-plugin] smart(er) dependency merge]
Apart from the fact that I start my summer vacation in 2 days I'm sure I can assist you in getting patches in. I like TLC ;) I'll add shade to my stream, but don't expect much for the next 4 weeks - europeans have vacation ;) I don't even consider patches without testcases. Kristian Den 30.06.2011 13:51, skrev Robert Burrell Donkin: On Thu, Jun 30, 2011 at 11:47 AM, ant elderant.el...@gmail.com wrote: snip If you can mange to get some patches applied and a release of the shade plugin done that would be fantastic. MSHADE-88 for me and I've another fix to different scoped dependencies which i can submit if theres a chance someone might apply it now. I'm happy to work with someone with Maven karma to review and improve the patches submitted (for example by add missing test cases) but if that's not possible then I'd be happy to fork and maintain an improved version over at GitHub (say). Be good to hear from you in either case :-) Robert - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [maven-shade-plugin] TLC [WAS Re: [maven-assembly-plugin] smart(er) dependency merge]
I'll play patch monkey. Name those JIRA. On Thu, Jun 30, 2011 at 8:00 AM, Kristian Rosenvold kristian.rosenv...@gmail.com wrote: Apart from the fact that I start my summer vacation in 2 days I'm sure I can assist you in getting patches in. I like TLC ;) I'll add shade to my stream, but don't expect much for the next 4 weeks - europeans have vacation ;) I don't even consider patches without testcases. Kristian Den 30.06.2011 13:51, skrev Robert Burrell Donkin: On Thu, Jun 30, 2011 at 11:47 AM, ant elderant.el...@gmail.com wrote: snip If you can mange to get some patches applied and a release of the shade plugin done that would be fantastic. MSHADE-88 for me and I've another fix to different scoped dependencies which i can submit if theres a chance someone might apply it now. I'm happy to work with someone with Maven karma to review and improve the patches submitted (for example by add missing test cases) but if that's not possible then I'd be happy to fork and maintain an improved version over at GitHub (say). Be good to hear from you in either case :-) Robert - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [maven-shade-plugin] TLC [WAS Re: [maven-assembly-plugin] smart(er) dependency merge]
On Thu, Jun 30, 2011 at 1:11 PM, Benson Margulies bimargul...@gmail.com wrote: I'll play patch monkey. Name those JIRA. :-) I've submitted a documentation patch [1] to let users know it exists. I'm out of typing time now but I'll step up with some more later today. Robert [1] http://jira.codehaus.org/browse/MASSEMBLY-562 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
RE: [maven-shade-plugin] TLC [WAS Re: [maven-assembly-plugin] smart(er) dependency merge]
Vacation is only for people with superfluous time and excess discretionary income (the only exception is wendy who must deal with a fire the size of north dakota not too far from campus) During your vacation we will be expecting the SAME amount of work and the SAME frequency of contact so...bring a blackberry (and a battery charger) Martin __ See you on the beach - Saving Private Ryan Date: Thu, 30 Jun 2011 08:11:49 -0400 Subject: Re: [maven-shade-plugin] TLC [WAS Re: [maven-assembly-plugin] smart(er) dependency merge] From: bimargul...@gmail.com To: dev@maven.apache.org I'll play patch monkey. Name those JIRA. On Thu, Jun 30, 2011 at 8:00 AM, Kristian Rosenvold kristian.rosenv...@gmail.com wrote: Apart from the fact that I start my summer vacation in 2 days I'm sure I can assist you in getting patches in. I like TLC ;) I'll add shade to my stream, but don't expect much for the next 4 weeks - europeans have vacation ;) I don't even consider patches without testcases. Kristian Den 30.06.2011 13:51, skrev Robert Burrell Donkin: On Thu, Jun 30, 2011 at 11:47 AM, ant elderant.el...@gmail.com wrote: snip If you can mange to get some patches applied and a release of the shade plugin done that would be fantastic. MSHADE-88 for me and I've another fix to different scoped dependencies which i can submit if theres a chance someone might apply it now. I'm happy to work with someone with Maven karma to review and improve the patches submitted (for example by add missing test cases) but if that's not possible then I'd be happy to fork and maintain an improved version over at GitHub (say). Be good to hear from you in either case :-) Robert - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [maven-shade-plugin] TLC [WAS Re: [maven-assembly-plugin] smart(er) dependency merge]
Martin, Are you saying I'm rich and idle ?? Cool. I will bring my laptop + 3g, might squeeze in a commit or two over a glass of champagne while contemplating the mediterranian sea. Kristian Den 30.06.2011 14:32, skrev Martin Gainty: Vacation is only for people with superfluous time and excess discretionary income (the only exception is wendy who must deal with a fire the size of north dakota not too far from campus) During your vacation we will be expecting the SAME amount of work and the SAME frequency of contact so...bring a blackberry (and a battery charger) Martin __ See you on the beach - Saving Private Ryan Date: Thu, 30 Jun 2011 08:11:49 -0400 Subject: Re: [maven-shade-plugin] TLC [WAS Re: [maven-assembly-plugin] smart(er) dependency merge] From: bimargul...@gmail.com To: dev@maven.apache.org I'll play patch monkey. Name those JIRA. On Thu, Jun 30, 2011 at 8:00 AM, Kristian Rosenvold kristian.rosenv...@gmail.com wrote: Apart from the fact that I start my summer vacation in 2 days I'm sure I can assist you in getting patches in. I like TLC ;) I'll add shade to my stream, but don't expect much for the next 4 weeks - europeans have vacation ;) I don't even consider patches without testcases. Kristian Den 30.06.2011 13:51, skrev Robert Burrell Donkin: On Thu, Jun 30, 2011 at 11:47 AM, ant elderant.el...@gmail.com wrote: snip If you can mange to get some patches applied and a release of the shade plugin done that would be fantastic. MSHADE-88 for me and I've another fix to different scoped dependencies which i can submit if theres a chance someone might apply it now. I'm happy to work with someone with Maven karma to review and improve the patches submitted (for example by add missing test cases) but if that's not possible then I'd be happy to fork and maintain an improved version over at GitHub (say). Be good to hear from you in either case :-) Robert - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [maven-shade-plugin] TLC [WAS Re: [maven-assembly-plugin] smart(er) dependency merge]
On Thursday, June 30, 2011 12:21:34 PM Robert Burrell Donkin wrote: On Thu, Jun 30, 2011 at 11:41 AM, Benson Margulies bimargul...@gmail.com wrote: The JIRA count is not a reliable indication of anything. Lots of us use shade in production. The JIRA count can indicate a plethora of improvement suggestions, or a bunch of uninvestigated complaints. Don't get me wrong, please do dig in. But you are likely to find that it works for you as is. I'm looking for smart merger of NOTICEs and LICENSEs. How is this currently implemented? For the NOTICE stuff, you can look at the org.apache.maven.plugins.shade.resource.ApacheNoticeResourceTransformer which several projects use to merge the Apache NOTICE things.That could likely also be a starting point for mergers of LICENSE files. Dan Robert - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org -- Daniel Kulp dk...@apache.org http://dankulp.com/blog Talend - http://www.talend.com - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [maven-shade-plugin] TLC [WAS Re: [maven-assembly-plugin] smart(er) dependency merge]
On Thu, Jun 30, 2011 at 6:33 PM, Daniel Kulp dk...@apache.org wrote: snip I'm looking for smart merger of NOTICEs and LICENSEs. How is this currently implemented? For the NOTICE stuff, you can look at the org.apache.maven.plugins.shade.resource.ApacheNoticeResourceTransformer which several projects use to merge the Apache NOTICE things. That could likely also be a starting point for mergers of LICENSE files. Great thanks :-) Robert - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
