Re: No more uber jar
On 23/09/2008, at 11:57 PM, Igor Fedorenko wrote: Would not it be better to move wagons and anything else not intended to be visible by plugins into a separate classloader? I believe that is essentially what the container changes on trunk did. Whether it's something along those lines or a simpler alternative that keeps the current extension semantics, this would certainly be better, but shading them might be simpler and more consistent with current behaviour in the short term. Cheers, Brett Brett Porter wrote: /me cheers Yep, go for it. This will also mean producing shaded versions of the wagons though I think, or creating a shaded built-in wagons JAR, to prevent some of their dependencies being forced on plugins. The ITs for MNG-3581/3599 might pick this up, but it would be worth an extra IT to verify. Cheers, Brett On 23/09/2008, at 3:00 AM, Jason van Zyl wrote: I made the uber jar and I think it was a mistake. It's a complete PITA to swap in new jars and test and the shading can work on the JARs necessary. I would like to remove the uber jar in 2.1 and do it on the 2.2 branch as well. Any objections? Thanks, Jason -- Jason van Zyl Founder, Apache Maven jason at sonatype dot com -- A party which is not afraid of letting culture, business, and welfare go to ruin completely can be omnipotent for a while. -- Jakob Burckhardt - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Brett Porter [EMAIL PROTECTED] http://blogs.exist.com/bporter/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Brett Porter [EMAIL PROTECTED] http://blogs.exist.com/bporter/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: No more uber jar
I have simple i don't want to export this working in ClassWorlds now so I will attempt to integrate that after doing some testing with Oleg in integrating Mercury. On 23-Sep-08, at 3:57 PM, Igor Fedorenko wrote: Would not it be better to move wagons and anything else not intended to be visible by plugins into a separate classloader? Brett Porter wrote: /me cheers Yep, go for it. This will also mean producing shaded versions of the wagons though I think, or creating a shaded built-in wagons JAR, to prevent some of their dependencies being forced on plugins. The ITs for MNG-3581/3599 might pick this up, but it would be worth an extra IT to verify. Cheers, Brett On 23/09/2008, at 3:00 AM, Jason van Zyl wrote: I made the uber jar and I think it was a mistake. It's a complete PITA to swap in new jars and test and the shading can work on the JARs necessary. I would like to remove the uber jar in 2.1 and do it on the 2.2 branch as well. Any objections? Thanks, Jason -- Jason van Zyl Founder, Apache Maven jason at sonatype dot com -- A party which is not afraid of letting culture, business, and welfare go to ruin completely can be omnipotent for a while. -- Jakob Burckhardt - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Brett Porter [EMAIL PROTECTED] http://blogs.exist.com/bporter/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] Thanks, Jason -- Jason van Zyl Founder, Apache Maven jason at sonatype dot com -- To do two things at once is to do neither. -—Publilius Syrus, Roman slave, first century B.C. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: No more uber jar
Awesome! Let's put it up with doco, etc. on the 2.2.x release plan, wdyt? Jason van Zyl wrote: I have simple i don't want to export this working in ClassWorlds now so I will attempt to integrate that after doing some testing with Oleg in integrating Mercury. On 23-Sep-08, at 3:57 PM, Igor Fedorenko wrote: Would not it be better to move wagons and anything else not intended to be visible by plugins into a separate classloader? Brett Porter wrote: /me cheers Yep, go for it. This will also mean producing shaded versions of the wagons though I think, or creating a shaded built-in wagons JAR, to prevent some of their dependencies being forced on plugins. The ITs for MNG-3581/3599 might pick this up, but it would be worth an extra IT to verify. Cheers, Brett On 23/09/2008, at 3:00 AM, Jason van Zyl wrote: I made the uber jar and I think it was a mistake. It's a complete PITA to swap in new jars and test and the shading can work on the JARs necessary. I would like to remove the uber jar in 2.1 and do it on the 2.2 branch as well. Any objections? Thanks, Jason -- Jason van Zyl Founder, Apache Maven jason at sonatype dot com -- A party which is not afraid of letting culture, business, and welfare go to ruin completely can be omnipotent for a while. -- Jakob Burckhardt - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Brett Porter [EMAIL PROTECTED] http://blogs.exist.com/bporter/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] Thanks, Jason -- Jason van Zyl Founder, Apache Maven jason at sonatype dot com -- To do two things at once is to do neither. -—Publilius Syrus, Roman slave, first century B.C. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: No more uber jar
Should work but I've been testing it with trunk ... I would have to restore some classes to make it work on the branch but I'll look. On 24-Sep-08, at 5:41 PM, John Casey wrote: Awesome! Let's put it up with doco, etc. on the 2.2.x release plan, wdyt? Jason van Zyl wrote: I have simple i don't want to export this working in ClassWorlds now so I will attempt to integrate that after doing some testing with Oleg in integrating Mercury. On 23-Sep-08, at 3:57 PM, Igor Fedorenko wrote: Would not it be better to move wagons and anything else not intended to be visible by plugins into a separate classloader? Brett Porter wrote: /me cheers Yep, go for it. This will also mean producing shaded versions of the wagons though I think, or creating a shaded built-in wagons JAR, to prevent some of their dependencies being forced on plugins. The ITs for MNG-3581/3599 might pick this up, but it would be worth an extra IT to verify. Cheers, Brett On 23/09/2008, at 3:00 AM, Jason van Zyl wrote: I made the uber jar and I think it was a mistake. It's a complete PITA to swap in new jars and test and the shading can work on the JARs necessary. I would like to remove the uber jar in 2.1 and do it on the 2.2 branch as well. Any objections? Thanks, Jason -- Jason van Zyl Founder, Apache Maven jason at sonatype dot com -- A party which is not afraid of letting culture, business, and welfare go to ruin completely can be omnipotent for a while. -- Jakob Burckhardt - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Brett Porter [EMAIL PROTECTED] http://blogs.exist.com/bporter/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] Thanks, Jason -- Jason van Zyl Founder, Apache Maven jason at sonatype dot com -- To do two things at once is to do neither. -—Publilius Syrus, Roman slave, first century B.C. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] Thanks, Jason -- Jason van Zyl Founder, Apache Maven jason at sonatype dot com -- You are never dedicated to something you have complete confidence in. No one is fanatically shouting that the sun is going to rise tomorrow. They know it is going to rise tomorrow. When people are fanatically dedicated to political or religious faiths or any other kind of dogmas or goals, it's always because these dogmas or goals are in doubt. -- Robert Pirzig, Zen and the Art of Motorcycle Maintenance - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: No more uber jar
If you're talking about migrating that change back to an older version of plexus/classworlds for the 2.2.x branch, I've been thinking of doing a write-up to migrate off of plexus 1.0-alpha-9 and make it up to date with the current plexus work. Given that, would you still have to backport things? -john Jason van Zyl wrote: Should work but I've been testing it with trunk ... I would have to restore some classes to make it work on the branch but I'll look. On 24-Sep-08, at 5:41 PM, John Casey wrote: Awesome! Let's put it up with doco, etc. on the 2.2.x release plan, wdyt? Jason van Zyl wrote: I have simple i don't want to export this working in ClassWorlds now so I will attempt to integrate that after doing some testing with Oleg in integrating Mercury. On 23-Sep-08, at 3:57 PM, Igor Fedorenko wrote: Would not it be better to move wagons and anything else not intended to be visible by plugins into a separate classloader? Brett Porter wrote: /me cheers Yep, go for it. This will also mean producing shaded versions of the wagons though I think, or creating a shaded built-in wagons JAR, to prevent some of their dependencies being forced on plugins. The ITs for MNG-3581/3599 might pick this up, but it would be worth an extra IT to verify. Cheers, Brett On 23/09/2008, at 3:00 AM, Jason van Zyl wrote: I made the uber jar and I think it was a mistake. It's a complete PITA to swap in new jars and test and the shading can work on the JARs necessary. I would like to remove the uber jar in 2.1 and do it on the 2.2 branch as well. Any objections? Thanks, Jason -- Jason van Zyl Founder, Apache Maven jason at sonatype dot com -- A party which is not afraid of letting culture, business, and welfare go to ruin completely can be omnipotent for a while. -- Jakob Burckhardt - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Brett Porter [EMAIL PROTECTED] http://blogs.exist.com/bporter/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] Thanks, Jason -- Jason van Zyl Founder, Apache Maven jason at sonatype dot com -- To do two things at once is to do neither. -—Publilius Syrus, Roman slave, first century B.C. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] Thanks, Jason -- Jason van Zyl Founder, Apache Maven jason at sonatype dot com -- You are never dedicated to something you have complete confidence in. No one is fanatically shouting that the sun is going to rise tomorrow. They know it is going to rise tomorrow. When people are fanatically dedicated to political or religious faiths or any other kind of dogmas or goals, it's always because these dogmas or goals are in doubt. -- Robert Pirzig, Zen and the Art of Motorcycle Maintenance - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: No more uber jar
I don't know if it's worth trying to upgrade the container. I tried for a couple days and gave up. I'm not really sure it's worth the effort. I think classworlds would be a few hours work and very doable. On 24-Sep-08, at 7:15 PM, John Casey wrote: If you're talking about migrating that change back to an older version of plexus/classworlds for the 2.2.x branch, I've been thinking of doing a write-up to migrate off of plexus 1.0-alpha-9 and make it up to date with the current plexus work. Given that, would you still have to backport things? -john Jason van Zyl wrote: Should work but I've been testing it with trunk ... I would have to restore some classes to make it work on the branch but I'll look. On 24-Sep-08, at 5:41 PM, John Casey wrote: Awesome! Let's put it up with doco, etc. on the 2.2.x release plan, wdyt? Jason van Zyl wrote: I have simple i don't want to export this working in ClassWorlds now so I will attempt to integrate that after doing some testing with Oleg in integrating Mercury. On 23-Sep-08, at 3:57 PM, Igor Fedorenko wrote: Would not it be better to move wagons and anything else not intended to be visible by plugins into a separate classloader? Brett Porter wrote: /me cheers Yep, go for it. This will also mean producing shaded versions of the wagons though I think, or creating a shaded built-in wagons JAR, to prevent some of their dependencies being forced on plugins. The ITs for MNG-3581/3599 might pick this up, but it would be worth an extra IT to verify. Cheers, Brett On 23/09/2008, at 3:00 AM, Jason van Zyl wrote: I made the uber jar and I think it was a mistake. It's a complete PITA to swap in new jars and test and the shading can work on the JARs necessary. I would like to remove the uber jar in 2.1 and do it on the 2.2 branch as well. Any objections? Thanks, Jason -- Jason van Zyl Founder, Apache Maven jason at sonatype dot com -- A party which is not afraid of letting culture, business, and welfare go to ruin completely can be omnipotent for a while. -- Jakob Burckhardt - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Brett Porter [EMAIL PROTECTED] http://blogs.exist.com/bporter/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] Thanks, Jason -- Jason van Zyl Founder, Apache Maven jason at sonatype dot com -- To do two things at once is to do neither. -—Publilius Syrus, Roman slave, first century B.C. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] Thanks, Jason -- Jason van Zyl Founder, Apache Maven jason at sonatype dot com -- You are never dedicated to something you have complete confidence in. No one is fanatically shouting that the sun is going to rise tomorrow. They know it is going to rise tomorrow. When people are fanatically dedicated to political or religious faiths or any other kind of dogmas or goals, it's always because these dogmas or goals are in doubt. -- Robert Pirzig, Zen and the Art of Motorcycle Maintenance - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] Thanks, Jason -- Jason van Zyl Founder, Apache Maven jason at sonatype dot com -- Selfish deeds are the shortest path to self destruction. -- The Seven Samuari, Akira Kirosawa - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: No more uber jar
Would not it be better to move wagons and anything else not intended to be visible by plugins into a separate classloader? Brett Porter wrote: /me cheers Yep, go for it. This will also mean producing shaded versions of the wagons though I think, or creating a shaded built-in wagons JAR, to prevent some of their dependencies being forced on plugins. The ITs for MNG-3581/3599 might pick this up, but it would be worth an extra IT to verify. Cheers, Brett On 23/09/2008, at 3:00 AM, Jason van Zyl wrote: I made the uber jar and I think it was a mistake. It's a complete PITA to swap in new jars and test and the shading can work on the JARs necessary. I would like to remove the uber jar in 2.1 and do it on the 2.2 branch as well. Any objections? Thanks, Jason -- Jason van Zyl Founder, Apache Maven jason at sonatype dot com -- A party which is not afraid of letting culture, business, and welfare go to ruin completely can be omnipotent for a while. -- Jakob Burckhardt - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Brett Porter [EMAIL PROTECTED] http://blogs.exist.com/bporter/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: No more uber jar
Jason van Zyl wrote: I would like to remove the uber jar in 2.1 and do it on the 2.2 branch as well. Any objections? How does this relate to MNG-2892? Are there other means that allow plugins to use different versions of the libs that are used by the core like plexus-utils? Benjamin - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: No more uber jar
Hey, so how's the vacation going? Will Mark still be contacting us after Oct 1? Gil -Original Message- From: Jason van Zyl [mailto:[EMAIL PROTECTED] Sent: Monday, September 22, 2008 10:01 AM To: Maven Developers List Subject: No more uber jar I made the uber jar and I think it was a mistake. It's a complete PITA to swap in new jars and test and the shading can work on the JARs necessary. I would like to remove the uber jar in 2.1 and do it on the 2.2 branch as well. Any objections? Thanks, Jason -- Jason van Zyl Founder, Apache Maven jason at sonatype dot com -- A party which is not afraid of letting culture, business, and welfare go to ruin completely can be omnipotent for a while. -- Jakob Burckhardt - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: No more uber jar
Please imagine the sound of an intermediate level of APPLAUSE for this suggestion. Jason van Zyl [EMAIL PROTECTED] m To Maven Developers List 09/22/2008 10:00 dev@maven.apache.org AM cc Subject Please respond to No more uber jar Maven Developers List [EMAIL PROTECTED] org I made the uber jar and I think it was a mistake. It's a complete PITA to swap in new jars and test and the shading can work on the JARs necessary. I would like to remove the uber jar in 2.1 and do it on the 2.2 branch as well. Any objections? Thanks, Jason -- Jason van Zyl Founder, Apache Maven jason at sonatype dot com -- A party which is not afraid of letting culture, business, and welfare go to ruin completely can be omnipotent for a while. -- Jakob Burckhardt - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] American Express made the following annotations on Mon Sep 22 2008 11:48:04 -- This message and any attachments are solely for the intended recipient and may contain confidential or privileged information. If you are not the intended recipient, any disclosure, copying, use, or distribution of the information included in this message and any attachments is prohibited. If you have received this communication in error, please notify us by reply e-mail and immediately and permanently delete this message and any attachments. Thank you. American Express a ajouté le commentaire suivant le Mon Sep 22 2008 11:48:04 Ce courrier et toute pièce jointe qu'il contient sont réservés au seul destinataire indiqué et peuvent renfermer des renseignements confidentiels et privilégiés. Si vous n'êtes pas le destinataire prévu, toute divulgation, duplication, utilisation ou distribution du courrier ou de toute pièce jointe est interdite. Si vous avez reçu cette communication par erreur, veuillez nous en aviser par courrier et détruire immédiatement le courrier et les pièces jointes. Merci. ** --- - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: No more uber jar
Sounds good to me, as long as we test to make sure it doesn't affect plugins using things like a different version of plexus-utils. -j --- John Casey Developer and PMC Member, Apache Maven (http://maven.apache.org) Member, Apache Software Foundation Blog: http://www.ejlife.net/blogs/buildchimp Jason van Zyl wrote: I made the uber jar and I think it was a mistake. It's a complete PITA to swap in new jars and test and the shading can work on the JARs necessary. I would like to remove the uber jar in 2.1 and do it on the 2.2 branch as well. Any objections? Thanks, Jason -- Jason van Zyl Founder, Apache Maven jason at sonatype dot com -- A party which is not afraid of letting culture, business, and welfare go to ruin completely can be omnipotent for a while. -- Jakob Burckhardt - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: No more uber jar
Just means we use a shaded version of plexus instead of shading the entire Maven runtime. Wouldn't change anything. Plugins could still use their own version of p-u. On 22-Sep-08, at 7:12 PM, Benjamin Bentmann wrote: Jason van Zyl wrote: I would like to remove the uber jar in 2.1 and do it on the 2.2 branch as well. Any objections? How does this relate to MNG-2892? Are there other means that allow plugins to use different versions of the libs that are used by the core like plexus-utils? Benjamin - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] Thanks, Jason -- Jason van Zyl Founder, Apache Maven jason at sonatype dot com -- Three people can keep a secret provided two of them are dead. -- Unknown - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: No more uber jar
/me cheers Yep, go for it. This will also mean producing shaded versions of the wagons though I think, or creating a shaded built-in wagons JAR, to prevent some of their dependencies being forced on plugins. The ITs for MNG-3581/3599 might pick this up, but it would be worth an extra IT to verify. Cheers, Brett On 23/09/2008, at 3:00 AM, Jason van Zyl wrote: I made the uber jar and I think it was a mistake. It's a complete PITA to swap in new jars and test and the shading can work on the JARs necessary. I would like to remove the uber jar in 2.1 and do it on the 2.2 branch as well. Any objections? Thanks, Jason -- Jason van Zyl Founder, Apache Maven jason at sonatype dot com -- A party which is not afraid of letting culture, business, and welfare go to ruin completely can be omnipotent for a while. -- Jakob Burckhardt - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Brett Porter [EMAIL PROTECTED] http://blogs.exist.com/bporter/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
