RE: cvs commit: maven-components/maven-core/src/main/java/org/apa che/maven DefaultMavenCore.java
-Original Message- From: Emmanuel Venisse [mailto:[EMAIL PROTECTED] Sent: Friday, May 28, 2004 2:12 PM To: Maven Developers List; [EMAIL PROTECTED] Subject: Re: cvs commit: maven-components/maven-core/src/main/java/org/apache/maven DefaultMavenCore.java Yes for the moment, I think we don't have a log strategy. Jason? Emmanuel - Original Message - From: Brett Porter [EMAIL PROTECTED] Are we really still using System.out in the new code? I thought there would be some monitors for this. I think we don't have yet the global strategy. This is something which we must think of but is not really needed to have working version of m2 alpha1. And this is what we are slowly but surly approaching. For plexus components we can use Plexus logging mechanism and/or Monitors. What might be difficult to deal with are Mojos (Maven Pojos) They are supposed to be really simple classes which are independent of Plexus or Maven and have (almost) no external dependencies. It will be bad to bind them to some logging framework or some API which defines contract for Monitors, but I don't see other way at the moment except AOP :( Michal - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: cvs commit: maven-components/maven-core/src/main/java/org/apa che/maven DefaultMavenCore.java
On Fri, 2004-05-28 at 08:21, Maczka Michal wrote: For plexus components we can use Plexus logging mechanism and/or Monitors. What might be difficult to deal with are Mojos (Maven Pojos) They are supposed to be really simple classes which are independent of Plexus or Maven and have (almost) no external dependencies. It will be bad to bind them to some logging framework or some API which defines contract for Monitors, but I don't see other way at the moment except AOP :( I think having a monitor is fine, but one of the nice things about the request/response is that any output intended for users can be collected and the output defferred until the operation of the plugin/mojo is complete and request populated. For example in the compiler plugin you could collect all compilation errors and corresponding sources files and they come back in a CompileError object. You don't have to spit any messages out to the user in the plugin itself, that information can be extracted and maven itself can toss the information out. But I still think a monitor is fine, right now the plugins depend on code which totals 7-8k, I'm not too concerned about that and addinga monitor in maven-plugin is not going to cause a great deal of impact. Michal - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- jvz. Jason van Zyl [EMAIL PROTECTED] http://maven.apache.org happiness is like a butterfly: the more you chase it, the more it will elude you, but if you turn your attention to other things, it will come and sit softly on your shoulder ... -- Thoreau - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: cvs commit: maven-components/maven-core/src/main/java/org/apa che/maven DefaultMavenCore.java
On Fri, 2004-05-28 at 08:43, Jason van Zyl wrote: On Fri, 2004-05-28 at 08:21, Maczka Michal wrote: For plexus components we can use Plexus logging mechanism and/or Monitors. What might be difficult to deal with are Mojos (Maven Pojos) They are supposed to be really simple classes which are independent of Plexus or Maven and have (almost) no external dependencies. It will be bad to bind them to some logging framework or some API which defines contract for Monitors, but I don't see other way at the moment except AOP :( I think having a monitor is fine, but one of the nice things about the request/response is that any output intended for users can be collected and the output defferred until the operation of the plugin/mojo is complete and request populated. For example in the compiler plugin you ^^^ I meant response there. could collect all compilation errors and corresponding sources files and they come back in a CompileError object. You don't have to spit any messages out to the user in the plugin itself, that information can be extracted and maven itself can toss the information out. But I still think a monitor is fine, right now the plugins depend on code which totals 7-8k, I'm not too concerned about that and addinga monitor in maven-plugin is not going to cause a great deal of impact. Michal - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- jvz. Jason van Zyl [EMAIL PROTECTED] http://maven.apache.org happiness is like a butterfly: the more you chase it, the more it will elude you, but if you turn your attention to other things, it will come and sit softly on your shoulder ... -- Thoreau - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
