Re: cvs commit: maven-plugins/javadoc/xdocs changes.xml goals.xml index.xml navigation.xml properties.xml
Must've missed it.
Oh well, time to postGoal javadoc and do some deleting
On Thu, 8 Jul 2004 07:50:22 +0200, Arnaud Heritier <[EMAIL PROTECTED]> wrote:
> Hello Dion,
>
> We discussed a little bit on the thread " Javadoc Plugin Change - What is better ?"
>
> I know that it was better if we can keep it but actually I (we?) have no solution to
> do something clean.
> The use of a fileset creates a lot of problems (MJAVADOC16, MPJAVADOC-28,
> MPJAVADOC-29) that we can fix even if we add a lot of
> tests to use a fileset only when needed.
>
> I think that it is better actually to not implement the functionality and to not
> create a lot of problems for users.
>
> If someone find a solution to use the javadoc with a fileset which doesn't break the
> "standard" functionalities, he's the welcome.
>
> Arnaud
>
> > -Message d'origine-
> > De : Dion Gillard [mailto:[EMAIL PROTECTED]
> > Envoyé : jeudi 8 juillet 2004 02:32
> > À : Maven Developers List
> > Objet : Re: cvs commit: maven-plugins/javadoc/xdocs changes.xml goals.xml
> > index.xml navigation.xml
>
>
> > properties.xml
> >
> > Was there any discussion of removing this functionality?
> >
> > I know I would have preferred another way around this.
> >
> > On 7 Jul 2004 21:21:45 -, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
> > > aheritier2004/07/07 14:21:45
> > >
> > > Modified:javadoc plugin.jelly
> > >javadoc/src/plugin-test maven.xml project.xml
> > >javadoc/src/plugin-test/src/main/org/apache/maven
> > > package.html
> > >javadoc/src/plugin-test/src/main/org/apache/maven2
> > > package.html
> > >javadoc/src/plugin-test/src/opt/org/apache/maven3
> > > package.html
> > >javadoc/xdocs changes.xml goals.xml index.xml navigation.xml
> > > properties.xml
> > > Log:
> > > Remove sourceModifications management in the plugin.
> > > It created a lot of problems (MPJAVADOC-28, MPJAVADOC-29).
> > >
> > > Revision ChangesPath
> > > 1.47 +9 -81 maven-plugins/javadoc/plugin.jelly
> > >
> > > Index: plugin.jelly
> > > ===
> > > RCS file: /home/cvs/maven-plugins/javadoc/plugin.jelly,v
> > > retrieving revision 1.46
> > > retrieving revision 1.47
> > > diff -u -r1.46 -r1.47
> > > --- plugin.jelly 7 Jul 2004 10:00:15 - 1.46
> > > +++ plugin.jelly 7 Jul 2004 21:21:45 - 1.47
> > > @@ -36,7 +36,6 @@
> > >
> > > > value="${maven.build.dir}/${maven.final.name}_javadoc.jar"/>
> > >
> > > -
> > > > value="${context.getAntProject().getReferences().get('maven.compile.src.set')}"/>
> > > > > value="${maven.build.dir}/javadoc"/>
> > >
> > > @@ -75,7 +74,6 @@
> > >==
> > >internal.javadoc.jar= [${internal.javadoc.jar}]
> > >internal.javadoc.needed = [${internal.javadoc.needed}]
> > > -internal.javadoc.src.modifs = [${internal.javadoc.src.modifs}]
> > >internal.javadoc.src.set= [${internal.javadoc.src.set}]
> > >internal.javadoc.working.dir= [${internal.javadoc.working.dir}]
> > >
> > > @@ -99,61 +97,29 @@
> > >
> > >
> > >
> > > - > > test="${maven.javadoc.debug}">${internal.javadoc.needed} not
> > null
> > > + > > test="${maven.javadoc.debug}">internal.javadoc.needed not null :
> > ${internal.javadoc.needed}
> > >
> > >
> > > -
> > > -
> > > -
> > > -
> > > -
> > > -
> > > - > > classname="${sm.className}"/>
> > > -
> > > -
> > > -
> > > -
> > > -
> > > -
> > >
RE: cvs commit: maven-plugins/javadoc/xdocs changes.xml goals.xml index.xml navigation.xml properties.xml
Hello Dion,
We discussed a little bit on the thread " Javadoc Plugin Change - What is better ?"
I know that it was better if we can keep it but actually I (we?) have no solution to
do something clean.
The use of a fileset creates a lot of problems (MJAVADOC16, MPJAVADOC-28,
MPJAVADOC-29) that we can fix even if we add a lot of
tests to use a fileset only when needed.
I think that it is better actually to not implement the functionality and to not
create a lot of problems for users.
If someone find a solution to use the javadoc with a fileset which doesn't break the
"standard" functionalities, he's the welcome.
Arnaud
> -Message d'origine-
> De : Dion Gillard [mailto:[EMAIL PROTECTED]
> Envoyé : jeudi 8 juillet 2004 02:32
> À : Maven Developers List
> Objet : Re: cvs commit: maven-plugins/javadoc/xdocs changes.xml goals.xml index.xml
> navigation.xml
> properties.xml
>
> Was there any discussion of removing this functionality?
>
> I know I would have preferred another way around this.
>
> On 7 Jul 2004 21:21:45 -, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
> > aheritier2004/07/07 14:21:45
> >
> > Modified:javadoc plugin.jelly
> >javadoc/src/plugin-test maven.xml project.xml
> >javadoc/src/plugin-test/src/main/org/apache/maven
> > package.html
> >javadoc/src/plugin-test/src/main/org/apache/maven2
> > package.html
> >javadoc/src/plugin-test/src/opt/org/apache/maven3
> > package.html
> >javadoc/xdocs changes.xml goals.xml index.xml navigation.xml
> > properties.xml
> > Log:
> > Remove sourceModifications management in the plugin.
> > It created a lot of problems (MPJAVADOC-28, MPJAVADOC-29).
> >
> > Revision ChangesPath
> > 1.47 +9 -81 maven-plugins/javadoc/plugin.jelly
> >
> > Index: plugin.jelly
> > ===
> > RCS file: /home/cvs/maven-plugins/javadoc/plugin.jelly,v
> > retrieving revision 1.46
> > retrieving revision 1.47
> > diff -u -r1.46 -r1.47
> > --- plugin.jelly 7 Jul 2004 10:00:15 - 1.46
> > +++ plugin.jelly 7 Jul 2004 21:21:45 - 1.47
> > @@ -36,7 +36,6 @@
> >
> > value="${maven.build.dir}/${maven.final.name}_javadoc.jar"/>
> >
> > -
> > value="${context.getAntProject().getReferences().get('maven.compile.src.set')}"/>
> > > value="${maven.build.dir}/javadoc"/>
> >
> > @@ -75,7 +74,6 @@
> >==
> >internal.javadoc.jar= [${internal.javadoc.jar}]
> >internal.javadoc.needed = [${internal.javadoc.needed}]
> > -internal.javadoc.src.modifs = [${internal.javadoc.src.modifs}]
> >internal.javadoc.src.set= [${internal.javadoc.src.set}]
> >internal.javadoc.working.dir= [${internal.javadoc.working.dir}]
> >
> > @@ -99,61 +97,29 @@
> >
> >
> >
> > - > test="${maven.javadoc.debug}">${internal.javadoc.needed} not
> null
> > + internal.javadoc.needed
> > not null :
> ${internal.javadoc.needed}
> >
> >
> > -
> > -
> > -
> > -
> > -
> > -
> > - > classname="${sm.className}"/>
> > -
> > -
> > -
> > -
> > -
> > -
> > -
> > -
> > -
> > -
> > -
> > -
> > -
> > - > value="true"/>
> > -
> > -
> > -
> > -internal.javadoc.src.modifs is
> > ${internal.javadoc.src.modifs}
> > -
> > +
> >
> >
> > delim="${path.separator}">${internal.javadoc.src.set}
> > -
> > -
> > -
> > -
> > +
> >
> >
> >
> >
> >
Re: cvs commit: maven-plugins/javadoc/xdocs changes.xml goals.xml index.xml navigation.xml properties.xml
Was there any discussion of removing this functionality?
I know I would have preferred another way around this.
On 7 Jul 2004 21:21:45 -, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
> aheritier2004/07/07 14:21:45
>
> Modified:javadoc plugin.jelly
>javadoc/src/plugin-test maven.xml project.xml
>javadoc/src/plugin-test/src/main/org/apache/maven
> package.html
>javadoc/src/plugin-test/src/main/org/apache/maven2
> package.html
>javadoc/src/plugin-test/src/opt/org/apache/maven3
> package.html
>javadoc/xdocs changes.xml goals.xml index.xml navigation.xml
> properties.xml
> Log:
> Remove sourceModifications management in the plugin.
> It created a lot of problems (MPJAVADOC-28, MPJAVADOC-29).
>
> Revision ChangesPath
> 1.47 +9 -81 maven-plugins/javadoc/plugin.jelly
>
> Index: plugin.jelly
> ===
> RCS file: /home/cvs/maven-plugins/javadoc/plugin.jelly,v
> retrieving revision 1.46
> retrieving revision 1.47
> diff -u -r1.46 -r1.47
> --- plugin.jelly 7 Jul 2004 10:00:15 - 1.46
> +++ plugin.jelly 7 Jul 2004 21:21:45 - 1.47
> @@ -36,7 +36,6 @@
>
> value="${maven.build.dir}/${maven.final.name}_javadoc.jar"/>
>
> -
> value="${context.getAntProject().getReferences().get('maven.compile.src.set')}"/>
> value="${maven.build.dir}/javadoc"/>
>
> @@ -75,7 +74,6 @@
>==
>internal.javadoc.jar= [${internal.javadoc.jar}]
>internal.javadoc.needed = [${internal.javadoc.needed}]
> -internal.javadoc.src.modifs = [${internal.javadoc.src.modifs}]
>internal.javadoc.src.set= [${internal.javadoc.src.set}]
>internal.javadoc.working.dir= [${internal.javadoc.working.dir}]
>
> @@ -99,61 +97,29 @@
>
>
>
> - test="${maven.javadoc.debug}">${internal.javadoc.needed} not
> null
> + internal.javadoc.needed
> not null : ${internal.javadoc.needed}
>
>
> -
> -
> -
> -
> -
> -
> -
> -
> -
> -
> -
> -
> -
> -
> -
> -
> -
> -
> -
> -
> -
> -
> -
> -
> -internal.javadoc.src.modifs is
> ${internal.javadoc.src.modifs}
> -
> +
>
>
> delim="${path.separator}">${internal.javadoc.src.set}
> -
> -
> -
> -
> +
>
>
>
>
>
> -
> -
> -
>
>
> -
> +
>
>
> value="${sources.iterator().hasNext()}" />
>
> -
>
> -
> +
>
>
>
> @@ -272,31 +238,9 @@
>verbose="${maven.javadoc.debug}"
>>
>
> -
> -
> -Javadoc uses a fileset
> -
> -
> - delim="${path.separator}">${internal.javadoc.src.set}
> -
> -
> -
> -[${dir}] added to javadoc sources
> -
> -
> -
> -
> -
> -
> -
> -
> -
> -Javadoc uses a source path
> -
> -
> -
> -
> -
> +
> +
> +
>
>
>
> @@ -421,22 +365,6 @@
>inputText="${inputText}"
>output="${genDocs}/javadoc.xml"/>
>
> -
> -
> - delim="${path.separator}">${internal.javadoc.src.set}
> -
> -
> -
> -
> -
> -
> -
> -
>
>
>
> @@ -525,4 +453,4 @@
>
>
>
> -
> +
> \ No newline at end of file
>
> 1.9 +6 -5 maven-plugins/javadoc/src/plugin-test/maven.xml
>
> Index: maven.xml
> ===
> RCS file: /home/cvs/maven-plugins/javadoc/src/plugin-test/maven.xml,v
> retrieving revision 1.8
> retrieving revision 1.9
> diff -u -r1.8 -r1.9
> --- maven.xml 26 May 2004 12:38:27 - 1.8
> +++ maven.xml 7 Jul 2004 21:21:45 - 1.9
> @@ -34,10 +34,10 @@
>
> file="${maven.jav
