Re: Cutting another maven-compiler-plugin release to set the default source/target to 1.5

2010-04-11 Thread Milos Kleint
On Sat, Apr 10, 2010 at 12:57 PM, Benjamin Bentmann <
benjamin.bentm...@udo.edu> wrote:

> Brett Porter wrote:
>
>  [...] though for your purposes it might be more expedient to put the
>> configuration in the 3.0 super POM?
>>
>
> -1, it's unlucky when builds depend on the version of Maven being used,
> this should not be be the norm. Ideally, plugin behavior should only be a
> function of the plugin version and not also the Maven version.
>


I agree with benjamin here. Adittionally to what has been said,
configuration in maven superpom makes IDE embedded resolution a pain.

Milos


>
>
> Benjamin
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>


Re: Cutting another maven-compiler-plugin release to set the default source/target to 1.5

2010-04-10 Thread Benjamin Bentmann

Brett Porter wrote:


[...] though for your purposes it might be more expedient to put the 
configuration in the 3.0 super POM?


-1, it's unlucky when builds depend on the version of Maven being used, 
this should not be be the norm. Ideally, plugin behavior should only be 
a function of the plugin version and not also the Maven version.



Benjamin

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: Cutting another maven-compiler-plugin release to set the default source/target to 1.5

2010-04-09 Thread Jason van Zyl

On Apr 9, 2010, at 10:05 PM, Brett Porter wrote:

> This is the issue to update when you do:
> 
> http://jira.codehaus.org/browse/MCOMPILER-80
> 
> I agree it should be done, though for your purposes it might be more 
> expedient to put the configuration in the 3.0 super POM?
> 

I think this would generally more useful in the plugin. I'm sure folks using 
2.x want this as well and we can cut a release of that soon to flip the default 
version in the POM. It's going to be 3 days anyway for beta-1 so it's not a big 
deal.

> - Brett
> 
> On 10/04/2010, at 10:58 AM, Jason van Zyl wrote:
> 
>> The defaults are currently set in the plexus-compiler-javac component (to 
>> source=1.3 and target=1.1) and not in the maven-compiler-plugin. I would 
>> just like to set the default in the AbstractCompilerMojo and be done with 
>> it. This way when we release 3.0-beta-1 the default source/target will be 
>> 1.5. I'll also bump the locked down version of the maven-compiler-plugin I 
>> cut accordingly.
>> 
>> If I don't hear anything I'll assume that's fine and cut it.
>> 
>> Thanks,
>> 
>> Jason
>> 
>> --
>> Jason van Zyl
>> Founder,  Apache Maven
>> http://twitter.com/jvanzyl
>> --
>> 
> 
> --
> Brett Porter
> br...@apache.org
> http://brettporter.wordpress.com/
> 
> 
> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
> 

Thanks,

Jason

--
Jason van Zyl
Founder,  Apache Maven
http://twitter.com/jvanzyl
--



Re: Cutting another maven-compiler-plugin release to set the default source/target to 1.5

2010-04-09 Thread Brett Porter
This is the issue to update when you do:

http://jira.codehaus.org/browse/MCOMPILER-80

I agree it should be done, though for your purposes it might be more expedient 
to put the configuration in the 3.0 super POM?

- Brett

On 10/04/2010, at 10:58 AM, Jason van Zyl wrote:

> The defaults are currently set in the plexus-compiler-javac component (to 
> source=1.3 and target=1.1) and not in the maven-compiler-plugin. I would just 
> like to set the default in the AbstractCompilerMojo and be done with it. This 
> way when we release 3.0-beta-1 the default source/target will be 1.5. I'll 
> also bump the locked down version of the maven-compiler-plugin I cut 
> accordingly.
> 
> If I don't hear anything I'll assume that's fine and cut it.
> 
> Thanks,
> 
> Jason
> 
> --
> Jason van Zyl
> Founder,  Apache Maven
> http://twitter.com/jvanzyl
> --
> 

--
Brett Porter
br...@apache.org
http://brettporter.wordpress.com/





-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org