Re: Integration test suite
Hi Herve, I saw your fix but I was wondering if just adding those two lines to the bootstrap.txt: +org.apache.maven.plugins:maven-dependency-plugin:3.1.1 +org.apache.maven.plugins:maven-dependency-plugin:3.3.0 wouldn't be a simpler fix. The test itself seems fine, just the deps are missing. -h On Sun, Aug 21, 2022 at 11:29 PM Hervé BOUTEMY wrote: > I did a first quick pass, but I fear there is an unexpected warning with m- > antrun-p that still causes a failure: I don't time yet to fix, I need to > leave, > help welcome... > > Le lundi 22 août 2022, 07:57:31 CEST Hervé BOUTEMY a écrit : > > uh, sorry, I overlooked that I broke the core ITs... > > > > looking at the error message: > > "[ERROR] Plugin org.apache.maven.plugins:maven-dependency-plugin:3.3.0 or > > one of its dependencies could not be resolved: > > org.apache.maven.plugins:maven- dependency-plugin:jar:3.3.0 was not found > > in file:target/null" > > it seems it's the classical "disconnected ITs run" issue: let's use my > > mistake as a training :) > > > > - explanations are in the "Core ITs Suite and Dependencies (incl. > Plugins)" > > of https://maven.apache.org/core-its/core-it-suite/ > > > > - looking at bootstrap output, it seems maven-dependency-plugin 3.1.1 is > > available instead of 3.3.0 => I'll update the failing ITs and it should > be > > solved > > > > Regards, > > > > Hervé > > > > Le lundi 22 août 2022, 06:50:40 CEST Henning Schmiedehausen a écrit : > > > Folks, > > > > > > I am somewhat struggling to make integration tests pass for PRs. And it > > > seems that I am not alone. Looking at > > > https://github.com/apache/maven/commits/master, none of the merged > commits > > > on master has successfully passed the test suite. It seems to have > started > > > with the "[MNG-7353] ..." commit here: > > > > https://github.com/apache/maven/commit/35b93b0a589752cc88105623a2ddf9e52b5 > > > 6c 1ce > > > > > > The same seems to apply for the maven-3.9.x branch ( > > > https://github.com/apache/maven/commits/maven-3.9.x) - test failures > for > > > all commits after "[MNG-7353] ..." ( > > > > https://github.com/apache/maven/commit/95bdbf6821d16c2b4f1df6f820600e0d4b1 > > > b9 166 ) > > > > > > This makes it slightly difficult for me to understand if my PRs > actually > > > break something in maven (I am pretty sure they do not) or whether > this is > > > a knock on effect from other integration tests failing. The issue may > be > > > with the CI setup itself; I can make the integration test suite pass > > > locally (MacOS 12, Intel, JDK 17) for either branch. > > > > > > I tried to make sense of the github actions but they seem to be more > > > complicated than I thought. I can get the test to pass locally by > running > > > > > > % cd maven > > > % mvn -PversionlessMavenDist clean install > > > % cd ../maven-integration-testing > > > % mvn -Prun-its clean install -DmavenDistro=... reference to the maven > > > folder .../apache-maven/target/apache-maven-bin.zip > > > > > > Grateful for any advice. Ideally the folks that wrote the gh actions > > > (Martin, Sylwester, Maarten) or who commited that change (Hervé) could > > > help. > > > > > > Thanks, > > > > > > Henning > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
Re: Integration test suite
Hi Maarten, Thank you for the explanation! The GH actions are much more visible on Pull Requests; I was not even aware that there is a jenkins setup (as this is not surfaced anywhere for a PR). It would be good to document that implicit maven / maven-integration-testing checking; I am not actually sure that I used the same branch names. I see failures in the GH actions (as shown on the github project in the actions tab). Hervé seems to have found the root cause; I can wait for him to dig deeper into this. -h -h On Mon, Aug 22, 2022 at 6:59 AM Maarten Mulders wrote: > Hi all, > > The overall idea of the integation tests in GH Actions is this: > 1. Check if the org/owner of the fork where the PR comes from _also_ has > a fork of maven-integration-testing. > 2. If so, check if they have a branch on that fork with the same name as > the fork of maven-core. > 3. If so, run the Maven PR against that fork. > Otherwise, run the Maven PR against the *master* branch of > maven-integration-testing. > > Having said that, I believe most of the GH Action jobs run fine. What > indeed fails - starting at #35b93b0a - is same jobs running in ASF > Jenkins. I believe they should do the same as GH Actions, but apparently > they do not do the same thing. Ideally, if one fails, the other should > fail as well. > > I've had a look at it and I think the main difference is that the GH > Actions set maven.repo.local to $HOME/.m2/repository, whereas Jenkins > does not. Would it make sense to specify maven.repo.local for GitHub > actions, too? > > > Thanks, > > Maarten > > > On 22/08/2022 07:57, Hervé BOUTEMY wrote: > > uh, sorry, I overlooked that I broke the core ITs... > > > > looking at the error message: > > "[ERROR] Plugin org.apache.maven.plugins:maven-dependency-plugin:3.3.0 > or one > > of its dependencies could not be resolved: > org.apache.maven.plugins:maven- > > dependency-plugin:jar:3.3.0 was not found in file:target/null" > > it seems it's the classical "disconnected ITs run" issue: let's use my > mistake > > as a training :) > > > > - explanations are in the "Core ITs Suite and Dependencies (incl. > Plugins)" of > > https://maven.apache.org/core-its/core-it-suite/ > > > > - looking at bootstrap output, it seems maven-dependency-plugin 3.1.1 is > > available instead of 3.3.0 => I'll update the failing ITs and it should > be > > solved > > > > Regards, > > > > Hervé > > > > Le lundi 22 août 2022, 06:50:40 CEST Henning Schmiedehausen a écrit : > >> Folks, > >> > >> I am somewhat struggling to make integration tests pass for PRs. And it > >> seems that I am not alone. Looking at > >> https://github.com/apache/maven/commits/master, none of the merged > commits > >> on master has successfully passed the test suite. It seems to have > started > >> with the "[MNG-7353] ..." commit here: > >> > https://github.com/apache/maven/commit/35b93b0a589752cc88105623a2ddf9e52b56c > >> 1ce > >> > >> The same seems to apply for the maven-3.9.x branch ( > >> https://github.com/apache/maven/commits/maven-3.9.x) - test failures > for > >> all commits after "[MNG-7353] ..." ( > >> > https://github.com/apache/maven/commit/95bdbf6821d16c2b4f1df6f820600e0d4b1b9 > >> 166 ) > >> > >> This makes it slightly difficult for me to understand if my PRs actually > >> break something in maven (I am pretty sure they do not) or whether this > is > >> a knock on effect from other integration tests failing. The issue may > be > >> with the CI setup itself; I can make the integration test suite pass > >> locally (MacOS 12, Intel, JDK 17) for either branch. > >> > >> I tried to make sense of the github actions but they seem to be more > >> complicated than I thought. I can get the test to pass locally by > running > >> > >> % cd maven > >> % mvn -PversionlessMavenDist clean install > >> % cd ../maven-integration-testing > >> % mvn -Prun-its clean install -DmavenDistro=... reference to the maven > >> folder .../apache-maven/target/apache-maven-bin.zip > >> > >> Grateful for any advice. Ideally the folks that wrote the gh actions > >> (Martin, Sylwester, Maarten) or who commited that change (Hervé) could > help. > >> > >> Thanks, > >> Henning > > > > > > > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
Re: Integration test suite
Hi all, The overall idea of the integation tests in GH Actions is this: 1. Check if the org/owner of the fork where the PR comes from _also_ has a fork of maven-integration-testing. 2. If so, check if they have a branch on that fork with the same name as the fork of maven-core. 3. If so, run the Maven PR against that fork. Otherwise, run the Maven PR against the *master* branch of maven-integration-testing. Having said that, I believe most of the GH Action jobs run fine. What indeed fails - starting at #35b93b0a - is same jobs running in ASF Jenkins. I believe they should do the same as GH Actions, but apparently they do not do the same thing. Ideally, if one fails, the other should fail as well. I've had a look at it and I think the main difference is that the GH Actions set maven.repo.local to $HOME/.m2/repository, whereas Jenkins does not. Would it make sense to specify maven.repo.local for GitHub actions, too? Thanks, Maarten On 22/08/2022 07:57, Hervé BOUTEMY wrote: uh, sorry, I overlooked that I broke the core ITs... looking at the error message: "[ERROR] Plugin org.apache.maven.plugins:maven-dependency-plugin:3.3.0 or one of its dependencies could not be resolved: org.apache.maven.plugins:maven- dependency-plugin:jar:3.3.0 was not found in file:target/null" it seems it's the classical "disconnected ITs run" issue: let's use my mistake as a training :) - explanations are in the "Core ITs Suite and Dependencies (incl. Plugins)" of https://maven.apache.org/core-its/core-it-suite/ - looking at bootstrap output, it seems maven-dependency-plugin 3.1.1 is available instead of 3.3.0 => I'll update the failing ITs and it should be solved Regards, Hervé Le lundi 22 août 2022, 06:50:40 CEST Henning Schmiedehausen a écrit : Folks, I am somewhat struggling to make integration tests pass for PRs. And it seems that I am not alone. Looking at https://github.com/apache/maven/commits/master, none of the merged commits on master has successfully passed the test suite. It seems to have started with the "[MNG-7353] ..." commit here: https://github.com/apache/maven/commit/35b93b0a589752cc88105623a2ddf9e52b56c 1ce The same seems to apply for the maven-3.9.x branch ( https://github.com/apache/maven/commits/maven-3.9.x) - test failures for all commits after "[MNG-7353] ..." ( https://github.com/apache/maven/commit/95bdbf6821d16c2b4f1df6f820600e0d4b1b9 166 ) This makes it slightly difficult for me to understand if my PRs actually break something in maven (I am pretty sure they do not) or whether this is a knock on effect from other integration tests failing. The issue may be with the CI setup itself; I can make the integration test suite pass locally (MacOS 12, Intel, JDK 17) for either branch. I tried to make sense of the github actions but they seem to be more complicated than I thought. I can get the test to pass locally by running % cd maven % mvn -PversionlessMavenDist clean install % cd ../maven-integration-testing % mvn -Prun-its clean install -DmavenDistro=... reference to the maven folder .../apache-maven/target/apache-maven-bin.zip Grateful for any advice. Ideally the folks that wrote the gh actions (Martin, Sylwester, Maarten) or who commited that change (Hervé) could help. Thanks, Henning - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Integration test suite
I did a first quick pass, but I fear there is an unexpected warning with m- antrun-p that still causes a failure: I don't time yet to fix, I need to leave, help welcome... Le lundi 22 août 2022, 07:57:31 CEST Hervé BOUTEMY a écrit : > uh, sorry, I overlooked that I broke the core ITs... > > looking at the error message: > "[ERROR] Plugin org.apache.maven.plugins:maven-dependency-plugin:3.3.0 or > one of its dependencies could not be resolved: > org.apache.maven.plugins:maven- dependency-plugin:jar:3.3.0 was not found > in file:target/null" > it seems it's the classical "disconnected ITs run" issue: let's use my > mistake as a training :) > > - explanations are in the "Core ITs Suite and Dependencies (incl. Plugins)" > of https://maven.apache.org/core-its/core-it-suite/ > > - looking at bootstrap output, it seems maven-dependency-plugin 3.1.1 is > available instead of 3.3.0 => I'll update the failing ITs and it should be > solved > > Regards, > > Hervé > > Le lundi 22 août 2022, 06:50:40 CEST Henning Schmiedehausen a écrit : > > Folks, > > > > I am somewhat struggling to make integration tests pass for PRs. And it > > seems that I am not alone. Looking at > > https://github.com/apache/maven/commits/master, none of the merged commits > > on master has successfully passed the test suite. It seems to have started > > with the "[MNG-7353] ..." commit here: > > https://github.com/apache/maven/commit/35b93b0a589752cc88105623a2ddf9e52b5 > > 6c 1ce > > > > The same seems to apply for the maven-3.9.x branch ( > > https://github.com/apache/maven/commits/maven-3.9.x) - test failures for > > all commits after "[MNG-7353] ..." ( > > https://github.com/apache/maven/commit/95bdbf6821d16c2b4f1df6f820600e0d4b1 > > b9 166 ) > > > > This makes it slightly difficult for me to understand if my PRs actually > > break something in maven (I am pretty sure they do not) or whether this is > > a knock on effect from other integration tests failing. The issue may be > > with the CI setup itself; I can make the integration test suite pass > > locally (MacOS 12, Intel, JDK 17) for either branch. > > > > I tried to make sense of the github actions but they seem to be more > > complicated than I thought. I can get the test to pass locally by running > > > > % cd maven > > % mvn -PversionlessMavenDist clean install > > % cd ../maven-integration-testing > > % mvn -Prun-its clean install -DmavenDistro=... reference to the maven > > folder .../apache-maven/target/apache-maven-bin.zip > > > > Grateful for any advice. Ideally the folks that wrote the gh actions > > (Martin, Sylwester, Maarten) or who commited that change (Hervé) could > > help. > > > > Thanks, > > > > Henning > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Integration test suite
uh, sorry, I overlooked that I broke the core ITs... looking at the error message: "[ERROR] Plugin org.apache.maven.plugins:maven-dependency-plugin:3.3.0 or one of its dependencies could not be resolved: org.apache.maven.plugins:maven- dependency-plugin:jar:3.3.0 was not found in file:target/null" it seems it's the classical "disconnected ITs run" issue: let's use my mistake as a training :) - explanations are in the "Core ITs Suite and Dependencies (incl. Plugins)" of https://maven.apache.org/core-its/core-it-suite/ - looking at bootstrap output, it seems maven-dependency-plugin 3.1.1 is available instead of 3.3.0 => I'll update the failing ITs and it should be solved Regards, Hervé Le lundi 22 août 2022, 06:50:40 CEST Henning Schmiedehausen a écrit : > Folks, > > I am somewhat struggling to make integration tests pass for PRs. And it > seems that I am not alone. Looking at > https://github.com/apache/maven/commits/master, none of the merged commits > on master has successfully passed the test suite. It seems to have started > with the "[MNG-7353] ..." commit here: > https://github.com/apache/maven/commit/35b93b0a589752cc88105623a2ddf9e52b56c > 1ce > > The same seems to apply for the maven-3.9.x branch ( > https://github.com/apache/maven/commits/maven-3.9.x) - test failures for > all commits after "[MNG-7353] ..." ( > https://github.com/apache/maven/commit/95bdbf6821d16c2b4f1df6f820600e0d4b1b9 > 166 ) > > This makes it slightly difficult for me to understand if my PRs actually > break something in maven (I am pretty sure they do not) or whether this is > a knock on effect from other integration tests failing. The issue may be > with the CI setup itself; I can make the integration test suite pass > locally (MacOS 12, Intel, JDK 17) for either branch. > > I tried to make sense of the github actions but they seem to be more > complicated than I thought. I can get the test to pass locally by running > > % cd maven > % mvn -PversionlessMavenDist clean install > % cd ../maven-integration-testing > % mvn -Prun-its clean install -DmavenDistro=... reference to the maven > folder .../apache-maven/target/apache-maven-bin.zip > > Grateful for any advice. Ideally the folks that wrote the gh actions > (Martin, Sylwester, Maarten) or who commited that change (Hervé) could help. > > Thanks, > Henning - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
