Re: Tagging Maven Checkstyle plugin

2019-05-10 Thread Enrico Olivelli
Il giorno ven 10 mag 2019 alle ore 14:53 Eric Lilja 
ha scritto:

> Great news! Which version of Checkstyle will be default, 8.20? Hoping for
> 8.20!
>

Actually we have 8.19
https://github.com/apache/maven-checkstyle-plugin/blob/6abad1cb750244899c6e3b45a7a8bb49fba954db/pom.xml#L71

Feel free to send a PR

Enrico


>
> - Eric L
>
> On Fri, May 10, 2019 at 2:42 PM Tibor Digana 
> wrote:
>
> > Thx for your effort.
> > Good job with everything you have done in Maven.
> >
> > On Fri, May 10, 2019 at 2:23 PM Enrico Olivelli 
> > wrote:
> >
> > > Hi all,
> > > I am going to cut a release of Maven Checkstyle Plugin during this
> > weekend.
> > >
> > > There are major changes, I will release 3.1.0 version:
> > > - drop support for Java 7 (Checkstyle 8 needs java 8)
> > > - drop support for Checkstyle  < 8.x (We have migrated to the new
> > > Checkstyle API)
> > > - do not resolve anymore project depedencies (This seems deprecated
> from
> > > Checkstyle perspective)
> > >
> > > Most of these works have been done with guys from Checkstyle project
> and
> > > this is great because our plugin is mostly a wrapper around Checkstyle
> > and
> > > it is good that we work together.
> > >
> > > Unfortunately Checkstyle 8 has major breking changes and checkstyle
> > > configuration files taht worked on CS 6 do not work any more (I had to
> > > change a bunch of ITs) but this is expected
> > > and this is very appreciated from CS community because now they are
> free
> > to
> > > move forward
> > > with the project.
> > >
> > > Enrico
> > >
> >
>


Re: Tagging Maven Checkstyle plugin

2019-05-10 Thread Eric Lilja
Great news! Which version of Checkstyle will be default, 8.20? Hoping for
8.20!

- Eric L

On Fri, May 10, 2019 at 2:42 PM Tibor Digana  wrote:

> Thx for your effort.
> Good job with everything you have done in Maven.
>
> On Fri, May 10, 2019 at 2:23 PM Enrico Olivelli 
> wrote:
>
> > Hi all,
> > I am going to cut a release of Maven Checkstyle Plugin during this
> weekend.
> >
> > There are major changes, I will release 3.1.0 version:
> > - drop support for Java 7 (Checkstyle 8 needs java 8)
> > - drop support for Checkstyle  < 8.x (We have migrated to the new
> > Checkstyle API)
> > - do not resolve anymore project depedencies (This seems deprecated from
> > Checkstyle perspective)
> >
> > Most of these works have been done with guys from Checkstyle project and
> > this is great because our plugin is mostly a wrapper around Checkstyle
> and
> > it is good that we work together.
> >
> > Unfortunately Checkstyle 8 has major breking changes and checkstyle
> > configuration files taht worked on CS 6 do not work any more (I had to
> > change a bunch of ITs) but this is expected
> > and this is very appreciated from CS community because now they are free
> to
> > move forward
> > with the project.
> >
> > Enrico
> >
>


Re: Tagging Maven Checkstyle plugin

2019-05-10 Thread Tibor Digana
Thx for your effort.
Good job with everything you have done in Maven.

On Fri, May 10, 2019 at 2:23 PM Enrico Olivelli  wrote:

> Hi all,
> I am going to cut a release of Maven Checkstyle Plugin during this weekend.
>
> There are major changes, I will release 3.1.0 version:
> - drop support for Java 7 (Checkstyle 8 needs java 8)
> - drop support for Checkstyle  < 8.x (We have migrated to the new
> Checkstyle API)
> - do not resolve anymore project depedencies (This seems deprecated from
> Checkstyle perspective)
>
> Most of these works have been done with guys from Checkstyle project and
> this is great because our plugin is mostly a wrapper around Checkstyle and
> it is good that we work together.
>
> Unfortunately Checkstyle 8 has major breking changes and checkstyle
> configuration files taht worked on CS 6 do not work any more (I had to
> change a bunch of ITs) but this is expected
> and this is very appreciated from CS community because now they are free to
> move forward
> with the project.
>
> Enrico
>