Re: Zip packaging in 2.0.x (MNG-1683)

2008-01-14 Thread Olivier Lamy
Hi,

2008/1/9, Olivier Lamy [EMAIL PROTECTED]:
 2008/1/9, Tom Huybrechts [EMAIL PROTECTED]:
  Are you proposing to add the zip packaging to the core ?

 Yep

  Won't this break (or at least change) builds that have defined their
  own zip packaging ?

 Right, I have to check before if an extensions declaration wins or not
 on native maven packaging.

I have checked that with both 2.0.x branch and trunk with a corporate
plugin which declare a custom zip packaging (with extensions flag) and
I have created locally a org.apache.maven.plugins:maven-zip-plugin.
I have added this last one in the core packaging, when I use it in a
simple project the one from the core wins in silent (no errors are
displayed).

Then I have added too the corporate plugings in build/extensions element .
In this case the build failed with 2.0.x but not with trunk (but the
core plugin is used).

Questions :
- can we add this in 2.1.x (this means some builds can break) ?
- can we add this in 2.1.x and fixing the trunk to avoid overriding
core packagings (which should a litte bit tricky) ?
- can we simply provide a maven-zip-plugin with a clear documentation
which explains how to use it as a packaging ?

If no the issue MNG-1683 must be marked as Won't fix

Thoughts ?

Thanks,
--
Olivier


 
  Tom
 
  On Jan 9, 2008 10:06 PM, Olivier Lamy [EMAIL PROTECTED] wrote:
   Hi,
   I have just read a thread [1] on the user mailing list.
   Is there any objections if I reopen the issue [2] and fix it in the
   2.0.x branch ?
   A new plugin (maven-zip-plugin) will be added too.
  
   Thoughts ?
  
   Thanks,
   --
   Olivier
  
   [1] 
   http://www.nabble.com/Existance-of-ZIP-Archetype--%7C-How-to-distribute-DB-code-to-different-mvn-modules--td14614465s177.html
   [2] http://jira.codehaus.org/browse/MNG-1683
  
   -
   To unsubscribe, e-mail: [EMAIL PROTECTED]
   For additional commands, e-mail: [EMAIL PROTECTED]
  
  
 
  -
  To unsubscribe, e-mail: [EMAIL PROTECTED]
  For additional commands, e-mail: [EMAIL PROTECTED]
 
 


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Zip packaging in 2.0.x (MNG-1683)

2008-01-09 Thread Tom Huybrechts
Are you proposing to add the zip packaging to the core ?
Won't this break (or at least change) builds that have defined their
own zip packaging ?

Tom

On Jan 9, 2008 10:06 PM, Olivier Lamy [EMAIL PROTECTED] wrote:
 Hi,
 I have just read a thread [1] on the user mailing list.
 Is there any objections if I reopen the issue [2] and fix it in the
 2.0.x branch ?
 A new plugin (maven-zip-plugin) will be added too.

 Thoughts ?

 Thanks,
 --
 Olivier

 [1] 
 http://www.nabble.com/Existance-of-ZIP-Archetype--%7C-How-to-distribute-DB-code-to-different-mvn-modules--td14614465s177.html
 [2] http://jira.codehaus.org/browse/MNG-1683

 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: Zip packaging in 2.0.x (MNG-1683)

2008-01-09 Thread Brian E. Fox
How was it resolved in 2.1? If there is a new zip plugin, will that
conflict with the 2.1 solution? (we'll end up supporting it forever).
And why not just a new goal to the assembly plugin?

-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of
Olivier Lamy
Sent: Wednesday, January 09, 2008 4:06 PM
To: Maven Developers List
Subject: Zip packaging in 2.0.x (MNG-1683)

Hi,
I have just read a thread [1] on the user mailing list.
Is there any objections if I reopen the issue [2] and fix it in the
2.0.x branch ?
A new plugin (maven-zip-plugin) will be added too.

Thoughts ?

Thanks,
--
Olivier

[1]
http://www.nabble.com/Existance-of-ZIP-Archetype--%7C-How-to-distribute-
DB-code-to-different-mvn-modules--td14614465s177.html
[2] http://jira.codehaus.org/browse/MNG-1683

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Zip packaging in 2.0.x (MNG-1683)

2008-01-09 Thread Olivier Lamy
2008/1/9, Tom Huybrechts [EMAIL PROTECTED]:
 Are you proposing to add the zip packaging to the core ?

Yep

 Won't this break (or at least change) builds that have defined their
 own zip packaging ?

Right, I have to check before if an extensions declaration wins or not
on native maven packaging.


 Tom

 On Jan 9, 2008 10:06 PM, Olivier Lamy [EMAIL PROTECTED] wrote:
  Hi,
  I have just read a thread [1] on the user mailing list.
  Is there any objections if I reopen the issue [2] and fix it in the
  2.0.x branch ?
  A new plugin (maven-zip-plugin) will be added too.
 
  Thoughts ?
 
  Thanks,
  --
  Olivier
 
  [1] 
  http://www.nabble.com/Existance-of-ZIP-Archetype--%7C-How-to-distribute-DB-code-to-different-mvn-modules--td14614465s177.html
  [2] http://jira.codehaus.org/browse/MNG-1683
 
  -
  To unsubscribe, e-mail: [EMAIL PROTECTED]
  For additional commands, e-mail: [EMAIL PROTECTED]
 
 

 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Zip packaging in 2.0.x (MNG-1683)

2008-01-09 Thread Olivier Lamy
2008/1/9, Brian E. Fox [EMAIL PROTECTED]:
 How was it resolved in 2.1? If there is a new zip plugin, will that
 conflict with the 2.1 solution? (we'll end up supporting it forever).
 And why not just a new goal to the assembly plugin?

It's marked as solved in trunk but not sure it's really fixed.
Just tested with a sample projet (zip packaging) with current trunk
and no artifact is produced.

When you talk about 2.1 solution, what is this ? (can you give me
any link to this ?).

Right we have the assembly hack. (but I agree here on the Vincent's comment [1])
And as it's a hack, users need to had some extra plugin configuration
to attach his real artifact (because the real needed artifact is a zip
and not a pom).

Thanks,
--
Olivier

[1] http://jira.codehaus.org/browse/MNG-1683#action_85816


 -Original Message-
 From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of
 Olivier Lamy
 Sent: Wednesday, January 09, 2008 4:06 PM
 To: Maven Developers List
 Subject: Zip packaging in 2.0.x (MNG-1683)

 Hi,
 I have just read a thread [1] on the user mailing list.
 Is there any objections if I reopen the issue [2] and fix it in the
 2.0.x branch ?
 A new plugin (maven-zip-plugin) will be added too.

 Thoughts ?

 Thanks,
 --
 Olivier

 [1]
 http://www.nabble.com/Existance-of-ZIP-Archetype--%7C-How-to-distribute-
 DB-code-to-different-mvn-modules--td14614465s177.html
 [2] http://jira.codehaus.org/browse/MNG-1683

 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]


 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]