Re: maven-surefire git commit: SUREFIRE_SYSPROP_DUPLICATES

2017-02-18 Thread Tibor Digana 
yes, Jira will be created for these branches, no problem, but let's see
what the future logs bring.

On Sat, Feb 18, 2017 at 12:51 PM, Tibor Digana-2 [via Maven] <
ml-node+s40175n5899063...@n5.nabble.com> wrote:

> The build processes use to take from 45min to 2:21h.
>
> On Sat, Feb 18, 2017 at 12:47 PM, Tibor Digana <[hidden email]
> >
> wrote:
>
> > I am waiting for Michael's "go on".
> > There are 58 TestNG ITs and this is not nice fix, however it is god but
> > the rootcause is that surefire-integration-tests POM has testng default
> > version 5.7 and that is the roortcause of system prop duplicates. I need
> to
> > find someone who will update 58 tests after we and Michael says that the
> > build is passed.
> > Let's see what Stephan's build on Mac says.
> > Fixing 58 test can be done later, does not block Maven.
> >
> >
> > On Sat, Feb 18, 2017 at 12:25 PM, Hervé BOUTEMY <[hidden email]
> >
> > wrote:
> >
> >> IIUC, this one is a good enhancement to integrate, since it makes
> >> Surefire more
> >> reliable (not relying on the way multiple "-Dmyprop=" is handled)
> >>
> >> Then there should just be a Jira issue created, and this fix integrated
> to
> >> Surefire master without waiting, isn't it?
> >>
> >> Or do you fear that this change can have unexpected impact?
> >>
> >> Regards,
> >>
> >> Hervé
> >>
> >> Le jeudi 16 février 2017, 17:42:07 CET [hidden email]
>  a écrit :
> >> > Repository: maven-surefire
> >> > Updated Branches:
> >> >   refs/heads/SUREFIRE_SYSPROP_DUPLICATES [created] ef5b0f460
> >> >
> >> >
> >> > SUREFIRE_SYSPROP_DUPLICATES
> >> >
> >> >
> >> > Project: http://git-wip-us.apache.org/repos/asf/maven-surefire/repo
> >> > Commit:
> >> > http://git-wip-us.apache.org/repos/asf/maven-surefire/commit/ef5b0f46
> >> Tree:
> >> > http://git-wip-us.apache.org/repos/asf/maven-surefire/tree/ef5b0f46
> >> Diff:
> >> > http://git-wip-us.apache.org/repos/asf/maven-surefire/diff/ef5b0f46
> >> >
> >> > Branch: refs/heads/SUREFIRE_SYSPROP_DUPLICATES
> >> > Commit: ef5b0f460021ad6f827d75cde38f888f37a54415
> >> > Parents: 179abbf
> >> > Author: Tibor17 <[hidden email]
> >
> >> > Authored: Thu Feb 16 18:40:45 2017 +0100
> >> > Committer: Tibor17 <[hidden email]
> >
> >> > Committed: Thu Feb 16 18:40:45 2017 +0100
> >> >
> >> > --
>
> >> >  .../surefire/its/fixture/MavenLauncher.java | 45
> >> ---
> >> >  .../surefire/its/fixture/MavenLauncherTest.java | 47
> >> 
> >> >  .../surefire/its/fixture/SurefireLauncher.java  |  6 +--
> >> >  3 files changed, 88 insertions(+), 10 deletions(-)
> >> > --
>
> >> >
> >> >
> >> > http://git-wip-us.apache.org/repos/asf/maven-surefire/blob/e
> >> f5b0f46/surefire
> >> > -integration-tests/src/test/java/org/apache/maven/surefire/
> >> its/fixture/Maven
> >> > Launcher.java
> >> > --
>
> >> diff
> >> > --git
> >> > a/surefire-integration-tests/src/test/java/org/apache/maven/
> >> surefire/its/fi
> >> > xture/MavenLauncher.java
> >> > b/surefire-integration-tests/src/test/java/org/apache/maven/
> >> surefire/its/fi
> >> > xture/MavenLauncher.java index 1198fcb..0945068 100755
> >> > ---
> >> > a/surefire-integration-tests/src/test/java/org/apache/maven/
> >> surefire/its/fi
> >> > xture/MavenLauncher.java +++
> >> > b/surefire-integration-tests/src/test/java/org/apache/maven/
> >> surefire/its/fi
> >> > xture/MavenLauncher.java @@ -19,18 +19,22 @@ package
> >> > org.apache.maven.surefire.its.fixture; * under the License.
> >> >   */
> >> >
> >> > +import org.apache.commons.lang.text.StrSubstitutor;
> >> > +import org.apache.maven.it.VerificationException;
> >> > +import org.apache.maven.it.Verifier;
> >> > +import org.apache.maven.it.util.ResourceExtractor;
> >> > +import org.apache.maven.shared.utils.io.FileUtils;
> >> > +
> >> >  import java.io.File;
> >> >  import java.io.IOException;
> >> >  import java.net.URL;
> >> >  import java.util.ArrayList;
> >> >  import java.util.HashMap;
> >> >  import java.util.List;
> >> > +import java.util.ListIterator;
> >> >  import java.util.Map;
> >> > -import org.apache.commons.lang.text.StrSubstitutor;
> >> > -import org.apache.maven.it.VerificationException;
> >> > -import org.apache.maven.it.Verifier;
> >> > -import org.apache.maven.it.util.ResourceExtractor;
> >> > -import org.apache.maven.shared.utils.io.FileUtils;
> >> > +
> >> > +import static java.util.Collections.unmodifiableList;
> >> >
> >> >  /**
> >> >   * Encapsulate all needed features to start a maven run
> >> > @@ -203,13 +207,13 @@ public class MavenLaun

Re: maven-surefire git commit: SUREFIRE_SYSPROP_DUPLICATES

2017-02-18 Thread Tibor Digana 
The build processes use to take from 45min to 2:21h.

On Sat, Feb 18, 2017 at 12:47 PM, Tibor Digana 
wrote:

> I am waiting for Michael's "go on".
> There are 58 TestNG ITs and this is not nice fix, however it is god but
> the rootcause is that surefire-integration-tests POM has testng default
> version 5.7 and that is the roortcause of system prop duplicates. I need to
> find someone who will update 58 tests after we and Michael says that the
> build is passed.
> Let's see what Stephan's build on Mac says.
> Fixing 58 test can be done later, does not block Maven.
>
>
> On Sat, Feb 18, 2017 at 12:25 PM, Hervé BOUTEMY 
> wrote:
>
>> IIUC, this one is a good enhancement to integrate, since it makes
>> Surefire more
>> reliable (not relying on the way multiple "-Dmyprop=" is handled)
>>
>> Then there should just be a Jira issue created, and this fix integrated to
>> Surefire master without waiting, isn't it?
>>
>> Or do you fear that this change can have unexpected impact?
>>
>> Regards,
>>
>> Hervé
>>
>> Le jeudi 16 février 2017, 17:42:07 CET tibordig...@apache.org a écrit :
>> > Repository: maven-surefire
>> > Updated Branches:
>> >   refs/heads/SUREFIRE_SYSPROP_DUPLICATES [created] ef5b0f460
>> >
>> >
>> > SUREFIRE_SYSPROP_DUPLICATES
>> >
>> >
>> > Project: http://git-wip-us.apache.org/repos/asf/maven-surefire/repo
>> > Commit:
>> > http://git-wip-us.apache.org/repos/asf/maven-surefire/commit/ef5b0f46
>> Tree:
>> > http://git-wip-us.apache.org/repos/asf/maven-surefire/tree/ef5b0f46
>> Diff:
>> > http://git-wip-us.apache.org/repos/asf/maven-surefire/diff/ef5b0f46
>> >
>> > Branch: refs/heads/SUREFIRE_SYSPROP_DUPLICATES
>> > Commit: ef5b0f460021ad6f827d75cde38f888f37a54415
>> > Parents: 179abbf
>> > Author: Tibor17 
>> > Authored: Thu Feb 16 18:40:45 2017 +0100
>> > Committer: Tibor17 
>> > Committed: Thu Feb 16 18:40:45 2017 +0100
>> >
>> > --
>> >  .../surefire/its/fixture/MavenLauncher.java | 45
>> ---
>> >  .../surefire/its/fixture/MavenLauncherTest.java | 47
>> 
>> >  .../surefire/its/fixture/SurefireLauncher.java  |  6 +--
>> >  3 files changed, 88 insertions(+), 10 deletions(-)
>> > --
>> >
>> >
>> > http://git-wip-us.apache.org/repos/asf/maven-surefire/blob/e
>> f5b0f46/surefire
>> > -integration-tests/src/test/java/org/apache/maven/surefire/
>> its/fixture/Maven
>> > Launcher.java
>> > --
>> diff
>> > --git
>> > a/surefire-integration-tests/src/test/java/org/apache/maven/
>> surefire/its/fi
>> > xture/MavenLauncher.java
>> > b/surefire-integration-tests/src/test/java/org/apache/maven/
>> surefire/its/fi
>> > xture/MavenLauncher.java index 1198fcb..0945068 100755
>> > ---
>> > a/surefire-integration-tests/src/test/java/org/apache/maven/
>> surefire/its/fi
>> > xture/MavenLauncher.java +++
>> > b/surefire-integration-tests/src/test/java/org/apache/maven/
>> surefire/its/fi
>> > xture/MavenLauncher.java @@ -19,18 +19,22 @@ package
>> > org.apache.maven.surefire.its.fixture; * under the License.
>> >   */
>> >
>> > +import org.apache.commons.lang.text.StrSubstitutor;
>> > +import org.apache.maven.it.VerificationException;
>> > +import org.apache.maven.it.Verifier;
>> > +import org.apache.maven.it.util.ResourceExtractor;
>> > +import org.apache.maven.shared.utils.io.FileUtils;
>> > +
>> >  import java.io.File;
>> >  import java.io.IOException;
>> >  import java.net.URL;
>> >  import java.util.ArrayList;
>> >  import java.util.HashMap;
>> >  import java.util.List;
>> > +import java.util.ListIterator;
>> >  import java.util.Map;
>> > -import org.apache.commons.lang.text.StrSubstitutor;
>> > -import org.apache.maven.it.VerificationException;
>> > -import org.apache.maven.it.Verifier;
>> > -import org.apache.maven.it.util.ResourceExtractor;
>> > -import org.apache.maven.shared.utils.io.FileUtils;
>> > +
>> > +import static java.util.Collections.unmodifiableList;
>> >
>> >  /**
>> >   * Encapsulate all needed features to start a maven run
>> > @@ -203,13 +207,13 @@ public class MavenLauncher
>> >
>> >  public MavenLauncher skipClean()
>> >  {
>> > -goals.add( "-Dclean.skip=true" );
>> > +writeGoal( "-Dclean.skip=true" );
>> >  return this;
>> >  }
>> >
>> >  public MavenLauncher addGoal( String goal )
>> >  {
>> > -goals.add( goal );
>> > +writeGoal( goal );
>> >  return this;
>> >  }
>> >
>> > @@ -223,6 +227,33 @@ public class MavenLauncher
>> >  return conditionalExec( "test" );
>> >  }
>> >
>> > +List getGoals()
>> > +{
>> > +return unmodifiableList( goals );
>> > +}
>> > +
>> > +private void writeGoal( String newGoal )
>> > +{
>> > +if ( newGoal != null && newGoal.startsWith( "-D" ) )
>> > +{
>> > +final String sysPropKey =
>>

Re: maven-surefire git commit: SUREFIRE_SYSPROP_DUPLICATES

2017-02-18 Thread Tibor Digana 
I am waiting for Michael's "go on".
There are 58 TestNG ITs and this is not nice fix, however it is god but the
rootcause is that surefire-integration-tests POM has testng default version
5.7 and that is the roortcause of system prop duplicates. I need to find
someone who will update 58 tests after we and Michael says that the build
is passed.
Let's see what Stephan's build on Mac says.
Fixing 58 test can be done later, does not block Maven.


On Sat, Feb 18, 2017 at 12:25 PM, Hervé BOUTEMY 
wrote:

> IIUC, this one is a good enhancement to integrate, since it makes Surefire
> more
> reliable (not relying on the way multiple "-Dmyprop=" is handled)
>
> Then there should just be a Jira issue created, and this fix integrated to
> Surefire master without waiting, isn't it?
>
> Or do you fear that this change can have unexpected impact?
>
> Regards,
>
> Hervé
>
> Le jeudi 16 février 2017, 17:42:07 CET tibordig...@apache.org a écrit :
> > Repository: maven-surefire
> > Updated Branches:
> >   refs/heads/SUREFIRE_SYSPROP_DUPLICATES [created] ef5b0f460
> >
> >
> > SUREFIRE_SYSPROP_DUPLICATES
> >
> >
> > Project: http://git-wip-us.apache.org/repos/asf/maven-surefire/repo
> > Commit:
> > http://git-wip-us.apache.org/repos/asf/maven-surefire/commit/ef5b0f46
> Tree:
> > http://git-wip-us.apache.org/repos/asf/maven-surefire/tree/ef5b0f46
> Diff:
> > http://git-wip-us.apache.org/repos/asf/maven-surefire/diff/ef5b0f46
> >
> > Branch: refs/heads/SUREFIRE_SYSPROP_DUPLICATES
> > Commit: ef5b0f460021ad6f827d75cde38f888f37a54415
> > Parents: 179abbf
> > Author: Tibor17 
> > Authored: Thu Feb 16 18:40:45 2017 +0100
> > Committer: Tibor17 
> > Committed: Thu Feb 16 18:40:45 2017 +0100
> >
> > --
> >  .../surefire/its/fixture/MavenLauncher.java | 45
> ---
> >  .../surefire/its/fixture/MavenLauncherTest.java | 47
> 
> >  .../surefire/its/fixture/SurefireLauncher.java  |  6 +--
> >  3 files changed, 88 insertions(+), 10 deletions(-)
> > --
> >
> >
> > http://git-wip-us.apache.org/repos/asf/maven-surefire/blob/
> ef5b0f46/surefire
> > -integration-tests/src/test/java/org/apache/maven/
> surefire/its/fixture/Maven
> > Launcher.java
> > --
> diff
> > --git
> > a/surefire-integration-tests/src/test/java/org/apache/
> maven/surefire/its/fi
> > xture/MavenLauncher.java
> > b/surefire-integration-tests/src/test/java/org/apache/
> maven/surefire/its/fi
> > xture/MavenLauncher.java index 1198fcb..0945068 100755
> > ---
> > a/surefire-integration-tests/src/test/java/org/apache/
> maven/surefire/its/fi
> > xture/MavenLauncher.java +++
> > b/surefire-integration-tests/src/test/java/org/apache/
> maven/surefire/its/fi
> > xture/MavenLauncher.java @@ -19,18 +19,22 @@ package
> > org.apache.maven.surefire.its.fixture; * under the License.
> >   */
> >
> > +import org.apache.commons.lang.text.StrSubstitutor;
> > +import org.apache.maven.it.VerificationException;
> > +import org.apache.maven.it.Verifier;
> > +import org.apache.maven.it.util.ResourceExtractor;
> > +import org.apache.maven.shared.utils.io.FileUtils;
> > +
> >  import java.io.File;
> >  import java.io.IOException;
> >  import java.net.URL;
> >  import java.util.ArrayList;
> >  import java.util.HashMap;
> >  import java.util.List;
> > +import java.util.ListIterator;
> >  import java.util.Map;
> > -import org.apache.commons.lang.text.StrSubstitutor;
> > -import org.apache.maven.it.VerificationException;
> > -import org.apache.maven.it.Verifier;
> > -import org.apache.maven.it.util.ResourceExtractor;
> > -import org.apache.maven.shared.utils.io.FileUtils;
> > +
> > +import static java.util.Collections.unmodifiableList;
> >
> >  /**
> >   * Encapsulate all needed features to start a maven run
> > @@ -203,13 +207,13 @@ public class MavenLauncher
> >
> >  public MavenLauncher skipClean()
> >  {
> > -goals.add( "-Dclean.skip=true" );
> > +writeGoal( "-Dclean.skip=true" );
> >  return this;
> >  }
> >
> >  public MavenLauncher addGoal( String goal )
> >  {
> > -goals.add( goal );
> > +writeGoal( goal );
> >  return this;
> >  }
> >
> > @@ -223,6 +227,33 @@ public class MavenLauncher
> >  return conditionalExec( "test" );
> >  }
> >
> > +List getGoals()
> > +{
> > +return unmodifiableList( goals );
> > +}
> > +
> > +private void writeGoal( String newGoal )
> > +{
> > +if ( newGoal != null && newGoal.startsWith( "-D" ) )
> > +{
> > +final String sysPropKey =
> > +newGoal.contains( "=" ) ? newGoal.substring( 0,
> > newGoal.indexOf( '=' ) ) : newGoal; +
> > +final String sysPropStarter = sysPropKey + "=";
> > +
> > +for ( ListIterator it = goals.listIterator();
> > it.hasNex

Re: maven-surefire git commit: SUREFIRE_SYSPROP_DUPLICATES

2017-02-18 Thread Hervé BOUTEMY 
IIUC, this one is a good enhancement to integrate, since it makes Surefire more 
reliable (not relying on the way multiple "-Dmyprop=" is handled)

Then there should just be a Jira issue created, and this fix integrated to 
Surefire master without waiting, isn't it?

Or do you fear that this change can have unexpected impact?

Regards,

Hervé

Le jeudi 16 février 2017, 17:42:07 CET tibordig...@apache.org a écrit :
> Repository: maven-surefire
> Updated Branches:
>   refs/heads/SUREFIRE_SYSPROP_DUPLICATES [created] ef5b0f460
> 
> 
> SUREFIRE_SYSPROP_DUPLICATES
> 
> 
> Project: http://git-wip-us.apache.org/repos/asf/maven-surefire/repo
> Commit:
> http://git-wip-us.apache.org/repos/asf/maven-surefire/commit/ef5b0f46 Tree:
> http://git-wip-us.apache.org/repos/asf/maven-surefire/tree/ef5b0f46 Diff:
> http://git-wip-us.apache.org/repos/asf/maven-surefire/diff/ef5b0f46
> 
> Branch: refs/heads/SUREFIRE_SYSPROP_DUPLICATES
> Commit: ef5b0f460021ad6f827d75cde38f888f37a54415
> Parents: 179abbf
> Author: Tibor17 
> Authored: Thu Feb 16 18:40:45 2017 +0100
> Committer: Tibor17 
> Committed: Thu Feb 16 18:40:45 2017 +0100
> 
> --
>  .../surefire/its/fixture/MavenLauncher.java | 45 ---
>  .../surefire/its/fixture/MavenLauncherTest.java | 47 
>  .../surefire/its/fixture/SurefireLauncher.java  |  6 +--
>  3 files changed, 88 insertions(+), 10 deletions(-)
> --
> 
> 
> http://git-wip-us.apache.org/repos/asf/maven-surefire/blob/ef5b0f46/surefire
> -integration-tests/src/test/java/org/apache/maven/surefire/its/fixture/Maven
> Launcher.java
> -- diff
> --git
> a/surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/fi
> xture/MavenLauncher.java
> b/surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/fi
> xture/MavenLauncher.java index 1198fcb..0945068 100755
> ---
> a/surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/fi
> xture/MavenLauncher.java +++
> b/surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/fi
> xture/MavenLauncher.java @@ -19,18 +19,22 @@ package
> org.apache.maven.surefire.its.fixture; * under the License.
>   */
> 
> +import org.apache.commons.lang.text.StrSubstitutor;
> +import org.apache.maven.it.VerificationException;
> +import org.apache.maven.it.Verifier;
> +import org.apache.maven.it.util.ResourceExtractor;
> +import org.apache.maven.shared.utils.io.FileUtils;
> +
>  import java.io.File;
>  import java.io.IOException;
>  import java.net.URL;
>  import java.util.ArrayList;
>  import java.util.HashMap;
>  import java.util.List;
> +import java.util.ListIterator;
>  import java.util.Map;
> -import org.apache.commons.lang.text.StrSubstitutor;
> -import org.apache.maven.it.VerificationException;
> -import org.apache.maven.it.Verifier;
> -import org.apache.maven.it.util.ResourceExtractor;
> -import org.apache.maven.shared.utils.io.FileUtils;
> +
> +import static java.util.Collections.unmodifiableList;
> 
>  /**
>   * Encapsulate all needed features to start a maven run
> @@ -203,13 +207,13 @@ public class MavenLauncher
> 
>  public MavenLauncher skipClean()
>  {
> -goals.add( "-Dclean.skip=true" );
> +writeGoal( "-Dclean.skip=true" );
>  return this;
>  }
> 
>  public MavenLauncher addGoal( String goal )
>  {
> -goals.add( goal );
> +writeGoal( goal );
>  return this;
>  }
> 
> @@ -223,6 +227,33 @@ public class MavenLauncher
>  return conditionalExec( "test" );
>  }
> 
> +List getGoals()
> +{
> +return unmodifiableList( goals );
> +}
> +
> +private void writeGoal( String newGoal )
> +{
> +if ( newGoal != null && newGoal.startsWith( "-D" ) )
> +{
> +final String sysPropKey =
> +newGoal.contains( "=" ) ? newGoal.substring( 0,
> newGoal.indexOf( '=' ) ) : newGoal; +
> +final String sysPropStarter = sysPropKey + "=";
> +
> +for ( ListIterator it = goals.listIterator();
> it.hasNext(); ) +{
> +String goal = it.next();
> +if ( goal.equals( sysPropKey ) || goal.startsWith(
> sysPropStarter ) ) +{
> +it.set( newGoal );
> +return;
> +}
> +}
> +}
> +goals.add( newGoal );
> +}
> +
>  private OutputValidator conditionalExec(String goal)
>  {
>  OutputValidator verify;
> 
> http://git-wip-us.apache.org/repos/asf/maven-surefire/blob/ef5b0f46/surefire
> -integration-tests/src/test/java/org/apache/maven/surefire/its/fixture/Maven
> LauncherTest.java
> -- diff
> --git
> a/surefire-integration-tests/src/te