On Mon, 1 May 2006, Brett Porter wrote: > ok, see now that the issue was closed. > > I'm not sure how you see the "old style" tests as cleaner. What makes > the new ones less clean in your opinion? The IT's are certainly not unit > tests (the plugin framework tests are only just barely units > themselves), and significantly slower to run.
True, unless we use the maven-it-plugin. Haven't really gotten around to applying that to plugins. The fact that they're cleaner is that you now only have small project with a minimal pom that describes exactly what you need to reproduce the problem. You can directly run maven on it to see what goes wrong. I find that the plumbing required for the new testcases duplicates too much maven core code (from the first glances) - most code is for setting up a trivial project, and you have to read the sources carefully to extract how this would map onto a real pom. It's hard to immediately see what is tested exactly. Given that, I first thought this problem had something to do with general resource and filter handling and so needed an integration test. As it turns out, this case could be tested using just a unit test on the Mojo itself since it only applies to POM fields that don't get any special processing from Maven. So I'll convert it, and have a closer look. Maybe then I can demonstrate my concerns better, or get convinced :) -- Kenney > > - Brett > > Brett Porter wrote: > > [EMAIL PROTECTED] wrote: > >> Author: kenney > >> Date: Sun Apr 30 15:01:04 2006 > >> New Revision: 398452 > >> > >> URL: http://svn.apache.org/viewcvs?rev=398452&view=rev > >> Log: > >> Added testcase for MRESOURCES-18. This should really go into > >> the resources-plugin itself using the new framework, but committing > >> anyway for future reference and regression testing. > >> > > > > Given that, maybe its better to roll it back out and attach it to the > > jira instead? > > > > - Brett > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > -- Kenney Westerhof http://www.neonics.com GPG public key: http://www.gods.nl/~forge/kenneyw.key --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
