Re: bug MNG-5459 (failure to resolve pom artifact from snapshotVersion in maven-metadata.xml)
At Sat, 24 Aug 2013 16:40:57 +0200, Robert Scholte wrote: Hi Claudio, my holidays are over, so time to have a look at this. I've attached a testcase to the original issue, but I'm not able to reproduce it. Your testcase works fine for me. That is, after I fixed the maven-metadata.xml file that somehow got truncated - which probably reveals another bug: After applying your patch, I also only got the -SNAPSHOT version. While investigating, I found that there were 2 exceptions stored inside the versionResult in DefaultArtifactResolver.java:318: -- [0] MetadataNotFoundException Could not find metadata org.apache.maven.its:dep-mng5459:0.4.0-SNAPSHOT/maven-metadata.xml in local ([...]\maven-aether-provider\target\local-repo) [1] EOFException no more data available - expected end tag /metadata to close start tag metadata from line 22, parser stopped on END_TAG seen .../versioning\n\n... @48:1 -- But the result was used happily further on, although the maven-metadata.xml was never read since the document end tag was missing. IMO, it makes no sense to use a result with /attached/ exceptions, but I may be missing something here. Here's the output of the test run after I added the /metadata tag: expected:[@todo] but was:[Could not find artifact org.apache.maven.its:dep-mng5459:pom:0.4.0-20130404.093655-3 in repo [...] With my patch applied, this changes to: expected:[@todo] but was:[Could not find artifact org.apache.maven.its:dep-mng5459:pom:0.4.0-20130404.090532-2 in repo Claudio -- AV-Test GmbH, Henricistraße 20, 04155 Leipzig, Germany Phone: +49 341 265 310 19 Web:http://www.av-test.org Eingetragen am / Registered at: Amtsgericht Stendal (HRB 114076) Geschaeftsfuehrer (CEO): Andreas Marx, Guido Habicht, Maik Morgenstern - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: bug MNG-5459 (failure to resolve pom artifact from snapshotVersion in maven-metadata.xml)
Duh, a bad copy/paste without any alarmbells from my IDE Thanks, it's fixed Robert Op Mon, 26 Aug 2013 12:50:36 +0200 schreef Claudio Bley cb...@av-test.de: At Sat, 24 Aug 2013 16:40:57 +0200, Robert Scholte wrote: Hi Claudio, my holidays are over, so time to have a look at this. I've attached a testcase to the original issue, but I'm not able to reproduce it. Your testcase works fine for me. That is, after I fixed the maven-metadata.xml file that somehow got truncated - which probably reveals another bug: After applying your patch, I also only got the -SNAPSHOT version. While investigating, I found that there were 2 exceptions stored inside the versionResult in DefaultArtifactResolver.java:318: -- [0] MetadataNotFoundException Could not find metadata org.apache.maven.its:dep-mng5459:0.4.0-SNAPSHOT/maven-metadata.xml in local ([...]\maven-aether-provider\target\local-repo) [1] EOFException no more data available - expected end tag /metadata to close start tag metadata from line 22, parser stopped on END_TAG seen .../versioning\n\n... @48:1 -- But the result was used happily further on, although the maven-metadata.xml was never read since the document end tag was missing. IMO, it makes no sense to use a result with /attached/ exceptions, but I may be missing something here. Here's the output of the test run after I added the /metadata tag: expected:[@todo] but was:[Could not find artifact org.apache.maven.its:dep-mng5459:pom:0.4.0-20130404.093655-3 in repo [...] With my patch applied, this changes to: expected:[@todo] but was:[Could not find artifact org.apache.maven.its:dep-mng5459:pom:0.4.0-20130404.090532-2 in repo Claudio - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: bug MNG-5459 (failure to resolve pom artifact from snapshotVersion in maven-metadata.xml)
Hi Claudio, my holidays are over, so time to have a look at this. I've attached a testcase to the original issue, but I'm not able to reproduce it. I'm not going to apply the 'fix', since I can't confirm the issue so I can't verify the patch. And we're talking about an important part of Maven, so let's have a working test first to ensure we're not doing any damage. So yes: you could help with that last part of the test. Thanks, Robert Op Thu, 15 Aug 2013 15:58:27 +0200 schreef Claudio Bley cb...@av-test.de: Hi Robert, At Thu, 02 May 2013 19:34:07 +0200, Robert Scholte wrote: Hi Claudio, I've had a look at it, because it looks like a simple fix. But first I had to write a unit-test to confirm the issue, but I haven't succeeded (yet). Any progress on this? I'd like to get this off my bug list. Maybe I can give you a hand? So that part is still required before we can apply this patch. Or, is it possible to relax the rules a bit this time, as writing a unit test seems to be far more involved than reasoning about the (simple) fix? Claudio - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: bug MNG-5459 (failure to resolve pom artifact from snapshotVersion in maven-metadata.xml)
Hi Robert, At Thu, 02 May 2013 19:34:07 +0200, Robert Scholte wrote: Hi Claudio, I've had a look at it, because it looks like a simple fix. But first I had to write a unit-test to confirm the issue, but I haven't succeeded (yet). Any progress on this? I'd like to get this off my bug list. Maybe I can give you a hand? So that part is still required before we can apply this patch. Or, is it possible to relax the rules a bit this time, as writing a unit test seems to be far more involved than reasoning about the (simple) fix? Claudio -- AV-Test GmbH, Henricistraße 20, 04155 Leipzig, Germany Phone: +49 341 265 310 19 Web:http://www.av-test.org Eingetragen am / Registered at: Amtsgericht Stendal (HRB 114076) Geschaeftsfuehrer (CEO): Andreas Marx, Guido Habicht, Maik Morgenstern - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
bug MNG-5459 (failure to resolve pom artifact from snapshotVersion in maven-metadata.xml)
Hi. I wonder what is the right workflow for reporting maven issues, because I did report an issue to https://jira.codehaus.org/browse/MNG-5459 almost a month ago, but nobody seems to react upon it. I also provided a patch which I think fixes the issue. What's the deal? Is it better to directly report to this list? Thanks! -- AV-Test GmbH, Henricistraße 20, 04155 Leipzig, Germany Phone: +49 341 265 310 19 Web:http://www.av-test.org Eingetragen am / Registered at: Amtsgericht Stendal (HRB 114076) Geschaeftsfuehrer (CEO): Andreas Marx, Guido Habicht, Maik Morgenstern - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: bug MNG-5459 (failure to resolve pom artifact from snapshotVersion in maven-metadata.xml)
Hi Claudio, I've had a look at it, because it looks like a simple fix. But first I had to write a unit-test to confirm the issue, but I haven't succeeded (yet). So that part is still required before we can apply this patch. thanks, Robert Op Thu, 02 May 2013 10:50:07 +0200 schreef Claudio Bley cb...@av-test.de: Hi. I wonder what is the right workflow for reporting maven issues, because I did report an issue to https://jira.codehaus.org/browse/MNG-5459 almost a month ago, but nobody seems to react upon it. I also provided a patch which I think fixes the issue. What's the deal? Is it better to directly report to this list? Thanks! - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
