Re: maven-pmd-plugin next version? (PMD 7 Upgrade)
Am 2024-04-05 um 21:42 schrieb Andreas Dangel: Hi all, I'd like to hear your opinions about [1] / [2]: Adding support for PMD 7, which is a major version upgrade from PMD 6.55.0, might impact end-users under certain conditions: If they use custom rulesets and use a rule, which no longer exists or has been replaced, they need to update their rulesets so that it will be working with PMD 7. Or if they have written custom rules. Using PMD 7 however, enables support for Java 21. Upgrading PMD in m-pm-p would bring this to all users. While m-pmd-p itself didn't change much (e.g. the maven configs are still valid), the underlying PMD of course did (and therefore any custom rulesets might need to be updated). This fact, that there might be changes needed when upgrading, will be added on the plugin documentation page [3] under "Upgrading notes" (part of PR 144). The question is now: Should the next version of m-pmd-p be called 3.22.0 or 4.0.0? Looking that the PR (which I reviewed) I consider 3.22.0 as totally fine. All necessary information has been provided to the user. Michael - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: maven-pmd-plugin next version? (PMD 7 Upgrade)
Hey, I see benefit in upgrading to PMD 7, users have to adjust their rulesets from time to time anyway. I had to upgrade the on from my team when trying (and failing ^^) to upgrade vom maven-pmd-plugin sub 2.14 to 2.21 too due changed/deprecated rules. >The question is now: Should the next version of m-pmd-p be called 3.22.0 or 4.0.0? There was a discussion the list that maven plugins should start with a 4 when they are upgraded to the Maven 4 plugin API (I hope the wording is correctly). So if this is not the case (and "only" the PMD version") is listed I would argue to not call it 4.0.0 but 3.3.1 (to show the bump of PMD via minor version). Greetings Matthias Am 05.04.2024 um 21:42 schrieb Andreas Dangel: Hi all, I'd like to hear your opinions about [1] / [2]: Adding support for PMD 7, which is a major version upgrade from PMD 6.55.0, might impact end-users under certain conditions: If they use custom rulesets and use a rule, which no longer exists or has been replaced, they need to update their rulesets so that it will be working with PMD 7. Or if they have written custom rules. Using PMD 7 however, enables support for Java 21. Upgrading PMD in m-pm-p would bring this to all users. While m-pmd-p itself didn't change much (e.g. the maven configs are still valid), the underlying PMD of course did (and therefore any custom rulesets might need to be updated). This fact, that there might be changes needed when upgrading, will be added on the plugin documentation page [3] under "Upgrading notes" (part of PR 144). The question is now: Should the next version of m-pmd-p be called 3.22.0 or 4.0.0? If there are no objections, I would merge PR 144 and start a release of m-pmd-p as 3.22.0 some time next week. Thanks, Andreas [1]: https://github.com/apache/maven-pmd-plugin/pull/144 [2]: https://issues.apache.org/jira/browse/MPMD-379 [3]: https://maven.apache.org/plugins/maven-pmd-plugin/index.html - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
maven-pmd-plugin next version? (PMD 7 Upgrade)
Hi all, I'd like to hear your opinions about [1] / [2]: Adding support for PMD 7, which is a major version upgrade from PMD 6.55.0, might impact end-users under certain conditions: If they use custom rulesets and use a rule, which no longer exists or has been replaced, they need to update their rulesets so that it will be working with PMD 7. Or if they have written custom rules. Using PMD 7 however, enables support for Java 21. Upgrading PMD in m-pm-p would bring this to all users. While m-pmd-p itself didn't change much (e.g. the maven configs are still valid), the underlying PMD of course did (and therefore any custom rulesets might need to be updated). This fact, that there might be changes needed when upgrading, will be added on the plugin documentation page [3] under "Upgrading notes" (part of PR 144). The question is now: Should the next version of m-pmd-p be called 3.22.0 or 4.0.0? If there are no objections, I would merge PR 144 and start a release of m-pmd-p as 3.22.0 some time next week. Thanks, Andreas [1]: https://github.com/apache/maven-pmd-plugin/pull/144 [2]: https://issues.apache.org/jira/browse/MPMD-379 [3]: https://maven.apache.org/plugins/maven-pmd-plugin/index.html - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
