Re: svn commit: r546719 - /maven/core-integration-testing/trunk/core-integration-tests/src/test/java/org/apache/maven/integrationtests/MavenIT0002Test.java
On 19/06/07, Jason van Zyl <[EMAIL PROTECTED]> wrote: If you do "mvn install" in the parent IT directory all the plugins and artifacts required will be installed and the ITs will pass. I'm sure we're crossing wires here: [EMAIL PROTECTED] core-integration-testing]$ mvn install ... [EMAIL PROTECTED] core-integration-testing]$ cd core-integration-tests [EMAIL PROTECTED] core-integration-tests]$ mvn test ... --- T E S T S --- Running org.apache.maven.integrationtests.IntegrationTestSuite Running integration tests for Maven 2.0.8-SNAPSHOT (testit).. Ok 0001(testit0001).. Ok 0002(testit0002).. Failure From core-integration-testing/core-integration-tests/target/test-classes/it0002/log.txt: + Error stacktraces are turned on. [INFO] Scanning for projects... [INFO] Searching repository for plugin with prefix: 'clean'. [INFO] [INFO] Building Maven Integration Test :: it0002 [INFO]task-segment: [clean:clean, package] [INFO] [INFO] [clean:clean] [INFO] Deleting directory c:\core-integration-testing\core-integration-tests\target\test-classes\it0002\target [INFO] Deleting directory c:\core-integration-testing\core-integration-tests\target\test-classes\it0002\target\classes [INFO] Deleting directory c:\core-integration-testing\core-integration-tests\target\test-classes\it0002\target\test-classes [INFO] Deleting directory c:\core-integration-testing\core-integration-tests\target\test-classes\it0002\target\site [INFO] [resources:resources] [INFO] Using default encoding to copy filtered resources. Downloading: http://maven.iizuka.co.uk//org/apache/maven/its/maven-core-it-support/1.0/maven-core-it-support-1.0.jar Downloading: http://repo1.maven.org/maven2/org/apache/maven/its/maven-core-it-support/1.0/maven-core-it-support-1.0.jar [INFO] [ERROR] BUILD ERROR [INFO] [INFO] Failed to resolve artifact. Missing: -- 1) org.apache.maven.its:maven-core-it-support:jar:1.0 ... Path to dependency: 1) org.apache.maven.its.it0002:maven-it-it0002:jar:1.0 2) org.apache.maven.its:maven-core-it-support:jar:1.0 ... Which doesn't surprise me since it0002 does: verifier.deleteArtifact( "org.apache.maven.its", "maven-core-it-support", "1.0", "jar" ); verifier.executeGoal( "package" ); ... verifier.assertArtifactPresent( "org.apache.maven.its", "maven-core-it-support", "1.0", "jar" ); And hence expects org.apache.maven.its:maven-core-it-support:jar:1.0 to be downloaded from a remote repo after the test deletes it from the local repo. Not sure why others aren't experiencing this? Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r546719 - /maven/core-integration-testing/trunk/core-integration-tests/src/test/java/org/apache/maven/integrationtests/MavenIT0002Test.java
On 19 Jun 07, at 8:39 AM 19 Jun 07, Mark Hobson wrote: On 19/06/07, Jason van Zyl <[EMAIL PROTECTED]> wrote: You have to run the outter build first and what we want ultimately is use a test remote repository before the ITs run. We have a problem with them being coupled to the real central. The ITs should ultimately be completely self contained. So that's what I'm moving toward so there are for certain some inconsistencies while I move that way. Anything you see like that the plan is to start from nothing, populate the test remote repository with the IT plugins and artifacts and then run the ITs. The old versions of the ITs artifacts were deployed to central and the new ones I did not so you're going to find some glitches. The overriding concern is the make it self contained. To use a file based remote repository first, then the next stage would be to use the ITs with a test web-based repository, then FTP ... you see where I'm going. Get the base ITs going and then test all our transports, test all our SCM providers ... Take a look at the notes in the IT directory. We have production plugins coupled with many ITs and in each of those listed cases test plugins should be made. Specific tests of a give plugin should be ITs in that particular plugin. I'm sure you're going to find some problems but that's the general plan. So even if you sketch out a bash/ruby script to setup the test repo before running that's the kind of work we need to get done. Okay, I can see the direction you're heading towards with making the ITs self-contained, I just wanted to make sure it wasn't failing due to my local set up. I can live with a failing it0002 for now. If you do "mvn install" in the parent IT directory all the plugins and artifacts required will be installed and the ITs will pass. Cheers, Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] Thanks, Jason -- Jason van Zyl Founder and PMC Chair, Apache Maven jason at sonatype dot com -- - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r546719 - /maven/core-integration-testing/trunk/core-integration-tests/src/test/java/org/apache/maven/integrationtests/MavenIT0002Test.java
On 19/06/07, Jason van Zyl <[EMAIL PROTECTED]> wrote: You have to run the outter build first and what we want ultimately is use a test remote repository before the ITs run. We have a problem with them being coupled to the real central. The ITs should ultimately be completely self contained. So that's what I'm moving toward so there are for certain some inconsistencies while I move that way. Anything you see like that the plan is to start from nothing, populate the test remote repository with the IT plugins and artifacts and then run the ITs. The old versions of the ITs artifacts were deployed to central and the new ones I did not so you're going to find some glitches. The overriding concern is the make it self contained. To use a file based remote repository first, then the next stage would be to use the ITs with a test web-based repository, then FTP ... you see where I'm going. Get the base ITs going and then test all our transports, test all our SCM providers ... Take a look at the notes in the IT directory. We have production plugins coupled with many ITs and in each of those listed cases test plugins should be made. Specific tests of a give plugin should be ITs in that particular plugin. I'm sure you're going to find some problems but that's the general plan. So even if you sketch out a bash/ruby script to setup the test repo before running that's the kind of work we need to get done. Okay, I can see the direction you're heading towards with making the ITs self-contained, I just wanted to make sure it wasn't failing due to my local set up. I can live with a failing it0002 for now. Cheers, Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r546719 - /maven/core-integration-testing/trunk/core-integration-tests/src/test/java/org/apache/maven/integrationtests/MavenIT0002Test.java
On 19 Jun 07, at 6:20 AM 19 Jun 07, Mark Hobson wrote: On 15/06/07, Jason van Zyl <[EMAIL PROTECTED]> wrote: > On 15/06/07, Jason van Zyl <[EMAIL PROTECTED]> wrote: >> If you install the artifacts you'll be fine. The invoker plugin broke >> which is why they are not installed. You can't simply run the ITs, >> you must install the plugins and artifacts that are used as part of >> the ITs. >> >> As I go through and find them I update them, but there is still a >> mixture of some old in there. Ideally the goal is to be able to start >> with nothing, install the artifacts required for running the ITs, and >> then run the ITs. So if you see things that aren't updated then fix >> them. >> >> This should ultimately become self-contained: >> >> http://svn.apache.org/repos/asf/maven/core-integration-testing/ trunk/ >> >> Without any requirement for anything to be installed in a remote >> repository. See the IT problem notes for details. > > Right. Should the rest of it0002 not be aligned with the new group id > too? Yes, just align them if you see they are wrong. I'm still unsure quite how it0002 is meant to pass without core-integration-testing-support being deployed to the remote repo under the new groupId. I run: You have to run the outter build first and what we want ultimately is use a test remote repository before the ITs run. We have a problem with them being coupled to the real central. The ITs should ultimately be completely self contained. So that's what I'm moving toward so there are for certain some inconsistencies while I move that way. Anything you see like that the plan is to start from nothing, populate the test remote repository with the IT plugins and artifacts and then run the ITs. The old versions of the ITs artifacts were deployed to central and the new ones I did not so you're going to find some glitches. The overriding concern is the make it self contained. To use a file based remote repository first, then the next stage would be to use the ITs with a test web-based repository, then FTP ... you see where I'm going. Get the base ITs going and then test all our transports, test all our SCM providers ... Take a look at the notes in the IT directory. We have production plugins coupled with many ITs and in each of those listed cases test plugins should be made. Specific tests of a give plugin should be ITs in that particular plugin. I'm sure you're going to find some problems but that's the general plan. So even if you sketch out a bash/ruby script to setup the test repo before running that's the kind of work we need to get done. core-integration-testing/core-integration-testing-support/build.sh core-integration-testing/run-its.sh And it0002 fails since it cannot download org.apache.maven.its:maven-core-it-support:jar:1.0. This is understandable since the test deletes the copy in the local repo installed by build.sh, and then expects it to be downloaded from the remote repo which doesn't exist: http://mirrors.ibiblio.org/pub/mirrors/maven2/org/apache/maven/its/ Should we not redeploy core-integration-testing-support to the remote repo? Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] Thanks, Jason -- Jason van Zyl Founder and PMC Chair, Apache Maven jason at sonatype dot com -- - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r546719 - /maven/core-integration-testing/trunk/core-integration-tests/src/test/java/org/apache/maven/integrationtests/MavenIT0002Test.java
On 15/06/07, Jason van Zyl <[EMAIL PROTECTED]> wrote: > On 15/06/07, Jason van Zyl <[EMAIL PROTECTED]> wrote: >> If you install the artifacts you'll be fine. The invoker plugin broke >> which is why they are not installed. You can't simply run the ITs, >> you must install the plugins and artifacts that are used as part of >> the ITs. >> >> As I go through and find them I update them, but there is still a >> mixture of some old in there. Ideally the goal is to be able to start >> with nothing, install the artifacts required for running the ITs, and >> then run the ITs. So if you see things that aren't updated then fix >> them. >> >> This should ultimately become self-contained: >> >> http://svn.apache.org/repos/asf/maven/core-integration-testing/trunk/ >> >> Without any requirement for anything to be installed in a remote >> repository. See the IT problem notes for details. > > Right. Should the rest of it0002 not be aligned with the new group id > too? Yes, just align them if you see they are wrong. I'm still unsure quite how it0002 is meant to pass without core-integration-testing-support being deployed to the remote repo under the new groupId. I run: core-integration-testing/core-integration-testing-support/build.sh core-integration-testing/run-its.sh And it0002 fails since it cannot download org.apache.maven.its:maven-core-it-support:jar:1.0. This is understandable since the test deletes the copy in the local repo installed by build.sh, and then expects it to be downloaded from the remote repo which doesn't exist: http://mirrors.ibiblio.org/pub/mirrors/maven2/org/apache/maven/its/ Should we not redeploy core-integration-testing-support to the remote repo? Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r546719 - /maven/core-integration-testing/trunk/core-integration-tests/src/test/java/org/apache/maven/integrationtests/MavenIT0002Test.java
On 15 Jun 07, at 6:33 AM 15 Jun 07, Mark Hobson wrote: On 15/06/07, Jason van Zyl <[EMAIL PROTECTED]> wrote: If you install the artifacts you'll be fine. The invoker plugin broke which is why they are not installed. You can't simply run the ITs, you must install the plugins and artifacts that are used as part of the ITs. As I go through and find them I update them, but there is still a mixture of some old in there. Ideally the goal is to be able to start with nothing, install the artifacts required for running the ITs, and then run the ITs. So if you see things that aren't updated then fix them. This should ultimately become self-contained: http://svn.apache.org/repos/asf/maven/core-integration-testing/trunk/ Without any requirement for anything to be installed in a remote repository. See the IT problem notes for details. Right. Should the rest of it0002 not be aligned with the new group id too? Yes, just align them if you see they are wrong. See: core-integration-tests/src/test/java/org/apache/maven/ integrationtests/MavenIT0002Test.java -verifier.deleteArtifact( "org.apache.maven", "maven-core-it-support", "1.0", "jar" ); +verifier.deleteArtifact( "org.apache.maven.its", "maven-core-it-support", "1.0", "jar" ); core-integration-tests/src/test/resources/it0002/pom.xml - org.apache.maven + org.apache.maven.its Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] Thanks, Jason -- Jason van Zyl Founder and PMC Chair, Apache Maven jason at sonatype dot com -- - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r546719 - /maven/core-integration-testing/trunk/core-integration-tests/src/test/java/org/apache/maven/integrationtests/MavenIT0002Test.java
On 15/06/07, Jason van Zyl <[EMAIL PROTECTED]> wrote: If you install the artifacts you'll be fine. The invoker plugin broke which is why they are not installed. You can't simply run the ITs, you must install the plugins and artifacts that are used as part of the ITs. As I go through and find them I update them, but there is still a mixture of some old in there. Ideally the goal is to be able to start with nothing, install the artifacts required for running the ITs, and then run the ITs. So if you see things that aren't updated then fix them. This should ultimately become self-contained: http://svn.apache.org/repos/asf/maven/core-integration-testing/trunk/ Without any requirement for anything to be installed in a remote repository. See the IT problem notes for details. Right. Should the rest of it0002 not be aligned with the new group id too? See: core-integration-tests/src/test/java/org/apache/maven/integrationtests/MavenIT0002Test.java -verifier.deleteArtifact( "org.apache.maven", "maven-core-it-support", "1.0", "jar" ); +verifier.deleteArtifact( "org.apache.maven.its", "maven-core-it-support", "1.0", "jar" ); core-integration-tests/src/test/resources/it0002/pom.xml - org.apache.maven + org.apache.maven.its Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r546719 - /maven/core-integration-testing/trunk/core-integration-tests/src/test/java/org/apache/maven/integrationtests/MavenIT0002Test.java
On 15 Jun 07, at 4:24 AM 15 Jun 07, Mark Hobson wrote: On 13/06/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: Author: jvanzyl Date: Tue Jun 12 20:26:16 2007 New Revision: 546719 URL: http://svn.apache.org/viewvc?view=rev&rev=546719 Log: o using the new groupId for the IT artifacts Modified: maven/core-integration-testing/trunk/core-integration-tests/ src/test/java/org/apache/maven/integrationtests/MavenIT0002Test.java Modified: maven/core-integration-testing/trunk/core-integration- tests/src/test/java/org/apache/maven/integrationtests/ MavenIT0002Test.java URL: http://svn.apache.org/viewvc/maven/core-integration-testing/ trunk/core-integration-tests/src/test/java/org/apache/maven/ integrationtests/MavenIT0002Test.java? view=diff&rev=546719&r1=546718&r2=546719 = = --- maven/core-integration-testing/trunk/core-integration-tests/ src/test/java/org/apache/maven/integrationtests/ MavenIT0002Test.java (original) +++ maven/core-integration-testing/trunk/core-integration-tests/ src/test/java/org/apache/maven/integrationtests/ MavenIT0002Test.java Tue Jun 12 20:26:16 2007 @@ -24,7 +24,7 @@ verifier.assertFilePresent( "target/test-classes/org/ apache/maven/it0002/PersonTest.class" ); verifier.assertFilePresent( "target/maven-it- it0002-1.0.jar" ); verifier.assertFilePresent( "target/maven-it- it0002-1.0.jar!/it0002.properties" ); -verifier.assertArtifactPresent( "org.apache.maven", "maven-core-it-support", "1.0", "jar" ); +verifier.assertArtifactPresent( "org.apache.maven.its", "maven-core-it-support", "1.0", "jar" ); verifier.verifyErrorFreeLog(); verifier.resetStreams(); This breaks it0002 for me. Shouldn't new versions of maven-core-it-support be deployed under the new groupId and the other references to it within the IT be updated?: If you install the artifacts you'll be fine. The invoker plugin broke which is why they are not installed. You can't simply run the ITs, you must install the plugins and artifacts that are used as part of the ITs. As I go through and find them I update them, but there is still a mixture of some old in there. Ideally the goal is to be able to start with nothing, install the artifacts required for running the ITs, and then run the ITs. So if you see things that aren't updated then fix them. This should ultimately become self-contained: http://svn.apache.org/repos/asf/maven/core-integration-testing/trunk/ Without any requirement for anything to be installed in a remote repository. See the IT problem notes for details. Index: core-integration-tests/src/test/java/org/apache/maven/ integrationtests/MavenIT0002Test.java === --- core-integration-tests/src/test/java/org/apache/maven/ integrationtests/MavenIT0002Test.java (revision 547616) +++ core-integration-tests/src/test/java/org/apache/maven/ integrationtests/MavenIT0002Test.java (working copy) @@ -18,7 +18,7 @@ { File testDir = ResourceExtractor.simpleExtractResources( getClass(), "/it0002" ); Verifier verifier = new Verifier( testDir.getAbsolutePath() ); -verifier.deleteArtifact( "org.apache.maven", "maven-core-it-support", "1.0", "jar" ); +verifier.deleteArtifact( "org.apache.maven.its", "maven-core-it-support", "1.0", "jar" ); verifier.executeGoal( "package" ); verifier.assertFilePresent( "target/classes/org/apache/maven/it0002/Person.class" ); verifier.assertFilePresent( "target/test-classes/org/apache/maven/it0002/PersonTest.class" ); Index: core-integration-tests/src/test/resources/it0002/pom.xml === --- core-integration-tests/src/test/resources/it0002/pom.xml (revision 547616) +++ core-integration-tests/src/test/resources/it0002/pom.xml (working copy) @@ -17,7 +17,7 @@ test - org.apache.maven + org.apache.maven.its maven-core-it-support 1.0 jar Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] Thanks, Jason -- Jason van Zyl Founder and PMC Chair, Apache Maven jason at sonatype dot com -- - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r546719 - /maven/core-integration-testing/trunk/core-integration-tests/src/test/java/org/apache/maven/integrationtests/MavenIT0002Test.java
On 13/06/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: Author: jvanzyl Date: Tue Jun 12 20:26:16 2007 New Revision: 546719 URL: http://svn.apache.org/viewvc?view=rev&rev=546719 Log: o using the new groupId for the IT artifacts Modified: maven/core-integration-testing/trunk/core-integration-tests/src/test/java/org/apache/maven/integrationtests/MavenIT0002Test.java Modified: maven/core-integration-testing/trunk/core-integration-tests/src/test/java/org/apache/maven/integrationtests/MavenIT0002Test.java URL: http://svn.apache.org/viewvc/maven/core-integration-testing/trunk/core-integration-tests/src/test/java/org/apache/maven/integrationtests/MavenIT0002Test.java?view=diff&rev=546719&r1=546718&r2=546719 == --- maven/core-integration-testing/trunk/core-integration-tests/src/test/java/org/apache/maven/integrationtests/MavenIT0002Test.java (original) +++ maven/core-integration-testing/trunk/core-integration-tests/src/test/java/org/apache/maven/integrationtests/MavenIT0002Test.java Tue Jun 12 20:26:16 2007 @@ -24,7 +24,7 @@ verifier.assertFilePresent( "target/test-classes/org/apache/maven/it0002/PersonTest.class" ); verifier.assertFilePresent( "target/maven-it-it0002-1.0.jar" ); verifier.assertFilePresent( "target/maven-it-it0002-1.0.jar!/it0002.properties" ); -verifier.assertArtifactPresent( "org.apache.maven", "maven-core-it-support", "1.0", "jar" ); +verifier.assertArtifactPresent( "org.apache.maven.its", "maven-core-it-support", "1.0", "jar" ); verifier.verifyErrorFreeLog(); verifier.resetStreams(); This breaks it0002 for me. Shouldn't new versions of maven-core-it-support be deployed under the new groupId and the other references to it within the IT be updated?: Index: core-integration-tests/src/test/java/org/apache/maven/integrationtests/MavenIT0002Test.java === --- core-integration-tests/src/test/java/org/apache/maven/integrationtests/MavenIT0002Test.java (revision 547616) +++ core-integration-tests/src/test/java/org/apache/maven/integrationtests/MavenIT0002Test.java (working copy) @@ -18,7 +18,7 @@ { File testDir = ResourceExtractor.simpleExtractResources( getClass(), "/it0002" ); Verifier verifier = new Verifier( testDir.getAbsolutePath() ); -verifier.deleteArtifact( "org.apache.maven", "maven-core-it-support", "1.0", "jar" ); +verifier.deleteArtifact( "org.apache.maven.its", "maven-core-it-support", "1.0", "jar" ); verifier.executeGoal( "package" ); verifier.assertFilePresent( "target/classes/org/apache/maven/it0002/Person.class" ); verifier.assertFilePresent( "target/test-classes/org/apache/maven/it0002/PersonTest.class" ); Index: core-integration-tests/src/test/resources/it0002/pom.xml === --- core-integration-tests/src/test/resources/it0002/pom.xml (revision 547616) +++ core-integration-tests/src/test/resources/it0002/pom.xml(working copy) @@ -17,7 +17,7 @@ test - org.apache.maven + org.apache.maven.its maven-core-it-support 1.0 jar Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]