Build failed in Jenkins: Mesos-Ubuntu-distcheck #263
See https://builds.apache.org/job/Mesos-Ubuntu-distcheck/263/changes Changes: [benjamin.hindman] Added a JSON::Object::find. [dhamon] Changed Try::error and Result::error to return const references. -- [...truncated 2646 lines...] Generating /x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/org/apache/mesos/state//package-frame.html... Generating /x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/org/apache/mesos/state//package-summary.html... Generating /x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/org/apache/mesos/state//package-tree.html... Generating /x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/constant-values.html... Generating /x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/serialized-form.html... Generating /x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/org/apache/mesos//class-use/SchedulerDriver.html... Generating /x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/org/apache/mesos//class-use/ExecutorDriver.html... Generating /x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/org/apache/mesos//class-use/MesosExecutorDriver.html... Generating /x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/org/apache/mesos//class-use/MesosSchedulerDriver.html... Generating /x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/org/apache/mesos//class-use/Scheduler.html... Generating /x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/org/apache/mesos//class-use/Executor.html... Generating /x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/org/apache/mesos//class-use/Log.html... Generating /x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/org/apache/mesos//class-use/Log.Position.html... Generating /x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/org/apache/mesos//class-use/Log.Entry.html... Generating /x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/org/apache/mesos//class-use/Log.OperationFailedException.html... Generating /x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/org/apache/mesos//class-use/Log.WriterFailedException.html... Generating /x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/org/apache/mesos//class-use/Log.Reader.html... Generating /x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/org/apache/mesos//class-use/Log.Writer.html... Generating /x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/org/apache/mesos/state//class-use/State.html... Generating /x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/org/apache/mesos/state//class-use/Variable.html... Generating /x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/org/apache/mesos/state//class-use/LevelDBState.html... Generating /x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/org/apache/mesos/state//class-use/AbstractState.html... Generating /x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/org/apache/mesos/state//class-use/InMemoryState.html... Generating /x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/org/apache/mesos/state//class-use/ZooKeeperState.html... Generating /x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/org/apache/mesos//package-use.html... Generating /x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/org/apache/mesos/state//package-use.html... Building index for all the packages and classes... Generating /x1/jenkins/jenkins-slave/workspace/Mesos-Ubuntu-distcheck/build/mesos-0.20.0/_build/src/java/target/apidocs/overview-tree.html... Generating
Build failed in Jenkins: mesos-reviewbot #1313
See https://builds.apache.org/job/mesos-reviewbot/1313/
--
[...truncated 5370 lines...]
rm -f state/.dirstamp
rm -f tests/.deps/.dirstamp
rm -f log/tool/*.lo
rm -f tests/.dirstamp
rm -f logging/*.o
rm -f usage/.deps/.dirstamp
rm -f logging/*.lo
rm -f usage/.dirstamp
rm -f master/*.o
rm -f zookeeper/.deps/.dirstamp
rm -f zookeeper/.dirstamp
rm -f master/*.lo
rm -f messages/*.o
rm -f messages/*.lo
rm -f sasl/*.o
rm -f sasl/*.lo
rm -f sched/*.o
rm -f sched/*.lo
rm -f scheduler/*.o
rm -f scheduler/*.lo
rm -f slave/*.o
rm -f slave/*.lo
rm -f slave/containerizer/*.o
rm -f slave/containerizer/*.lo
rm -f slave/containerizer/isolators/cgroups/*.o
rm -f slave/containerizer/isolators/cgroups/*.lo
rm -f slave/containerizer/isolators/network/*.o
rm -f slave/containerizer/isolators/network/*.lo
rm -f slave/containerizer/mesos/*.o
rm -f slave/containerizer/mesos/*.lo
rm -f state/*.o
rm -f state/*.lo
rm -f tests/*.o
rm -rf authorizer/.libs authorizer/_libs
rm -rf common/.libs common/_libs
rm -rf containerizer/.libs containerizer/_libs
rm -rf docker/.libs docker/_libs
rm -rf exec/.libs exec/_libs
rm -rf files/.libs files/_libs
rm -rf java/jni/.libs java/jni/_libs
rm -rf jvm/.libs jvm/_libs
rm -rf jvm/org/apache/.libs jvm/org/apache/_libs
rm -rf linux/.libs linux/_libs
rm -rf linux/routing/.libs linux/routing/_libs
rm -rf linux/routing/filter/.libs linux/routing/filter/_libs
rm -rf linux/routing/link/.libs linux/routing/link/_libs
rm -rf linux/routing/queueing/.libs linux/routing/queueing/_libs
rm -rf local/.libs local/_libs
rm -rf log/.libs log/_libs
rm -f usage/*.o
rm -f usage/*.lo
rm -f zookeeper/*.o
rm -rf log/tool/.libs log/tool/_libs
rm -f zookeeper/*.lo
rm -rf logging/.libs logging/_libs
rm -rf master/.libs master/_libs
rm -rf messages/.libs messages/_libs
rm -rf sasl/.libs sasl/_libs
rm -rf sched/.libs sched/_libs
rm -rf scheduler/.libs scheduler/_libs
rm -rf slave/.libs slave/_libs
rm -rf slave/containerizer/.libs slave/containerizer/_libs
rm -rf slave/containerizer/isolators/cgroups/.libs
slave/containerizer/isolators/cgroups/_libs
rm -rf slave/containerizer/isolators/network/.libs
slave/containerizer/isolators/network/_libs
rm -rf slave/containerizer/mesos/.libs slave/containerizer/mesos/_libs
rm -rf state/.libs state/_libs
rm -rf usage/.libs usage/_libs
rm -rf zookeeper/.libs zookeeper/_libs
rm -rf ./.deps authorizer/.deps cli/.deps common/.deps containerizer/.deps
docker/.deps examples/.deps exec/.deps files/.deps health-check/.deps
java/jni/.deps jvm/.deps jvm/org/apache/.deps launcher/.deps linux/.deps
linux/routing/.deps linux/routing/filter/.deps linux/routing/link/.deps
linux/routing/queueing/.deps local/.deps log/.deps log/tool/.deps logging/.deps
master/.deps messages/.deps sasl/.deps sched/.deps scheduler/.deps slave/.deps
slave/containerizer/.deps slave/containerizer/isolators/cgroups/.deps
slave/containerizer/isolators/network/.deps slave/containerizer/mesos/.deps
state/.deps tests/.deps usage/.deps zookeeper/.deps
rm -f Makefile
make[2]: Leaving directory
`https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.20.0/_build/src'
Making distclean in ec2
make[2]: Entering directory
`https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.20.0/_build/ec2'
rm -rf .libs _libs
rm -f *.lo
test -z || rm -f
test . = ../../ec2 || test -z || rm -f
rm -f Makefile
make[2]: Leaving directory
`https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.20.0/_build/ec2'
rm -f config.status config.cache config.log configure.lineno
config.status.lineno
rm -f Makefile
make[1]: Leaving directory
`https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.20.0/_build'
if test -d mesos-0.20.0; then find mesos-0.20.0 -type d ! -perm -200 -exec
chmod u+w {} ';' rm -rf mesos-0.20.0 || { sleep 5 rm -rf
mesos-0.20.0; }; else :; fi
==
mesos-0.20.0 archives ready for distribution:
mesos-0.20.0.tar.gz
==
real21m0.513s
user135m3.627s
sys 7m36.046s
+ chmod -R +w 3rdparty CHANGELOG Doxyfile LICENSE Makefile Makefile.am
Makefile.in NOTICE README.md aclocal.m4 ar-lib autom4te.cache bin bootstrap
compile config.guess config.log config.lt config.status config.sub configure
configure.ac depcomp docs ec2 frameworks include install-sh libtool ltmain.sh
m4 mesos-0.20.0.tar.gz mesos.pc mesos.pc.in missing mpi src support
+ git clean -fdx
Removing .libs/
Removing 3rdparty/Makefile
Removing 3rdparty/Makefile.in
Removing 3rdparty/libprocess/.deps/
Removing 3rdparty/libprocess/3rdparty/.deps/
Removing 3rdparty/libprocess/3rdparty/Makefile
Removing 3rdparty/libprocess/3rdparty/Makefile.in
Removing 3rdparty/libprocess/3rdparty/stout/Makefile
Removing 3rdparty/libprocess/3rdparty/stout/Makefile.in
Removing 3rdparty/libprocess/3rdparty/stout/aclocal.m4
Removing 3rdparty/libprocess/3rdparty/stout/autom4te.cache/
Removing 3rdparty/libprocess/3rdparty/stout/config.log
Removing
Re: Review Request 24475: Add new Docker configurations
On Aug. 11, 2014, 4:34 a.m., Benjamin Hindman wrote: src/slave/containerizer/docker.cpp, line 127 https://reviews.apache.org/r/24475/diff/2/?file=657110#file657110line127 Can we use the continuation syntax to name this method? It'll make it easier for someone to do a broad sweep and add C++11 lambdas later. I'm still going to rename it differently than the other _fetch, since it's really only called on fetch failed. (_fetchFailed) - Timothy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24475/#review50135 --- On Aug. 10, 2014, 7:39 a.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24475/ --- (Updated Aug. 10, 2014, 7:39 a.m.) Review request for mesos, Benjamin Hindman, Ian Downes, and Jie Yu. Repository: mesos-git Description --- Added new DockerInfo for future docker options, and allow command uris to be fetched and mapped into docker before launching docker container. Diffs - include/mesos/mesos.proto cc9f20e src/docker/docker.hpp 98b2d60 src/docker/docker.cpp 1cba381 src/slave/containerizer/containerizer.hpp 02754cd src/slave/containerizer/containerizer.cpp c91ba38 src/slave/containerizer/docker.cpp 904cdd3 src/slave/containerizer/mesos/containerizer.cpp 694c9d1 src/slave/slave.cpp 787bd05 src/tests/docker_containerizer_tests.cpp a559836 src/tests/docker_tests.cpp 4ef1df4 Diff: https://reviews.apache.org/r/24475/diff/ Testing --- make check Thanks, Timothy Chen
Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME #2328
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2328/changes Changes: [benjamin.hindman] Added a JSON::Object::find. [dhamon] Changed Try::error and Result::error to return const references. -- [...truncated 3750 lines...] make[2]: Entering directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/ws/build/mesos-0.20.0/_build' make[2]: Nothing to be done for `dvi-am'. make[2]: Leaving directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/ws/build/mesos-0.20.0/_build' Making dvi in 3rdparty make[2]: Entering directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/ws/build/mesos-0.20.0/_build/3rdparty' Making dvi in libprocess make[3]: Entering directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/ws/build/mesos-0.20.0/_build/3rdparty/libprocess' Making dvi in 3rdparty make[4]: Entering directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/ws/build/mesos-0.20.0/_build/3rdparty/libprocess/3rdparty' Making dvi in stout make[5]: Entering directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/ws/build/mesos-0.20.0/_build/3rdparty/libprocess/3rdparty/stout' Making dvi in . make[6]: Entering directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/ws/build/mesos-0.20.0/_build/3rdparty/libprocess/3rdparty/stout' make[6]: Nothing to be done for `dvi-am'. make[6]: Leaving directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/ws/build/mesos-0.20.0/_build/3rdparty/libprocess/3rdparty/stout' Making dvi in include make[6]: Entering directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/ws/build/mesos-0.20.0/_build/3rdparty/libprocess/3rdparty/stout/include' make[6]: Nothing to be done for `dvi'. make[6]: Leaving directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/ws/build/mesos-0.20.0/_build/3rdparty/libprocess/3rdparty/stout/include' make[5]: Leaving directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/ws/build/mesos-0.20.0/_build/3rdparty/libprocess/3rdparty/stout' make[5]: Entering directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/ws/build/mesos-0.20.0/_build/3rdparty/libprocess/3rdparty' make[5]: Nothing to be done for `dvi-am'. make[5]: Leaving directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/ws/build/mesos-0.20.0/_build/3rdparty/libprocess/3rdparty' make[4]: Leaving directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/ws/build/mesos-0.20.0/_build/3rdparty/libprocess/3rdparty' Making dvi in . make[4]: Entering directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/ws/build/mesos-0.20.0/_build/3rdparty/libprocess' make[4]: Nothing to be done for `dvi-am'. make[4]: Leaving directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/ws/build/mesos-0.20.0/_build/3rdparty/libprocess' Making dvi in include make[4]: Entering directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/ws/build/mesos-0.20.0/_build/3rdparty/libprocess/include' make[4]: Nothing to be done for `dvi'. make[4]: Leaving directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/ws/build/mesos-0.20.0/_build/3rdparty/libprocess/include' make[3]: Leaving directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/ws/build/mesos-0.20.0/_build/3rdparty/libprocess' make[3]: Entering directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/ws/build/mesos-0.20.0/_build/3rdparty' make[3]: Nothing to be done for `dvi-am'. make[3]: Leaving directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/ws/build/mesos-0.20.0/_build/3rdparty' make[2]: Leaving directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/ws/build/mesos-0.20.0/_build/3rdparty' Making dvi in src make[2]: Entering directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/ws/build/mesos-0.20.0/_build/src' make[2]: Nothing to be done for `dvi'. make[2]: Leaving directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/ws/build/mesos-0.20.0/_build/src' Making dvi in ec2 make[2]: Entering directory `https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/ws/build/mesos-0.20.0/_build/ec2' make[2]: Nothing to be done for `dvi'. make[2]: Leaving directory
Jenkins build is back to normal : mesos-reviewbot #1314
See https://builds.apache.org/job/mesos-reviewbot/1314/changes
Re: Review Request 24569: Added missing 'defer' helpers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24569/#review50282 --- ben, can you commit this? - Vinod Kone On Aug. 11, 2014, 6:45 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24569/ --- (Updated Aug. 11, 2014, 6:45 p.m.) Review request for mesos and Jie Yu. Bugs: MESOS-1692 https://issues.apache.org/jira/browse/MESOS-1692 Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/include/process/defer.hpp dce7f3b71fc30e28fe55b2ed20ea48090aa57781 3rdparty/libprocess/include/process/future.hpp db7fcbcff34bcb82c62689e7019b416fdad20048 Diff: https://reviews.apache.org/r/24569/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 24569: Added missing 'defer' helpers.
On Aug. 12, 2014, 3:15 a.m., Vinod Kone wrote: ben, can you commit this? Committed! - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24569/#review50282 --- On Aug. 11, 2014, 6:45 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24569/ --- (Updated Aug. 11, 2014, 6:45 p.m.) Review request for mesos and Jie Yu. Bugs: MESOS-1692 https://issues.apache.org/jira/browse/MESOS-1692 Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/include/process/defer.hpp dce7f3b71fc30e28fe55b2ed20ea48090aa57781 3rdparty/libprocess/include/process/future.hpp db7fcbcff34bcb82c62689e7019b416fdad20048 Diff: https://reviews.apache.org/r/24569/diff/ Testing --- make check Thanks, Benjamin Hindman
Review Request 24588: Added Docker::pull.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24588/ --- Review request for mesos, Jie Yu and Timothy Chen. Repository: mesos-git Description --- See summary. Diffs - src/docker/docker.hpp 98b2d6099988f51f12e7b108e73dcfd0143adc48 src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571 Diff: https://reviews.apache.org/r/24588/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 24464: Redirect docker logs
On Aug. 11, 2014, 10:46 p.m., Jie Yu wrote: src/slave/containerizer/docker.cpp, line 446 https://reviews.apache.org/r/24464/diff/10/?file=657551#file657551line446 You probably want to do a 'logs.wait()' here: logs.wait() .onAny(defer(self(), Self::__logging, ...); Inside __logging, you can add some logging. I don't want to block on wait here since I want to launch the command executor right away afterwards. - Timothy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24464/#review50206 --- On Aug. 11, 2014, 8:19 a.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24464/ --- (Updated Aug. 11, 2014, 8:19 a.m.) Review request for mesos, Benjamin Hindman and Jie Yu. Repository: mesos-git Description --- Review: https://reviews.apache.org/r/24464 Diffs - src/docker/docker.hpp 98b2d6099988f51f12e7b108e73dcfd0143adc48 src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571 src/slave/containerizer/docker.cpp 904cdd32362591777aecaa58e723af36419f011c src/tests/docker_containerizer_tests.cpp a559836dd11a9a97e5939364c4b35a8dbb6a503d Diff: https://reviews.apache.org/r/24464/diff/ Testing --- make check Thanks, Timothy Chen
Review Request 24541: Added a JSON::Object::find.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24541/ --- Review request for mesos, Ben Mahler and Timothy Chen. Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 0ce002c1eb269095ba39cf901acaf2687225c464 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp ee82d152b0df5c62188e097aef7b6a335b893285 Diff: https://reviews.apache.org/r/24541/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 24533: Detect image entrypoint in docker run
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24533/#review50143
---
Not a complete review yet, wanted to help out with
https://reviews.apache.org/r/24541.
src/docker/docker.hpp
https://reviews.apache.org/r/24533/#comment87740
Why not return 'Image' and make it public?
src/docker/docker.cpp
https://reviews.apache.org/r/24533/#comment87741
s/str/s/
src/docker/docker.cpp
https://reviews.apache.org/r/24533/#comment87761
Okay, it's very very clear that we need some JSON helpers for looking
things up!!! This is getting insane! ;-)
I just threw up https://reviews.apache.org/r/24541 which should let you do:
ResultJSON::Value entrypoint =
json.findJSON::Value(ContainerConfig.Entrypoint);
if (entrypoint.isError()) {
return Error(Failed to find 'ContainerConfig.Entrypoint': +
entrypoint.error());
} else if (entrypoint.isNone()) {
return Error(Unable to find 'ContainerConfig.Entrypoint');
}
if (entrypoint.isJSON::Null()) {
return Docker::Image(None());
}
if (!entrypoint.isJSON::Array()) {
return Error(Unexpected type found for 'ContainerConfig.Entrypoint' (not
an array));
}
...
src/docker/docker.cpp
https://reviews.apache.org/r/24533/#comment87762
Might the entrypoint not actually be all of the values in the JSON array?
- Benjamin Hindman
On Aug. 10, 2014, 7:44 a.m., Timothy Chen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24533/
---
(Updated Aug. 10, 2014, 7:44 a.m.)
Review request for mesos, Benjamin Hindman, Ian Downes, and Jie Yu.
Repository: mesos-git
Description
---
We need to treat docker images with entrypoint specially since a docker image
without an entrypoint requires us to wrap the command in /bin/sh -c, where
command to a image with entrypoint should be passed arguments directly to the
image.
Diffs
-
src/docker/docker.hpp 98b2d60
src/docker/docker.cpp 1cba381
Diff: https://reviews.apache.org/r/24533/diff/
Testing
---
make check
Thanks,
Timothy Chen
Re: Review Request 24541: Added a JSON::Object::find.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24541/#review50169 --- Ship it! Ship It! - Timothy Chen On Aug. 11, 2014, 7:03 a.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24541/ --- (Updated Aug. 11, 2014, 7:03 a.m.) Review request for mesos, Ben Mahler and Timothy Chen. Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 0ce002c1eb269095ba39cf901acaf2687225c464 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp ee82d152b0df5c62188e097aef7b6a335b893285 Diff: https://reviews.apache.org/r/24541/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 24541: Added a JSON::Object::find.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24541/#review50168 --- 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp https://reviews.apache.org/r/24541/#comment87763 It will be ideal if we can print the found type, but it's fine if it's too much to do as I don't see a simple way to do so. - Timothy Chen On Aug. 11, 2014, 7:03 a.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24541/ --- (Updated Aug. 11, 2014, 7:03 a.m.) Review request for mesos, Ben Mahler and Timothy Chen. Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 0ce002c1eb269095ba39cf901acaf2687225c464 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp ee82d152b0df5c62188e097aef7b6a335b893285 Diff: https://reviews.apache.org/r/24541/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 24464: Redirect docker logs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24464/ --- (Updated Aug. 11, 2014, 8:19 a.m.) Review request for mesos, Benjamin Hindman and Jie Yu. Repository: mesos-git Description --- Review: https://reviews.apache.org/r/24464 Diffs (updated) - src/docker/docker.hpp 98b2d6099988f51f12e7b108e73dcfd0143adc48 src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571 src/slave/containerizer/docker.cpp 904cdd32362591777aecaa58e723af36419f011c src/tests/docker_containerizer_tests.cpp a559836dd11a9a97e5939364c4b35a8dbb6a503d Diff: https://reviews.apache.org/r/24464/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 24469: Created pure python package for the CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24469/#review50171 --- Bad patch! Reviews applied: [24469] Failed command: git apply --index 24469.patch Error: error: patch failed: src/Makefile.am:954 error: src/Makefile.am: patch does not apply - Mesos ReviewBot On Aug. 8, 2014, 7:36 p.m., Thomas Rampelberg wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24469/ --- (Updated Aug. 8, 2014, 7:36 p.m.) Review request for mesos and Benjamin Hindman. Bugs: mesos-1016 https://issues.apache.org/jira/browse/mesos-1016 Repository: mesos-git Description --- This is a re-implementation of the CLI tools that removes the dependencies on compiled code and implements everything purely in python. You will now be able to `pip install mesos.cli` and get these tools anywhere (such as developer's laptops who don't have mesos itself installed or even a windows machine). The interface has changed and the tool has been made task centric. You can configure the master you'd like to use and then ignore which framework a task is running under completely. Diffs - src/Makefile.am 39af0365e429b8d08addadb09ee18080a19625f8 src/cli/mesos-cat 73dc63ebc2fab9150f4dd691e10defaf989b9e6b src/cli/mesos-ps ddd9ec5dd0045d168ee4ed840194fe18c304b56a src/cli/mesos-scp 77b8557d8ca33960d9135ad4fa6bfe3dcd087108 src/cli/mesos-tail 256a804b98b2efb2fb0256635449b36a3a4d0a6b src/cli/mesos.cpp 171a707cd2ba2348898e7fbe8fe9f0634edd6d86 src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef src/cli/python/mesos/cli.py 857059e2c12ed7f1419dfbf0d11dda0ff9fae235 src/cli/python/mesos/futures.py da2f4ceb72f4d8f1a1a48b0c3a1723b2f638 src/cli/python/mesos/http.py 0e19aa8dd6595a9b292189364fd51fb9b3bfb285 src/cli/resolve.cpp a99b6094dffc9f7aa44bcf63ad40121e1abb120b src/python/cli/Makefile PRE-CREATION src/python/cli/README.rst PRE-CREATION src/python/cli/bin/mesos-zsh-completion.sh PRE-CREATION src/python/cli/docs/debugging.md PRE-CREATION src/python/cli/mesos/__init__.py PRE-CREATION src/python/cli/mesos/cli/__init__.py PRE-CREATION src/python/cli/mesos/cli/cfg.py PRE-CREATION src/python/cli/mesos/cli/cli.py PRE-CREATION src/python/cli/mesos/cli/cluster.py PRE-CREATION src/python/cli/mesos/cli/cmds/cat.py PRE-CREATION src/python/cli/mesos/cli/cmds/completion.py PRE-CREATION src/python/cli/mesos/cli/cmds/config.py PRE-CREATION src/python/cli/mesos/cli/cmds/events.py PRE-CREATION src/python/cli/mesos/cli/cmds/find.py PRE-CREATION src/python/cli/mesos/cli/cmds/head.py PRE-CREATION src/python/cli/mesos/cli/cmds/help.py PRE-CREATION src/python/cli/mesos/cli/cmds/ls.py PRE-CREATION src/python/cli/mesos/cli/cmds/ps.py PRE-CREATION src/python/cli/mesos/cli/cmds/resolve.py PRE-CREATION src/python/cli/mesos/cli/cmds/scp.py PRE-CREATION src/python/cli/mesos/cli/cmds/ssh.py PRE-CREATION src/python/cli/mesos/cli/cmds/state.py PRE-CREATION src/python/cli/mesos/cli/cmds/tail.py PRE-CREATION src/python/cli/mesos/cli/completion_helpers.py PRE-CREATION src/python/cli/mesos/cli/exceptions.py PRE-CREATION src/python/cli/mesos/cli/log.py PRE-CREATION src/python/cli/mesos/cli/main.py PRE-CREATION src/python/cli/mesos/cli/master.py PRE-CREATION src/python/cli/mesos/cli/mesos_file.py PRE-CREATION src/python/cli/mesos/cli/slave.py PRE-CREATION src/python/cli/mesos/cli/task.py PRE-CREATION src/python/cli/mesos/cli/util.py PRE-CREATION src/python/cli/mesos/cli/zookeeper.py PRE-CREATION src/python/cli/setup.cfg PRE-CREATION src/python/cli/setup.py PRE-CREATION src/python/cli/tests/__init__.py PRE-CREATION src/python/cli/tests/data/browse.json PRE-CREATION src/python/cli/tests/data/config.json PRE-CREATION src/python/cli/tests/data/master-host PRE-CREATION src/python/cli/tests/data/master.pb PRE-CREATION src/python/cli/tests/data/master_state.json PRE-CREATION src/python/cli/tests/data/sandbox/log PRE-CREATION src/python/cli/tests/data/sandbox/stderr PRE-CREATION src/python/cli/tests/data/sandbox/stdout PRE-CREATION src/python/cli/tests/data/slave-20140619-151434-16842879-5050-1196-0.json PRE-CREATION src/python/cli/tests/data/slave_statistics.json PRE-CREATION src/python/cli/tests/integration/__init__.py PRE-CREATION src/python/cli/tests/integration/test_cat.py PRE-CREATION src/python/cli/tests/integration/test_completion.py PRE-CREATION src/python/cli/tests/integration/test_config.py PRE-CREATION
Re: Review Request 24509: Refactored credentials and ACLs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24509/#review50173 --- Bad patch! Reviews applied: [24509] Failed command: git apply --index 24509.patch Error: error: patch failed: 3rdparty/libprocess/include/process/defer.hpp:405 error: 3rdparty/libprocess/include/process/defer.hpp: patch does not apply error: patch failed: 3rdparty/libprocess/include/process/deferred.hpp:31 error: 3rdparty/libprocess/include/process/deferred.hpp: patch does not apply error: patch failed: include/mesos/mesos.proto:662 error: include/mesos/mesos.proto: patch does not apply error: patch failed: src/authorizer/authorizer.hpp:49 error: src/authorizer/authorizer.hpp: patch does not apply error: patch failed: src/authorizer/authorizer.cpp:54 error: src/authorizer/authorizer.cpp: patch does not apply error: patch failed: src/credentials/credentials.hpp:53 error: src/credentials/credentials.hpp: patch does not apply error: patch failed: src/master/flags.hpp:213 error: src/master/flags.hpp: patch does not apply error: patch failed: src/master/http.cpp:39 error: src/master/http.cpp: patch does not apply error: patch failed: src/master/master.hpp:422 error: src/master/master.hpp: patch does not apply error: patch failed: src/master/master.cpp:1207 error: src/master/master.cpp: patch does not apply error: patch failed: src/sasl/authenticator.hpp:466 error: src/sasl/authenticator.hpp: patch does not apply error: patch failed: src/tests/authorization_tests.cpp:37 error: src/tests/authorization_tests.cpp: patch does not apply error: patch failed: src/tests/master_authorization_tests.cpp:72 error: src/tests/master_authorization_tests.cpp: patch does not apply error: patch failed: src/tests/mesos.hpp:492 error: src/tests/mesos.hpp: patch does not apply error: patch failed: src/tests/reconciliation_tests.cpp:622 error: src/tests/reconciliation_tests.cpp: patch does not apply error: patch failed: src/tests/script.cpp:135 error: src/tests/script.cpp: patch does not apply - Mesos ReviewBot On Aug. 8, 2014, 11:58 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24509/ --- (Updated Aug. 8, 2014, 11:58 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-1343 https://issues.apache.org/jira/browse/MESOS-1343 Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/include/process/defer.hpp dc2ec3bb4cc76bbef0dba2a4d7dd804f9ba1fa4a 3rdparty/libprocess/include/process/deferred.hpp 0552fb51f310b2ee0db7fbe31eabc6d161d1506e include/mesos/mesos.proto 6d4fd145004a14514e27ba65b2eae19b945aeb83 src/authorizer/authorizer.hpp b7f11191aea5deeea2403a6dd900eec9cc77ad56 src/authorizer/authorizer.cpp 40a14becde44324bddefef1c6fe61b228ca505d3 src/credentials/credentials.hpp 1790793ae8190fc5986c8dab089e9bdf32d55eb0 src/master/flags.hpp 2b92de37b64c3363915918c65ab092efd5b378d6 src/master/http.cpp f2ca6599eb165c4c1bc4580175fa439f797c832b src/master/master.hpp d8a4d9e04ecff60020b99ea6447055787d187797 src/master/master.cpp 56306809096db36bc1884c87957a7b2c76610a93 src/sasl/authenticator.hpp aa222d30eaf738d9ed1d46a6689e39b2283ec1c8 src/tests/authorization_tests.cpp 611f3713c0bf4dee631a935f08c9edf2776ab3ad src/tests/master_authorization_tests.cpp 009afa4186a7b69527ee28d8ad323315101947b6 src/tests/mesos.hpp 75c66fda2485afa0d4541e710780d90b3411839a src/tests/reconciliation_tests.cpp 952f29b97e7516a3aa69e599901bf49cd2b6d596 src/tests/script.cpp 31294790f7146e5867067a0d45bd4d0e7d0885cd Diff: https://reviews.apache.org/r/24509/diff/ Testing --- make check (WIP) Thanks, Benjamin Hindman
Review Request 24555: MESOS-1169: unbundle distribute
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24555/ --- Review request for mesos, Adam B and Vinod Kone. Bugs: MESOS-1169 https://issues.apache.org/jira/browse/MESOS-1169 Repository: mesos-git Description --- Enabling unbundling for distribute python utils. Diffs - 3rdparty/Makefile.am 70b45fe configure.ac 8fb0a3a mpi/mpiexec-mesos.in 8812ee2 src/examples/python/test-containerizer.in f71828d src/examples/python/test-executor.in b22e7a7 src/examples/python/test-framework.in 64fb1dd Diff: https://reviews.apache.org/r/24555/diff/ Testing --- ./configure make check ./configure --disable-bundled make check For prefixed installs require updated PYTHON_PATH. Thanks, Timothy St. Clair
Review Request 24562: ZK URL Parsing Consolidation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24562/ --- Review request for mesos, Adam B and Ben Mahler. Repository: mesos-git Description --- Consolidated redundant code for zk url parsing. Through that, identified a test that used zk file for something other than zk. Fixed test, and added test for file parsing. It is tough to know if something other than zk can be in the file (assuming it is a zk file). If other things can go into the file in question, then I can create a file parser. The current URL::Parser lives in the zookeeper namespace. This patch also completes several documented todo is the code. Diffs - src/master/contender.cpp c1bf82b621d6b46afe001acafe9ee53336726406 src/master/detector.cpp 6436b8ee7e1ab6451a6b999a1cfbb2f79190e6ca src/tests/master_contender_detector_tests.cpp fdddfa1a9c793bb406d85d214a18ca4ced53b09f src/zookeeper/url.hpp 16e711c5c0bc29b1967a20f0827238f8a7b0deaf Diff: https://reviews.apache.org/r/24562/diff/ Testing --- 1 test changed and 1 test added to: master_contender_detector_tests.cpp MasterContenderDetectorTest BasicMasterContenderDetectorTest all tests pass including styling. Thanks, Ken Sipe
Review Request 24563: MESOS-1693: enable build against non-x86 arch
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24563/ --- Review request for mesos, Adam B and Vinod Kone. Bugs: MESOS-1693 https://issues.apache.org/jira/browse/MESOS-1693 Repository: mesos-git Description --- Enable building against non-x86 arch, namely arm builders on Fedora. Diffs - 3rdparty/libprocess/include/process/internal.hpp 9f478ec 3rdparty/libprocess/src/process.cpp 14cf317 configure.ac 8fb0a3a Diff: https://reviews.apache.org/r/24563/diff/ Testing --- make check Thanks, Timothy St. Clair
Re: Review Request 24563: MESOS-1693: enable build against non-x86 arch
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24563/#review50186 --- Have you tested this on ppc? - Dominic Hamon On Aug. 11, 2014, 9:45 a.m., Timothy St. Clair wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24563/ --- (Updated Aug. 11, 2014, 9:45 a.m.) Review request for mesos, Adam B and Vinod Kone. Bugs: MESOS-1693 https://issues.apache.org/jira/browse/MESOS-1693 Repository: mesos-git Description --- Enable building against non-x86 arch, namely arm builders on Fedora. Diffs - 3rdparty/libprocess/include/process/internal.hpp 9f478ec 3rdparty/libprocess/src/process.cpp 14cf317 configure.ac 8fb0a3a Diff: https://reviews.apache.org/r/24563/diff/ Testing --- make check Thanks, Timothy St. Clair
Re: Review Request 24562: ZK URL Parsing Consolidation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24562/#review50187 --- src/tests/master_contender_detector_tests.cpp https://reviews.apache.org/r/24562/#comment87793 style only: some extra whitespace crept in here - please remove it. - Dominic Hamon On Aug. 11, 2014, 9:44 a.m., Ken Sipe wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24562/ --- (Updated Aug. 11, 2014, 9:44 a.m.) Review request for mesos, Adam B and Ben Mahler. Repository: mesos-git Description --- Consolidated redundant code for zk url parsing. Through that, identified a test that used zk file for something other than zk. Fixed test, and added test for file parsing. It is tough to know if something other than zk can be in the file (assuming it is a zk file). If other things can go into the file in question, then I can create a file parser. The current URL::Parser lives in the zookeeper namespace. This patch also completes several documented todo is the code. Diffs - src/master/contender.cpp c1bf82b621d6b46afe001acafe9ee53336726406 src/master/detector.cpp 6436b8ee7e1ab6451a6b999a1cfbb2f79190e6ca src/tests/master_contender_detector_tests.cpp fdddfa1a9c793bb406d85d214a18ca4ced53b09f src/zookeeper/url.hpp 16e711c5c0bc29b1967a20f0827238f8a7b0deaf Diff: https://reviews.apache.org/r/24562/diff/ Testing --- 1 test changed and 1 test added to: master_contender_detector_tests.cpp MasterContenderDetectorTest BasicMasterContenderDetectorTest all tests pass including styling. Thanks, Ken Sipe
Re: Review Request 24563: MESOS-1693: enable build against non-x86 arch
On Aug. 11, 2014, 4:57 p.m., Dominic Hamon wrote: Have you tested this on ppc? Tested no, but it should enable the build now, which was the goal at this point. - Timothy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24563/#review50186 --- On Aug. 11, 2014, 4:45 p.m., Timothy St. Clair wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24563/ --- (Updated Aug. 11, 2014, 4:45 p.m.) Review request for mesos, Adam B and Vinod Kone. Bugs: MESOS-1693 https://issues.apache.org/jira/browse/MESOS-1693 Repository: mesos-git Description --- Enable building against non-x86 arch, namely arm builders on Fedora. Diffs - 3rdparty/libprocess/include/process/internal.hpp 9f478ec 3rdparty/libprocess/src/process.cpp 14cf317 configure.ac 8fb0a3a Diff: https://reviews.apache.org/r/24563/diff/ Testing --- make check Thanks, Timothy St. Clair
Re: Review Request 24264: Installed python libraries during make install.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24264/ --- (Updated Aug. 11, 2014, 6:09 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-899 https://issues.apache.org/jira/browse/MESOS-899 Repository: mesos-git Description --- Because eggs are impossible to uninstall, pip + wheel has been added as a packaging format. The wheels are generated in addition to eggs and then subsequently installed/uninstalled. Note that the building of eggs has not been removed. This is because wheels cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs are needed for all the test scripts to run correctly without actually installing anything locally. Diffs (updated) - 3rdparty/Makefile.am 70b45fe8b846a2a3fda599c0b5b7cfa5eb7e78e0 3rdparty/libprocess/include/process/defer.hpp dce7f3b71fc30e28fe55b2ed20ea48090aa57781 3rdparty/libprocess/include/process/deferred.hpp 8bdc69235c7c25d8c8c0a5a6dcc99c4a2c34f94a 3rdparty/pip-1.5.6.tar.gz PRE-CREATION 3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5 3rdparty/wheel-0.24.0.tar.gz PRE-CREATION Doxyfile 8bba46152f59478bbd5a4573eab85ec9628316bf configure.ac 8fb0a3a794db4d3671243d06ff45232eae53c27b docs/authorization.md 669794457f10e357bdd10b1a096a2ee9b629971f include/mesos/mesos.proto cc9f20e5cf0ecad58a9c8fa2e4e6e79cea8b344c mpi/mpiexec-mesos.in 8812ee28c1f845bc3de40ffbf9e9d18033e450f2 src/Makefile.am 39af0365e429b8d08addadb09ee18080a19625f8 src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc src/credentials/credentials.hpp 4cdadb1b6d5a607cee8caeb38f2cbf2e3ec5da7a src/examples/python/test-containerizer.in f71828db98a90f455c88d90cb4e3320b7e8c9e9e src/examples/python/test-executor.in b22e7a7dc0c26f805eb63c7139066ce7dc830636 src/examples/python/test-framework.in 64fb1ddc1a0e5772c12d7497dfc1cf6ca2a7dceb src/linux/cgroups.hpp abf31df1b4dbf6f715f93256b83c9996a45099cf src/linux/cgroups.cpp 989e307a3483f2ec419aa12f7769bc107d5ac4d4 src/master/flags.hpp 5e9ecb567fb2f4576b38303a9d73b93d8cd14115 src/master/hierarchical_allocator_process.hpp 34f8cd658920b36b1062bd3b7f6bfbd1bcb6bb52 src/master/http.cpp 9317a95133e9bba54d037057a147ae6d91125441 src/master/master.hpp c9f989aa209c1067b60d02cfb4f032afe0f9de4c src/master/master.cpp d53d6c2d2c89258880df42b1c0a2cfb04cffa215 src/sasl/authenticator.hpp 35ab79449093e10877248b91ba7070e04c9cdd6f src/slave/constants.hpp 9030871fa2c6b449a7eee7644691ca54b0635566 src/slave/constants.cpp e1da5c064b3ea4f2c0d18f4da64111cbea2544d1 src/slave/containerizer/isolators/cgroups/mem.hpp c734dae834c3f771b2954868138a622b7712aa32 src/slave/containerizer/isolators/cgroups/mem.cpp 3ba580d7b5e16ca2ea04c2843780b2e5bc52ec95 src/slave/containerizer/isolators/network/port_mapping.cpp 938782ae2ab1da34eb316381131e9bfcb7c810d1 src/slave/flags.hpp 1e36c517ccebf42d18cd2534d40d98badd488cad src/tests/allocator_tests.cpp 774528a61c937b2f6aa9fa3ecc59868070e21860 src/tests/authorization_tests.cpp a8fa4ccf4558532f6717f7a6e6301565aec7d5d1 src/tests/health_check_tests.cpp 731d944dd92ac325b0752655f8454f6ec7275c03 src/tests/master_authorization_tests.cpp f0f064808d8bf36a2a756bc907c477dd6440636c src/tests/mesos.hpp b31c347299707cba242619c3dc6915f295bee9cb src/tests/mesos.cpp 5bd8ba0bb56c9be9d0a3c49c27b6ebc03cfbdf7a src/tests/port_mapping_tests.cpp a990da38bd1ff8dcfb6510ed4aa411253020ba20 src/tests/reconciliation_tests.cpp 3c4d7ed886333f0ccc1460178b9e06e7e38246c9 src/tests/script.cpp 515e3141e1d517da4cfc1421d5301d0a3bd6ad51 src/tests/shutdown_tests.cpp 12ebef43a1ff339b30329d96d3c00646462ba37e support/timed_tests.sh e060966b67089a60d4c93759bf907b3c8015e92f Diff: https://reviews.apache.org/r/24264/diff/ Testing --- `make distcheck -j6` Thanks, Thomas Rampelberg
Re: Review Request 24264: Installed python libraries during make install.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24264/ --- (Updated Aug. 11, 2014, 6:09 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-899 https://issues.apache.org/jira/browse/MESOS-899 Repository: mesos-git Description --- Because eggs are impossible to uninstall, pip + wheel has been added as a packaging format. The wheels are generated in addition to eggs and then subsequently installed/uninstalled. Note that the building of eggs has not been removed. This is because wheels cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs are needed for all the test scripts to run correctly without actually installing anything locally. Diffs (updated) - 3rdparty/Makefile.am 70b45fe8b846a2a3fda599c0b5b7cfa5eb7e78e0 3rdparty/pip-1.5.6.tar.gz PRE-CREATION 3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5 3rdparty/wheel-0.24.0.tar.gz PRE-CREATION configure.ac 8fb0a3a794db4d3671243d06ff45232eae53c27b mpi/mpiexec-mesos.in 8812ee28c1f845bc3de40ffbf9e9d18033e450f2 src/Makefile.am 39af0365e429b8d08addadb09ee18080a19625f8 src/examples/python/test-containerizer.in f71828db98a90f455c88d90cb4e3320b7e8c9e9e src/examples/python/test-executor.in b22e7a7dc0c26f805eb63c7139066ce7dc830636 src/examples/python/test-framework.in 64fb1ddc1a0e5772c12d7497dfc1cf6ca2a7dceb Diff: https://reviews.apache.org/r/24264/diff/ Testing --- `make distcheck -j6` Thanks, Thomas Rampelberg
Re: Review Request 24407: Use curl-config to locate lib curl when possible
On Aug. 8, 2014, 6:31 p.m., Timothy St. Clair wrote: why not follow the prefix pattern if it's in a non-standard location --with-curl=/my/custom/path? I have no problem with that suggestion. I've created a new patch which adds --with-curl (and also supports --with-sasl2 and --with-zlib). Would it be OK to attach the patch to this review, or is it better to close this out and submit again? - Chris --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24407/#review50057 --- On Aug. 6, 2014, 7:37 p.m., Chris Heller wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24407/ --- (Updated Aug. 6, 2014, 7:37 p.m.) Review request for mesos and Timothy St. Clair. Repository: mesos-git Description --- If libcurl.a is located on a non-standard path, the test for libcurl in the configure script fails, even if the path is specified in LDFLAGS. To work around this we can use curl-config to provide the needed path and link options to the compiler. This patch modifies configure.ac to check for curl-config and use its output as an argument to AC_CHECK_LIB if possible. Diffs - configure.ac a9cc6df Diff: https://reviews.apache.org/r/24407/diff/ Testing --- Tested this on Ubuntu 12.04 against master with libcurl in a path not included in LDFLAGS. Thanks, Chris Heller
Re: Review Request 23086: MESOS-1174: Update system check to unbundle protobuf
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23086/#review50207 --- can you rebase? - Vinod Kone On Aug. 8, 2014, 5:58 p.m., Timothy St. Clair wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23086/ --- (Updated Aug. 8, 2014, 5:58 p.m.) Review request for mesos, Benjamin Hindman and Vinod Kone. Bugs: MESOS-1174 https://issues.apache.org/jira/browse/MESOS-1174 Repository: mesos-git Description --- Enable mesos to build against system installed version of protobuf. Diffs - 3rdparty/libprocess/3rdparty/Makefile.am 497d038 3rdparty/libprocess/configure.ac 7b39e63 Doxyfile 8bba461 configure.ac 8fb0a3a mpi/mpiexec-mesos.in 8812ee2 src/Makefile.am 39af036 src/examples/java/test-exception-framework.in 065f3c0 src/examples/java/test-executor.in 35559d2 src/examples/java/test-framework.in 9af48f9 src/examples/java/test-log.in 8afed0d src/examples/java/test-multiple-executors-framework.in 235eb23 src/examples/python/test-containerizer.in f71828d src/examples/python/test-executor.in b22e7a7 src/examples/python/test-framework.in 64fb1dd src/master/hierarchical_allocator_process.hpp 34f8cd6 src/master/master.cpp e688b41 src/python/native/ext_modules.py.in 477e63d src/slave/constants.hpp 9030871 src/slave/constants.cpp e1da5c0 src/slave/containerizer/isolators/network/port_mapping.cpp 938782a src/slave/slave.cpp 787bd05 src/tests/allocator_tests.cpp 774528a src/tests/health_check_tests.cpp 731d944 src/tests/mesos.cpp 6b5c43f src/tests/port_mapping_tests.cpp a990da3 support/timed_tests.sh e060966 Diff: https://reviews.apache.org/r/23086/diff/ Testing --- make check Thanks, Timothy St. Clair
Review Request 24569: Added missing 'defer' helpers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24569/ --- Review request for mesos and Jie Yu. Bugs: MESOS-1692 https://issues.apache.org/jira/browse/MESOS-1692 Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/include/process/defer.hpp dce7f3b71fc30e28fe55b2ed20ea48090aa57781 3rdparty/libprocess/include/process/future.hpp db7fcbcff34bcb82c62689e7019b416fdad20048 Diff: https://reviews.apache.org/r/24569/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 24555: MESOS-1169: unbundle distribute
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24555/#review50210 --- Have you tested this with a prefix installed 'distribute'? configure.ac https://reviews.apache.org/r/24555/#comment87827 How does this find a prefix installed 'distribute'? - Vinod Kone On Aug. 11, 2014, 3:43 p.m., Timothy St. Clair wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24555/ --- (Updated Aug. 11, 2014, 3:43 p.m.) Review request for mesos, Adam B and Vinod Kone. Bugs: MESOS-1169 https://issues.apache.org/jira/browse/MESOS-1169 Repository: mesos-git Description --- Enabling unbundling for distribute python utils. Diffs - 3rdparty/Makefile.am 70b45fe configure.ac 8fb0a3a mpi/mpiexec-mesos.in 8812ee2 src/examples/python/test-containerizer.in f71828d src/examples/python/test-executor.in b22e7a7 src/examples/python/test-framework.in 64fb1dd Diff: https://reviews.apache.org/r/24555/diff/ Testing --- ./configure make check ./configure --disable-bundled make check For prefixed installs require updated PYTHON_PATH. Thanks, Timothy St. Clair
Re: Review Request 24563: MESOS-1693: enable build against non-x86 arch
On Aug. 11, 2014, 4:57 p.m., Dominic Hamon wrote: Have you tested this on ppc? Timothy St. Clair wrote: Tested no, but it should enable the build now, which was the goal at this point. Please test this locally before updating upstream. - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24563/#review50186 --- On Aug. 11, 2014, 4:45 p.m., Timothy St. Clair wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24563/ --- (Updated Aug. 11, 2014, 4:45 p.m.) Review request for mesos, Adam B and Vinod Kone. Bugs: MESOS-1693 https://issues.apache.org/jira/browse/MESOS-1693 Repository: mesos-git Description --- Enable building against non-x86 arch, namely arm builders on Fedora. Diffs - 3rdparty/libprocess/include/process/internal.hpp 9f478ec 3rdparty/libprocess/src/process.cpp 14cf317 configure.ac 8fb0a3a Diff: https://reviews.apache.org/r/24563/diff/ Testing --- make check Thanks, Timothy St. Clair
Re: Review Request 24555: MESOS-1169: unbundle distribute
On Aug. 11, 2014, 6:50 p.m., Vinod Kone wrote: Have you tested this with a prefix installed 'distribute'? Has to be PYTHONPATH, on this one. - Timothy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24555/#review50210 --- On Aug. 11, 2014, 3:43 p.m., Timothy St. Clair wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24555/ --- (Updated Aug. 11, 2014, 3:43 p.m.) Review request for mesos, Adam B and Vinod Kone. Bugs: MESOS-1169 https://issues.apache.org/jira/browse/MESOS-1169 Repository: mesos-git Description --- Enabling unbundling for distribute python utils. Diffs - 3rdparty/Makefile.am 70b45fe configure.ac 8fb0a3a mpi/mpiexec-mesos.in 8812ee2 src/examples/python/test-containerizer.in f71828d src/examples/python/test-executor.in b22e7a7 src/examples/python/test-framework.in 64fb1dd Diff: https://reviews.apache.org/r/24555/diff/ Testing --- ./configure make check ./configure --disable-bundled make check For prefixed installs require updated PYTHON_PATH. Thanks, Timothy St. Clair
Re: Review Request 24563: MESOS-1693: enable build against non-x86 arch
On Aug. 11, 2014, 4:57 p.m., Dominic Hamon wrote: Have you tested this on ppc? Timothy St. Clair wrote: Tested no, but it should enable the build now, which was the goal at this point. Vinod Kone wrote: Please test this locally before updating upstream. It's been tested on existing platforms, but I don't have resources to test ppc ... I just figure we should not inhibit their ability to build as I've been explicitly asked to enable. - Timothy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24563/#review50186 --- On Aug. 11, 2014, 4:45 p.m., Timothy St. Clair wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24563/ --- (Updated Aug. 11, 2014, 4:45 p.m.) Review request for mesos, Adam B and Vinod Kone. Bugs: MESOS-1693 https://issues.apache.org/jira/browse/MESOS-1693 Repository: mesos-git Description --- Enable building against non-x86 arch, namely arm builders on Fedora. Diffs - 3rdparty/libprocess/include/process/internal.hpp 9f478ec 3rdparty/libprocess/src/process.cpp 14cf317 configure.ac 8fb0a3a Diff: https://reviews.apache.org/r/24563/diff/ Testing --- make check Thanks, Timothy St. Clair
Re: Review Request 23086: MESOS-1174: Update system check to unbundle protobuf
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23086/ --- (Updated Aug. 11, 2014, 7:11 p.m.) Review request for mesos, Benjamin Hindman and Vinod Kone. Changes --- rebase per request. Bugs: MESOS-1174 https://issues.apache.org/jira/browse/MESOS-1174 Repository: mesos-git Description --- Enable mesos to build against system installed version of protobuf. Diffs (updated) - 3rdparty/libprocess/3rdparty/Makefile.am 497d038 3rdparty/libprocess/configure.ac 7b39e63 configure.ac 8fb0a3a mpi/mpiexec-mesos.in 8812ee2 src/Makefile.am 39af036 src/examples/java/test-exception-framework.in 065f3c0 src/examples/java/test-executor.in 35559d2 src/examples/java/test-framework.in 9af48f9 src/examples/java/test-log.in 8afed0d src/examples/java/test-multiple-executors-framework.in 235eb23 src/examples/python/test-containerizer.in f71828d src/examples/python/test-executor.in b22e7a7 src/examples/python/test-framework.in 64fb1dd src/python/native/ext_modules.py.in 477e63d Diff: https://reviews.apache.org/r/23086/diff/ Testing --- make check Thanks, Timothy St. Clair
Re: Review Request 24407: Use curl-config to locate lib curl when possible
On Aug. 8, 2014, 6:31 p.m., Timothy St. Clair wrote: why not follow the prefix pattern if it's in a non-standard location --with-curl=/my/custom/path? Chris Heller wrote: I have no problem with that suggestion. I've created a new patch which adds --with-curl (and also supports --with-sasl2 and --with-zlib). Would it be OK to attach the patch to this review, or is it better to close this out and submit again? Feel free to attach to update the patch to this review for the curl mod, then we can create a JIRA and update for the other dep(s). - Timothy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24407/#review50057 --- On Aug. 6, 2014, 7:37 p.m., Chris Heller wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24407/ --- (Updated Aug. 6, 2014, 7:37 p.m.) Review request for mesos and Timothy St. Clair. Repository: mesos-git Description --- If libcurl.a is located on a non-standard path, the test for libcurl in the configure script fails, even if the path is specified in LDFLAGS. To work around this we can use curl-config to provide the needed path and link options to the compiler. This patch modifies configure.ac to check for curl-config and use its output as an argument to AC_CHECK_LIB if possible. Diffs - configure.ac a9cc6df Diff: https://reviews.apache.org/r/24407/diff/ Testing --- Tested this on Ubuntu 12.04 against master with libcurl in a path not included in LDFLAGS. Thanks, Chris Heller
Re: Review Request 24407: Use curl-config to locate lib curl when possible
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24407/ --- (Updated Aug. 11, 2014, 7:28 p.m.) Review request for mesos and Timothy St. Clair. Changes --- Adds --with-xxx flags for required libs: curl, sasl2 and zlib. These flags can be used to point to non-standard paths when in use. Repository: mesos-git Description --- If libcurl.a is located on a non-standard path, the test for libcurl in the configure script fails, even if the path is specified in LDFLAGS. To work around this we can use curl-config to provide the needed path and link options to the compiler. This patch modifies configure.ac to check for curl-config and use its output as an argument to AC_CHECK_LIB if possible. Diffs - configure.ac a9cc6df Diff: https://reviews.apache.org/r/24407/diff/ Testing --- Tested this on Ubuntu 12.04 against master with libcurl in a path not included in LDFLAGS. File Attachments (updated) Add --with-curl, --with-sasl2, --with-zlib to configure https://reviews.apache.org/media/uploaded/files/2014/08/11/32382e61-68c9-44d4-8a39-a80c3f9e24e1___configure_with_libs.patch Thanks, Chris Heller
Re: Review Request 24562: ZK URL Parsing Consolidation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24562/ --- (Updated Aug. 11, 2014, 7:54 p.m.) Review request for mesos, Adam B and Ben Mahler. Changes --- good catch. I'm not sure how that was introduced and style check didn't catch. Repository: mesos-git Description --- Consolidated redundant code for zk url parsing. Through that, identified a test that used zk file for something other than zk. Fixed test, and added test for file parsing. It is tough to know if something other than zk can be in the file (assuming it is a zk file). If other things can go into the file in question, then I can create a file parser. The current URL::Parser lives in the zookeeper namespace. This patch also completes several documented todo is the code. Diffs (updated) - src/master/contender.cpp c1bf82b621d6b46afe001acafe9ee53336726406 src/master/detector.cpp 6436b8ee7e1ab6451a6b999a1cfbb2f79190e6ca src/tests/master_contender_detector_tests.cpp fdddfa1a9c793bb406d85d214a18ca4ced53b09f src/zookeeper/url.hpp 16e711c5c0bc29b1967a20f0827238f8a7b0deaf Diff: https://reviews.apache.org/r/24562/diff/ Testing --- 1 test changed and 1 test added to: master_contender_detector_tests.cpp MasterContenderDetectorTest BasicMasterContenderDetectorTest all tests pass including styling. Thanks, Ken Sipe
Re: Review Request 24562: ZK URL Parsing Consolidation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24562/#review50222 --- Just a quick drive by review here, nothing complete. src/master/detector.cpp https://reviews.apache.org/r/24562/#comment87871 The original intent _was_ to enable putting something like 'ip:port' in the file, which this change no longer supports, but I don't actually know if that is being used anywhere in production. :-( - Benjamin Hindman On Aug. 11, 2014, 7:54 p.m., Ken Sipe wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24562/ --- (Updated Aug. 11, 2014, 7:54 p.m.) Review request for mesos, Adam B and Ben Mahler. Repository: mesos-git Description --- Consolidated redundant code for zk url parsing. Through that, identified a test that used zk file for something other than zk. Fixed test, and added test for file parsing. It is tough to know if something other than zk can be in the file (assuming it is a zk file). If other things can go into the file in question, then I can create a file parser. The current URL::Parser lives in the zookeeper namespace. This patch also completes several documented todo is the code. Diffs - src/master/contender.cpp c1bf82b621d6b46afe001acafe9ee53336726406 src/master/detector.cpp 6436b8ee7e1ab6451a6b999a1cfbb2f79190e6ca src/tests/master_contender_detector_tests.cpp fdddfa1a9c793bb406d85d214a18ca4ced53b09f src/zookeeper/url.hpp 16e711c5c0bc29b1967a20f0827238f8a7b0deaf Diff: https://reviews.apache.org/r/24562/diff/ Testing --- 1 test changed and 1 test added to: master_contender_detector_tests.cpp MasterContenderDetectorTest BasicMasterContenderDetectorTest all tests pass including styling. Thanks, Ken Sipe
Re: Review Request 24541: Added a JSON::Object::find.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24541/#review50208 --- Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp https://reviews.apache.org/r/24541/#comment87824 Maybe a small comment about the fact that this supports nesting? Doesn't seem implied from the signature. As another example, this doesn't support indexing: a.b[1].c Kind of reminds me of xpath mapped to json: http://goessner.net/articles/JsonPath/ Should 'key' be renamed to 'path' to suggest the nested nature? 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp https://reviews.apache.org/r/24541/#comment87826 Seems like this should be an Error() or None() since it's due to invalid input from the caller and we have a Result? - Ben Mahler On Aug. 11, 2014, 7:03 a.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24541/ --- (Updated Aug. 11, 2014, 7:03 a.m.) Review request for mesos, Ben Mahler and Timothy Chen. Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 0ce002c1eb269095ba39cf901acaf2687225c464 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp ee82d152b0df5c62188e097aef7b6a335b893285 Diff: https://reviews.apache.org/r/24541/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 23086: MESOS-1174: Update system check to unbundle protobuf
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23086/#review50231 --- configure.ac https://reviews.apache.org/r/23086/#comment87876 Can you make sure to look in the user supplied protobuf path (with_protobuf) for protoc? You might also want to do a AC_SUBST to pass it through. src/examples/python/test-executor.in https://reviews.apache.org/r/23086/#comment87879 Here and in other example python scripts below, do you want to pass PROTOBUF_EGG from configure.ac, similar to what you did with PROTOBUF_JAR? I think that would be more cleaner? src/examples/python/test-executor.in https://reviews.apache.org/r/23086/#comment87880 I think we should test whether protobuf is present on PYTHONPATH. How about testing if python -c 'import google.protobuf' works? Longer term, the idiomatic way of doing this seems to be using virtualenv/pip, but lets not worry about that in this review. - Vinod Kone On Aug. 11, 2014, 7:11 p.m., Timothy St. Clair wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23086/ --- (Updated Aug. 11, 2014, 7:11 p.m.) Review request for mesos, Benjamin Hindman and Vinod Kone. Bugs: MESOS-1174 https://issues.apache.org/jira/browse/MESOS-1174 Repository: mesos-git Description --- Enable mesos to build against system installed version of protobuf. Diffs - 3rdparty/libprocess/3rdparty/Makefile.am 497d038 3rdparty/libprocess/configure.ac 7b39e63 configure.ac 8fb0a3a mpi/mpiexec-mesos.in 8812ee2 src/Makefile.am 39af036 src/examples/java/test-exception-framework.in 065f3c0 src/examples/java/test-executor.in 35559d2 src/examples/java/test-framework.in 9af48f9 src/examples/java/test-log.in 8afed0d src/examples/java/test-multiple-executors-framework.in 235eb23 src/examples/python/test-containerizer.in f71828d src/examples/python/test-executor.in b22e7a7 src/examples/python/test-framework.in 64fb1dd src/python/native/ext_modules.py.in 477e63d Diff: https://reviews.apache.org/r/23086/diff/ Testing --- make check Thanks, Timothy St. Clair
Re: Review Request 24555: MESOS-1169: unbundle distribute
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24555/#review50234 --- mpi/mpiexec-mesos.in https://reviews.apache.org/r/24555/#comment87882 Similar to earlier review on protobuf, can we do a python import test here to ensure the PYTHONPATH includes distribute? - Vinod Kone On Aug. 11, 2014, 3:43 p.m., Timothy St. Clair wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24555/ --- (Updated Aug. 11, 2014, 3:43 p.m.) Review request for mesos, Adam B and Vinod Kone. Bugs: MESOS-1169 https://issues.apache.org/jira/browse/MESOS-1169 Repository: mesos-git Description --- Enabling unbundling for distribute python utils. Diffs - 3rdparty/Makefile.am 70b45fe configure.ac 8fb0a3a mpi/mpiexec-mesos.in 8812ee2 src/examples/python/test-containerizer.in f71828d src/examples/python/test-executor.in b22e7a7 src/examples/python/test-framework.in 64fb1dd Diff: https://reviews.apache.org/r/24555/diff/ Testing --- ./configure make check ./configure --disable-bundled make check For prefixed installs require updated PYTHON_PATH. Thanks, Timothy St. Clair
Re: Review Request 23104: Added documentation for authorization.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23104/#review50236 --- docs/authorization.md https://reviews.apache.org/r/23104/#comment87886 Vinod, can you clarify the diff between users and roles objects? In framework like aurora, the role is the unix user that run the task on mesos slave. In this situation, how they are different? - Bhuvan Arumugam On June 27, 2014, 9:52 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23104/ --- (Updated June 27, 2014, 9:52 p.m.) Review request for mesos, Benjamin Hindman and Ben Mahler. Bugs: MESOS-1480 https://issues.apache.org/jira/browse/MESOS-1480 Repository: mesos-git Description --- Let me know what you think. Diffs - docs/authorization.md PRE-CREATION Diff: https://reviews.apache.org/r/23104/diff/ Testing --- Thanks, Vinod Kone
Re: Review Request 24569: Added missing 'defer' helpers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24569/#review50238 --- Ship it! This seems to have fixed MESOS-1692. Thanks! - Brenden Matthews On Aug. 11, 2014, 6:45 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24569/ --- (Updated Aug. 11, 2014, 6:45 p.m.) Review request for mesos and Jie Yu. Bugs: MESOS-1692 https://issues.apache.org/jira/browse/MESOS-1692 Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/include/process/defer.hpp dce7f3b71fc30e28fe55b2ed20ea48090aa57781 3rdparty/libprocess/include/process/future.hpp db7fcbcff34bcb82c62689e7019b416fdad20048 Diff: https://reviews.apache.org/r/24569/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 24475: Add new Docker configurations
On Aug. 11, 2014, 4:34 a.m., Benjamin Hindman wrote: src/slave/containerizer/docker.cpp, lines 670-671 https://reviews.apache.org/r/24475/diff/2/?file=657110#file657110line670 Please comment on MESOS-1686 since it was addressing this code that you're now killing. I don't think MESOS-1686 is related at all? - Timothy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24475/#review50135 --- On Aug. 10, 2014, 7:39 a.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24475/ --- (Updated Aug. 10, 2014, 7:39 a.m.) Review request for mesos, Benjamin Hindman, Ian Downes, and Jie Yu. Repository: mesos-git Description --- Added new DockerInfo for future docker options, and allow command uris to be fetched and mapped into docker before launching docker container. Diffs - include/mesos/mesos.proto cc9f20e src/docker/docker.hpp 98b2d60 src/docker/docker.cpp 1cba381 src/slave/containerizer/containerizer.hpp 02754cd src/slave/containerizer/containerizer.cpp c91ba38 src/slave/containerizer/docker.cpp 904cdd3 src/slave/containerizer/mesos/containerizer.cpp 694c9d1 src/slave/slave.cpp 787bd05 src/tests/docker_containerizer_tests.cpp a559836 src/tests/docker_tests.cpp 4ef1df4 Diff: https://reviews.apache.org/r/24475/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 23104: Added documentation for authorization.
On Aug. 11, 2014, 9:30 p.m., Bhuvan Arumugam wrote: docs/authorization.md, line 38 https://reviews.apache.org/r/23104/diff/2/?file=619935#file619935line38 Vinod, can you clarify the diff between users and roles objects? In framework like aurora, the role is the unix user that run the task on mesos slave. In this situation, how they are different? Hey Bhuvan. The term roles refers to different things in Mesos and Aurora (and probably other frameworks). In Mesos, roles are tags used for resources and used in allocation. It has nothing to do with the unix user that is used to launch the task/executor. I would confirm with Aurora, but I think an Aurora 'role' maps to Mesos 'user'. - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23104/#review50236 --- On June 27, 2014, 9:52 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23104/ --- (Updated June 27, 2014, 9:52 p.m.) Review request for mesos, Benjamin Hindman and Ben Mahler. Bugs: MESOS-1480 https://issues.apache.org/jira/browse/MESOS-1480 Repository: mesos-git Description --- Let me know what you think. Diffs - docs/authorization.md PRE-CREATION Diff: https://reviews.apache.org/r/23104/diff/ Testing --- Thanks, Vinod Kone
Re: Review Request 24475: Add new Docker configurations
On Aug. 11, 2014, 4:34 a.m., Benjamin Hindman wrote: src/slave/containerizer/docker.cpp, lines 670-671 https://reviews.apache.org/r/24475/diff/2/?file=657110#file657110line670 Please comment on MESOS-1686 since it was addressing this code that you're now killing. Timothy Chen wrote: I don't think MESOS-1686 is related at all? Oops! I meant MESOS-1691. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24475/#review50135 --- On Aug. 10, 2014, 7:39 a.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24475/ --- (Updated Aug. 10, 2014, 7:39 a.m.) Review request for mesos, Benjamin Hindman, Ian Downes, and Jie Yu. Repository: mesos-git Description --- Added new DockerInfo for future docker options, and allow command uris to be fetched and mapped into docker before launching docker container. Diffs - include/mesos/mesos.proto cc9f20e src/docker/docker.hpp 98b2d60 src/docker/docker.cpp 1cba381 src/slave/containerizer/containerizer.hpp 02754cd src/slave/containerizer/containerizer.cpp c91ba38 src/slave/containerizer/docker.cpp 904cdd3 src/slave/containerizer/mesos/containerizer.cpp 694c9d1 src/slave/slave.cpp 787bd05 src/tests/docker_containerizer_tests.cpp a559836 src/tests/docker_tests.cpp 4ef1df4 Diff: https://reviews.apache.org/r/24475/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 23104: Added documentation for authorization.
On Aug. 11, 2014, 9:30 p.m., Bhuvan Arumugam wrote: docs/authorization.md, line 38 https://reviews.apache.org/r/23104/diff/2/?file=619935#file619935line38 Vinod, can you clarify the diff between users and roles objects? In framework like aurora, the role is the unix user that run the task on mesos slave. In this situation, how they are different? Vinod Kone wrote: Hey Bhuvan. The term roles refers to different things in Mesos and Aurora (and probably other frameworks). In Mesos, roles are tags used for resources and used in allocation. It has nothing to do with the unix user that is used to launch the task/executor. I would confirm with Aurora, but I think an Aurora 'role' maps to Mesos 'user'. Also, FYI, the ACLs format of this yet-to-be-released feature has been updated recently. So, please make sure to check the updated doc at https://github.com/apache/mesos/blob/master/docs/authorization.md if you've already been using it. - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23104/#review50236 --- On June 27, 2014, 9:52 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23104/ --- (Updated June 27, 2014, 9:52 p.m.) Review request for mesos, Benjamin Hindman and Ben Mahler. Bugs: MESOS-1480 https://issues.apache.org/jira/browse/MESOS-1480 Repository: mesos-git Description --- Let me know what you think. Diffs - docs/authorization.md PRE-CREATION Diff: https://reviews.apache.org/r/23104/diff/ Testing --- Thanks, Vinod Kone
Re: Review Request 18489: Changed string returns to const references.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18489/ --- (Updated Aug. 11, 2014, 3:43 p.m.) Review request for mesos, Benjamin Hindman and Ben Mahler. Changes --- rebased Bugs: MESOS-1147 https://issues.apache.org/jira/browse/MESOS-1147 Repository: mesos-git Description --- See summary Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp 3a10379f13bdf9ff9e6d424ed1877539c30f2731 3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp d99b75aeae10319b574c67beeb6023358cac7aec Diff: https://reviews.apache.org/r/18489/diff/ Testing --- make check Thanks, Dominic Hamon
Re: Review Request 24537: Updated metrics::Timer::stop to return elapsed time.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24537/#review50251 --- Ship it! 3rdparty/libprocess/include/process/metrics/timer.hpp https://reviews.apache.org/r/24537/#comment87928 Can we now remove this variable in favor of 'push(t.value())' below? - Ben Mahler On Aug. 11, 2014, 3:34 a.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24537/ --- (Updated Aug. 11, 2014, 3:34 a.m.) Review request for mesos and Ben Mahler. Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/include/process/metrics/timer.hpp dfd7dd951f0997689dc08fed02a6e621c8d4683f Diff: https://reviews.apache.org/r/24537/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 24537: Updated metrics::Timer::stop to return elapsed time.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24537/#review50253 --- Ship it! 3rdparty/libprocess/include/process/metrics/timer.hpp https://reviews.apache.org/r/24537/#comment87933 maybe also return the time from this too for symmetry? - Dominic Hamon On Aug. 10, 2014, 8:34 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24537/ --- (Updated Aug. 10, 2014, 8:34 p.m.) Review request for mesos and Ben Mahler. Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/include/process/metrics/timer.hpp dfd7dd951f0997689dc08fed02a6e621c8d4683f Diff: https://reviews.apache.org/r/24537/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 24464: Redirect docker logs
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24464/#review50206
---
Synced with BenH on this patch. Here is our comments. Let us know if you have
any question! Thanks Tim!
src/docker/docker.hpp
https://reviews.apache.org/r/24464/#comment87883
s/LogStream/Logs/
so you'll have logs.out() and logs.err() which reads pretty good.
src/docker/docker.hpp
https://reviews.apache.org/r/24464/#comment87878
Instead of saving pid, out, err, status, could we just store the subprocess
itself? That's much more clear to me.
Also, I'm not convinced that we should save containerName in Logs class
because you'll just need that for logging, right? These loggings are supposed
to be done by the containerizer.
src/docker/docker.hpp
https://reviews.apache.org/r/24464/#comment87905
Instead of overloading close() with some 'wait' semantics, what about
having another function 'wait()':
// Stop the log stream. (Please remove the const as a
// close does not sound like a const function).
void close()
{
if (s.status().isPending()) {
:kill(...);
}
}
// Block until the underlying log process is terminated.
// Returns a failure if any error occurs.
FutureNothing wait()
{
return s.status()
.then(lambda::bind(_wait, lambda::_1));
}
src/docker/docker.hpp
https://reviews.apache.org/r/24464/#comment87885
s/containerName/container/
Here and everywhere else so that it's consistent with other functions (e.g.
'_kill' below).
src/docker/docker.cpp
https://reviews.apache.org/r/24464/#comment87914
These can be killed. See my comments above.
src/docker/docker.cpp
https://reviews.apache.org/r/24464/#comment87911
See my comments above. You can kill those VLOGs.
src/docker/docker.cpp
https://reviews.apache.org/r/24464/#comment87912
Ditto.
src/docker/docker.cpp
https://reviews.apache.org/r/24464/#comment87918
return Logs(s);
You probably want to make the constructor of Docker::Logs private and add
Docker class to the friend list of Docker::Logs.
src/slave/containerizer/docker.cpp
https://reviews.apache.org/r/24464/#comment87924
s/logStreams/logs/
src/slave/containerizer/docker.cpp
https://reviews.apache.org/r/24464/#comment87925
We may want to rename this function to avoid name collision with member
field 'logs'.
s/logs/logging/
src/slave/containerizer/docker.cpp
https://reviews.apache.org/r/24464/#comment87926
s/containerName/name
src/slave/containerizer/docker.cpp
https://reviews.apache.org/r/24464/#comment87929
Please take a look at src/slave/containerizer/mesos/containerizer.cpp where
redirection is handled.
You need to close 'out' and 'err' at least. You may also wanna do cloexec
on out and err.
src/slave/containerizer/docker.cpp
https://reviews.apache.org/r/24464/#comment87820
Kill extra line here.
src/slave/containerizer/docker.cpp
https://reviews.apache.org/r/24464/#comment87927
logs.put(containerId, _logs);
You may want to move this up before opening 'stdout/stderr'. This is
because the opening may fail, if that's the case, you still want to cleanup the
log process, right?
src/slave/containerizer/docker.cpp
https://reviews.apache.org/r/24464/#comment87931
You probably want to do a 'logs.wait()' here:
logs.wait()
.onAny(defer(self(), Self::__logging, ...);
Inside __logging, you can add some logging.
src/slave/containerizer/docker.cpp
https://reviews.apache.org/r/24464/#comment87887
CHECK(!status.isPending());
src/tests/docker_containerizer_tests.cpp
https://reviews.apache.org/r/24464/#comment87889
EXPECT_FALSE(strings::contains(..., out!)); as well to make sure stdout
output is not in stderr.
- Jie Yu
On Aug. 11, 2014, 8:19 a.m., Timothy Chen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24464/
---
(Updated Aug. 11, 2014, 8:19 a.m.)
Review request for mesos, Benjamin Hindman and Jie Yu.
Repository: mesos-git
Description
---
Review: https://reviews.apache.org/r/24464
Diffs
-
src/docker/docker.hpp 98b2d6099988f51f12e7b108e73dcfd0143adc48
src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571
src/slave/containerizer/docker.cpp 904cdd32362591777aecaa58e723af36419f011c
src/tests/docker_containerizer_tests.cpp
a559836dd11a9a97e5939364c4b35a8dbb6a503d
Diff: https://reviews.apache.org/r/24464/diff/
Testing
---
make check
Thanks,
Timothy Chen
Re: Review Request 24541: Added a JSON::Object::find.
On Aug. 11, 2014, 8:38 p.m., Ben Mahler wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp, lines 85-86 https://reviews.apache.org/r/24541/diff/1/?file=657521#file657521line85 Maybe a small comment about the fact that this supports nesting? Doesn't seem implied from the signature. As another example, this doesn't support indexing: a.b[1].c Kind of reminds me of xpath mapped to json: http://goessner.net/articles/JsonPath/ Should 'key' be renamed to 'path' to suggest the nested nature? Added a comment, included a TODO to support indexing. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24541/#review50208 --- On Aug. 11, 2014, 7:03 a.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24541/ --- (Updated Aug. 11, 2014, 7:03 a.m.) Review request for mesos, Ben Mahler and Timothy Chen. Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 0ce002c1eb269095ba39cf901acaf2687225c464 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp ee82d152b0df5c62188e097aef7b6a335b893285 Diff: https://reviews.apache.org/r/24541/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 24541: Added a JSON::Object::find.
On Aug. 11, 2014, 7:23 a.m., Timothy Chen wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp, line 223 https://reviews.apache.org/r/24541/diff/1/?file=657521#file657521line223 It will be ideal if we can print the found type, but it's fine if it's too much to do as I don't see a simple way to do so. Added a TODO. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24541/#review50168 --- On Aug. 11, 2014, 7:03 a.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24541/ --- (Updated Aug. 11, 2014, 7:03 a.m.) Review request for mesos, Ben Mahler and Timothy Chen. Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 0ce002c1eb269095ba39cf901acaf2687225c464 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp ee82d152b0df5c62188e097aef7b6a335b893285 Diff: https://reviews.apache.org/r/24541/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 22313: MESOS-886: Prevented slave from launching tasks before containerize's update completes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22313/#review50239 --- src/slave/slave.cpp https://reviews.apache.org/r/22313/#comment87891 I don't think we need to send an update here because when an executor terminates, we send the update for this task (since it is launched tasks) in executorTerminated(). So just return here. src/slave/slave.cpp https://reviews.apache.org/r/22313/#comment87890 I think you also want to return immediately if executor is in TERMINATING/TERMINATED state. src/tests/slave_tests.cpp https://reviews.apache.org/r/22313/#comment87892 s/finishing/finishes/ src/tests/slave_tests.cpp https://reviews.apache.org/r/22313/#comment87895 Why do you need to advance the clock? reviveOffers() should do an immediate allocation. src/tests/slave_tests.cpp https://reviews.apache.org/r/22313/#comment87904 s/updateCall/update/ src/tests/slave_tests.cpp https://reviews.apache.org/r/22313/#comment87903 s/runTask/_runTask/ new line after this. src/tests/slave_tests.cpp https://reviews.apache.org/r/22313/#comment87906 I think you can get rid of 'runTask' future and just work with 'updateCall' future. Any reason to need both? src/tests/slave_tests.cpp https://reviews.apache.org/r/22313/#comment87907 ditto. i don't think you need to advance the clock? src/tests/slave_tests.cpp https://reviews.apache.org/r/22313/#comment87908 s/updateCall/update/ src/tests/slave_tests.cpp https://reviews.apache.org/r/22313/#comment87909 Why is the driver.join() here instead of immediately after driver.stop() above? src/tests/slave_tests.cpp https://reviews.apache.org/r/22313/#comment87920 Why are you failing the promise here? Don't you want to set it to Nothing and then make sure that task doesn't launch? Otherwise, what you are testing is containerizer update failure path and not executor/framework removed path. src/tests/slave_tests.cpp https://reviews.apache.org/r/22313/#comment87921 This should be split up for task1 expectation here and task2 expectation later when that task is launched. src/tests/slave_tests.cpp https://reviews.apache.org/r/22313/#comment87922 declare status2 where its expectation is declared. src/tests/slave_tests.cpp https://reviews.apache.org/r/22313/#comment87923 Kill this? Why would there be subsequent updates here? src/tests/slave_tests.cpp https://reviews.apache.org/r/22313/#comment87941 no need to advance? - Vinod Kone On Aug. 6, 2014, 1:11 a.m., Yifan Gu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22313/ --- (Updated Aug. 6, 2014, 1:11 a.m.) Review request for mesos, Ian Downes and Vinod Kone. Bugs: MESOS-886 https://issues.apache.org/jira/browse/MESOS-886 Repository: mesos-git Description --- Added __runTask() to wait for the completion of containerizer-update() and check the result before sending RunTaskMessage. Diffs - src/slave/slave.hpp c12cd0a src/slave/slave.cpp c56cac8 src/tests/slave_tests.cpp 3a7fee6 Diff: https://reviews.apache.org/r/22313/diff/ Testing --- SlaveTest.WillNotLaunchTaskBeforeContainerizerUpdate SlaveTest.WillNotLaunchTaskIfFrameworkIsRemoved SlaveTest.LaunchTaskAfterContainerizerUpdate ./bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure --gtest_filter=*LaunchTask* successful times 2000 make check File Attachments framework will exit https://reviews.apache.org/media/uploaded/files/2014/06/18/fbe73273-7aa9-4faa-b1c5-003ab03042a9__issue-886.diff log https://reviews.apache.org/media/uploaded/files/2014/06/18/84d801a0-5c2a-4bb9-901b-e1962031461c__log Thanks, Yifan Gu
Re: Review Request 18489: Changed string returns to const references.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18489/#review50256 --- Ship it! Thanks Dominic, a few suggestions: (1) What about a clearer review subject (commit message): 'Changed Result::error() and Try::error() to return const references. (2) Since 'make check' can miss callers that take a const reference that will now go out of scope and become invalid, can you do a visual audit of all the callers before you commit this change? Will you be following through with Future::failure()? Same thing applies there. - Ben Mahler On Aug. 11, 2014, 10:43 p.m., Dominic Hamon wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18489/ --- (Updated Aug. 11, 2014, 10:43 p.m.) Review request for mesos, Benjamin Hindman and Ben Mahler. Bugs: MESOS-1147 https://issues.apache.org/jira/browse/MESOS-1147 Repository: mesos-git Description --- See summary Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp 3a10379f13bdf9ff9e6d424ed1877539c30f2731 3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp d99b75aeae10319b574c67beeb6023358cac7aec Diff: https://reviews.apache.org/r/18489/diff/ Testing --- make check Thanks, Dominic Hamon
Re: Review Request 22313: MESOS-886: Prevented slave from launching tasks before containerize's update completes.
On June 23, 2014, 6:50 p.m., Vinod Kone wrote: src/slave/slave.cpp, line 1185 https://reviews.apache.org/r/22313/diff/11/?file=612826#file612826line1185 Also, what about launching the tasks after updating resources in registerExecutor()? Yifan Gu wrote: Sounds good, Should I do it in this patch or open a new JIRA? Vinod Kone wrote: this one is fine. in fact i would prefer to registerExecutor() one first because that is going to affect all executors. the one in launchTask() when executor is RUNNING can be done latter (maybe in a subsequent patch) because that only affects executors that have multiple tasks. Yifan Gu wrote: Ok. Will do, I just reverted this patch. Yifan Gu wrote: And I found we need to do this too in reregisterExecutor()... Vinod Kone wrote: What did you revert? I still see container update() being called in runTask(). Yifan Gu wrote: Sorry for confusion. By 'revert' I mean now, I don't put the executor in pending anymore, and I do a check on NULL framework and NULL executor as before. I haven't done the (re)registerExecutor() stuff. Will try to do it tomorrow. But still, I will need some review on this one, since the approach on (re)registerExecutor will almost be the same as this one. Thanks Vinod! Vinod Kone wrote: OK. Can you resolve or drop (with comments) the issues that were raised? Can you add a TODO and open a ticket to track this? - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22313/#review46429 --- On Aug. 6, 2014, 1:11 a.m., Yifan Gu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22313/ --- (Updated Aug. 6, 2014, 1:11 a.m.) Review request for mesos, Ian Downes and Vinod Kone. Bugs: MESOS-886 https://issues.apache.org/jira/browse/MESOS-886 Repository: mesos-git Description --- Added __runTask() to wait for the completion of containerizer-update() and check the result before sending RunTaskMessage. Diffs - src/slave/slave.hpp c12cd0a src/slave/slave.cpp c56cac8 src/tests/slave_tests.cpp 3a7fee6 Diff: https://reviews.apache.org/r/22313/diff/ Testing --- SlaveTest.WillNotLaunchTaskBeforeContainerizerUpdate SlaveTest.WillNotLaunchTaskIfFrameworkIsRemoved SlaveTest.LaunchTaskAfterContainerizerUpdate ./bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure --gtest_filter=*LaunchTask* successful times 2000 make check File Attachments framework will exit https://reviews.apache.org/media/uploaded/files/2014/06/18/fbe73273-7aa9-4faa-b1c5-003ab03042a9__issue-886.diff log https://reviews.apache.org/media/uploaded/files/2014/06/18/84d801a0-5c2a-4bb9-901b-e1962031461c__log Thanks, Yifan Gu
Re: Review Request 18489: Changed Try::error and Result::error to return const references.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18489/ --- (Updated Aug. 11, 2014, 4:10 p.m.) Review request for mesos, Benjamin Hindman and Ben Mahler. Changes --- updated summary/commit message Summary (updated) - Changed Try::error and Result::error to return const references. Bugs: MESOS-1147 https://issues.apache.org/jira/browse/MESOS-1147 Repository: mesos-git Description --- See summary Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp 3a10379f13bdf9ff9e6d424ed1877539c30f2731 3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp d99b75aeae10319b574c67beeb6023358cac7aec Diff: https://reviews.apache.org/r/18489/diff/ Testing --- make check Thanks, Dominic Hamon
Re: Review Request 18489: Changed Try::error and Result::error to return const references.
On Aug. 11, 2014, 3:57 p.m., Ben Mahler wrote: Thanks Dominic, a few suggestions: (1) What about a clearer review subject (commit message): 'Changed Result::error() and Try::error() to return const references. (2) Since 'make check' can miss callers that take a const reference that will now go out of scope and become invalid, can you do a visual audit of all the callers before you commit this change? Will you be following through with Future::failure()? Same thing applies there. 1. done 2. done - everything is either copied into a string or appended to another string (thus copied to a string). i didn't see a ticket for failure. i can add something. - Dominic --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18489/#review50256 --- On Aug. 11, 2014, 4:10 p.m., Dominic Hamon wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18489/ --- (Updated Aug. 11, 2014, 4:10 p.m.) Review request for mesos, Benjamin Hindman and Ben Mahler. Bugs: MESOS-1147 https://issues.apache.org/jira/browse/MESOS-1147 Repository: mesos-git Description --- See summary Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp 3a10379f13bdf9ff9e6d424ed1877539c30f2731 3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp d99b75aeae10319b574c67beeb6023358cac7aec Diff: https://reviews.apache.org/r/18489/diff/ Testing --- make check Thanks, Dominic Hamon
Re: Review Request 24569: Added missing 'defer' helpers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24569/#review50260 --- Ship it! LGTM! 3rdparty/libprocess/include/process/defer.hpp https://reviews.apache.org/r/24569/#comment87948 s/set/associate/ - Jie Yu On Aug. 11, 2014, 6:45 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24569/ --- (Updated Aug. 11, 2014, 6:45 p.m.) Review request for mesos and Jie Yu. Bugs: MESOS-1692 https://issues.apache.org/jira/browse/MESOS-1692 Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/include/process/defer.hpp dce7f3b71fc30e28fe55b2ed20ea48090aa57781 3rdparty/libprocess/include/process/future.hpp db7fcbcff34bcb82c62689e7019b416fdad20048 Diff: https://reviews.apache.org/r/24569/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 24475: Add new Docker configurations
On Aug. 11, 2014, 4:34 a.m., Benjamin Hindman wrote: src/slave/containerizer/docker.cpp, lines 246-247 https://reviews.apache.org/r/24475/diff/2/?file=657110#file657110line246 It doesn't look like you're every putting containers into 'fetching'! Also, this is starting to get a lot more complicated, so I'd suggest adding both comments and CHECKs as much as possible (a CHECK would have caught your bug!). As in, IIUC, now you're expecting that 'fetching' and 'promises' are disjoint, and that a container transitions through from fetching to launched, i.e., from the 'fetching' set to the 'promises' set. Am I correct? Let's make it easier for other people to understand these semantics. Also, I'm assuming that you didn't want to just put the container in 'promises' until after fetching is complete because it was easier to cleanup after fetching (whether it's successful or an failure) by just removing from 'fetching', but I wanted to mention that you can use .onFailed to cleanup 'promises' if fetching fails and otherwise just fall through to the next continuation where 'promises' still has the container. I originally don't want to put in promises as I felt I don't want to let docker wait yet as it wasn't clear what I should put in the promise. But thinking about it as you said I'll just use promises and clean up in _fetch. - Timothy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24475/#review50135 --- On Aug. 10, 2014, 7:39 a.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24475/ --- (Updated Aug. 10, 2014, 7:39 a.m.) Review request for mesos, Benjamin Hindman, Ian Downes, and Jie Yu. Repository: mesos-git Description --- Added new DockerInfo for future docker options, and allow command uris to be fetched and mapped into docker before launching docker container. Diffs - include/mesos/mesos.proto cc9f20e src/docker/docker.hpp 98b2d60 src/docker/docker.cpp 1cba381 src/slave/containerizer/containerizer.hpp 02754cd src/slave/containerizer/containerizer.cpp c91ba38 src/slave/containerizer/docker.cpp 904cdd3 src/slave/containerizer/mesos/containerizer.cpp 694c9d1 src/slave/slave.cpp 787bd05 src/tests/docker_containerizer_tests.cpp a559836 src/tests/docker_tests.cpp 4ef1df4 Diff: https://reviews.apache.org/r/24475/diff/ Testing --- make check Thanks, Timothy Chen
Review Request 24583: Added a missing test target in Makefile.am.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24583/ --- Review request for mesos and Jiang Yan Xu. Repository: mesos-git Description --- I've added 'values_tests.cpp' to the targets, also alphabetized the list. Diffs - src/Makefile.am 39af0365e429b8d08addadb09ee18080a19625f8 Diff: https://reviews.apache.org/r/24583/diff/ Testing --- make check Thanks, Ben Mahler
Review Request 24582: Removed unused test file 'process_spawn.cpp'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24582/ --- Review request for mesos and Jiang Yan Xu. Repository: mesos-git Description --- This file was not referenced by anything. Diffs - src/tests/process_spawn.cpp db07ba0e5ddefe6e03683102c3696e46f862168f Diff: https://reviews.apache.org/r/24582/diff/ Testing --- make check Thanks, Ben Mahler
Review Request 24515: Model pending tasks in the Master's metrics and JSON.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24515/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-1620 https://issues.apache.org/jira/browse/MESOS-1620 Repository: mesos-git Description --- We were not surfacing tasks that are pending validation / authorization. These are now surfaced as staging tasks through metrics and through the http state endpoint. Diffs - src/Makefile.am 39af0365e429b8d08addadb09ee18080a19625f8 src/common/http.hpp 8216401e116406da7557f144ea13756013ec1c09 src/common/http.cpp d27fe21cd381ed2b6a52b1246bf6c7db33c0873e src/master/http.cpp f2ca6599eb165c4c1bc4580175fa439f797c832b src/master/master.cpp e688b41b9f2e555acd8fe0da5d3eb4e8bce32211 src/tests/common/http_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/24515/diff/ Testing --- Added a test for the JSON modeling, there were no tests previously. Thanks, Ben Mahler
Review Request 24576: Some Master cleanups.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24576/ --- Review request for mesos, Niklas Nielsen and Vinod Kone. Repository: mesos-git Description --- There were a few cleanups here that I did on the way to MESOS-1620. (1) Remove the need for Offer/Task Visitor memory cleanup by using Owned. (2) Restructured the launch task code to be easier to read and understand. Diffs - src/master/master.cpp e688b41b9f2e555acd8fe0da5d3eb4e8bce32211 Diff: https://reviews.apache.org/r/24576/diff/ Testing --- make check Thanks, Ben Mahler
Review Request 24516: Expose pending tasks during reconciliation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24516/ --- Review request for mesos, Niklas Nielsen and Vinod Kone. Bugs: MESOS-1620 https://issues.apache.org/jira/browse/MESOS-1620 Repository: mesos-git Description --- We were not surfacing tasks that are pending validation / authorization. These are now surfaced as staging tasks Diffs - src/master/master.cpp e688b41b9f2e555acd8fe0da5d3eb4e8bce32211 src/tests/master_authorization_tests.cpp 5c3557752df86e798ba5d804de588db55ddcfbf6 src/tests/reconciliation_tests.cpp 952f29b97e7516a3aa69e599901bf49cd2b6d596 Diff: https://reviews.apache.org/r/24516/diff/ Testing --- Updated the existing test. I also removed the MasterAuthorizationTest.ReconcileTask test because it was redundant with ReconciliationTest.PendingTask. Thanks, Ben Mahler
Re: Review Request 24576: Some Master cleanups.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24576/#review50263 --- src/master/master.cpp https://reviews.apache.org/r/24576/#comment87951 you might want to clear the list or scope it to here. otherwise the pointers remain allocated for the remainder of this method. i doubt it will cause an issue, but i prefer keeping things tightly scoped. btw - https://reviews.apache.org/r/20423 :) - Dominic Hamon On Aug. 11, 2014, 4:32 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24576/ --- (Updated Aug. 11, 2014, 4:32 p.m.) Review request for mesos, Niklas Nielsen and Vinod Kone. Repository: mesos-git Description --- There were a few cleanups here that I did on the way to MESOS-1620. (1) Remove the need for Offer/Task Visitor memory cleanup by using Owned. (2) Restructured the launch task code to be easier to read and understand. Diffs - src/master/master.cpp e688b41b9f2e555acd8fe0da5d3eb4e8bce32211 Diff: https://reviews.apache.org/r/24576/diff/ Testing --- make check Thanks, Ben Mahler
Re: Review Request 24582: Removed unused test file 'process_spawn.cpp'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24582/#review50265 --- Ship it! Ship It! - Jiang Yan Xu On Aug. 11, 2014, 4:32 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24582/ --- (Updated Aug. 11, 2014, 4:32 p.m.) Review request for mesos and Jiang Yan Xu. Repository: mesos-git Description --- This file was not referenced by anything. Diffs - src/tests/process_spawn.cpp db07ba0e5ddefe6e03683102c3696e46f862168f Diff: https://reviews.apache.org/r/24582/diff/ Testing --- make check Thanks, Ben Mahler
Re: Review Request 24583: Added a missing test target in Makefile.am.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24583/#review50266 --- Ship it! So 'values_tests.cpp' was written but never run before? - Jiang Yan Xu On Aug. 11, 2014, 4:32 p.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24583/ --- (Updated Aug. 11, 2014, 4:32 p.m.) Review request for mesos and Jiang Yan Xu. Repository: mesos-git Description --- I've added 'values_tests.cpp' to the targets, also alphabetized the list. Diffs - src/Makefile.am 39af0365e429b8d08addadb09ee18080a19625f8 Diff: https://reviews.apache.org/r/24583/diff/ Testing --- make check Thanks, Ben Mahler
Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2308
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2308/changes Changes: [benjamin.hindman] Added a JSON::Object::find. [dhamon] Changed Try::error and Result::error to return const references. -- [...truncated 2600 lines...] rm -fr .libs/libzookeeper_st.lax/libzkst.a mkdir .libs/libzookeeper_st.lax/libzkst.a (cd .libs/libzookeeper_st.lax/libzkst.a ar x /x1/jenkins/jenkins-slave/workspace/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/build/3rdparty/zookeeper-3.4.5/src/c/./.libs/libzkst.a) rm -fr .libs/libzookeeper_st.lax/libhashtable.a mkdir .libs/libzookeeper_st.lax/libhashtable.a (cd .libs/libzookeeper_st.lax/libhashtable.a ar x /x1/jenkins/jenkins-slave/workspace/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/build/3rdparty/zookeeper-3.4.5/src/c/./.libs/libhashtable.a) ar cru .libs/libzookeeper_st.a .libs/libzookeeper_st.lax/libzkst.a/zookeeper.o .libs/libzookeeper_st.lax/libzkst.a/zookeeper.jute.o .libs/libzookeeper_st.lax/libzkst.a/zk_hashtable.o .libs/libzookeeper_st.lax/libzkst.a/zk_log.o .libs/libzookeeper_st.lax/libzkst.a/recordio.o .libs/libzookeeper_st.lax/libzkst.a/st_adaptor.o .libs/libzookeeper_st.lax/libhashtable.a/hashtable_itr.o .libs/libzookeeper_st.lax/libhashtable.a/hashtable.o ranlib .libs/libzookeeper_st.a rm -fr .libs/libzookeeper_st.lax creating libzookeeper_st.la (cd .libs rm -f libzookeeper_st.la ln -s ../libzookeeper_st.la libzookeeper_st.la) if /bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I. -I. -I./include -I./tests -I./generated -DTHREADED -g -O2 -D_GNU_SOURCE -MT libzkmt_la-zookeeper.lo -MD -MP -MF .deps/libzkmt_la-zookeeper.Tpo -c -o libzkmt_la-zookeeper.lo `test -f 'src/zookeeper.c' || echo './'`src/zookeeper.c; \ then mv -f .deps/libzkmt_la-zookeeper.Tpo .deps/libzkmt_la-zookeeper.Plo; else rm -f .deps/libzkmt_la-zookeeper.Tpo; exit 1; fi gcc -DHAVE_CONFIG_H -I. -I. -I. -I./include -I./tests -I./generated -DTHREADED -g -O2 -D_GNU_SOURCE -MT libzkmt_la-zookeeper.lo -MD -MP -MF .deps/libzkmt_la-zookeeper.Tpo -c src/zookeeper.c -fPIC -DPIC -o libzkmt_la-zookeeper.o if /bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I. -I. -I./include -I./tests -I./generated -DTHREADED -g -O2 -D_GNU_SOURCE -MT libzkmt_la-recordio.lo -MD -MP -MF .deps/libzkmt_la-recordio.Tpo -c -o libzkmt_la-recordio.lo `test -f 'src/recordio.c' || echo './'`src/recordio.c; \ then mv -f .deps/libzkmt_la-recordio.Tpo .deps/libzkmt_la-recordio.Plo; else rm -f .deps/libzkmt_la-recordio.Tpo; exit 1; fi gcc -DHAVE_CONFIG_H -I. -I. -I. -I./include -I./tests -I./generated -DTHREADED -g -O2 -D_GNU_SOURCE -MT libzkmt_la-recordio.lo -MD -MP -MF .deps/libzkmt_la-recordio.Tpo -c src/recordio.c -fPIC -DPIC -o libzkmt_la-recordio.o if /bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I. -I. -I./include -I./tests -I./generated -DTHREADED -g -O2 -D_GNU_SOURCE -MT libzkmt_la-zookeeper.jute.lo -MD -MP -MF .deps/libzkmt_la-zookeeper.jute.Tpo -c -o libzkmt_la-zookeeper.jute.lo `test -f 'generated/zookeeper.jute.c' || echo './'`generated/zookeeper.jute.c; \ then mv -f .deps/libzkmt_la-zookeeper.jute.Tpo .deps/libzkmt_la-zookeeper.jute.Plo; else rm -f .deps/libzkmt_la-zookeeper.jute.Tpo; exit 1; fi gcc -DHAVE_CONFIG_H -I. -I. -I. -I./include -I./tests -I./generated -DTHREADED -g -O2 -D_GNU_SOURCE -MT libzkmt_la-zookeeper.jute.lo -MD -MP -MF .deps/libzkmt_la-zookeeper.jute.Tpo -c generated/zookeeper.jute.c -fPIC -DPIC -o libzkmt_la-zookeeper.jute.o if /bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I. -I. -I./include -I./tests -I./generated -DTHREADED -g -O2 -D_GNU_SOURCE -MT libzkmt_la-zk_log.lo -MD -MP -MF .deps/libzkmt_la-zk_log.Tpo -c -o libzkmt_la-zk_log.lo `test -f 'src/zk_log.c' || echo './'`src/zk_log.c; \ then mv -f .deps/libzkmt_la-zk_log.Tpo .deps/libzkmt_la-zk_log.Plo; else rm -f .deps/libzkmt_la-zk_log.Tpo; exit 1; fi gcc -DHAVE_CONFIG_H -I. -I. -I. -I./include -I./tests -I./generated -DTHREADED -g -O2 -D_GNU_SOURCE -MT libzkmt_la-zk_log.lo -MD -MP -MF .deps/libzkmt_la-zk_log.Tpo -c src/zk_log.c -fPIC -DPIC -o libzkmt_la-zk_log.o if /bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I. -I. -I./include -I./tests -I./generated -DTHREADED -g -O2 -D_GNU_SOURCE -MT libzkmt_la-zk_hashtable.lo -MD -MP -MF .deps/libzkmt_la-zk_hashtable.Tpo -c -o libzkmt_la-zk_hashtable.lo `test -f 'src/zk_hashtable.c' || echo './'`src/zk_hashtable.c; \ then mv -f .deps/libzkmt_la-zk_hashtable.Tpo .deps/libzkmt_la-zk_hashtable.Plo; else rm -f .deps/libzkmt_la-zk_hashtable.Tpo; exit 1; fi gcc -DHAVE_CONFIG_H -I. -I. -I. -I./include -I./tests -I./generated -DTHREADED -g -O2 -D_GNU_SOURCE -MT libzkmt_la-zk_hashtable.lo -MD -MP -MF .deps/libzkmt_la-zk_hashtable.Tpo
