Re: Review Request 24700: Log the user id when receiving a SIGTERM.

2014-08-22 Thread Alexandra Sava

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24700/
---

(Updated Aug. 22, 2014, 1:29 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

First, check if si_uid and si_pid exist and after that use them.


Bugs: MESOS-1567
https://issues.apache.org/jira/browse/MESOS-1567


Repository: mesos-git


Description
---

Log the user id when receiving a SIGTERM. This will make debugging more easy.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/glog.hpp 
5f763e52a6a3d5a7cb38110ea650283b7a9fa789 

Diff: https://reviews.apache.org/r/24700/diff/


Testing
---

* make check
* run master binary and send it SIGTERM signal with kill 


Thanks,

Alexandra Sava



Review Request 24984: Libprocess: Use Content-Length instead of Encoding: Chunked

2014-08-22 Thread Nikita Vetoshkin

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24984/
---

Review request for mesos.


Bugs: MESOS-1625
https://issues.apache.org/jira/browse/MESOS-1625


Repository: mesos-git


Description
---

As mentioned in MESOS-1625 current HTTP Chunked Encoding implementation can 
break clients (e.g. Tornado). As I see no need in Chunked-Encoding because we 
know content size beforehand - I propose to use Content-Length.


Diffs
-

  3rdparty/libprocess/src/encoder.hpp 9c5aa8134c101214d740bf231559ce5b5d51764c 

Diff: https://reviews.apache.org/r/24984/diff/


Testing
---

`make check` and manual testing with golang language native binding


Thanks,

Nikita Vetoshkin



Re: [RESULT][VOTE] Release Apache Mesos 0.20.0 (rc2)

2014-08-22 Thread Henning Schmiedehausen
I seem to be missing the 0.20-rc2 and 0.20 release tags in git.

-h



On Thu, Aug 21, 2014 at 11:59 PM, Jie Yu yujie@gmail.com wrote:
 Hi all,

 The vote for Mesos 0.20.0 (rc2) has passed with the
 following votes.

 +1 (Binding)
 --
 Vinod Kone
 Ian Downes
 Niklas Nielsen
 Tim St Clair

 +1 (Non-binding)
 --
 Timothy Chen

 There were no 0 or -1 votes.

 Please find the release at:
 https://dist.apache.org/repos/dist/release/mesos/0.20.0

 It is recommended to use a mirror to download the release:
 http://www.apache.org/dyn/closer.cgi

 The CHANGELOG for the release is available at:
 https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob_plain;f=CHANGELOG;hb=0.20.0

 The mesos-0.20.0.jar has been released to:
 https://repository.apache.org

 The website (http://mesos.apache.org) will be updated shortly to reflect
 this release.

 Thanks,
 - Jie


Re: [RESULT][VOTE] Release Apache Mesos 0.20.0 (rc2)

2014-08-22 Thread Henning Schmiedehausen
never mind, Tim hooked me up. :-)

-h


On Fri, Aug 22, 2014 at 12:00 PM, Henning Schmiedehausen
henn...@schmiedehausen.org wrote:
 I seem to be missing the 0.20-rc2 and 0.20 release tags in git.

 -h



 On Thu, Aug 21, 2014 at 11:59 PM, Jie Yu yujie@gmail.com wrote:
 Hi all,

 The vote for Mesos 0.20.0 (rc2) has passed with the
 following votes.

 +1 (Binding)
 --
 Vinod Kone
 Ian Downes
 Niklas Nielsen
 Tim St Clair

 +1 (Non-binding)
 --
 Timothy Chen

 There were no 0 or -1 votes.

 Please find the release at:
 https://dist.apache.org/repos/dist/release/mesos/0.20.0

 It is recommended to use a mirror to download the release:
 http://www.apache.org/dyn/closer.cgi

 The CHANGELOG for the release is available at:
 https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob_plain;f=CHANGELOG;hb=0.20.0

 The mesos-0.20.0.jar has been released to:
 https://repository.apache.org

 The website (http://mesos.apache.org) will be updated shortly to reflect
 this release.

 Thanks,
 - Jie


Build failed in Jenkins: mesos-reviewbot #1388

2014-08-22 Thread Apache Jenkins Server
See https://builds.apache.org/job/mesos-reviewbot/1388/

--
[...truncated 10369 lines...]
warning: failed to remove 
mesos-0.21.0/src/java/src/org/apache/mesos/Scheduler.java
warning: failed to remove 
mesos-0.21.0/src/java/src/org/apache/mesos/MesosExecutorDriver.java
warning: failed to remove mesos-0.21.0/src/java/src/org/apache/mesos/Log.java
warning: failed to remove mesos-0.21.0/src/python/interface/setup.py.in
warning: failed to remove 
mesos-0.21.0/src/python/interface/src/mesos/interface/__init__.py
warning: failed to remove 
mesos-0.21.0/src/python/interface/src/mesos/__init__.py
warning: failed to remove mesos-0.21.0/src/python/setup.py.in
warning: failed to remove mesos-0.21.0/src/python/src/mesos/__init__.py
warning: failed to remove mesos-0.21.0/src/python/native/ext_modules.py.in
warning: failed to remove mesos-0.21.0/src/python/native/setup.py.in
warning: failed to remove mesos-0.21.0/src/python/native/src/mesos/__init__.py
warning: failed to remove 
mesos-0.21.0/src/python/native/src/mesos/native/proxy_executor.cpp
warning: failed to remove 
mesos-0.21.0/src/python/native/src/mesos/native/proxy_executor.hpp
warning: failed to remove 
mesos-0.21.0/src/python/native/src/mesos/native/module.hpp
warning: failed to remove 
mesos-0.21.0/src/python/native/src/mesos/native/proxy_scheduler.hpp
warning: failed to remove 
mesos-0.21.0/src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp
warning: failed to remove 
mesos-0.21.0/src/python/native/src/mesos/native/module.cpp
warning: failed to remove 
mesos-0.21.0/src/python/native/src/mesos/native/mesos_executor_driver_impl.hpp
warning: failed to remove 
mesos-0.21.0/src/python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp
warning: failed to remove 
mesos-0.21.0/src/python/native/src/mesos/native/__init__.py
warning: failed to remove 
mesos-0.21.0/src/python/native/src/mesos/native/proxy_scheduler.cpp
warning: failed to remove 
mesos-0.21.0/src/python/native/src/mesos/native/mesos_executor_driver_impl.cpp
warning: failed to remove mesos-0.21.0/src/authorizer/authorizer.cpp
warning: failed to remove mesos-0.21.0/src/authorizer/authorizer.hpp
warning: failed to remove mesos-0.21.0/src/master/master.cpp
warning: failed to remove mesos-0.21.0/src/master/master.hpp
warning: failed to remove mesos-0.21.0/src/master/drf_sorter.cpp
warning: failed to remove mesos-0.21.0/src/master/detector.cpp
warning: failed to remove 
mesos-0.21.0/src/master/hierarchical_allocator_process.hpp
warning: failed to remove mesos-0.21.0/src/master/registrar.cpp
warning: failed to remove mesos-0.21.0/src/master/registry.hpp
warning: failed to remove mesos-0.21.0/src/master/drf_sorter.hpp
warning: failed to remove mesos-0.21.0/src/master/contender.hpp
warning: failed to remove mesos-0.21.0/src/master/detector.hpp
warning: failed to remove mesos-0.21.0/src/master/main.cpp
warning: failed to remove mesos-0.21.0/src/master/registrar.hpp
warning: failed to remove mesos-0.21.0/src/master/contender.cpp
warning: failed to remove mesos-0.21.0/src/master/registry.proto
warning: failed to remove mesos-0.21.0/src/master/allocator.hpp
warning: failed to remove mesos-0.21.0/src/master/flags.hpp
warning: failed to remove mesos-0.21.0/src/master/http.cpp
warning: failed to remove mesos-0.21.0/src/master/repairer.hpp
warning: failed to remove mesos-0.21.0/src/master/constants.cpp
warning: failed to remove mesos-0.21.0/src/master/sorter.hpp
warning: failed to remove mesos-0.21.0/src/master/repairer.cpp
warning: failed to remove mesos-0.21.0/src/master/constants.hpp
warning: failed to remove mesos-0.21.0/src/scheduler/scheduler.cpp
warning: failed to remove mesos-0.21.0/src/exec/exec.cpp
warning: failed to remove mesos-0.21.0/Makefile.in
warning: failed to remove mesos-0.21.0/config.sub
warning: failed to remove mesos-0.21.0/bin/valgrind-mesos-slave.sh.in
warning: failed to remove mesos-0.21.0/bin/gdb-mesos-local.sh.in
warning: failed to remove mesos-0.21.0/bin/valgrind-mesos-local.sh.in
warning: failed to remove mesos-0.21.0/bin/mesos-tests.sh.in
warning: failed to remove mesos-0.21.0/bin/gdb-mesos-tests.sh.in
warning: failed to remove mesos-0.21.0/bin/gdb-mesos-master.sh.in
warning: failed to remove mesos-0.21.0/bin/gdb-mesos-slave.sh.in
warning: failed to remove mesos-0.21.0/bin/mesos-local-flags.sh.in
warning: failed to remove mesos-0.21.0/bin/valgrind-mesos-tests.sh.in
warning: failed to remove mesos-0.21.0/bin/lldb-mesos-local.sh.in
warning: failed to remove mesos-0.21.0/bin/valgrind-mesos-master.sh.in
warning: failed to remove mesos-0.21.0/bin/mesos.sh.in
warning: failed to remove mesos-0.21.0/bin/mesos-master-flags.sh.in
warning: failed to remove mesos-0.21.0/bin/lldb-mesos-master.sh.in
warning: failed to remove mesos-0.21.0/bin/mesos-tests-flags.sh.in
warning: failed to remove mesos-0.21.0/bin/mesos-master.sh.in
warning: failed to remove mesos-0.21.0/bin/mesos-local.sh.in
warning: failed to remove 

Jenkins build is back to normal : mesos-reviewbot #1389

2014-08-22 Thread Apache Jenkins Server
See https://builds.apache.org/job/mesos-reviewbot/1389/



Re: Review Request 24902: Fixed the build error in routing tests.

2014-08-22 Thread David Robinson

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24902/#review51305
---



src/tests/routing_tests.cpp
https://reviews.apache.org/r/24902/#comment89457

Why is '#if LINUX_VERSION_CODE = KERNEL_VERSION(2, 6, 24)' being removed?


- David Robinson


On Aug. 20, 2014, 6:21 p.m., Jie Yu wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/24902/
 ---
 
 (Updated Aug. 20, 2014, 6:21 p.m.)
 
 
 Review request for mesos, Ian Downes and Vinod Kone.
 
 
 Repository: mesos-git
 
 
 Description
 ---
 
 Realized that checking linux version is not very useful. We may have a new 
 kernel header but an old glibc in some cases.
 
 
 Diffs
 -
 
   src/tests/routing_tests.cpp 020676cac092aae63fcb45f37b206323db100f95 
 
 Diff: https://reviews.apache.org/r/24902/diff/
 
 
 Testing
 ---
 
 sudo make check
 
 
 Thanks,
 
 Jie Yu
 




Review Request 24987: Fail when no command provided with shell enabled in docker

2014-08-22 Thread Timothy Chen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24987/
---

Review request for mesos and Benjamin Hindman.


Repository: mesos-git


Description
---

Fail when no command provided with shell enabled in docker


Diffs
-

  src/docker/docker.cpp ad5886b6fa2f39bd0a8c93f31d8e334fb0ba2537 
  src/tests/docker_tests.cpp 3d0270252e8f7889a72ad2eb5bfec4c3b2f58953 

Diff: https://reviews.apache.org/r/24987/diff/


Testing
---

make check


Thanks,

Timothy Chen



Re: Review Request 24987: Fail when no command provided with shell enabled in docker

2014-08-22 Thread Timothy Chen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24987/
---

(Updated Aug. 22, 2014, 7:14 p.m.)


Review request for mesos and Benjamin Hindman.


Bugs: MESOS-1730
https://issues.apache.org/jira/browse/MESOS-1730


Repository: mesos-git


Description
---

Fail when no command provided with shell enabled in docker


Diffs
-

  src/docker/docker.cpp ad5886b6fa2f39bd0a8c93f31d8e334fb0ba2537 
  src/tests/docker_tests.cpp 3d0270252e8f7889a72ad2eb5bfec4c3b2f58953 

Diff: https://reviews.apache.org/r/24987/diff/


Testing
---

make check


Thanks,

Timothy Chen



Differentiate user requests protobuf messages

2014-08-22 Thread Bhuvan Arumugam
Hello,

We use auth/authz implementation for frameworks and slaves. They are
neat! This thread is about auth for web ui, between master and user.

We are implementing authentication for master web ui (port: 5050). The
master seem to serve both user requests and protobuf messages from
slave  frameworks on same port. Right? We want to authenticate user
requests only. Is there a way to differentiate these messages?

Based on how these messages can be differentiated, we are thinking to
run mesos master behind a proxy, apache or apache traffic server,
primarily for 2 reasons:
  1. authentication. The auth could be implemented through apache
module or ATS plugin.
  2. security. serve user requests through https.

If we use ATS, it may also solve caching problem; but we aren't
solving this problem right now.

Making changes to mesos to address these concern doesn't look neat.
Mesos seem to return complete json blob and all magic is done at the
client side, in angularjs. Mesos master isn't a full fletched http
server. It's not meant to keep track of user session; dealing with
http cookies/headers/redirection are non-trivial.

Anyone running mesos master behind proxy, or solved same problem differently?

-- 
Regards,
Bhuvan Arumugam
www.livecipher.com