Re: Reorganize 3rdparty directory

2016-02-11 Thread Marco Massenzio
This is a great initiative and something I wanted to do since the first day
I did `git clone` for Mesos :)
Happy to help wherever I can, Kapil - just say the word!

In my opinion, we should take full advantage of git submodules and move
stout/libprocess out into their own repositories (which, incidentally,
already exist [0, 1]) and move all the binaries (*.tar.gz) out of our repo:
I never quite understood why we're carrying along zookeeper and protobuf
(just to mention two), which I'm sure both Apache and Google can take good
care of (and we just install as part of the build process - or whatever).

I've recently been using git submodules and they're pretty awesome, also
allowing other teams who may want to use either library the opportunity to
do so (and contribute back - without having to be part of Mesos proper).

So, totally +1 to this idea.

[0] https://github.com/3rdparty/stout
[1] https://github.com/3rdparty/libprocess

-- 
*Marco Massenzio*
http://codetrips.com

On Tue, Feb 9, 2016 at 4:14 PM, Kapil Arya  wrote:

> Hi All,
>
> TLDR: Move everything from 3rdparty/libprocess/3rdparty/* into 3rdparty/.
> (Optionally) Move libprocess/stout to the top-level directory.
>
> I wanted to start some discussion around reorganizing stuff inside
> "3rdparty". I apologize for the length of the email, please bear with me.
>
> Traditionally, 3rdparty has been used to hold all Mesos dependencies
> (zookeeper, libprocess, protobuf, stout, etc.). Further,
> libprocess/3rdparty was to hold all libprocess dependencies (which may in
> turn be Mesos dependencies as well).
>
> As I understand, the original motivation was to emphasize that libprocess
> is an independent project which depends on "stout", which in turn is also
> an independent project.
>
> However, in the current code base, we don't strictly follow the 3rdparty
> structure. For example, stout has a dependency on picojson and
> google-protobuf, but we don't put these two packages inside
> 3rdparty/libprocess/3rdparty/stout/3rdparty/.
>
> In light of these anomalies, I want to propose that we flatten out the
> 3rdparty directory and put all packages (libprocess, stout, protobuf,
> picojson, zookeeper, etc.) at the same level in 3rdparty. We can still use
> "--with-XYZ=..." to the full extent as needed.
>
> To take it a step further, I want to propose that we bring libprocess and
> stout out of 3rdparty/ and move them at the top level (i.e., make them
> peers of src/). That way, all code in 3rdparty/ is stuff from "third"
> parties and is used only when "--with-bundled" is defined (by default).
> This hierarchy will still allow us to keep libprocess and stout as separate
> independent projects.
>
> The motivation for this proposal came when dealing with 3rdparty
> dependencies for module development. A module developer needs access to
> protobuf, picojson, glog, etc., and for that matter, the exact versions of
> these packages that Mesos was compiled with.
>
> We want to solve this problem by installing module-specific 3rdparty
> dependencies into "${pkglibdir}/3rdparty" as part of "make install" (if
> configured with something like "--enable-install-module-dependencies").
> (There is a discussion going on in a separate thread).
>
> Further, as of today, when we install Mesos using "make install", we
> install stout headers in "${prefix}/include/stout". However, stout has
> dependencies on picojson[1] and google-protobuf headers which may not be
> present on the machine. This leaves stout, and in turn libprocess and Mesos
> headers, fairly broken. I understand that this issue is somewhat orthogonal
> to the main issue being discussed in this mail, but I wanted to put it out
> since it's related.
>
> Any thoughts, comments, concerns are most welcome!
>
> Best,
> Kapil
>
>
> [1]: Picojson issue was resolved as part of
> https://reviews.apache.org/r/41424/ which installs picojson.h into the
> include-dir.
>


Re: Inconsistent naming of support scripts

2016-02-11 Thread Marco Massenzio
+10 for consistency
+1 for hyphens (less carpal-tunnel :)

-- 
*Marco Massenzio*
http://codetrips.com

On Thu, Feb 11, 2016 at 2:58 PM, Michael Park  wrote:

> +1 for consistency, +1 for hyphens for executables.
>
> On 11 February 2016 at 14:25, Kevin Klues  wrote:
>
> > I typically think of files having dashes as binaries or scripts that
> > are runnable, whereas files with underscores are meant as source or
> > otherwise supplementary to the binary produced (e.g. a supplementary
> > python library that the main python program imports).  I'm  not sure
> > where I inherited this convention from, but it's always been the way
> > I've done things.
> >
> > As far as our code base goes, we seem to use this convention as well
> > with our mesos-master.sh. mesos-slave.sh, etc. binaries.
> >
> > On Thu, Feb 11, 2016 at 2:17 PM, Vinod Kone 
> wrote:
> > > Why hyphens? Most of the files in our repo use underscores. I would
> like
> > us
> > > to be consistent on how we name files in the repo.
> > >
> > > On Thu, Feb 11, 2016 at 1:40 PM, Kevin Klues 
> wrote:
> > >
> > >> I prefer hyphens as well
> > >>
> > >> On Thu, Feb 11, 2016 at 1:28 PM, Jojy Varghese 
> > wrote:
> > >> > hyphen++. Is google friendly apparently.  Also less keys to press :)
> > >> >
> > >> > -Jojy
> > >> >
> > >> >
> > >> >
> > >> >> On Feb 11, 2016, at 12:43 PM, Greg Mann 
> wrote:
> > >> >>
> > >> >> +1
> > >> >>
> > >> >> On Thu, Feb 11, 2016 at 11:41 AM, Vinod Kone  >
> > >> wrote:
> > >> >>
> > >> >>> Some the scripts in the "support" directory have dashes ("-") in
> > their
> > >> >>> names (e.g., apply-review.sh, apply-reviews.py), whereas some have
> > >> >>> underscores ("_") (e.g., docker_build.sh, mesos_split.py).
> > >> >>>
> > >> >>> This is really confusing and we should stick with one style. I
> > propose
> > >> to
> > >> >>> change all them to use underscores. I will make sure the CI jobs
> are
> > >> >>> updated accordingly.
> > >> >>>
> > >> >>> Any objections?
> > >> >>>
> > >> >>> Thanks,
> > >> >>> Vinod
> > >> >>>
> > >> >
> > >>
> > >>
> > >>
> > >> --
> > >> ~Kevin
> > >>
> >
> >
> >
> > --
> > ~Kevin
> >
>


Shepherd for MESOS-3486

2016-02-11 Thread Michael Browning
Hello,

I've picked a small issue off of the newbie issues stack to get started
with:

https://issues.apache.org/jira/browse/MESOS-3486

...and I've commented on the issue with a proposed solution, and am now
looking for a shepherd on this one.

Thank you,
Michael


Re: Inconsistent naming of support scripts

2016-02-11 Thread Michael Park
+1 for consistency, +1 for hyphens for executables.

On 11 February 2016 at 14:25, Kevin Klues  wrote:

> I typically think of files having dashes as binaries or scripts that
> are runnable, whereas files with underscores are meant as source or
> otherwise supplementary to the binary produced (e.g. a supplementary
> python library that the main python program imports).  I'm  not sure
> where I inherited this convention from, but it's always been the way
> I've done things.
>
> As far as our code base goes, we seem to use this convention as well
> with our mesos-master.sh. mesos-slave.sh, etc. binaries.
>
> On Thu, Feb 11, 2016 at 2:17 PM, Vinod Kone  wrote:
> > Why hyphens? Most of the files in our repo use underscores. I would like
> us
> > to be consistent on how we name files in the repo.
> >
> > On Thu, Feb 11, 2016 at 1:40 PM, Kevin Klues  wrote:
> >
> >> I prefer hyphens as well
> >>
> >> On Thu, Feb 11, 2016 at 1:28 PM, Jojy Varghese 
> wrote:
> >> > hyphen++. Is google friendly apparently.  Also less keys to press :)
> >> >
> >> > -Jojy
> >> >
> >> >
> >> >
> >> >> On Feb 11, 2016, at 12:43 PM, Greg Mann  wrote:
> >> >>
> >> >> +1
> >> >>
> >> >> On Thu, Feb 11, 2016 at 11:41 AM, Vinod Kone 
> >> wrote:
> >> >>
> >> >>> Some the scripts in the "support" directory have dashes ("-") in
> their
> >> >>> names (e.g., apply-review.sh, apply-reviews.py), whereas some have
> >> >>> underscores ("_") (e.g., docker_build.sh, mesos_split.py).
> >> >>>
> >> >>> This is really confusing and we should stick with one style. I
> propose
> >> to
> >> >>> change all them to use underscores. I will make sure the CI jobs are
> >> >>> updated accordingly.
> >> >>>
> >> >>> Any objections?
> >> >>>
> >> >>> Thanks,
> >> >>> Vinod
> >> >>>
> >> >
> >>
> >>
> >>
> >> --
> >> ~Kevin
> >>
>
>
>
> --
> ~Kevin
>


Re: Inconsistent naming of support scripts

2016-02-11 Thread Kevin Klues
I typically think of files having dashes as binaries or scripts that
are runnable, whereas files with underscores are meant as source or
otherwise supplementary to the binary produced (e.g. a supplementary
python library that the main python program imports).  I'm  not sure
where I inherited this convention from, but it's always been the way
I've done things.

As far as our code base goes, we seem to use this convention as well
with our mesos-master.sh. mesos-slave.sh, etc. binaries.

On Thu, Feb 11, 2016 at 2:17 PM, Vinod Kone  wrote:
> Why hyphens? Most of the files in our repo use underscores. I would like us
> to be consistent on how we name files in the repo.
>
> On Thu, Feb 11, 2016 at 1:40 PM, Kevin Klues  wrote:
>
>> I prefer hyphens as well
>>
>> On Thu, Feb 11, 2016 at 1:28 PM, Jojy Varghese  wrote:
>> > hyphen++. Is google friendly apparently.  Also less keys to press :)
>> >
>> > -Jojy
>> >
>> >
>> >
>> >> On Feb 11, 2016, at 12:43 PM, Greg Mann  wrote:
>> >>
>> >> +1
>> >>
>> >> On Thu, Feb 11, 2016 at 11:41 AM, Vinod Kone 
>> wrote:
>> >>
>> >>> Some the scripts in the "support" directory have dashes ("-") in their
>> >>> names (e.g., apply-review.sh, apply-reviews.py), whereas some have
>> >>> underscores ("_") (e.g., docker_build.sh, mesos_split.py).
>> >>>
>> >>> This is really confusing and we should stick with one style. I propose
>> to
>> >>> change all them to use underscores. I will make sure the CI jobs are
>> >>> updated accordingly.
>> >>>
>> >>> Any objections?
>> >>>
>> >>> Thanks,
>> >>> Vinod
>> >>>
>> >
>>
>>
>>
>> --
>> ~Kevin
>>



-- 
~Kevin


Re: Inconsistent naming of support scripts

2016-02-11 Thread Vinod Kone
Why hyphens? Most of the files in our repo use underscores. I would like us
to be consistent on how we name files in the repo.

On Thu, Feb 11, 2016 at 1:40 PM, Kevin Klues  wrote:

> I prefer hyphens as well
>
> On Thu, Feb 11, 2016 at 1:28 PM, Jojy Varghese  wrote:
> > hyphen++. Is google friendly apparently.  Also less keys to press :)
> >
> > -Jojy
> >
> >
> >
> >> On Feb 11, 2016, at 12:43 PM, Greg Mann  wrote:
> >>
> >> +1
> >>
> >> On Thu, Feb 11, 2016 at 11:41 AM, Vinod Kone 
> wrote:
> >>
> >>> Some the scripts in the "support" directory have dashes ("-") in their
> >>> names (e.g., apply-review.sh, apply-reviews.py), whereas some have
> >>> underscores ("_") (e.g., docker_build.sh, mesos_split.py).
> >>>
> >>> This is really confusing and we should stick with one style. I propose
> to
> >>> change all them to use underscores. I will make sure the CI jobs are
> >>> updated accordingly.
> >>>
> >>> Any objections?
> >>>
> >>> Thanks,
> >>> Vinod
> >>>
> >
>
>
>
> --
> ~Kevin
>


Re: Slave Terminology Rename Proposal

2016-02-11 Thread Vinod Kone
What do you mean by keeping the old symbols?

For example, in the case of the `Allocator::addSlave()`, are you suggesting
that when we add `Allocator::addAgent()`, we keep `Allocator::addSlave()`
as well? Master will only call `Allocator::addAgent()` from that point
onward, so I'm not sure what's the value of keeping the
`Allocator::addSlave()`? Any allocator modules have to be recompiled anyway
with the new interface right?

On Thu, Feb 11, 2016 at 1:24 PM, James Peach  wrote:

>
> > On Feb 9, 2016, at 7:23 AM, Diana J Arroyo  wrote:
> >
> >
> >
> > Hello Everyone,
> >
> > The initial proposal for the slave to agent rename has been added to the
> > Epic JIRA item: https://issues.apache.org/jira/browse/MESOS-1478 for
> your
> > review.  The link to the proposal working document is posted in the
> > description of the JIRA item.  Your comments/feedback would be greatly
> > appreciated.
>
> Looking at the list in https://issues.apache.org/jira/browse/MESOS-3777,
> are you introducing new symbols and keeping the old ones for a while?
>
> J


Re: Inconsistent naming of support scripts

2016-02-11 Thread Kevin Klues
I prefer hyphens as well

On Thu, Feb 11, 2016 at 1:28 PM, Jojy Varghese  wrote:
> hyphen++. Is google friendly apparently.  Also less keys to press :)
>
> -Jojy
>
>
>
>> On Feb 11, 2016, at 12:43 PM, Greg Mann  wrote:
>>
>> +1
>>
>> On Thu, Feb 11, 2016 at 11:41 AM, Vinod Kone  wrote:
>>
>>> Some the scripts in the "support" directory have dashes ("-") in their
>>> names (e.g., apply-review.sh, apply-reviews.py), whereas some have
>>> underscores ("_") (e.g., docker_build.sh, mesos_split.py).
>>>
>>> This is really confusing and we should stick with one style. I propose to
>>> change all them to use underscores. I will make sure the CI jobs are
>>> updated accordingly.
>>>
>>> Any objections?
>>>
>>> Thanks,
>>> Vinod
>>>
>



-- 
~Kevin


Re: Inconsistent naming of support scripts

2016-02-11 Thread Jojy Varghese
hyphen++. Is google friendly apparently.  Also less keys to press :)

-Jojy 



> On Feb 11, 2016, at 12:43 PM, Greg Mann  wrote:
> 
> +1
> 
> On Thu, Feb 11, 2016 at 11:41 AM, Vinod Kone  wrote:
> 
>> Some the scripts in the "support" directory have dashes ("-") in their
>> names (e.g., apply-review.sh, apply-reviews.py), whereas some have
>> underscores ("_") (e.g., docker_build.sh, mesos_split.py).
>> 
>> This is really confusing and we should stick with one style. I propose to
>> change all them to use underscores. I will make sure the CI jobs are
>> updated accordingly.
>> 
>> Any objections?
>> 
>> Thanks,
>> Vinod
>> 



Re: Slave Terminology Rename Proposal

2016-02-11 Thread James Peach

> On Feb 9, 2016, at 7:23 AM, Diana J Arroyo  wrote:
> 
> 
> 
> Hello Everyone,
> 
> The initial proposal for the slave to agent rename has been added to the
> Epic JIRA item: https://issues.apache.org/jira/browse/MESOS-1478 for your
> review.  The link to the proposal working document is posted in the
> description of the JIRA item.  Your comments/feedback would be greatly
> appreciated.

Looking at the list in https://issues.apache.org/jira/browse/MESOS-3777, are 
you introducing new symbols and keeping the old ones for a while?

J

Re: Inconsistent naming of support scripts

2016-02-11 Thread Greg Mann
+1

On Thu, Feb 11, 2016 at 11:41 AM, Vinod Kone  wrote:

> Some the scripts in the "support" directory have dashes ("-") in their
> names (e.g., apply-review.sh, apply-reviews.py), whereas some have
> underscores ("_") (e.g., docker_build.sh, mesos_split.py).
>
> This is really confusing and we should stick with one style. I propose to
> change all them to use underscores. I will make sure the CI jobs are
> updated accordingly.
>
> Any objections?
>
> Thanks,
> Vinod
>


Announcing MesosCon North America 2016

2016-02-11 Thread Kiersten Gaffney
Hello all,


We’re excited to announce that MesosCon North America 2016 will be held in
Denver, CO on June 1-2, 2016. MesosCon is a community-driven conference,
organized for the Apache Mesos community.

Talk submissions, sponsorship opportunities, and early-bird registration
are now open for the conference.

Speak at MesosCon

Several formats are being accepted for speaking proposals, including:
Presentations, Panels, Keynotes and Lightning Talks. Submissions are being
accepted through March 9, 2016:
http://events.linuxfoundation.org/events/mesoscon/program/cfp

You can take a look at MesosCon 2015 list of talks

for ideas. If you’re unsure about your proposal, or want some feedback or
advice in general, please don’t hesitate to reach out to us. We’ll be happy
to help out! Further details are available on the CFP website.


All submissions for MesosCon North America will also be considered for the
upcoming MesosCon Europe and China events (details to be announced shortly).

Sponsor MesosCon

The sponsorship prospectus for MesosCon is now available:
http://events.linuxfoundation.org/events/mesoscon/sponsors, including
several opportunities with limited availability.

Attend MesosCon

Early-Bird registration is open through April 22nd:
http://events.linuxfoundation.org/events/mesoscon/attend/register

We look forward to seeing you at MesosCon North America, as well as
MesosCon Europe and MesosCon China taking place later this year (details to
be announced shortly).

Kiersten


Inconsistent naming of support scripts

2016-02-11 Thread Vinod Kone
Some the scripts in the "support" directory have dashes ("-") in their
names (e.g., apply-review.sh, apply-reviews.py), whereas some have
underscores ("_") (e.g., docker_build.sh, mesos_split.py).

This is really confusing and we should stick with one style. I propose to
change all them to use underscores. I will make sure the CI jobs are
updated accordingly.

Any objections?

Thanks,
Vinod