[GitHub] mesos pull request #237: Documentation: Fix event syntax by wrapping a task ...

2017-10-03 Thread adamtheturtle 
GitHub user adamtheturtle opened a pull request:

https://github.com/apache/mesos/pull/237

Documentation: Fix event syntax by wrapping a task definition in curly 
braces.

cc @greggomann 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/adamtheturtle/mesos 
fix-launch-group-event-syntax

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/mesos/pull/237.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #237


commit 6fb37274aec4a9c0b08d53cb882c0e330b06eba9
Author: Adam Dangoor 
Date:   2017-10-03T10:44:38Z

Fix event syntax by wrapping a task definition in curly braces.




---

[GitHub] mesos pull request #237: Documentation: Fix event syntax by wrapping a task ...

2017-10-06 Thread rukletsov 
Github user rukletsov commented on a diff in the pull request:

https://github.com/apache/mesos/pull/237#discussion_r143264159
  
--- Diff: docs/executor-http-api.md ---
@@ -279,19 +279,21 @@ LAUNCH_GROUP Event (JSON)
   "launch_group": {
 "task_group" : {
   "tasks" : [
-"task": {
-  "name": "dummy-task",
-  "task_id": {
-"value": "d40f3f3e-bbe3-44af-a230-4cb1eae72f67"
-  },
-  "agent_id": {
-"value": "f1c9cdc5-195e-41a7-a0d7-adaa9af07f81"
-  },
-  "command": {
-"value": "sleep",
-"arguments": [
-  "100"
-]
+{
+  "task": {
--- End diff --

Shouldn't we remove `"task": ` instead?


---

[GitHub] mesos pull request #237: Documentation: Fix event syntax by wrapping a task ...

2017-10-09 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/mesos/pull/237


---