Re: Review Request 30140: Fixed the build issue in collect.hpp for gcc-4.4.
> On Jan. 21, 2015, 10 p.m., Ben Mahler wrote: > > Thanks Jie, mind including a bit of context in the review description next > > time? Perhaps a little NOTE in the code would make that unnecessary (i.e. > > that we can't overload because of a compilation issue on gcc-4.4). Sure. Added a NOTE in the code. - Jie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30140/#review69031 --- On Jan. 21, 2015, 9:55 p.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30140/ > --- > > (Updated Jan. 21, 2015, 9:55 p.m.) > > > Review request for mesos, Vinod Kone and Jiang Yan Xu. > > > Bugs: MESOS-2236 > https://issues.apache.org/jira/browse/MESOS-2236 > > > Repository: mesos-git > > > Description > --- > > Fixed the build issue in collect.hpp for gcc-4.4. > > > Diffs > - > > 3rdparty/libprocess/include/process/collect.hpp > 6352883ccdfbede8cac22063d8c2e40bcc5f40cf > > Diff: https://reviews.apache.org/r/30140/diff/ > > > Testing > --- > > make check using gcc-4.4.7 > > > Thanks, > > Jie Yu > >
Re: Review Request 30140: Fixed the build issue in collect.hpp for gcc-4.4.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30140/#review69031 --- Ship it! Thanks Jie, mind including a bit of context in the review description next time? Perhaps a little NOTE in the code would make that unnecessary (i.e. that we can't overload because of a compilation issue on gcc-4.4). - Ben Mahler On Jan. 21, 2015, 9:55 p.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30140/ > --- > > (Updated Jan. 21, 2015, 9:55 p.m.) > > > Review request for mesos, Vinod Kone and Jiang Yan Xu. > > > Bugs: MESOS-2236 > https://issues.apache.org/jira/browse/MESOS-2236 > > > Repository: mesos-git > > > Description > --- > > Fixed the build issue in collect.hpp for gcc-4.4. > > > Diffs > - > > 3rdparty/libprocess/include/process/collect.hpp > 6352883ccdfbede8cac22063d8c2e40bcc5f40cf > > Diff: https://reviews.apache.org/r/30140/diff/ > > > Testing > --- > > make check using gcc-4.4.7 > > > Thanks, > > Jie Yu > >
Review Request 30140: Fixed the build issue in collect.hpp for gcc-4.4.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30140/ --- Review request for mesos, Vinod Kone and Jiang Yan Xu. Bugs: MESOS-2236 https://issues.apache.org/jira/browse/MESOS-2236 Repository: mesos-git Description --- Fixed the build issue in collect.hpp for gcc-4.4. Diffs - 3rdparty/libprocess/include/process/collect.hpp 6352883ccdfbede8cac22063d8c2e40bcc5f40cf Diff: https://reviews.apache.org/r/30140/diff/ Testing --- make check using gcc-4.4.7 Thanks, Jie Yu
Re: Build Issue?
I thought it was, on a fresh checkout it didn't though! I've got a path to follow now. Thanks for the tip :) On Thursday, July 3, 2014, Vinod Kone wrote: > does 'make distcheck' work for you? > > > On Thu, Jul 3, 2014 at 3:33 PM, Thomas Rampelberg > > wrote: > > > I have a patch that splits the python module out into separate > > packages (so that people can pick and choose what they want) > > (https://reviews.apache.org/r/23224/). Locally, this all builds just > > fine. Unfortunately, remotely, reviewbot is complaining: > > > > cp: cannot stat `../../src/python/protocol/src/mesos/__init__.py': > > No such file or directory > > > > In `src/Makefile.am` I have the following: > > > > python/protocol/src/mesos/__init__.py: $(PYTHON_PROTOS) > > cp $(srcdir)/$@ $@ > > > > Any suggestions? I can't figure out why it isn't working for the life of > > me. > > >
Re: Build Issue?
does 'make distcheck' work for you? On Thu, Jul 3, 2014 at 3:33 PM, Thomas Rampelberg wrote: > I have a patch that splits the python module out into separate > packages (so that people can pick and choose what they want) > (https://reviews.apache.org/r/23224/). Locally, this all builds just > fine. Unfortunately, remotely, reviewbot is complaining: > > cp: cannot stat `../../src/python/protocol/src/mesos/__init__.py': > No such file or directory > > In `src/Makefile.am` I have the following: > > python/protocol/src/mesos/__init__.py: $(PYTHON_PROTOS) > cp $(srcdir)/$@ $@ > > Any suggestions? I can't figure out why it isn't working for the life of > me. >
Build Issue?
I have a patch that splits the python module out into separate packages (so that people can pick and choose what they want) (https://reviews.apache.org/r/23224/). Locally, this all builds just fine. Unfortunately, remotely, reviewbot is complaining: cp: cannot stat `../../src/python/protocol/src/mesos/__init__.py': No such file or directory In `src/Makefile.am` I have the following: python/protocol/src/mesos/__init__.py: $(PYTHON_PROTOS) cp $(srcdir)/$@ $@ Any suggestions? I can't figure out why it isn't working for the life of me.
