Re: Review Request 16824: Fixed flaky GroupTest.RetryableErrors test.
On Jan. 15, 2014, 11:38 p.m., Ben Mahler wrote: Committed! Please mark this as submitted. - Ben --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16824/#review31961 --- On Jan. 14, 2014, 1:33 a.m., Jiang Yan Xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16824/ --- (Updated Jan. 14, 2014, 1:33 a.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-871 https://issues.apache.org/jira/browse/MESOS-871 Repository: mesos-git Description --- I plan on investigating the pure virtual method called terminate called without an active exception problem further but this patch for now prevents GroupTest.RetryableErrors from stopping our Jenkins tests because of its failure. Diffs - src/tests/group_tests.cpp 957256e68ab8c69309b15d9e20fab8b70fa9f0a6 Diff: https://reviews.apache.org/r/16824/diff/ Testing --- make check on jenkins/fedora-19-gcc multiple runs, each run 50 iterations. Thanks, Jiang Yan Xu
Re: Review Request 16824: Fixed flaky GroupTest.RetryableErrors test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16824/#review31961 --- Ship it! src/tests/group_tests.cpp https://reviews.apache.org/r/16824/#comment60721 Should these be re-ordered? - Ben Mahler On Jan. 14, 2014, 1:33 a.m., Jiang Yan Xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16824/ --- (Updated Jan. 14, 2014, 1:33 a.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-871 https://issues.apache.org/jira/browse/MESOS-871 Repository: mesos-git Description --- I plan on investigating the pure virtual method called terminate called without an active exception problem further but this patch for now prevents GroupTest.RetryableErrors from stopping our Jenkins tests because of its failure. Diffs - src/tests/group_tests.cpp 957256e68ab8c69309b15d9e20fab8b70fa9f0a6 Diff: https://reviews.apache.org/r/16824/diff/ Testing --- make check on jenkins/fedora-19-gcc multiple runs, each run 50 iterations. Thanks, Jiang Yan Xu
Re: Review Request 16824: Fixed flaky GroupTest.RetryableErrors test.
On Jan. 15, 2014, 3:38 p.m., Ben Mahler wrote: src/tests/group_tests.cpp, lines 372-373 https://reviews.apache.org/r/16824/diff/1/?file=421662#file421662line372 Should these be re-ordered? The two futures become ready in reaction to group.join() and server-expireSession() and can occur in either order in theory so I think it's fine. - Jiang Yan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16824/#review31961 --- On Jan. 13, 2014, 5:33 p.m., Jiang Yan Xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16824/ --- (Updated Jan. 13, 2014, 5:33 p.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-871 https://issues.apache.org/jira/browse/MESOS-871 Repository: mesos-git Description --- I plan on investigating the pure virtual method called terminate called without an active exception problem further but this patch for now prevents GroupTest.RetryableErrors from stopping our Jenkins tests because of its failure. Diffs - src/tests/group_tests.cpp 957256e68ab8c69309b15d9e20fab8b70fa9f0a6 Diff: https://reviews.apache.org/r/16824/diff/ Testing --- make check on jenkins/fedora-19-gcc multiple runs, each run 50 iterations. Thanks, Jiang Yan Xu
