Re: Review Request 25169: require some c++11 features for mesos

[Dominic Hamon]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25169/
---

(Updated Aug. 28, 2014, 4:41 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Bugs: MESOS-750
https://issues.apache.org/jira/browse/MESOS-750


Repository: mesos-git


Description
---

fatal if expected C++11 features aren't supported by the compiler


Diffs (updated)
-

  3rdparty/libprocess/configure.ac 408b0dbe2604e0fc55fcea7745e4c1fd0a1b35b4 
  configure.ac 4b34173ed23bfe4e6f108db57f2611e50927ed2b 

Diff: https://reviews.apache.org/r/25169/diff/


Testing
---

make with clang++, g++-4.4, g++-4.6, and g++-4.8


Thanks,

Dominic Hamon

Re: Review Request 25169: require some c++11 features for mesos

[Vinod Kone]

> On Aug. 28, 2014, 11:30 p.m., Vinod Kone wrote:
> > 3rdparty/libprocess/configure.ac, line 518
> > 
> >
> > Can we print the supported versions here. I think that will be helpful 
> > for users.

nm. i think we are getting away from specifying compiler versions.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25169/#review51846
---


On Aug. 28, 2014, 10:40 p.m., Dominic Hamon wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25169/
> ---
> 
> (Updated Aug. 28, 2014, 10:40 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-750
> https://issues.apache.org/jira/browse/MESOS-750
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> fatal if expected C++11 features aren't supported by the compiler
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/configure.ac 408b0dbe2604e0fc55fcea7745e4c1fd0a1b35b4 
>   configure.ac 4b34173ed23bfe4e6f108db57f2611e50927ed2b 
> 
> Diff: https://reviews.apache.org/r/25169/diff/
> 
> 
> Testing
> ---
> 
> make with clang++, g++-4.4, g++-4.6, and g++-4.8
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>

Re: Review Request 25169: require some c++11 features for mesos

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25169/#review51846
---

Ship it!



3rdparty/libprocess/configure.ac


Can we print the supported versions here. I think that will be helpful for 
users.



configure.ac


can you rephrase this statement because there is no with-cxx11 arg anymore?


- Vinod Kone


On Aug. 28, 2014, 10:40 p.m., Dominic Hamon wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25169/
> ---
> 
> (Updated Aug. 28, 2014, 10:40 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-750
> https://issues.apache.org/jira/browse/MESOS-750
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> fatal if expected C++11 features aren't supported by the compiler
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/configure.ac 408b0dbe2604e0fc55fcea7745e4c1fd0a1b35b4 
>   configure.ac 4b34173ed23bfe4e6f108db57f2611e50927ed2b 
> 
> Diff: https://reviews.apache.org/r/25169/diff/
> 
> 
> Testing
> ---
> 
> make with clang++, g++-4.4, g++-4.6, and g++-4.8
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>