Re: Review Request 25439: Fix protobuf detection on systems with Python 3 as default
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25439/#review52898 --- Ship it! Ship It! - Timothy St. Clair On Sept. 9, 2014, 2:49 p.m., Kamil Domanski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25439/ > --- > > (Updated Sept. 9, 2014, 2:49 p.m.) > > > Review request for mesos and Timothy St. Clair. > > > Bugs: MESOS-1774 > https://issues.apache.org/jira/browse/MESOS-1774 > > > Repository: mesos-git > > > Description > --- > > MESOS-1774 > > > Diffs > - > > m4/ac_python_module.m4 8360b65434e3c1912e2b8670f70e4130352a3c92 > > Diff: https://reviews.apache.org/r/25439/diff/ > > > Testing > --- > > ./configure --disable-bundled > > > Thanks, > > Kamil Domanski > >
Re: Review Request 25439: Fix protobuf detection on systems with Python 3 as default
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25439/ --- (Updated Sept. 9, 2014, 4:49 p.m.) Review request for mesos and Timothy St. Clair. Changes --- rebased diff Bugs: MESOS-1774 https://issues.apache.org/jira/browse/MESOS-1774 Repository: mesos-git Description --- MESOS-1774 Diffs (updated) - m4/ac_python_module.m4 8360b65434e3c1912e2b8670f70e4130352a3c92 Diff: https://reviews.apache.org/r/25439/diff/ Testing --- ./configure --disable-bundled Thanks, Kamil Domanski
Re: Review Request 25439: Fix protobuf detection on systems with Python 3 as default
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25439/#review52717 --- Could you please rebase for clean apply. - Timothy St. Clair On Sept. 8, 2014, 6:35 p.m., Kamil Domanski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25439/ > --- > > (Updated Sept. 8, 2014, 6:35 p.m.) > > > Review request for mesos and Timothy St. Clair. > > > Bugs: MESOS-1774 > https://issues.apache.org/jira/browse/MESOS-1774 > > > Repository: mesos-git > > > Description > --- > > MESOS-1774 > > > Diffs > - > > m4/ac_python_module.m4 5cb56ab01e9976d0d30a2e2960af007fc6400667 > > Diff: https://reviews.apache.org/r/25439/diff/ > > > Testing > --- > > ./configure --disable-bundled > > > Thanks, > > Kamil Domanski > >
Re: Review Request 25439: Fix protobuf detection on systems with Python 3 as default
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25439/#review52651 --- Bad patch! Reviews applied: [25439] Failed command: git apply --index 25439.patch Error: error: patch failed: m4/ac_python_module.m4:1 error: m4/ac_python_module.m4: patch does not apply - Mesos ReviewBot On Sept. 8, 2014, 6:35 p.m., Kamil Domanski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25439/ > --- > > (Updated Sept. 8, 2014, 6:35 p.m.) > > > Review request for mesos and Timothy St. Clair. > > > Bugs: MESOS-1774 > https://issues.apache.org/jira/browse/MESOS-1774 > > > Repository: mesos-git > > > Description > --- > > MESOS-1774 > > > Diffs > - > > m4/ac_python_module.m4 5cb56ab01e9976d0d30a2e2960af007fc6400667 > > Diff: https://reviews.apache.org/r/25439/diff/ > > > Testing > --- > > ./configure --disable-bundled > > > Thanks, > > Kamil Domanski > >
Re: Review Request 25439: Fix protobuf detection on systems with Python 3 as default
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25439/ --- (Updated Sept. 8, 2014, 8:35 p.m.) Review request for mesos and Timothy St. Clair. Bugs: MESOS-1774 https://issues.apache.org/jira/browse/MESOS-1774 Repository: mesos-git Description --- MESOS-1774 Diffs (updated) - m4/ac_python_module.m4 5cb56ab01e9976d0d30a2e2960af007fc6400667 Diff: https://reviews.apache.org/r/25439/diff/ Testing --- ./configure --disable-bundled Thanks, Kamil Doma?ski
Re: Review Request 25439: Fix protobuf detection on systems with Python 3 as default
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25439/#review52610 --- Ship it! Ship It! - Timothy St. Clair On Sept. 8, 2014, 2:27 p.m., Kamil Doma?ski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25439/ > --- > > (Updated Sept. 8, 2014, 2:27 p.m.) > > > Review request for mesos and Timothy St. Clair. > > > Bugs: MESOS-1774 > https://issues.apache.org/jira/browse/MESOS-1774 > > > Repository: mesos-git > > > Description > --- > > MESOS-1774 > > > Diffs > - > > m4/ac_python_module.m4 5cb56ab01e9976d0d30a2e2960af007fc6400667 > > Diff: https://reviews.apache.org/r/25439/diff/ > > > Testing > --- > > ./configure --disable-bundled > > > Thanks, > > Kamil Doma?ski > >
Re: Review Request 25439: Fix protobuf detection on systems with Python 3 as default
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25439/#review52600 --- Patch looks great! Reviews applied: [25439] All tests passed. - Mesos ReviewBot On Sept. 8, 2014, 2:27 p.m., Kamil Doma?ski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25439/ > --- > > (Updated Sept. 8, 2014, 2:27 p.m.) > > > Review request for mesos and Timothy St. Clair. > > > Bugs: MESOS-1774 > https://issues.apache.org/jira/browse/MESOS-1774 > > > Repository: mesos-git > > > Description > --- > > MESOS-1774 > > > Diffs > - > > m4/ac_python_module.m4 5cb56ab01e9976d0d30a2e2960af007fc6400667 > > Diff: https://reviews.apache.org/r/25439/diff/ > > > Testing > --- > > ./configure --disable-bundled > > > Thanks, > > Kamil Doma?ski > >
Re: Review Request 25439: Fix protobuf detection on systems with Python 3 as default
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25439/ --- (Updated Sept. 8, 2014, 4:27 p.m.) Review request for mesos and Timothy St. Clair. Changes --- Updated "bugs" Bugs: MESOS-1774 https://issues.apache.org/jira/browse/MESOS-1774 Repository: mesos-git Description --- MESOS-1774 Diffs - m4/ac_python_module.m4 5cb56ab01e9976d0d30a2e2960af007fc6400667 Diff: https://reviews.apache.org/r/25439/diff/ Testing --- ./configure --disable-bundled Thanks, Kamil Doma?ski
Re: Review Request 25439: Fix protobuf detection on systems with Python 3 as default
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25439/ --- (Updated Sept. 8, 2014, 4:25 p.m.) Review request for mesos and Timothy St. Clair. Changes --- added Timothy St. Clair as reviewer Repository: mesos-git Description --- MESOS-1774 Diffs - m4/ac_python_module.m4 5cb56ab01e9976d0d30a2e2960af007fc6400667 Diff: https://reviews.apache.org/r/25439/diff/ Testing --- ./configure --disable-bundled Thanks, Kamil Doma?ski
Re: Review Request 25439: Fix protobuf detection on systems with Python 3 as default
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25439/ --- (Updated Sept. 8, 2014, 4:09 p.m.) Review request for mesos. Changes --- fixed date Repository: mesos-git Description --- MESOS-1774 Diffs (updated) - m4/ac_python_module.m4 5cb56ab01e9976d0d30a2e2960af007fc6400667 Diff: https://reviews.apache.org/r/25439/diff/ Testing --- ./configure --disable-bundled Thanks, Kamil Doma?ski
