Re: Review Request 27509: Used io::poll instead of libev for receiving_connect.
On Nov. 12, 2014, 7:07 p.m., Niklas Nielsen wrote: 3rdparty/libprocess/src/process.cpp, line 845 https://reviews.apache.org/r/27509/diff/1/?file=747127#file747127line845 Why do you also need to pass 's' along? couldn't you get that from socket? Yes, but since this code gets replaced by Joris' upcoming patches I'm going to just leave as is so I don't make rebases much worse for him. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27509/#review61026 --- On Nov. 11, 2014, 4:55 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27509/ --- (Updated Nov. 11, 2014, 4:55 p.m.) Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, Niklas Nielsen, and Vinod Kone. Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/src/process.cpp 85fb9958342f0bcdde322d9c55333126e6f86668 Diff: https://reviews.apache.org/r/27509/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 27509: Used io::poll instead of libev for receiving_connect.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27509/ --- (Updated Nov. 14, 2014, 11:18 p.m.) Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, Niklas Nielsen, and Vinod Kone. Repository: mesos-git Description --- See summary. Diffs (updated) - 3rdparty/libprocess/src/process.cpp 5842705ae78ebe36c1c01bfcd468e9ebe55de3be Diff: https://reviews.apache.org/r/27509/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 27509: Used io::poll instead of libev for receiving_connect.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27509/#review61591 --- Ship it! Ship It! - Niklas Nielsen On Nov. 14, 2014, 3:18 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27509/ --- (Updated Nov. 14, 2014, 3:18 p.m.) Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, Niklas Nielsen, and Vinod Kone. Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/src/process.cpp 5842705ae78ebe36c1c01bfcd468e9ebe55de3be Diff: https://reviews.apache.org/r/27509/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 27509: Used io::poll instead of libev for receiving_connect.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27509/#review61026 --- LGTM module question below 3rdparty/libprocess/src/process.cpp https://reviews.apache.org/r/27509/#comment102491 Why do you also need to pass 's' along? couldn't you get that from socket? - Niklas Nielsen On Nov. 11, 2014, 8:55 a.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27509/ --- (Updated Nov. 11, 2014, 8:55 a.m.) Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, Niklas Nielsen, and Vinod Kone. Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/src/process.cpp 85fb9958342f0bcdde322d9c55333126e6f86668 Diff: https://reviews.apache.org/r/27509/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 27509: Used io::poll instead of libev for receiving_connect.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27509/ --- (Updated Nov. 11, 2014, 4:55 p.m.) Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, Niklas Nielsen, and Vinod Kone. Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/src/process.cpp 85fb9958342f0bcdde322d9c55333126e6f86668 Diff: https://reviews.apache.org/r/27509/diff/ Testing --- make check Thanks, Benjamin Hindman
