Re: Review Request 32833: Added os::signals::install to install signal handlers.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32833/#review79067
---



3rdparty/libprocess/3rdparty/stout/include/stout/os/signals.hpp


Why not use Try?


- Ben Mahler


On April 3, 2015, 9:28 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32833/
> ---
> 
> (Updated April 3, 2015, 9:28 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added os::signals::install to install signal handlers.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/signals.hpp 
> 30232f50cc72a79acd21499fe7602c9bcd624ff6 
> 
> Diff: https://reviews.apache.org/r/32833/diff/
> 
> 
> Testing
> ---
> 
> Tested in the later patch.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 32833: Added os::signals::install to install signal handlers.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32833/#review78836
---

Ship it!


Ship It!

- Vinod Kone


On April 3, 2015, 9:28 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32833/
> ---
> 
> (Updated April 3, 2015, 9:28 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added os::signals::install to install signal handlers.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/signals.hpp 
> 30232f50cc72a79acd21499fe7602c9bcd624ff6 
> 
> Diff: https://reviews.apache.org/r/32833/diff/
> 
> 
> Testing
> ---
> 
> Tested in the later patch.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>