Re: Review Request 24776: Add docker containerizer destroy tests

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24776/
---

(Updated Nov. 3, 2014, 8:53 p.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Summary (updated)
-

Add docker containerizer destroy tests


Repository: mesos-git


Description
---

Review: https://reviews.apache.org/r/24776


Diffs
-

  src/docker/docker.hpp 443db49318a5923b987c06cda8060ccfb3301a2f 
  src/docker/docker.cpp 6063114e700d13b1cd5d59cff356518021eb3286 
  src/slave/containerizer/docker.hpp fbbd45d77e5f2f74ca893552f85eb893b3dd948f 
  src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4 
  src/tests/docker_containerizer_tests.cpp 
1981f49d228903ccaa094a9747dec49054c1e0f2 

Diff: https://reviews.apache.org/r/24776/diff/


Testing
---

make check


Thanks,

Timothy Chen

Re: Review Request 24776: Add docker containerizer destroy tests and modify docker pull

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24776/#review53781
---


Patch looks great!

Reviews applied: [24776]

All tests passed.

- Mesos ReviewBot


On Sept. 17, 2014, 11:22 p.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24776/
> ---
> 
> (Updated Sept. 17, 2014, 11:22 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Review: https://reviews.apache.org/r/24776
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 443db49318a5923b987c06cda8060ccfb3301a2f 
>   src/docker/docker.cpp 6063114e700d13b1cd5d59cff356518021eb3286 
>   src/slave/containerizer/docker.hpp fbbd45d77e5f2f74ca893552f85eb893b3dd948f 
>   src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4 
>   src/tests/docker_containerizer_tests.cpp 
> 1981f49d228903ccaa094a9747dec49054c1e0f2 
> 
> Diff: https://reviews.apache.org/r/24776/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 24776: Add docker containerizer destroy tests and modify docker pull

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24776/
---

(Updated Sept. 17, 2014, 11:22 p.m.)


Review request for drill, Benjamin Hindman and Jie Yu.


Repository: mesos-git


Description
---

Review: https://reviews.apache.org/r/24776


Diffs (updated)
-

  src/docker/docker.hpp 443db49318a5923b987c06cda8060ccfb3301a2f 
  src/docker/docker.cpp 6063114e700d13b1cd5d59cff356518021eb3286 
  src/slave/containerizer/docker.hpp fbbd45d77e5f2f74ca893552f85eb893b3dd948f 
  src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4 
  src/tests/docker_containerizer_tests.cpp 
1981f49d228903ccaa094a9747dec49054c1e0f2 

Diff: https://reviews.apache.org/r/24776/diff/


Testing
---

make check


Thanks,

Timothy Chen

Re: Review Request 24776: Add docker containerizer destroy tests and modify docker pull

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24776/
---

(Updated Sept. 17, 2014, 11:22 p.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Repository: mesos-git


Description
---

Review: https://reviews.apache.org/r/24776


Diffs
-

  src/docker/docker.hpp 443db49318a5923b987c06cda8060ccfb3301a2f 
  src/docker/docker.cpp 6063114e700d13b1cd5d59cff356518021eb3286 
  src/slave/containerizer/docker.hpp fbbd45d77e5f2f74ca893552f85eb893b3dd948f 
  src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4 
  src/tests/docker_containerizer_tests.cpp 
1981f49d228903ccaa094a9747dec49054c1e0f2 

Diff: https://reviews.apache.org/r/24776/diff/


Testing
---

make check


Thanks,

Timothy Chen

Re: Review Request 24776: Add docker containerizer destroy tests and modify docker pull

[Timothy Chen]

> On Sept. 17, 2014, 11:20 p.m., Adam B wrote:
> > src/slave/containerizer/docker.cpp, lines 353-358
> > 
> >
> > Why call new DockerContainerizerProcess twice?

Oops, bad merge!


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24776/#review53767
---


On Sept. 17, 2014, 11:11 p.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24776/
> ---
> 
> (Updated Sept. 17, 2014, 11:11 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Review: https://reviews.apache.org/r/24776
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 443db49318a5923b987c06cda8060ccfb3301a2f 
>   src/docker/docker.cpp 6063114e700d13b1cd5d59cff356518021eb3286 
>   src/slave/containerizer/docker.hpp fbbd45d77e5f2f74ca893552f85eb893b3dd948f 
>   src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4 
>   src/tests/docker_containerizer_tests.cpp 
> 1981f49d228903ccaa094a9747dec49054c1e0f2 
> 
> Diff: https://reviews.apache.org/r/24776/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 24776: Add docker containerizer destroy tests and modify docker pull

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24776/#review53767
---



src/slave/containerizer/docker.cpp


Why call new DockerContainerizerProcess twice?


- Adam B


On Sept. 17, 2014, 4:11 p.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24776/
> ---
> 
> (Updated Sept. 17, 2014, 4:11 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Review: https://reviews.apache.org/r/24776
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 443db49318a5923b987c06cda8060ccfb3301a2f 
>   src/docker/docker.cpp 6063114e700d13b1cd5d59cff356518021eb3286 
>   src/slave/containerizer/docker.hpp fbbd45d77e5f2f74ca893552f85eb893b3dd948f 
>   src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4 
>   src/tests/docker_containerizer_tests.cpp 
> 1981f49d228903ccaa094a9747dec49054c1e0f2 
> 
> Diff: https://reviews.apache.org/r/24776/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 24776: Add docker containerizer destroy tests and modify docker pull

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24776/
---

(Updated Sept. 17, 2014, 11:11 p.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Summary (updated)
-

Add docker containerizer destroy tests and modify docker pull


Repository: mesos-git


Description
---

Review: https://reviews.apache.org/r/24776


Diffs (updated)
-

  src/docker/docker.hpp 443db49318a5923b987c06cda8060ccfb3301a2f 
  src/docker/docker.cpp 6063114e700d13b1cd5d59cff356518021eb3286 
  src/slave/containerizer/docker.hpp fbbd45d77e5f2f74ca893552f85eb893b3dd948f 
  src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4 
  src/tests/docker_containerizer_tests.cpp 
1981f49d228903ccaa094a9747dec49054c1e0f2 

Diff: https://reviews.apache.org/r/24776/diff/


Testing
---

make check


Thanks,

Timothy Chen

Re: Review Request 24776: Add docker containerizer destroy tests

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24776/#review53692
---


Bad patch!

Reviews applied: [24776]

Failed command: git apply --index 24776.patch

Error:
 error: patch failed: src/slave/containerizer/docker.cpp:73
error: src/slave/containerizer/docker.cpp: patch does not apply
error: patch failed: src/tests/docker_containerizer_tests.cpp:1630
error: src/tests/docker_containerizer_tests.cpp: patch does not apply

- Mesos ReviewBot


On Sept. 17, 2014, 12:21 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24776/
> ---
> 
> (Updated Sept. 17, 2014, 12:21 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Review: https://reviews.apache.org/r/24776
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.hpp fbbd45d77e5f2f74ca893552f85eb893b3dd948f 
>   src/slave/containerizer/docker.cpp 0febbac5df4126f6c8d9a06dd0ba1668d041b34a 
>   src/tests/docker_containerizer_tests.cpp 
> 8654f9c787bd207f6a7b821651e0c083bea9dc8a 
> 
> Diff: https://reviews.apache.org/r/24776/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 24776: Add docker containerizer destroy tests

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24776/
---

(Updated Sept. 17, 2014, 12:21 a.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Repository: mesos-git


Description
---

Review: https://reviews.apache.org/r/24776


Diffs (updated)
-

  src/slave/containerizer/docker.hpp fbbd45d77e5f2f74ca893552f85eb893b3dd948f 
  src/slave/containerizer/docker.cpp 0febbac5df4126f6c8d9a06dd0ba1668d041b34a 
  src/tests/docker_containerizer_tests.cpp 
8654f9c787bd207f6a7b821651e0c083bea9dc8a 

Diff: https://reviews.apache.org/r/24776/diff/


Testing
---

make check


Thanks,

Timothy Chen

Re: Review Request 24776: Add docker containerizer destroy tests

[Benjamin Hindman]

> On Sept. 9, 2014, 6:15 p.m., Benjamin Hindman wrote:
> > Why did you need to mock DockerContainerizerProcess in order to write these 
> > tests? Couldn't you have just used the existing MockDockerContainerizer?
> 
> Timothy Chen wrote:
> I wanted to simulate having destroy called in a pull/fetching state, so I 
> thought the only way to do so is to mock the process since the callbacks are 
> on DockerContainerizerProcess and not the Containerizer, so the callbacks for 
> fetch and pull blocks and I can call destroy in that state and verify it was 
> able to destroy.

Yup yup, you're correct, my apologies!


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24776/#review52758
---


On Sept. 15, 2014, 8:33 p.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24776/
> ---
> 
> (Updated Sept. 15, 2014, 8:33 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Review: https://reviews.apache.org/r/24776
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.hpp fbbd45d77e5f2f74ca893552f85eb893b3dd948f 
>   src/slave/containerizer/docker.cpp 0febbac5df4126f6c8d9a06dd0ba1668d041b34a 
>   src/tests/docker_containerizer_tests.cpp 
> 8654f9c787bd207f6a7b821651e0c083bea9dc8a 
> 
> Diff: https://reviews.apache.org/r/24776/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 24776: Add docker containerizer destroy tests

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24776/#review53535
---

Ship it!


LGTM, but as always let's definitely resolve the two issues before committing.


src/slave/containerizer/docker.cpp


Hmm, these are a wierd semantics ... can you please document the construct 
sufficiently about this (that it also gets terminated in the destructor).



src/tests/docker_containerizer_tests.cpp


Why is this '* 2'? This raises my eyebrow that you had to do this to get 
the test to deterministically pass which makes me wonder if we're not waiting 
for all the right conditions and we could still have a non-deterministic 
failure if timing doesn't work out. We try and avoid these kind of constants in 
order to make our tests as deterministic as possible.


- Benjamin Hindman


On Sept. 15, 2014, 8:33 p.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24776/
> ---
> 
> (Updated Sept. 15, 2014, 8:33 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Review: https://reviews.apache.org/r/24776
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.hpp fbbd45d77e5f2f74ca893552f85eb893b3dd948f 
>   src/slave/containerizer/docker.cpp 0febbac5df4126f6c8d9a06dd0ba1668d041b34a 
>   src/tests/docker_containerizer_tests.cpp 
> 8654f9c787bd207f6a7b821651e0c083bea9dc8a 
> 
> Diff: https://reviews.apache.org/r/24776/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 24776: Add docker containerizer destroy tests

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24776/#review53418
---


Patch looks great!

Reviews applied: [24776]

All tests passed.

- Mesos ReviewBot


On Sept. 15, 2014, 8:33 p.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24776/
> ---
> 
> (Updated Sept. 15, 2014, 8:33 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Review: https://reviews.apache.org/r/24776
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.hpp fbbd45d77e5f2f74ca893552f85eb893b3dd948f 
>   src/slave/containerizer/docker.cpp 0febbac5df4126f6c8d9a06dd0ba1668d041b34a 
>   src/tests/docker_containerizer_tests.cpp 
> 8654f9c787bd207f6a7b821651e0c083bea9dc8a 
> 
> Diff: https://reviews.apache.org/r/24776/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 24776: Add docker containerizer destroy tests

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24776/
---

(Updated Sept. 15, 2014, 8:33 p.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Repository: mesos-git


Description (updated)
---

Review: https://reviews.apache.org/r/24776


Diffs (updated)
-

  src/slave/containerizer/docker.hpp fbbd45d77e5f2f74ca893552f85eb893b3dd948f 
  src/slave/containerizer/docker.cpp 0febbac5df4126f6c8d9a06dd0ba1668d041b34a 
  src/tests/docker_containerizer_tests.cpp 
8654f9c787bd207f6a7b821651e0c083bea9dc8a 

Diff: https://reviews.apache.org/r/24776/diff/


Testing
---

make check


Thanks,

Timothy Chen

Re: Review Request 24776: Add docker containerizer destroy tests

[Timothy Chen]

> On Sept. 9, 2014, 6:15 p.m., Benjamin Hindman wrote:
> > Why did you need to mock DockerContainerizerProcess in order to write these 
> > tests? Couldn't you have just used the existing MockDockerContainerizer?

I wanted to simulate having destroy called in a pull/fetching state, so I 
thought the only way to do so is to mock the process since the callbacks are on 
DockerContainerizerProcess and not the Containerizer, so the callbacks for 
fetch and pull blocks and I can call destroy in that state and verify it was 
able to destroy.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24776/#review52758
---


On Aug. 16, 2014, 10:23 p.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24776/
> ---
> 
> (Updated Aug. 16, 2014, 10:23 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Add docker containerizer destroy tests
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.hpp fbbd45d77e5f2f74ca893552f85eb893b3dd948f 
>   src/slave/containerizer/docker.cpp fe5b29167811d4ac2fe29070c70a04f84093a6ff 
>   src/tests/docker_containerizer_tests.cpp 
> 8654f9c787bd207f6a7b821651e0c083bea9dc8a 
> 
> Diff: https://reviews.apache.org/r/24776/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 24776: Add docker containerizer destroy tests

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24776/#review52758
---


Why did you need to mock DockerContainerizerProcess in order to write these 
tests? Couldn't you have just used the existing MockDockerContainerizer?


src/tests/docker_containerizer_tests.cpp


Please move '=' back on previous line.



src/tests/docker_containerizer_tests.cpp


Looks like wierd indentation here.


- Benjamin Hindman


On Aug. 16, 2014, 10:23 p.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24776/
> ---
> 
> (Updated Aug. 16, 2014, 10:23 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Add docker containerizer destroy tests
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.hpp fbbd45d77e5f2f74ca893552f85eb893b3dd948f 
>   src/slave/containerizer/docker.cpp fe5b29167811d4ac2fe29070c70a04f84093a6ff 
>   src/tests/docker_containerizer_tests.cpp 
> 8654f9c787bd207f6a7b821651e0c083bea9dc8a 
> 
> Diff: https://reviews.apache.org/r/24776/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 24776: Add docker containerizer destroy tests

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24776/#review51751
---


Jie or Ben can you guys commit this?

- Timothy Chen


On Aug. 16, 2014, 10:23 p.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24776/
> ---
> 
> (Updated Aug. 16, 2014, 10:23 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Add docker containerizer destroy tests
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.hpp fbbd45d77e5f2f74ca893552f85eb893b3dd948f 
>   src/slave/containerizer/docker.cpp fe5b29167811d4ac2fe29070c70a04f84093a6ff 
>   src/tests/docker_containerizer_tests.cpp 
> 8654f9c787bd207f6a7b821651e0c083bea9dc8a 
> 
> Diff: https://reviews.apache.org/r/24776/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 24776: Add docker containerizer destroy tests

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24776/#review51750
---


Jie or Ben can you guys commit this?

- Timothy Chen


On Aug. 16, 2014, 10:23 p.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24776/
> ---
> 
> (Updated Aug. 16, 2014, 10:23 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Add docker containerizer destroy tests
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.hpp fbbd45d77e5f2f74ca893552f85eb893b3dd948f 
>   src/slave/containerizer/docker.cpp fe5b29167811d4ac2fe29070c70a04f84093a6ff 
>   src/tests/docker_containerizer_tests.cpp 
> 8654f9c787bd207f6a7b821651e0c083bea9dc8a 
> 
> Diff: https://reviews.apache.org/r/24776/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 24776: Add docker containerizer destroy tests

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24776/#review50835
---


Patch looks great!

Reviews applied: [24776]

All tests passed.

- Mesos ReviewBot


On Aug. 16, 2014, 10:23 p.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24776/
> ---
> 
> (Updated Aug. 16, 2014, 10:23 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Add docker containerizer destroy tests
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.hpp fbbd45d77e5f2f74ca893552f85eb893b3dd948f 
>   src/slave/containerizer/docker.cpp fe5b29167811d4ac2fe29070c70a04f84093a6ff 
>   src/tests/docker_containerizer_tests.cpp 
> 8654f9c787bd207f6a7b821651e0c083bea9dc8a 
> 
> Diff: https://reviews.apache.org/r/24776/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Review Request 24776: Add docker containerizer destroy tests

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24776/
---

Review request for mesos, Benjamin Hindman and Jie Yu.


Repository: mesos-git


Description
---

Add docker containerizer destroy tests


Diffs
-

  src/slave/containerizer/docker.hpp fbbd45d77e5f2f74ca893552f85eb893b3dd948f 
  src/slave/containerizer/docker.cpp fe5b29167811d4ac2fe29070c70a04f84093a6ff 
  src/tests/docker_containerizer_tests.cpp 
8654f9c787bd207f6a7b821651e0c083bea9dc8a 

Diff: https://reviews.apache.org/r/24776/diff/


Testing
---

make check


Thanks,

Timothy Chen