Review Request 25129: Fixed signal handling for Mesos.

2014-08-27 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25129/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-1729
https://issues.apache.org/jira/browse/MESOS-1729


Repository: mesos-git


Description
---

Reset SIGPIPE handler to default handler to avoid issues with embedded 
ZooKeeper.

See bug for details. 


Diffs
-

  src/logging/logging.cpp 547673c7584a0962d3a54da51f3ad069d9285bb9 
  src/tests/main.cpp 32a24564ff460a9bc0d11bc02b7a5b29f599c57b 

Diff: https://reviews.apache.org/r/25129/diff/


Testing
---

make check


Thanks,

Vinod Kone



Re: Review Request 25129: Fixed signal handling for Mesos.

2014-08-27 Thread Jie Yu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25129/#review51718
---

Ship it!



src/logging/logging.cpp
https://reviews.apache.org/r/25129/#comment90266

I don't quite get this part. But let's ship this first as you just moved it.


- Jie Yu


On Aug. 27, 2014, 10:57 p.m., Vinod Kone wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/25129/
 ---
 
 (Updated Aug. 27, 2014, 10:57 p.m.)
 
 
 Review request for mesos and Jie Yu.
 
 
 Bugs: MESOS-1729
 https://issues.apache.org/jira/browse/MESOS-1729
 
 
 Repository: mesos-git
 
 
 Description
 ---
 
 Reset SIGPIPE handler to default handler to avoid issues with embedded 
 ZooKeeper.
 
 See bug for details. 
 
 
 Diffs
 -
 
   src/logging/logging.cpp 547673c7584a0962d3a54da51f3ad069d9285bb9 
   src/tests/main.cpp 32a24564ff460a9bc0d11bc02b7a5b29f599c57b 
 
 Diff: https://reviews.apache.org/r/25129/diff/
 
 
 Testing
 ---
 
 make check
 
 
 Thanks,
 
 Vinod Kone