Re: Review Request 25785: Add guide to becoming a committer
On Sept. 19, 2014, 5:24 p.m., Adam B wrote: I think it's valuable to outline some guidelines for anybody interested in becoming a committer, but I don't think we should set too many strict rules and regulations around it. Other thoughts below. Dominic Hamon wrote: I think exactly the opposite. I think clear guidelines give contributors goals to attain and allow them to have an aim further than just contributing to the project. It also reduces friction when deciding who to nominate as a new committer and encourages the nomination of new committers as contributors mature. Taken the number of different views on the topic - isn't it worthwhile to bring to the dev@ list for discussion rather then iterating on a patch? Or have a google doc for mutual commenting / editing? I also have a hard time getting comfortable with establishing a process that haven't been up for vote (but written down anyway) - to put it another way: how can we honor/exercise these rules if there haven't been consensus around them? - Niklas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25785/#review54053 --- On Sept. 18, 2014, 10:41 a.m., Dominic Hamon wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25785/ --- (Updated Sept. 18, 2014, 10:41 a.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-1815 https://issues.apache.org/jira/browse/MESOS-1815 Repository: mesos-git Description --- Add a guide to becoming a committer. Diffs - docs/becoming-a-committer.md PRE-CREATION Diff: https://reviews.apache.org/r/25785/diff/ Testing --- Thanks, Dominic Hamon
Re: Review Request 25785: Add guide to becoming a committer
On Sept. 19, 2014, 5:24 p.m., Adam B wrote: I think it's valuable to outline some guidelines for anybody interested in becoming a committer, but I don't think we should set too many strict rules and regulations around it. Other thoughts below. I think exactly the opposite. I think clear guidelines give contributors goals to attain and allow them to have an aim further than just contributing to the project. It also reduces friction when deciding who to nominate as a new committer and encourages the nomination of new committers as contributors mature. On Sept. 19, 2014, 5:24 p.m., Adam B wrote: docs/becoming-a-committer.md, line 13 https://reviews.apache.org/r/25785/diff/1/?file=693607#file693607line13 10-20 non-trivial patches seems arbitrarily high. I've seen us call votes for contributors with as few as a dozen patches, and some of them may have been trivial by some definition. We should discuss what the actual (non-trivial) patch limit should be. I would be fine nominating somebody with 5 non-trivial patches if they are active in the community and committed to the project. If they are to be a docs or website committer, the requirements could be even less. Maybe we shouldn't even publish a hard limit publicly. Maybe anybody can ask to be nominated, and the existing committers can evaluate the requirements for that individual/role. I think a limit or guideline is important to avoid the decision-making seem arbitrary, however i'm completely open to changing this number based on what people are comfortable with. There's always going to be room for interpretation when actually voting regarding the triviality or otherwise of the patches. On Sept. 19, 2014, 5:24 p.m., Adam B wrote: docs/becoming-a-committer.md, line 27 https://reviews.apache.org/r/25785/diff/1/?file=693607#file693607line27 Why 10 days? Why not 1 week? How did you arrive at this number? I had to start somewhere. I wanted something that would give people enough time to vote and as people often go on vacation for a week, it avoids people missing the chance to give feedback. On Sept. 19, 2014, 5:24 p.m., Adam B wrote: docs/becoming-a-committer.md, line 34 https://reviews.apache.org/r/25785/diff/1/?file=693607#file693607line34 Does that mean we will be revoking committer status from the Berkeley guys who have moved on to other things and are no longer contributing to Mesos? i need to find better wording for this. by 'positive contributor' i only meant 'not a negative contributor'. ie, not working actively against the project or being difficult to work with. On Sept. 19, 2014, 5:24 p.m., Adam B wrote: docs/becoming-a-committer.md, line 36 https://reviews.apache.org/r/25785/diff/1/?file=693607#file693607line36 Has this process been used/defined previously, or are you proposing a new process here? How long does the revocation vote last? I believe this is a new process. - Dominic --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25785/#review54053 --- On Sept. 18, 2014, 10:41 a.m., Dominic Hamon wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25785/ --- (Updated Sept. 18, 2014, 10:41 a.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-1815 https://issues.apache.org/jira/browse/MESOS-1815 Repository: mesos-git Description --- Add a guide to becoming a committer. Diffs - docs/becoming-a-committer.md PRE-CREATION Diff: https://reviews.apache.org/r/25785/diff/ Testing --- Thanks, Dominic Hamon
Re: Review Request 25785: Add guide to becoming a committer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25785/#review54053 --- I think it's valuable to outline some guidelines for anybody interested in becoming a committer, but I don't think we should set too many strict rules and regulations around it. Other thoughts below. docs/becoming-a-committer.md https://reviews.apache.org/r/25785/#comment93988 I like how BenH words it as a committer is somebody who is committed to the project. That's the most important thing, whether they are c++ code committers, build committers, doc committers, website committers, etc. docs/becoming-a-committer.md https://reviews.apache.org/r/25785/#comment93998 Let's call out the kinds of things we expect for community participation (IRC, mailing lists, reviewing other patches/JIRAs, etc.) docs/becoming-a-committer.md https://reviews.apache.org/r/25785/#comment93994 10-20 non-trivial patches seems arbitrarily high. I've seen us call votes for contributors with as few as a dozen patches, and some of them may have been trivial by some definition. We should discuss what the actual (non-trivial) patch limit should be. I would be fine nominating somebody with 5 non-trivial patches if they are active in the community and committed to the project. If they are to be a docs or website committer, the requirements could be even less. Maybe we shouldn't even publish a hard limit publicly. Maybe anybody can ask to be nominated, and the existing committers can evaluate the requirements for that individual/role. docs/becoming-a-committer.md https://reviews.apache.org/r/25785/#comment93990 code is relative, since some committers don't even write/commit c++ code. docs/becoming-a-committer.md https://reviews.apache.org/r/25785/#comment94002 Why do you even need to specify real names? An email address and github/jira/review-board handle should be sufficient. I'd nominate an pseudononymous contributor who's been writing awesome code for us. docs/becoming-a-committer.md https://reviews.apache.org/r/25785/#comment94004 Why 10 days? Why not 1 week? How did you arrive at this number? docs/becoming-a-committer.md https://reviews.apache.org/r/25785/#comment93991 Or you need to show more community involvement on JIRA/RB, mailing lists, and/or IRC. docs/becoming-a-committer.md https://reviews.apache.org/r/25785/#comment94005 You can also get access to the Jenkins server, the Maven repo, and possibly the github.com/mesos organization. docs/becoming-a-committer.md https://reviews.apache.org/r/25785/#comment93992 Does that mean we will be revoking committer status from the Berkeley guys who have moved on to other things and are no longer contributing to Mesos? docs/becoming-a-committer.md https://reviews.apache.org/r/25785/#comment93993 Has this process been used/defined previously, or are you proposing a new process here? How long does the revocation vote last? - Adam B On Sept. 18, 2014, 10:41 a.m., Dominic Hamon wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25785/ --- (Updated Sept. 18, 2014, 10:41 a.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-1815 https://issues.apache.org/jira/browse/MESOS-1815 Repository: mesos-git Description --- Add a guide to becoming a committer. Diffs - docs/becoming-a-committer.md PRE-CREATION Diff: https://reviews.apache.org/r/25785/diff/ Testing --- Thanks, Dominic Hamon
Review Request 25785: Add guide to becoming a committer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25785/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-1815 https://issues.apache.org/jira/browse/MESOS-1815 Repository: mesos-git Description --- Add a guide to becoming a committer. Diffs - docs/becoming-a-committer.md PRE-CREATION Diff: https://reviews.apache.org/r/25785/diff/ Testing --- Thanks, Dominic Hamon
Re: Review Request 25785: Add guide to becoming a committer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25785/#review53843 --- Where do these dead-lines come from? Has there been any agreement on this process in general and doesn't this deserve to be discussed and consensus reached (dev@ or private) before putting out a document on it? I might be missing something here of course; if so, can you point me to the references? - Niklas Nielsen On Sept. 18, 2014, 10:41 a.m., Dominic Hamon wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25785/ --- (Updated Sept. 18, 2014, 10:41 a.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-1815 https://issues.apache.org/jira/browse/MESOS-1815 Repository: mesos-git Description --- Add a guide to becoming a committer. Diffs - docs/becoming-a-committer.md PRE-CREATION Diff: https://reviews.apache.org/r/25785/diff/ Testing --- Thanks, Dominic Hamon
Re: Review Request 25785: Add guide to becoming a committer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25785/#review53846 --- Patch looks great! Reviews applied: [25785] All tests passed. - Mesos ReviewBot On Sept. 18, 2014, 5:41 p.m., Dominic Hamon wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25785/ --- (Updated Sept. 18, 2014, 5:41 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-1815 https://issues.apache.org/jira/browse/MESOS-1815 Repository: mesos-git Description --- Add a guide to becoming a committer. Diffs - docs/becoming-a-committer.md PRE-CREATION Diff: https://reviews.apache.org/r/25785/diff/ Testing --- Thanks, Dominic Hamon
Re: Review Request 25785: Add guide to becoming a committer
On Sept. 18, 2014, 11:40 a.m., Niklas Nielsen wrote: Where do these dead-lines come from? Has there been any agreement on this process in general and doesn't this deserve to be discussed and consensus reached (dev@ or private) before putting out a document on it? I might be missing something here of course; if so, can you point me to the references? This is the attempt to reach consensus. I feel it's better to have something to start with that can then be discussed. I was going to put it up on private, but was discouraged as private is for voting only. - Dominic --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25785/#review53843 --- On Sept. 18, 2014, 10:41 a.m., Dominic Hamon wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25785/ --- (Updated Sept. 18, 2014, 10:41 a.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-1815 https://issues.apache.org/jira/browse/MESOS-1815 Repository: mesos-git Description --- Add a guide to becoming a committer. Diffs - docs/becoming-a-committer.md PRE-CREATION Diff: https://reviews.apache.org/r/25785/diff/ Testing --- Thanks, Dominic Hamon
Re: Review Request 25785: Add guide to becoming a committer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25785/#review53869 --- docs/becoming-a-committer.md https://reviews.apache.org/r/25785/#comment93731 It would be nice to have metrics that are easy to gather, similar to what is done on openstack. With one snapshot you can see details about the user. The idea of spreading around reviews may be a bit difficult for folks who are new to the project. - Timothy St. Clair On Sept. 18, 2014, 5:41 p.m., Dominic Hamon wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25785/ --- (Updated Sept. 18, 2014, 5:41 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-1815 https://issues.apache.org/jira/browse/MESOS-1815 Repository: mesos-git Description --- Add a guide to becoming a committer. Diffs - docs/becoming-a-committer.md PRE-CREATION Diff: https://reviews.apache.org/r/25785/diff/ Testing --- Thanks, Dominic Hamon
