Review Request 25844: Ignore terminal task resources in the Master's Framework struct.

2014-09-19 Thread Ben Mahler

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25844/
---

Review request for mesos and Vinod Kone.


Repository: mesos-git


Description
---

During my refactor to hold on to terminal tasks in the master, I forgot to 
update the Framework's resource accounting to ignore these terminal tasks.


Diffs
-

  src/master/http.cpp 8db4d9a7565212e06b01dc0e1f801fc9c7ff509c 
  src/master/master.hpp 41da2402a1ff54ff8d8d12caaa7939f25fdd4da9 
  src/master/master.cpp c88d5351f8ff90f8e2a6b6d89f94e151a5176e1d 

Diff: https://reviews.apache.org/r/25844/diff/


Testing
---

make check


Thanks,

Ben Mahler



Re: Review Request 25844: Ignore terminal task resources in the Master's Framework struct.

2014-09-19 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25844/#review54020
---

Ship it!


Ship It!

- Vinod Kone


On Sept. 19, 2014, 7:57 p.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25844/
> ---
> 
> (Updated Sept. 19, 2014, 7:57 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> During my refactor to hold on to terminal tasks in the master, I forgot to 
> update the Framework's resource accounting to ignore these terminal tasks.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 8db4d9a7565212e06b01dc0e1f801fc9c7ff509c 
>   src/master/master.hpp 41da2402a1ff54ff8d8d12caaa7939f25fdd4da9 
>   src/master/master.cpp c88d5351f8ff90f8e2a6b6d89f94e151a5176e1d 
> 
> Diff: https://reviews.apache.org/r/25844/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>